From tlikonen@iki.fi Sun May 31 10:09:42 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 31 May 2009 17:09:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.2 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4VH9bs0013952 for ; Sun, 31 May 2009 10:09:39 -0700 Received: from mail.gnu.org ([199.232.76.166]:40773 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MAoXQ-0007fw-Vj for emacs-pretest-bug@gnu.org; Sun, 31 May 2009 13:09:37 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MAoXO-0002iW-JR for emacs-pretest-bug@gnu.org; Sun, 31 May 2009 13:09:36 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:41251 helo=jenni1.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAoXN-0002hb-Qw for emacs-pretest-bug@gnu.org; Sun, 31 May 2009 13:09:34 -0400 Received: from mithlond.arda.local (80.220.180.181) by jenni1.inet.fi (8.5.014) id 49F59766014EA7E6; Sun, 31 May 2009 20:09:32 +0300 Received: from dtw by mithlond.arda.local with local (Exim 4.69) (envelope-from ) id 1MAoWY-0002a9-Ik; Sun, 31 May 2009 20:08:42 +0300 From: Teemu Likonen To: emacs-pretest-bug@gnu.org Cc: rfrancoise@debian.org Subject: 23.0.91; kill-visual-line at the end of logical line deletes also th next line Date: Sun, 31 May 2009 20:08:42 +0300 Message-ID: <87ws7xjj39.fsf@iki.fi> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) When "kill-visual-line" command is executed at the end of line it kills the next line up to the cursor column. To reproduce: 1. Take a scratch buffer. Turn on visual-line-mode: C-u M-x visual-line-mode RET 2. Put the following lines to the buffer (at the column 0): foobar 123456789 3. Move the cursor at the end of "foobar" line. 4. Execute kill-visual-line (C-k). The buffer looks like this: foobar789 I think the expected result would be foobar123456789 with the point between "r" and "1". This is how "kill-line" works, that is, only kill the newline. In GNU Emacs 23.0.91.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)) of 2009-03-21 on elegiac, modified by Debian (emacs-snapshot package, version 1:20090320-1~lenny1) Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.91/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.91/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: en_US.UTF-8 value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: fi_FI.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: TeX-PDF-mode: t gnus-agent-mode: t shell-dirtrack-mode: t gnus-undo-mode: t ergo-movement-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t From tlikonen@iki.fi Tue Jun 9 08:17:55 2009 Received: (at 3437) by emacsbugs.donarmstrong.com; 9 Jun 2009 15:17:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.6 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from jenni2.inet.fi (mta-out.inet.fi [195.156.147.13]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n59FHoVO016788 for <3437@emacsbugs.donarmstrong.com>; Tue, 9 Jun 2009 08:17:52 -0700 Received: from imladris.arda.local (84.251.6.80) by jenni2.inet.fi (8.5.014) id 49F5CB64019EEB34 for 3437@emacsbugs.donarmstrong.com; Tue, 9 Jun 2009 18:17:49 +0300 Received: from dtw by imladris.arda.local with local (Exim 4.69) (envelope-from ) id 1ME357-0001Pr-La for 3437@emacsbugs.donarmstrong.com; Tue, 09 Jun 2009 18:17:45 +0300 From: Teemu Likonen To: 3437@debbugs.gnu.org Subject: Add patch to bug #3437 Date: Tue, 09 Jun 2009 18:17:45 +0300 Message-ID: <87ab4hzbae.fsf@iki.fi> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Here's a patch that does what I mean. It changes the original "if" form to "cond" form and adds a condition branch for the case when the point is at the end of logical line: (cond ((eolp) (goto-char (1+ (point)))) ...) The semantics of the original "if" form is reproduced in the place of "..." above, that is, as other "cond" branches. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=simple.el.patch --- simple.el.orig 2009-06-09 17:42:26.000000000 +0300 +++ simple.el 2009-06-09 17:54:16.000000000 +0300 @@ -4488,15 +4488,18 @@ (signal 'end-of-buffer nil)) (setq end (save-excursion (end-of-visual-line) (point))) - (if (or (save-excursion - ;; If trailing whitespace is visible, - ;; don't treat it as nothing. - (unless show-trailing-whitespace - (skip-chars-forward " \t" end)) - (= (point) end)) - (and kill-whole-line (bolp))) - (line-move 1) - (goto-char end))) + (cond ((eolp) + (goto-char (1+ (point)))) + ((or (save-excursion + ;; If trailing whitespace is visible, + ;; don't treat it as nothing. + (unless show-trailing-whitespace + (skip-chars-forward " \t" end)) + (= (point) end)) + (and kill-whole-line (bolp))) + (line-move 1)) + (t + (goto-char end)))) (kill-region opoint (point)))) (defun next-logical-line (&optional arg try-vscroll) --=-=-=-- From tlikonen@iki.fi Tue Jun 9 19:51:38 2009 Received: (at control) by emacsbugs.donarmstrong.com; 10 Jun 2009 02:51:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.5 required=4.0 tests=AWL,MURPHY_DRUGS_REL8, VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from kirsi1.inet.fi (mta-out.inet.fi [195.156.147.13]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5A2pX7N018358 for ; Tue, 9 Jun 2009 19:51:34 -0700 Received: from imladris.arda.local (84.251.6.80) by kirsi1.inet.fi (8.5.014) id 49F6055A01A2F3CA for control@emacsbugs.donarmstrong.com; Wed, 10 Jun 2009 05:51:32 +0300 Received: from dtw by imladris.arda.local with local (Exim 4.69) (envelope-from ) id 1MEDuR-00011n-DM for control@emacsbugs.donarmstrong.com; Wed, 10 Jun 2009 05:51:27 +0300 From: Teemu Likonen To: control@debbugs.gnu.org Subject: Add patch tag Date: Wed, 10 Jun 2009 05:51:27 +0300 Message-ID: <87ski8yf68.fsf@iki.fi> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii tag 3437 + patch thanks From cyd@stupidchicken.com Sat Jun 13 11:57:28 2009 Received: (at 3437) by emacsbugs.donarmstrong.com; 13 Jun 2009 18:57:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5DIvOu5031105 for <3437@emacsbugs.donarmstrong.com>; Sat, 13 Jun 2009 11:57:25 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 66D0A57E21E; Sat, 13 Jun 2009 14:57:31 -0400 (EDT) From: Chong Yidong To: Teemu Likonen Cc: Deniz Dogan , Rudi Schlatte , emacs-devel@gnu.org, 3437@debbugs.gnu.org Subject: Re: Please consider fixing #3437 before release References: <87r5xp5d6x.fsf@iki.fi> Date: Sat, 13 Jun 2009 14:57:31 -0400 In-Reply-To: <87r5xp5d6x.fsf@iki.fi> (Teemu Likonen's message of "Sat, 13 Jun 2009 00:56:06 +0300") Message-ID: <878wjwgdwk.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I've checked in a fixed-up version of kill-visual-line into CVS. Please test it and see if there are any problems. From deniz.a.m.dogan@gmail.com Sat Jun 13 12:09:37 2009 Received: (at 3437) by emacsbugs.donarmstrong.com; 13 Jun 2009 19:09:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5DJ9WbW000949 for <3437@emacsbugs.donarmstrong.com>; Sat, 13 Jun 2009 12:09:34 -0700 Received: by fg-out-1718.google.com with SMTP id e12so134443fga.20 for <3437@emacsbugs.donarmstrong.com>; Sat, 13 Jun 2009 12:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DwyGFhPNtn3r4Grrc/9I6cw609yCIionlVVg8DnhFPs=; b=L7aImGQtgK9q5jo3nyb3m0xYUgdl1+ntBTnzrpXbvvewdgts7GMwqvZlEA87NFQZQS h14po8alc1CRnyJSJ1BtrqK00gcxAa4YVZnbH8MDhr/ta2/D5fCqY6TcXNRiyJiNHGbz 21+vuuevpKKagfEEzHnioATWyO+JW9aWczdA0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=xHy06jmtaRhegkzG4TqdYkiDBXIr5roQuf0toU0vuqG7CqLgWTvRgfPo9Pcw1Td6hl aKvTS316EUdHxrxxViEKqRArerl/9Y3ua6J3k1Pw/LGWbwgim7dJBPn4tXA0IbMma4z9 X6MX4mVx1+hVjtwU+PPwUyCPIm3cpmuYYgcB8= MIME-Version: 1.0 Received: by 10.86.74.1 with SMTP id w1mr5207687fga.53.1244920168794; Sat, 13 Jun 2009 12:09:28 -0700 (PDT) In-Reply-To: <878wjwgdwk.fsf@cyd.mit.edu> References: <87r5xp5d6x.fsf@iki.fi> <878wjwgdwk.fsf@cyd.mit.edu> Date: Sat, 13 Jun 2009 21:09:28 +0200 Message-ID: <7b501d5c0906131209j2ccc188v245cd85a83c0bb86@mail.gmail.com> Subject: Re: Please consider fixing #3437 before release From: Deniz Dogan To: Chong Yidong Cc: Teemu Likonen , Rudi Schlatte , emacs-devel@gnu.org, 3437@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2009/6/13 Chong Yidong : > I've checked in a fixed-up version of kill-visual-line into CVS. =A0Pleas= e > test it and see if there are any problems. > Seems fixed to me. --=20 Deniz Dogan From cyd@stupidchicken.com Sat Jun 13 12:29:23 2009 Received: (at control) by emacsbugs.donarmstrong.com; 13 Jun 2009 19:29:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5DJTKAH003996 for ; Sat, 13 Jun 2009 12:29:21 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id B8FFF57E21E; Sat, 13 Jun 2009 15:29:27 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 3437 Date: Sat, 13 Jun 2009 15:29:27 -0400 Message-ID: <87d4986ig8.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii close 3437 thanks From unknown Tue Jun 24 17:24:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sun, 12 Jul 2009 14:24:10 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator