GNU bug report logs - #34343
[PATCH] Make project--find-regexp-in-files work with remote files

Previous Next

Package: emacs;

Reported by: Felicián Németh <felician.nemeth <at> gmail.com>

Date: Wed, 6 Feb 2019 08:19:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #50 received at 34343 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 34343 <at> debbugs.gnu.org,
 Felicián Németh <felician.nemeth <at> gmail.com>
Subject: Re: bug#34343: [PATCH] Make project--find-regexp-in-files work with
 remote files
Date: Sat, 28 Dec 2019 19:46:04 +0100
Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 27.12.2019 19:57, Michael Albinus wrote:
>> file-local-name uses internally file-remote-p, which calls
>> expand-file-name if the connection is already established
>
> Why? If the caller needs an expanded name, they can call
> expand-file-name themselves. Or if they need an expanded local name:
>
>     (file-local-name (expand-file-name filename))
>
> Aside from performance problems, this feels like an inconsistent behavior.

I said already, that expand-file-name isn't needed for
file-local-name. I will try to find a better implementation.




This bug report was last modified 3 years and 303 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.