GNU bug report logs - #34343
[PATCH] Make project--find-regexp-in-files work with remote files

Previous Next

Package: emacs;

Reported by: Felicián Németh <felician.nemeth <at> gmail.com>

Date: Wed, 6 Feb 2019 08:19:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 34343 <at> debbugs.gnu.org, Felicián Németh <felician.nemeth <at> gmail.com>
Subject: bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files
Date: Sat, 28 Dec 2019 11:21:01 +0100

Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi Dmitry,

> file-local-name uses internally file-remote-p, which calls
> expand-file-name if the connection is already established. Not needed in
> case of local names.
>
> Could you pls test the appended patch, whether it improves performance?

Please forget this. I ran Tramp regression tests over night, and some of
them failed due to this change.

So we need a cheaper file-local-name. Just checking for
tramp-file-name-regexp isn't sufficient, because the file could be
"remote" independent of Tramp. Let me contemplate about.

Best regards, Michael.
This bug report was last modified 3 years and 303 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.