GNU bug report logs - #34323
reproducibility: absolute file names in ox-odt.elc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34323 in the body.
You can then email your comments to 34323 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: reproducibility: absolute file names in ox-odt.elc 
Date: Mon, 04 Feb 2019 18:05:21 -0500

Package: emacs,org-mode
Version: 26.1.91
Severity: minor

The compiled file ox-odt.elc contains strings that refer to the
absolute location of the build directory, through
org-odt-schema-dir-list and org-odt-styles-dir-list.
For example, in the Emacs 26.1.91 pretest tarfile, it contains
"/home/nico/work/emacs-26/etc/schema/" and
"/home/nico/work/emacs-26/etc/styles/".
This means the generated elc file is non-reproducible (ie, the contents
change depending on the build directory).

(Like https://debbugs.gnu.org/34321, issued spotted in
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/emacs.html
)

Message #6 received at 34323 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Glenn Morris <rgm <at> gnu.org>
Cc: kjambunathan <at> gmail.com, 34323 <at> debbugs.gnu.org
Subject: Re: bug#34323: reproducibility: absolute file names in ox-odt.elc
Date: Wed, 06 Feb 2019 22:17:14 +0100

Hello,

Glenn Morris <rgm <at> gnu.org> writes:

> Package: emacs,org-mode
> Version: 26.1.91
> Severity: minor
>
> The compiled file ox-odt.elc contains strings that refer to the
> absolute location of the build directory, through
> org-odt-schema-dir-list and org-odt-styles-dir-list.
> For example, in the Emacs 26.1.91 pretest tarfile, it contains
> "/home/nico/work/emacs-26/etc/schema/" and
> "/home/nico/work/emacs-26/etc/styles/".
> This means the generated elc file is non-reproducible (ie, the contents
> change depending on the build directory).
>
> (Like https://debbugs.gnu.org/34321, issued spotted in
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/emacs.html
> )

I'm Cc'ing the author of ox-odt.el as he might have more insight.

Regards,

-- 
Nicolas Goaziou

Message #9 received at 34323 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 34323 <at> debbugs.gnu.org
Subject: Re: bug#34323: reproducibility: absolute file names in ox-odt.elc
Date: Wed, 06 Feb 2019 18:52:58 -0500

It's due to the eval-when-compile sections in org-odt-schema-dir-list
and org-odt-styles-dir-list. These don't make sense to me. All they do
is add the build directory. There is a comment "see make install", but I
cannot see what this refers to. No similar variable initializes itself
in this way AFAIK. If those sections are removed, does anything stop
working?

Message #14 received at 34323-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Org Mode List <emacs-orgmode <at> gnu.org>, 34323-done <at> debbugs.gnu.org
Subject: Re: bug#34323: reproducibility: absolute file names in ox-odt.elc
Date: Sat, 09 Feb 2019 12:33:30 +0100

Hello,

Glenn Morris <rgm <at> gnu.org> writes:

> It's due to the eval-when-compile sections in org-odt-schema-dir-list
> and org-odt-styles-dir-list. These don't make sense to me. All they do
> is add the build directory. There is a comment "see make install", but I
> cannot see what this refers to. No similar variable initializes itself
> in this way AFAIK. If those sections are removed, does anything stop
> working?

I don't know. I removed `the `eval-when-compile' calls. We'll see what
horrible things happen.

I'm closing this bug for now. Thank you for reporting it.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.