Subject: Re: bug#34292: 26.1; ido-everywhere interferes with find-file

From: Noam Postavsky <[email-masked]>
Date: Tue, 02 Apr 2019 19:58:16 -0400

[forwarding to list, please use "Reply All" to keep [email-masked] on Cc]

Subject: Re: bug#34292: 26.1; ido-everywhere interferes with find-file
From: Dave Abrahams <[email-masked]>
To: Noam Postavsky <[email-masked]>
Date: Tue, 2 Apr 2019 14:00:33 -0700

Sorry, I don't know enough about ido's implementation to tell whether that's what I'm looking for.  It seems strange that this code should affect my use-case, since I must *have* ido-mode; even with emacs -Q, (require 'ido) succeeds.

> On Apr 1, 2019, at 4:37 PM, Noam Postavsky <[email-masked]> wrote:
> So are you looking for something like this?
> 
> diff --git i/lisp/ido.el w/lisp/ido.el
> index f9a9607a3a..6dcd5bcd99 100644
> --- i/lisp/ido.el
> +++ w/lisp/ido.el
> @@ -1588,6 +1588,8 @@ (define-minor-mode ido-everywhere
>   (remove-function read-file-name-function #'ido-read-file-name)
>   (remove-function read-buffer-function #'ido-read-buffer)
>   (when ido-everywhere
> +    (unless ido-mode
> +      (error "Can't turn on `ido-everywhere' without `ido-mode'"))
>     (add-function :override read-file-name-function #'ido-read-file-name)
>     (add-function :override read-buffer-function #'ido-read-buffer)))
>