From unknown Sat Jun 21 03:22:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34291 <34291@debbugs.gnu.org> To: bug#34291 <34291@debbugs.gnu.org> Subject: Status: Some EWW patches Reply-To: bug#34291 <34291@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:22:20 +0000 retitle 34291 Some EWW patches reassign 34291 emacs submitter 34291 Nicholas Drozd severity 34291 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 14:26:58 2019 Received: (at submit) by debbugs.gnu.org; 2 Feb 2019 19:26:58 +0000 Received: from localhost ([127.0.0.1]:56593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gq0wM-0003PE-BJ for submit@debbugs.gnu.org; Sat, 02 Feb 2019 14:26:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gq0wK-0003Oz-Fw for submit@debbugs.gnu.org; Sat, 02 Feb 2019 14:26:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:34095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gq0wE-0001jO-Cd for submit@debbugs.gnu.org; Sat, 02 Feb 2019 14:26:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gq0wD-0004zE-4e for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 14:26:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gq0w7-0001e5-E3 for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 14:26:46 -0500 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:37304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gq0w0-0001Y6-K5 for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 14:26:39 -0500 Received: by mail-lf1-x12d.google.com with SMTP id n23so2155462lfl.4 for ; Sat, 02 Feb 2019 11:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=pAG+Hbz8E/kC8nCnHAyZdyyQ7vdaTJRYY8VFyU1dTtg=; b=ieGqdCb9ZPjxbIJ/oXYkWwlzk16NF1loguIKKaKkWfqpaw9aCq5AAr2TbJIt7CYzQJ nkoftlOeUJKZNBUFi2rnfn3D9+fC2r82dAT2/edYCbKIHz3UikgW5QfN31l3ugxJKN+d pewRYimkq4Afm2iN67I1X1gR49LqtU93WaKm/yVCx/NazBuPfD3koUQx5gh95yAvv9wX MFBtyE10loTSp4tQrouJYThJL6L5UwEG5E0Xj1a7NrAV6yXjnVrlBIwI9NuKRu1/Nd4V t8pFQC++wsDubwFmJoIfVpKWign9YC7lQKIJ5WAgicxDkIJXvz6d8zcqRYuj21rsFuuu FfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=pAG+Hbz8E/kC8nCnHAyZdyyQ7vdaTJRYY8VFyU1dTtg=; b=cAMNVCNjijdm9p1tM0CayzGe3kRsj+AXfAmbRZu6pgFUdhMRbK4SjspV7iOIByxCx+ hqP8O3g/egNY48Dy2K7AN7ixi+qkeDEgLulDdJy9u/YPi1JhabbJuiubUhSLL+DBS4fQ /jqTVawQiCS89xX+1B/y5LQ6pry34NNBan5icDKEEPqHoUuMtb8ynfIFK06nhtyBL0it cM8Gx7hEUxpCVaEtaZE47KTO0XzTjnztKqettb9NkWQiBLt1Cui6+Qkx1aab1mePhhIn aCZlsUVOLECzNBxs4QFDaljnrmIsxMQi91V7nAZYlGunuWzQnR1nHwM26Z4PnzPapR8C BKxg== X-Gm-Message-State: AHQUAuYzDOLGMymiekF6II76o4ozyx7RlTk+5Qeu9xYRCqvOFie3Dz33 hDccfYgtJXU4PbrZ+lO4POJhjS/qFPItdfjj7H15675y X-Google-Smtp-Source: AHgI3IaXG9negFqUfVQfQX9GeaWvYYC2Dva/R2fxbttAFYjGclZUJHV28xT+7svzucc1w5y7tEEOFzK7Z+13EqGNnwA= X-Received: by 2002:ac2:551d:: with SMTP id j29mr8430216lfk.143.1549135589670; Sat, 02 Feb 2019 11:26:29 -0800 (PST) MIME-Version: 1.0 From: Nicholas Drozd Date: Sat, 2 Feb 2019 13:26:16 -0600 Message-ID: Subject: Some EWW patches To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000088e0000580ee3ca6" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::12d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --00000000000088e0000580ee3ca6 Content-Type: text/plain; charset="UTF-8" One doc fix, one minor feature, one minor bug fix. Let me know if these attachments are a problem, and I can send the text of the patches individually. --00000000000088e0000580ee3ca6 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch" Content-Disposition: attachment; filename="0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrnv4vcq2 RnJvbSA2ZTQ5MWE5NGIwZDc4NTM5MzFjOTZlYmRjYzM5Y2QwNDVkYTU5ZmM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjUwOjAzIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAzLzNd ICogbGlzcC9uZXQvZXd3LmVsIChld3ctZG93bmxvYWQtY2FsbGJhY2spOiBGaXggZG93bmxvYWQK IFVSTCBwYXRoCgpQcmV2aW91c2x5IHRoaXMgd2Fzbid0IGhhbmRsaW5nIGRvd25sb2FkIFVSTHMg Y29ycmVjdGx5LCByZXN1bHRpbmcgaW4KYWxsIGRvd25sb2FkZWQgcGFnZXMgYmVpbmcgbmFtZWQg IiEiLCAiISgxKSIsIGV0Yy4KClRha2UgImh0dHBzOi8vZW1wdHlzcXVhLnJlL2Jsb2cvZ2V0YWRk cmluZm8tY3B5dGhvbi1tYWMtYW5kLWJzZC8iIGFzCmFuIGV4YW1wbGUuIGB1cmwtcGF0aC1hbmQt cXVlcnknIGJyZWFrcyB0aGlzIGRvd24gdG8KIi9ibG9nL2dldGFkZHJpbmZvLWNweXRob24tbWFj LWFuZC1ic2QvIiwgYW5kIHRoaXMgZ2V0cyBwYXNzZWQgdG8KYGZpbGUtbmFtZS1ub25kaXJlY3Rv cnknLiBCdXQgdGhhdCBwYXRoIGxvb2tzIGxpa2UgYSBkaXJlY3RvcnkgYmVjYXVzZQpvZiB0aGUg dHJhaWxpbmcgc2xhc2gsIHNvIGBld3ctZGVjb2RlLXVybC1maWxlLW5hbWUnIHdvdWxkIGVuZCB1 cCB3aXRoCmFuIGVtcHR5IHN0cmluZy4gSW5zdGVhZCwgcmVtb3ZlIHRoZSB0cmFpbGluZyBzbGFz aCBzbyB0aGF0IGEgbm9uZW1wdHkKZmlsZSBuYW1lIGlzIHBhc3NlZCBpbi4KLS0tCiBsaXNwL25l dC9ld3cuZWwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9saXNwL25ldC9ld3cuZWwgYi9saXNwL25ldC9ld3cuZWwKaW5k ZXggMGM4YmZmYTU3OS4uZGExODUzNWZkYiAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3LmVsCisr KyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtMTU0NCw3ICsxNTQ0LDcgQEAgZXd3LWRvd25sb2FkCiAo ZGVmdW4gZXd3LWRvd25sb2FkLWNhbGxiYWNrIChzdGF0dXMgdXJsKQogICAodW5sZXNzIChwbGlz dC1nZXQgc3RhdHVzIDplcnJvcikKICAgICAobGV0KiAoKG9iaiAodXJsLWdlbmVyaWMtcGFyc2Ut dXJsIHVybCkpCi0gICAgICAgICAgIChwYXRoIChjYXIgKHVybC1wYXRoLWFuZC1xdWVyeSBvYmop KSkKKyAgICAgICAgICAgKHBhdGggKHN0cmluZy1yZW1vdmUtc3VmZml4ICIvIiAoY2FyICh1cmwt cGF0aC1hbmQtcXVlcnkgb2JqKSkpKQogICAgICAgICAgICAoZmlsZSAoZXd3LW1ha2UtdW5pcXVl LWZpbGUtbmFtZQogICAgICAgICAgICAgICAgICAgKGV3dy1kZWNvZGUtdXJsLWZpbGUtbmFtZSAo ZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSBwYXRoKSkKICAgICAgICAgICAgICAgICAgIGV3dy1kb3du bG9hZC1kaXJlY3RvcnkpKSkKLS0gCjIuMTcuMQoK --00000000000088e0000580ee3ca6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch" Content-Disposition: attachment; filename="0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrnv4va60 RnJvbSBmYjk1Y2RkNTU2NDFhOGVhOWI0ODE3NjYwNGExNDIwZmYyY2JiN2JmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjMxOjQ0IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAxLzNd ICogZG9jL21pc2MvZXd3LnRleGkgKEJhc2ljcyk6IEZpeCBld3cgbWFudWFsIGtleWJpbmRpbmcK CkMgaXMgYm91bmQgdG8gdXJsLWNvb2tpZS1saXN0LgotLS0KIGRvYy9taXNjL2V3dy50ZXhpIHwg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRleCBiMjk5 ZWExZmI3Li4wODhkYTZmNWZlIDEwMDY0NAotLS0gYS9kb2MvbWlzYy9ld3cudGV4aQorKysgYi9k b2MvbWlzYy9ld3cudGV4aQpAQCAtMTE4LDcgKzExOCw3IEBAIEJhc2ljcwogQGZpbmRleCBld3ct dG9nZ2xlLWNvbG9ycwogQGZpbmRleCBzaHItdXNlLWNvbG9ycwogQGtpbmRleCBGCi0gIFRoZSBA a2Jke0N9IGNvbW1hbmQgKEBjb2Rle2V3dy10b2dnbGUtY29sb3JzfSkgdG9nZ2xlcyB3aGV0aGVy IHRvIHVzZQorICBUaGUgQGtiZHtNLUN9IGNvbW1hbmQgKEBjb2Rle2V3dy10b2dnbGUtY29sb3Jz fSkgdG9nZ2xlcyB3aGV0aGVyIHRvIHVzZQogSFRNTC1zcGVjaWZpZWQgY29sb3JzIG9yIG5vdC4g IFRoaXMgc2V0cyB0aGUgQGNvZGV7c2hyLXVzZS1jb2xvcnN9IHZhcmlhYmxlLgogCiBAZmluZGV4 IGV3dy1kb3dubG9hZAotLSAKMi4xNy4xCgo= --00000000000088e0000580ee3ca6 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-eww-download-Use-link-under-point-or-current-URL.patch" Content-Disposition: attachment; filename="0002-eww-download-Use-link-under-point-or-current-URL.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrnv4vbp1 RnJvbSA5ZDYwZWM3MTI2MGY2Mjc5NDBkMTc5ZTNiZDU1OTAxNGI2YzVhMTVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjM1OjAyIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAyLzNd IGV3dy1kb3dubG9hZDogVXNlIGxpbmsgdW5kZXIgcG9pbnQgb3IgY3VycmVudCBVUkwKCiogbGlz cC9uZXQvZXd3LmVsIChld3ctZG93bmxvYWQpCiogZG9jL21pc2MvZXd3LnRleGkgKEJhc2ljcykK LS0tCiBkb2MvbWlzYy9ld3cudGV4aSB8IDcgKysrKy0tLQogbGlzcC9uZXQvZXd3LmVsICAgfCA2 ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRl eCAwODhkYTZmNWZlLi43OTE3NWQxMGE5IDEwMDY0NAotLS0gYS9kb2MvbWlzYy9ld3cudGV4aQor KysgYi9kb2MvbWlzYy9ld3cudGV4aQpAQCAtMTI1LDkgKzEyNSwxMCBAQCBCYXNpY3MKIEB2aW5k ZXggZXd3LWRvd25sb2FkLWRpcmVjdG9yeQogQGtpbmRleCBkCiBAY2luZGV4IERvd25sb2FkCi0g IEEgVVJMIHVuZGVyIHRoZSBwb2ludCBjYW4gYmUgZG93bmxvYWRlZCB3aXRoIEBrYmR7ZH0KLShA Y29kZXtld3ctZG93bmxvYWR9KS4gIFRoZSBmaWxlIHdpbGwgYmUgd3JpdHRlbiB0byB0aGUgZGly ZWN0b3J5Ci1zcGVjaWZpZWQgaW4gQGNvZGV7ZXd3LWRvd25sb2FkLWRpcmVjdG9yeX0gKERlZmF1 bHQ6IEBmaWxle34vRG93bmxvYWRzL30pLgorICBBIFVSTCBjYW4gYmUgZG93bmxvYWRlZCB3aXRo IEBrYmR7ZH0gKEBjb2Rle2V3dy1kb3dubG9hZH0pLiAgVGhpcword2lsbCBkb3dubG9hZCB0aGUg bGluayB1bmRlciBwb2ludCBpZiB0aGVyZSBpcyBvbmUsIG9yIGVsc2UgdGhlIFVSTCBvZgordGhl IGN1cnJlbnQgcGFnZS4gVGhlIGZpbGUgd2lsbCBiZSB3cml0dGVuIHRvIHRoZSBkaXJlY3Rvcnkg c3BlY2lmaWVkCitpbiBAY29kZXtld3ctZG93bmxvYWQtZGlyZWN0b3J5fSAoRGVmYXVsdDogQGZp bGV7fi9Eb3dubG9hZHMvfSkuCiAKIEBmaW5kZXggZXd3LWJhY2stdXJsCiBAZmluZGV4IGV3dy1m b3J3YXJkLXVybApkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvZXd3LmVsIGIvbGlzcC9uZXQvZXd3LmVs CmluZGV4IDNiN2Q5ZDVjMmYuLjBjOGJmZmE1NzkgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2V3dy5l bAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTE1MzEsMTAgKzE1MzEsMTIgQEAgZXd3LWNvcHkt cGFnZS11cmwKICAgKGtpbGwtbmV3IChwbGlzdC1nZXQgZXd3LWRhdGEgOnVybCkpKQogCiAoZGVm dW4gZXd3LWRvd25sb2FkICgpCi0gICJEb3dubG9hZCBVUkwgdW5kZXIgcG9pbnQgdG8gYGV3dy1k b3dubG9hZC1kaXJlY3RvcnknLiIKKyAgIkRvd25sb2FkIFVSTCB0byBgZXd3LWRvd25sb2FkLWRp cmVjdG9yeScuCitVc2UgbGluayB1bmRlciBwb2ludCBpZiB0aGVyZSBpcyBvbmUsIGVsc2UgdGhl IGN1cnJlbnQgcGFnZSBVUkwuIgogICAoaW50ZXJhY3RpdmUpCiAgIChhY2Nlc3MtZmlsZSBld3ct ZG93bmxvYWQtZGlyZWN0b3J5ICJEb3dubG9hZCBmYWlsZWQiKQotICAobGV0ICgodXJsIChnZXQt dGV4dC1wcm9wZXJ0eSAocG9pbnQpICdzaHItdXJsKSkpCisgIChsZXQgKCh1cmwgKG9yIChnZXQt dGV4dC1wcm9wZXJ0eSAocG9pbnQpICdzaHItdXJsKQorICAgICAgICAgICAgICAgICAoZXd3LWN1 cnJlbnQtdXJsKSkpKQogICAgIChpZiAobm90IHVybCkKICAgICAgICAgKG1lc3NhZ2UgIk5vIFVS TCB1bmRlciBwb2ludCIpCiAgICAgICAodXJsLXJldHJpZXZlIHVybCAnZXd3LWRvd25sb2FkLWNh bGxiYWNrIChsaXN0IHVybCkpKSkpCi0tIAoyLjE3LjEKCg== --00000000000088e0000580ee3ca6-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 14:54:23 2019 Received: (at 34291) by debbugs.gnu.org; 2 Feb 2019 19:54:23 +0000 Received: from localhost ([127.0.0.1]:56605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gq1Mt-000496-6B for submit@debbugs.gnu.org; Sat, 02 Feb 2019 14:54:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gq1Ms-00048t-4K for 34291@debbugs.gnu.org; Sat, 02 Feb 2019 14:54:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gq1Ml-00040W-G4; Sat, 02 Feb 2019 14:54:16 -0500 Received: from [176.228.60.248] (port=3883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gq1Mk-0008AE-Qt; Sat, 02 Feb 2019 14:54:15 -0500 Date: Sat, 02 Feb 2019 21:53:52 +0200 Message-Id: <83d0oavuen.fsf@gnu.org> From: Eli Zaretskii To: Nicholas Drozd In-reply-to: (message from Nicholas Drozd on Sat, 2 Feb 2019 13:26:16 -0600) Subject: Re: bug#34291: Some EWW patches References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34291 Cc: 34291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Nicholas Drozd > Date: Sat, 2 Feb 2019 13:26:16 -0600 > > Subject: [PATCH 3/3] * lisp/net/eww.el (eww-download-callback): Fix download > URL path > > Previously this wasn't handling download URLs correctly, resulting in > all downloaded pages being named "!", "!(1)", etc. > > Take "https://emptysqua.re/blog/getaddrinfo-cpython-mac-and-bsd/" as > an example. `url-path-and-query' breaks this down to > "/blog/getaddrinfo-cpython-mac-and-bsd/", and this gets passed to > `file-name-nondirectory'. But that path looks like a directory because > of the trailing slash, so `eww-decode-url-file-name' would end up with > an empty string. Instead, remove the trailing slash so that a nonempty > file name is passed in. This log message lacks the ChangeLog-style list of functions that are being changes, with short descriptions of the changes in each one. (Same problem with the second patch.) Also, please leave 2 spaces between sentences. > - (path (car (url-path-and-query obj))) > + (path (string-remove-suffix "/" (car (url-path-and-query obj)))) Please use directory-file-name here instead of string-remove-suffix. Btw, isn't it better to remove all the leading directories, leaving just the last component (a.k.a. the "basename")? > * lisp/net/eww.el (eww-download) > * doc/misc/eww.texi (Basics) This should tell what was changed in each function/node. See CONTRIBUTE, and the examples in the ChangeLog files in the tree. > +the current page. The file will be written to the directory specified ^^ Two spaces between sentences, please. > +in @code{eww-download-directory} (Default: @file{~/Downloads/}). The "Default" part should not be capitalized (it's not a separate sentence). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 04 19:27:11 2019 Received: (at 34291) by debbugs.gnu.org; 5 Feb 2019 00:27:11 +0000 Received: from localhost ([127.0.0.1]:59930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqoZz-00071l-65 for submit@debbugs.gnu.org; Mon, 04 Feb 2019 19:27:11 -0500 Received: from mail-lf1-f50.google.com ([209.85.167.50]:40390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqoZw-00071U-5I for 34291@debbugs.gnu.org; Mon, 04 Feb 2019 19:27:08 -0500 Received: by mail-lf1-f50.google.com with SMTP id v5so1341841lfe.7 for <34291@debbugs.gnu.org>; Mon, 04 Feb 2019 16:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/sLNJzBt8BVGxOMoW+Wze6RNVzgc2+jtGpRJr/zXvgc=; b=ZVW2el/dtygsw6IK/ZbOGNdt1OC1l7kuXD44Wsd0vm+usIUWdIlhO9XCEoipjHhL/7 1LM7mJWzLR38ogYn86+YwGtDOGXttcMxmTyEmwSeMh33PIKpssZtjFdYHRlqmajoFTqM dHHp7slTyuJuQiveQng20ibHX/IypENrVWW9tZovAI/Ob5U0eX1isSpyskvUWRgTuke5 Y0mKjrQshcfwtUcaTKmo/U/JCLRnmF0TRws2r1GnZSbWvwONH+w1sPB0UpUKlOHtklWQ Kes1bwV5hKXE2gBk++/baojA4ftbmNEFuha4ch1O2AXU/hj4p/iiZPDBRK9+BkbFrqiG AX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/sLNJzBt8BVGxOMoW+Wze6RNVzgc2+jtGpRJr/zXvgc=; b=JZ68Pbl0/VjRFXrN3en7ZJUfMPUUh6y9k9tsoL6ME3g2LUtk1IPE0o7A3QBA0afT4e tesj/zbkXNZM7OTmLElhMcn7NpPAE5UK0O+jKRZgjo4OXK7Jv1Ytf2MR2//wKHgV1PLh 5RrkVxOf/mjCr3JoPyIUNIKmZcRV4PELGnZ2TBpFX89OHSfiQPoA55ZOfTQMs+X5I26Q A2cHrIZXhxcun1osSbKDBO9+f8X7D1wofq88uol+3HZ+nSxWxsqbUGH+AmuEk8iur1LZ dP4H7u1bWFKfIISkcTh/+Hl3b/Pbu2rQpEWA4SiMasn3YHaajqfYdyC0IUpZmYzmL0xf 8Qzg== X-Gm-Message-State: AHQUAub98cu8H+TNHHFXlIsO1UnPsAqYiu9aYvkGOSD1ujysNGZwHAQ3 NFr1ptOaQhwjd6wb5GL+CrDvHJcl9LgSijDjK6I= X-Google-Smtp-Source: AHgI3IYETbs2gxJYpKBw5wPRKq5s7IF2ORRmWsy2UG7Br8KgS3ujSBH79utvF8qm04cKTYH3aguW3yka8stfE84cBy0= X-Received: by 2002:a19:a98f:: with SMTP id s137mr1347663lfe.18.1549326421543; Mon, 04 Feb 2019 16:27:01 -0800 (PST) MIME-Version: 1.0 References: <83d0oavuen.fsf@gnu.org> In-Reply-To: <83d0oavuen.fsf@gnu.org> From: Nicholas Drozd Date: Mon, 4 Feb 2019 18:26:49 -0600 Message-ID: Subject: Re: bug#34291: Some EWW patches To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000003c5a05811aab87" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34291 Cc: 34291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000003c5a05811aab87 Content-Type: text/plain; charset="UTF-8" Feel free to fix any remaining formatting / style issues. On Sat, Feb 2, 2019 at 1:54 PM Eli Zaretskii wrote: > > > From: Nicholas Drozd > > Date: Sat, 2 Feb 2019 13:26:16 -0600 > > > > Subject: [PATCH 3/3] * lisp/net/eww.el (eww-download-callback): Fix download > > URL path > > > > Previously this wasn't handling download URLs correctly, resulting in > > all downloaded pages being named "!", "!(1)", etc. > > > > Take "https://emptysqua.re/blog/getaddrinfo-cpython-mac-and-bsd/" as > > an example. `url-path-and-query' breaks this down to > > "/blog/getaddrinfo-cpython-mac-and-bsd/", and this gets passed to > > `file-name-nondirectory'. But that path looks like a directory because > > of the trailing slash, so `eww-decode-url-file-name' would end up with > > an empty string. Instead, remove the trailing slash so that a nonempty > > file name is passed in. > > This log message lacks the ChangeLog-style list of functions that are > being changes, with short descriptions of the changes in each one. > (Same problem with the second patch.) > > Also, please leave 2 spaces between sentences. > > > - (path (car (url-path-and-query obj))) > > + (path (string-remove-suffix "/" (car (url-path-and-query obj)))) > > Please use directory-file-name here instead of string-remove-suffix. > > Btw, isn't it better to remove all the leading directories, leaving > just the last component (a.k.a. the "basename")? > > > * lisp/net/eww.el (eww-download) > > * doc/misc/eww.texi (Basics) > > This should tell what was changed in each function/node. See > CONTRIBUTE, and the examples in the ChangeLog files in the tree. > > > +the current page. The file will be written to the directory specified > ^^ > Two spaces between sentences, please. > > > +in @code{eww-download-directory} (Default: @file{~/Downloads/}). > > The "Default" part should not be capitalized (it's not a separate > sentence). > > Thanks. --000000000000003c5a05811aab87 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Use-link-under-point-or-current-URL-for-eww-download.patch" Content-Disposition: attachment; filename="0002-Use-link-under-point-or-current-URL-for-eww-download.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrr0slkx1 RnJvbSBlNTY5ZDI0YTFmODAwNDE5NDczZTI5M2RkMTM1NDBjNTk1YzZiNTdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjM1OjAyIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAyLzNd IFVzZSBsaW5rIHVuZGVyIHBvaW50IG9yIGN1cnJlbnQgVVJMIGZvciBld3ctZG93bmxvYWQKCiog bGlzcC9uZXQvZXd3LmVsIChld3ctZG93bmxvYWQpOiBQcmV2aW91c2x5IHRoZSBiZWhhdmlvciB3 YXMgdGhlIHVzZQp0aGUgbGluayB1bmRlciBwb2ludCBvciBlcnJvciBpZiB0aGVyZSB3YXNuJ3Qg b25lLgoqIGRvYy9taXNjL2V3dy50ZXhpIChCYXNpY3MpOiBVcGRhdGUgZG9jdW1lbnRhdGlvbi4K LS0tCiBkb2MvbWlzYy9ld3cudGV4aSB8IDcgKysrKy0tLQogbGlzcC9uZXQvZXd3LmVsICAgfCA2 ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRl eCAwODhkYTZmNWZlLi5kN2RjMzI4NDZlIDEwMDY0NAotLS0gYS9kb2MvbWlzYy9ld3cudGV4aQor KysgYi9kb2MvbWlzYy9ld3cudGV4aQpAQCAtMTI1LDkgKzEyNSwxMCBAQCBCYXNpY3MKIEB2aW5k ZXggZXd3LWRvd25sb2FkLWRpcmVjdG9yeQogQGtpbmRleCBkCiBAY2luZGV4IERvd25sb2FkCi0g IEEgVVJMIHVuZGVyIHRoZSBwb2ludCBjYW4gYmUgZG93bmxvYWRlZCB3aXRoIEBrYmR7ZH0KLShA Y29kZXtld3ctZG93bmxvYWR9KS4gIFRoZSBmaWxlIHdpbGwgYmUgd3JpdHRlbiB0byB0aGUgZGly ZWN0b3J5Ci1zcGVjaWZpZWQgaW4gQGNvZGV7ZXd3LWRvd25sb2FkLWRpcmVjdG9yeX0gKERlZmF1 bHQ6IEBmaWxle34vRG93bmxvYWRzL30pLgorICBBIFVSTCBjYW4gYmUgZG93bmxvYWRlZCB3aXRo IEBrYmR7ZH0gKEBjb2Rle2V3dy1kb3dubG9hZH0pLiAgVGhpcword2lsbCBkb3dubG9hZCB0aGUg bGluayB1bmRlciBwb2ludCBpZiB0aGVyZSBpcyBvbmUsIG9yIGVsc2UgdGhlIFVSTCBvZgordGhl IGN1cnJlbnQgcGFnZS4gIFRoZSBmaWxlIHdpbGwgYmUgd3JpdHRlbiB0byB0aGUgZGlyZWN0b3J5 IHNwZWNpZmllZAoraW4gQGNvZGV7ZXd3LWRvd25sb2FkLWRpcmVjdG9yeX0gKGRlZmF1bHQ6IEBm aWxle34vRG93bmxvYWRzL30pLgogCiBAZmluZGV4IGV3dy1iYWNrLXVybAogQGZpbmRleCBld3ct Zm9yd2FyZC11cmwKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3dy5l bAppbmRleCAzYjdkOWQ1YzJmLi4wYzhiZmZhNTc5IDEwMDY0NAotLS0gYS9saXNwL25ldC9ld3cu ZWwKKysrIGIvbGlzcC9uZXQvZXd3LmVsCkBAIC0xNTMxLDEwICsxNTMxLDEyIEBAIGV3dy1jb3B5 LXBhZ2UtdXJsCiAgIChraWxsLW5ldyAocGxpc3QtZ2V0IGV3dy1kYXRhIDp1cmwpKSkKIAogKGRl ZnVuIGV3dy1kb3dubG9hZCAoKQotICAiRG93bmxvYWQgVVJMIHVuZGVyIHBvaW50IHRvIGBld3ct ZG93bmxvYWQtZGlyZWN0b3J5Jy4iCisgICJEb3dubG9hZCBVUkwgdG8gYGV3dy1kb3dubG9hZC1k aXJlY3RvcnknLgorVXNlIGxpbmsgdW5kZXIgcG9pbnQgaWYgdGhlcmUgaXMgb25lLCBlbHNlIHRo ZSBjdXJyZW50IHBhZ2UgVVJMLiIKICAgKGludGVyYWN0aXZlKQogICAoYWNjZXNzLWZpbGUgZXd3 LWRvd25sb2FkLWRpcmVjdG9yeSAiRG93bmxvYWQgZmFpbGVkIikKLSAgKGxldCAoKHVybCAoZ2V0 LXRleHQtcHJvcGVydHkgKHBvaW50KSAnc2hyLXVybCkpKQorICAobGV0ICgodXJsIChvciAoZ2V0 LXRleHQtcHJvcGVydHkgKHBvaW50KSAnc2hyLXVybCkKKyAgICAgICAgICAgICAgICAgKGV3dy1j dXJyZW50LXVybCkpKSkKICAgICAoaWYgKG5vdCB1cmwpCiAgICAgICAgIChtZXNzYWdlICJObyBV UkwgdW5kZXIgcG9pbnQiKQogICAgICAgKHVybC1yZXRyaWV2ZSB1cmwgJ2V3dy1kb3dubG9hZC1j YWxsYmFjayAobGlzdCB1cmwpKSkpKQotLSAKMi4xNy4xCgo= --000000000000003c5a05811aab87 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch" Content-Disposition: attachment; filename="0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrr0slj80 RnJvbSBmYjk1Y2RkNTU2NDFhOGVhOWI0ODE3NjYwNGExNDIwZmYyY2JiN2JmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjMxOjQ0IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAxLzNd ICogZG9jL21pc2MvZXd3LnRleGkgKEJhc2ljcyk6IEZpeCBld3cgbWFudWFsIGtleWJpbmRpbmcK CkMgaXMgYm91bmQgdG8gdXJsLWNvb2tpZS1saXN0LgotLS0KIGRvYy9taXNjL2V3dy50ZXhpIHwg MiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRleCBiMjk5 ZWExZmI3Li4wODhkYTZmNWZlIDEwMDY0NAotLS0gYS9kb2MvbWlzYy9ld3cudGV4aQorKysgYi9k b2MvbWlzYy9ld3cudGV4aQpAQCAtMTE4LDcgKzExOCw3IEBAIEJhc2ljcwogQGZpbmRleCBld3ct dG9nZ2xlLWNvbG9ycwogQGZpbmRleCBzaHItdXNlLWNvbG9ycwogQGtpbmRleCBGCi0gIFRoZSBA a2Jke0N9IGNvbW1hbmQgKEBjb2Rle2V3dy10b2dnbGUtY29sb3JzfSkgdG9nZ2xlcyB3aGV0aGVy IHRvIHVzZQorICBUaGUgQGtiZHtNLUN9IGNvbW1hbmQgKEBjb2Rle2V3dy10b2dnbGUtY29sb3Jz fSkgdG9nZ2xlcyB3aGV0aGVyIHRvIHVzZQogSFRNTC1zcGVjaWZpZWQgY29sb3JzIG9yIG5vdC4g IFRoaXMgc2V0cyB0aGUgQGNvZGV7c2hyLXVzZS1jb2xvcnN9IHZhcmlhYmxlLgogCiBAZmluZGV4 IGV3dy1kb3dubG9hZAotLSAKMi4xNy4xCgo= --000000000000003c5a05811aab87 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch" Content-Disposition: attachment; filename="0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrr0sllj2 RnJvbSA2NGQ1OTgzYTE2ZmVlYzA1Nzg4OGZmODVjZDBiMDgxNzk4YmVjNGY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIERyb3pkIDxuaWNob2xhc2Ryb3pkQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEZlYiAyMDE5IDEyOjUwOjAzIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAzLzNd ICogbGlzcC9uZXQvZXd3LmVsIChld3ctZG93bmxvYWQtY2FsbGJhY2spOiBGaXggZG93bmxvYWQK IFVSTCBwYXRoCgpQcmV2aW91c2x5IHRoaXMgd2Fzbid0IGhhbmRsaW5nIGRvd25sb2FkIFVSTHMg Y29ycmVjdGx5LCByZXN1bHRpbmcgaW4KYWxsIGRvd25sb2FkZWQgcGFnZXMgYmVpbmcgbmFtZWQg IiEiLCAiISgxKSIsIGV0Yy4KLS0tCiBsaXNwL25ldC9ld3cuZWwgfCAyICstCiAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL25l dC9ld3cuZWwgYi9saXNwL25ldC9ld3cuZWwKaW5kZXggMGM4YmZmYTU3OS4uYmVjOTdiMTJkNiAx MDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3LmVsCisrKyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtMTU0 NCw3ICsxNTQ0LDcgQEAgZXd3LWRvd25sb2FkCiAoZGVmdW4gZXd3LWRvd25sb2FkLWNhbGxiYWNr IChzdGF0dXMgdXJsKQogICAodW5sZXNzIChwbGlzdC1nZXQgc3RhdHVzIDplcnJvcikKICAgICAo bGV0KiAoKG9iaiAodXJsLWdlbmVyaWMtcGFyc2UtdXJsIHVybCkpCi0gICAgICAgICAgIChwYXRo IChjYXIgKHVybC1wYXRoLWFuZC1xdWVyeSBvYmopKSkKKyAgICAgICAgICAgKHBhdGggKGRpcmVj dG9yeS1maWxlLW5hbWUgKGNhciAodXJsLXBhdGgtYW5kLXF1ZXJ5IG9iaikpKSkKICAgICAgICAg ICAgKGZpbGUgKGV3dy1tYWtlLXVuaXF1ZS1maWxlLW5hbWUKICAgICAgICAgICAgICAgICAgIChl d3ctZGVjb2RlLXVybC1maWxlLW5hbWUgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgcGF0aCkpCiAg ICAgICAgICAgICAgICAgICBld3ctZG93bmxvYWQtZGlyZWN0b3J5KSkpCi0tIAoyLjE3LjEKCg== --000000000000003c5a05811aab87-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 08 02:53:33 2019 Received: (at 34291-done) by debbugs.gnu.org; 8 Feb 2019 07:53:33 +0000 Received: from localhost ([127.0.0.1]:38870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gs0yb-0003jK-4C for submit@debbugs.gnu.org; Fri, 08 Feb 2019 02:53:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gs0ya-0003j8-Aq for 34291-done@debbugs.gnu.org; Fri, 08 Feb 2019 02:53:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs0yU-0004hT-SZ; Fri, 08 Feb 2019 02:53:26 -0500 Received: from [176.228.60.248] (port=3236 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gs0yU-00047A-Gr; Fri, 08 Feb 2019 02:53:26 -0500 Date: Fri, 08 Feb 2019 09:53:23 +0200 Message-Id: <83a7j6ra18.fsf@gnu.org> From: Eli Zaretskii To: Nicholas Drozd In-reply-to: (message from Nicholas Drozd on Mon, 4 Feb 2019 18:26:49 -0600) Subject: Re: bug#34291: Some EWW patches References: <83d0oavuen.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34291-done Cc: 34291-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Nicholas Drozd > Date: Mon, 4 Feb 2019 18:26:49 -0600 > Cc: 34291@debbugs.gnu.org > > Feel free to fix any remaining formatting / style issues. Done. Please note that user-visible changes in behavior (PATCH 1/3 below) should also be called out in NEWS. Closing the bug report. Thanks for working on this. From unknown Sat Jun 21 03:22:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Mar 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator