GNU bug report logs - #34291
Some EWW patches

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34291 in the body.
You can then email your comments to 34291 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Some EWW patches
Date: Sat, 2 Feb 2019 13:26:16 -0600

[Message part 1 (text/plain, inline)]

One doc fix, one minor feature, one minor bug fix.

Let me know if these attachments are a problem, and I can send the
text of the patches individually.

[0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch (text/x-patch, attachment)]

[0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch (text/x-patch, attachment)]

[0002-eww-download-Use-link-under-point-or-current-URL.patch (text/x-patch, attachment)]

Message #8 received at 34291 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Nicholas Drozd <nicholasdrozd <at> gmail.com>
Cc: 34291 <at> debbugs.gnu.org
Subject: Re: bug#34291: Some EWW patches
Date: Sat, 02 Feb 2019 21:53:52 +0200

> From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
> Date: Sat, 2 Feb 2019 13:26:16 -0600
> 
> Subject: [PATCH 3/3] * lisp/net/eww.el (eww-download-callback): Fix download
>  URL path
> 
> Previously this wasn't handling download URLs correctly, resulting in
> all downloaded pages being named "!", "!(1)", etc.
> 
> Take "https://emptysqua.re/blog/getaddrinfo-cpython-mac-and-bsd/" as
> an example. `url-path-and-query' breaks this down to
> "/blog/getaddrinfo-cpython-mac-and-bsd/", and this gets passed to
> `file-name-nondirectory'. But that path looks like a directory because
> of the trailing slash, so `eww-decode-url-file-name' would end up with
> an empty string. Instead, remove the trailing slash so that a nonempty
> file name is passed in.

This log message lacks the ChangeLog-style list of functions that are
being changes, with short descriptions of the changes in each one.
(Same problem with the second patch.)

Also, please leave 2 spaces between sentences.

> -           (path (car (url-path-and-query obj)))
> +           (path (string-remove-suffix "/" (car (url-path-and-query obj))))

Please use directory-file-name here instead of string-remove-suffix.

Btw, isn't it better to remove all the leading directories, leaving
just the last component (a.k.a. the "basename")?

> * lisp/net/eww.el (eww-download)
> * doc/misc/eww.texi (Basics)

This should tell what was changed in each function/node.  See
CONTRIBUTE, and the examples in the ChangeLog files in the tree.

> +the current page. The file will be written to the directory specified
                   ^^
Two spaces between sentences, please.

> +in @code{eww-download-directory} (Default: @file{~/Downloads/}).

The "Default" part should not be capitalized (it's not a separate
sentence).

Thanks.

Message #11 received at 34291 <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34291 <at> debbugs.gnu.org
Subject: Re: bug#34291: Some EWW patches
Date: Mon, 4 Feb 2019 18:26:49 -0600

[Message part 1 (text/plain, inline)]

Feel free to fix any remaining formatting / style issues.

On Sat, Feb 2, 2019 at 1:54 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
> > Date: Sat, 2 Feb 2019 13:26:16 -0600
> >
> > Subject: [PATCH 3/3] * lisp/net/eww.el (eww-download-callback): Fix download
> >  URL path
> >
> > Previously this wasn't handling download URLs correctly, resulting in
> > all downloaded pages being named "!", "!(1)", etc.
> >
> > Take "https://emptysqua.re/blog/getaddrinfo-cpython-mac-and-bsd/" as
> > an example. `url-path-and-query' breaks this down to
> > "/blog/getaddrinfo-cpython-mac-and-bsd/", and this gets passed to
> > `file-name-nondirectory'. But that path looks like a directory because
> > of the trailing slash, so `eww-decode-url-file-name' would end up with
> > an empty string. Instead, remove the trailing slash so that a nonempty
> > file name is passed in.
>
> This log message lacks the ChangeLog-style list of functions that are
> being changes, with short descriptions of the changes in each one.
> (Same problem with the second patch.)
>
> Also, please leave 2 spaces between sentences.
>
> > -           (path (car (url-path-and-query obj)))
> > +           (path (string-remove-suffix "/" (car (url-path-and-query obj))))
>
> Please use directory-file-name here instead of string-remove-suffix.
>
> Btw, isn't it better to remove all the leading directories, leaving
> just the last component (a.k.a. the "basename")?
>
> > * lisp/net/eww.el (eww-download)
> > * doc/misc/eww.texi (Basics)
>
> This should tell what was changed in each function/node.  See
> CONTRIBUTE, and the examples in the ChangeLog files in the tree.
>
> > +the current page. The file will be written to the directory specified
>                    ^^
> Two spaces between sentences, please.
>
> > +in @code{eww-download-directory} (Default: @file{~/Downloads/}).
>
> The "Default" part should not be capitalized (it's not a separate
> sentence).
>
> Thanks.

[0002-Use-link-under-point-or-current-URL-for-eww-download.patch (text/x-patch, attachment)]

[0001-doc-misc-eww.texi-Basics-Fix-eww-manual-keybinding.patch (text/x-patch, attachment)]

[0003-lisp-net-eww.el-eww-download-callback-Fix-download-U.patch (text/x-patch, attachment)]

Message #16 received at 34291-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Nicholas Drozd <nicholasdrozd <at> gmail.com>
Cc: 34291-done <at> debbugs.gnu.org
Subject: Re: bug#34291: Some EWW patches
Date: Fri, 08 Feb 2019 09:53:23 +0200

> From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
> Date: Mon, 4 Feb 2019 18:26:49 -0600
> Cc: 34291 <at> debbugs.gnu.org
> 
> Feel free to fix any remaining formatting / style issues.

Done.  Please note that user-visible changes in behavior (PATCH 1/3
below) should also be called out in NEWS.

Closing the bug report.  Thanks for working on this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.