From unknown Sat Jun 21 10:25:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34290 <34290@debbugs.gnu.org> To: bug#34290 <34290@debbugs.gnu.org> Subject: Status: [PATCH] checkdoc byte compile warnings Reply-To: bug#34290 <34290@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:25:54 +0000 retitle 34290 [PATCH] checkdoc byte compile warnings reassign 34290 emacs submitter 34290 Alex Branham severity 34290 wishlist tag 34290 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 10:48:03 2019 Received: (at submit) by debbugs.gnu.org; 2 Feb 2019 15:48:03 +0000 Received: from localhost ([127.0.0.1]:56521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpxWV-0006Bc-DK for submit@debbugs.gnu.org; Sat, 02 Feb 2019 10:48:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpxWU-0006B9-CD for submit@debbugs.gnu.org; Sat, 02 Feb 2019 10:48:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:55341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpxWN-0002Ti-01 for submit@debbugs.gnu.org; Sat, 02 Feb 2019 10:47:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpxWM-00021d-4z for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 10:47:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpxWL-0002TG-D2 for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 10:47:54 -0500 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:34283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpxWJ-0002Sg-Fg for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 10:47:53 -0500 Received: by mail-ot1-x32a.google.com with SMTP id t5so8722510otk.1 for ; Sat, 02 Feb 2019 07:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=+7iWqKk5YqrpWkP7Qgdw54Q/Cq3kYCCbepNQpESe2B4=; b=FZJMGtgDaxgY0Y9+e8qFo2Z/2U/uS/W9nT4lo5PiKeHcNG8EPOTUJDSfnwIgCZJ4LG 1Er3sBhZLsXfcU0yGZMS6tHPKHUFYaqlcauIntzgDoSulZD/i3oRABvoXPdhBHmop92V wQ5x0A7OMSB9M1+B7+kheqxyrRDU/6mjLl1+B1D9G4LEdHgGEmKfKELC/bx0yYD/Ho1z k/Fk8arJN8fRQPnFYzE7Pq3a8hVJLp9fyF26ckVFXuL7O7cbxcNXkIO8U7579Vnx/gTB 2Rj2NdkGqbh14eugqGa0ZeT5ASiIwzvDhSF7oo2X757eKjw/unEJpDYXG+7PA92cNOiB T4rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=+7iWqKk5YqrpWkP7Qgdw54Q/Cq3kYCCbepNQpESe2B4=; b=TmBRUhJ0HWKCHWlcBKYNw/KyXjuU+yczQPv6cKrLo0n0ebyX5oGJK2asaDW7dfIT2M ksMIsxXtSiGQsJ/mWW7SpzcA07/kCUgqze+JMONEc25Y2pegFGtVwgCitb/Zk9iLQWRH lHmqgVwUWthQ/HVv3+Ezy0nqUqsTWAjlTMByySBfI+GtJ8zfIMS28IcBTAgLI+Idqhao hgDuqVK6+u+VdwuHHPUPpvBel/1he4GMIi0kjaIdoD2IWiTDrv2mB+oGqg6FiiKmOfR3 QdAZ8i2BfkpttB33g7UcXi9tuunvHN9Wlf7k9gGly6A8AMp5F6TyF0HwUdjJ+vBMJoB6 Wueg== X-Gm-Message-State: AJcUukcc7eH7jcJ9kv4gUs1E9zc0C4sr2+NfsW85SRP3mXTsIipWzcC3 2tfqMkLV3A0Rb0K2Mvof/tMLe9xb X-Google-Smtp-Source: ALg8bN6L6IGQcVb4d1J2jOALnJRPt22PPd6dJ2sxK+5RbyuMm4hestl9/1cEatu8XLqzCL2jljD8kQ== X-Received: by 2002:a9d:2aa2:: with SMTP id e31mr29957545otb.246.1549122468899; Sat, 02 Feb 2019 07:47:48 -0800 (PST) Received: from mars (72-47-130-203.brhmcmtc01.res.dyn.suddenlink.net. [72.47.130.203]) by smtp.gmail.com with ESMTPSA id z9sm4945972oiz.21.2019.02.02.07.47.47 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Feb 2019 07:47:47 -0800 (PST) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: bug-gnu-emacs@gnu.org Subject: [PATCH] checkdoc byte compile warnings Date: Sat, 02 Feb 2019 09:47:45 -0600 Message-ID: <87zhre9opq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32a X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hi all - The attached patch fixes the byte compiler warnings that checkdoc issues currently by declaring the functions for the byte compiler. It also removes some old XEmacs compatibility code. Thanks, Alex --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-byte-compile-warnings-in-checkdoc.el.patch >From 78ec520b6214d768d340d0ab07159605e1f1b3e1 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Sat, 2 Feb 2019 09:45:11 -0600 Subject: [PATCH] Fix byte compile warnings in checkdoc.el * lisp/emacs-lisp/checkdoc.el (checkdoc-file-comments-engine): Fix byte compile warnings by declaring functions, remove XEmacs compatibility code. --- lisp/emacs-lisp/checkdoc.el | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index c0da61a589..1289e1cbc9 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -2205,21 +2205,17 @@ News agents may remove it" ;; (defvar generate-autoload-cookie) -(eval-when-compile (require 'lisp-mnt)) ; expand silly defsubsts -(declare-function lm-summary "lisp-mnt" (&optional file)) -(declare-function lm-section-start "lisp-mnt" (header &optional after)) -(declare-function lm-section-end "lisp-mnt" (header)) +(declare-function lm-summary "lisp-mnt" (&optional file)) +(declare-function lm-commentary-mark "lisp-mnt") +(declare-function lm-history-mark "lisp-mnt") +(declare-function lm-code-mark "lisp-mnt") +(declare-function lm-commentary-end "lisp-mnt") (defun checkdoc-file-comments-engine () "Return a message list if this file does not match the Emacs standard. This checks for style only, such as the first line, Commentary:, Code:, and others referenced in the style guide." - (if (featurep 'lisp-mnt) - nil - (require 'lisp-mnt) - ;; Old XEmacs don't have `lm-commentary-mark' - (if (and (not (fboundp 'lm-commentary-mark)) (fboundp 'lm-commentary)) - (defalias 'lm-commentary-mark #'lm-commentary))) + (require 'lisp-mnt) (save-excursion (let* ((f1 (file-name-nondirectory (buffer-file-name))) (fn (file-name-sans-extension f1)) @@ -2280,7 +2276,7 @@ Code:, and others referenced in the style guide." (if (or (not checkdoc-force-history-flag) (file-exists-p "ChangeLog") (file-exists-p "../ChangeLog") - (and (fboundp 'lm-history-mark) (funcall #'lm-history-mark))) + (lm-history-mark)) nil (progn (goto-char (or (lm-commentary-mark) (point-min))) -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 11:06:58 2019 Received: (at 34290) by debbugs.gnu.org; 2 Feb 2019 16:06:58 +0000 Received: from localhost ([127.0.0.1]:56530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpxoo-0006fQ-J0 for submit@debbugs.gnu.org; Sat, 02 Feb 2019 11:06:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpxom-0006fE-Am for 34290@debbugs.gnu.org; Sat, 02 Feb 2019 11:06:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpxoZ-00011c-Ox; Sat, 02 Feb 2019 11:06:47 -0500 Received: from [176.228.60.248] (port=1601 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gpxoY-0001Zf-By; Sat, 02 Feb 2019 11:06:43 -0500 Date: Sat, 02 Feb 2019 18:06:22 +0200 Message-Id: <83imy2w4xt.fsf@gnu.org> From: Eli Zaretskii To: Alex Branham In-reply-to: <87zhre9opq.fsf@gmail.com> (message from Alex Branham on Sat, 02 Feb 2019 09:47:45 -0600) Subject: Re: bug#34290: [PATCH] checkdoc byte compile warnings References: <87zhre9opq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34290 Cc: 34290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Date: Sat, 02 Feb 2019 09:47:45 -0600 > > The attached patch fixes the byte compiler warnings that checkdoc issues > currently by declaring the functions for the byte compiler. It also > removes some old XEmacs compatibility code. Thanks. Can you explain the purpose of requiring lisp-mnt inside a function, as opposed to at the top level? The latter would then remove the need for using declare-function, I think. AFAIU, declare-function is useful when the function in question is auto-loaded, but we don't want to load its package unconditionally, e.g. because that function is used only in a small part of the package being compiled. None of which seems to be the case here, or did I miss something? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 11:28:23 2019 Received: (at 34290) by debbugs.gnu.org; 2 Feb 2019 16:28:23 +0000 Received: from localhost ([127.0.0.1]:56537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpy9X-0007Be-FN for submit@debbugs.gnu.org; Sat, 02 Feb 2019 11:28:23 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:45976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpy9V-0007BS-U2 for 34290@debbugs.gnu.org; Sat, 02 Feb 2019 11:28:22 -0500 Received: by mail-oi1-f195.google.com with SMTP id y1so8314064oie.12 for <34290@debbugs.gnu.org>; Sat, 02 Feb 2019 08:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=8Jaub9lnAxLB1DVHoaY42LN/tZgqhEgqOi2h0p5JyOI=; b=SdlbxqyIHC8TGZfvoLMIdqPLpRXfH/JdoS9BBK76uWO85iifTyqzzDmLsQfNRRl/GZ iYL2B3gpqZDf/jnd2pJE9DFi+99fBbYjnxdIMmvYQlnoh8Bunn6FqUNqmq4cpHCXgk4E Ut4GdDD/BNqE9ZoTW7E0+P9b+gE7/Vc+z7LUyx9wj6j2MI76peWEGMZcYqfacwFUOvin Le4zl9RB7YrJ8EO3Mr/459cEIAYnt011YsRN1n3RqPLSWCQLPOq/0lLm5KodXryKzzFN Rirbe+sUce6OceoGtaxT4kN8cgjl846kAl1KwPxvEprzhIJxRNTG7MdaWejjlWRFXadr USpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=8Jaub9lnAxLB1DVHoaY42LN/tZgqhEgqOi2h0p5JyOI=; b=RfXS14pjunBy1EaxlALzCGihm0dbUp19ISIyzfUewHU8lGoE9+zdbYupIbc2c2UAhU 2NFz43wV27q3P2VUIylKqQFju3Wc0DECpN7TwOba3CouxZJUKxFmeLOa5VtZBxEX5zta taqd58Ym/AsnmT5Gw9Q+C5PwVa9N7mZl59cOljN51tgkvfnOAKi8Ay2RuQSp2M5g3cNz unCVDmo87uLjNyx1t77vZOXIxNJauSnW79gEsjq23ltkWz5lP058IDuN8b8zKlxR2/K2 7rHxWQSSOs53++jAmVC3z0omebcvPjNJ+55qmEA+kkj4PyHRrrhDPKTMoXCdGj6wtiNt wL6g== X-Gm-Message-State: AHQUAuaEqdmsgkP0nn8SoXkTUHvp6DNSYcxywjrmrVVriNeHJ3ItVkex kZHOSOpGeepkEmTgqecgkpgsnu2A X-Google-Smtp-Source: ALg8bN6+EjBBOTXxFb5/6h0aTzvb9v1DrzGvnWAFgoyUHhlPobzsK16nVjt4kt/EkoUIXwC2mlNNXA== X-Received: by 2002:aca:e6c1:: with SMTP id d184mr20808407oih.316.1549124895713; Sat, 02 Feb 2019 08:28:15 -0800 (PST) Received: from mars (72-47-130-203.brhmcmtc01.res.dyn.suddenlink.net. [72.47.130.203]) by smtp.gmail.com with ESMTPSA id 62sm4179845otu.42.2019.02.02.08.28.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Feb 2019 08:28:14 -0800 (PST) References: <87zhre9opq.fsf@gmail.com> <83imy2w4xt.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: Eli Zaretskii Subject: Re: bug#34290: [PATCH] checkdoc byte compile warnings In-reply-to: <83imy2w4xt.fsf@gnu.org> Date: Sat, 02 Feb 2019 10:28:13 -0600 Message-ID: <87womi9mua.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34290 Cc: 34290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On Sat 02 Feb 2019 at 10:06, Eli Zaretskii wrote: > AFAIU, declare-function is useful when the function in question is > auto-loaded, but we don't want to load its package unconditionally, > e.g. because that function is used only in a small part of the package > being compiled. None of which seems to be the case here, or did I > miss something? I was just following with what the file was already doing. More than happy to require lisp-mnt top-level though, patch attached. Alex --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-byte-compile-warnings-in-checkdoc.el.patch Content-Transfer-Encoding: quoted-printable From=203327f9d74f6e063104726ec7aa4df805aa51decd Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Sat, 2 Feb 2019 09:45:11 -0600 Subject: [PATCH] Fix byte compile warnings in checkdoc.el * lisp/emacs-lisp/checkdoc.el (checkdoc-file-comments-engine): Fix byte compile warnings by requiring lisp-mnt top-level, remove XEmacs compatibility code. =2D-- lisp/emacs-lisp/checkdoc.el | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index c0da61a589..dca2f16956 100644 =2D-- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -174,6 +174,7 @@ (require 'cl-lib) (require 'help-mode) ;; for help-xref-info-regexp (require 'thingatpt) ;; for handy thing-at-point-looking-at +(require 'lisp-mnt) =20 (defvar compilation-error-regexp-alist) (defvar compilation-mode-font-lock-keywords) @@ -2205,21 +2206,10 @@ News agents may remove it" ;; (defvar generate-autoload-cookie) =20 =2D(eval-when-compile (require 'lisp-mnt)) ; expand silly defsubsts =2D(declare-function lm-summary "lisp-mnt" (&optional file)) =2D(declare-function lm-section-start "lisp-mnt" (header &optional after)) =2D(declare-function lm-section-end "lisp-mnt" (header)) =2D (defun checkdoc-file-comments-engine () "Return a message list if this file does not match the Emacs standard. This checks for style only, such as the first line, Commentary:, Code:, and others referenced in the style guide." =2D (if (featurep 'lisp-mnt) =2D nil =2D (require 'lisp-mnt) =2D ;; Old XEmacs don't have `lm-commentary-mark' =2D (if (and (not (fboundp 'lm-commentary-mark)) (fboundp 'lm-commentary= )) =2D (defalias 'lm-commentary-mark #'lm-commentary))) (save-excursion (let* ((f1 (file-name-nondirectory (buffer-file-name))) (fn (file-name-sans-extension f1)) @@ -2280,7 +2270,7 @@ Code:, and others referenced in the style guide." (if (or (not checkdoc-force-history-flag) (file-exists-p "ChangeLog") (file-exists-p "../ChangeLog") =2D (and (fboundp 'lm-history-mark) (funcall #'lm-history-ma= rk))) + (lm-history-mark)) nil (progn (goto-char (or (lm-commentary-mark) (point-min))) =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxVxR0ACgkQHkInolPp msf1eQf/VLHBbSHIGAtSaWQN1timGr4no8BISazhZ22VZSIDsHwMTdTSW3Vyafy9 fenurJ6kgeQ0Io22v09Q89Yvl1hvU0pQDojvIHbhrEYjvzlAHcg1oMyV6ufm3hkg 6fuv8aeKkf3xOyLmgPxhzucRFdSpe8yV7R2c2g8cpNmg2NJV/QyCsB3dY7wBdXSK nSUs5nFKGYaC2dDW8j9XU4S2M7DLjld7eDcH5kf2jpFcXhLIx1ZYxn2V0Vl922BW DO506HXfAgSykb7Xm4bsoLW6WbOBygJec3jlPG4HeCkbwZd/aUcjQfrDqLQNUbgn UidhEJ4OIuq+y3cJhMO1UJ/TkGqITQ== =AVvL -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 02 11:36:09 2019 Received: (at 34290) by debbugs.gnu.org; 2 Feb 2019 16:36:10 +0000 Received: from localhost ([127.0.0.1]:56547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpyH3-0007Oh-Nc for submit@debbugs.gnu.org; Sat, 02 Feb 2019 11:36:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpyH2-0007OU-1K for 34290@debbugs.gnu.org; Sat, 02 Feb 2019 11:36:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpyGo-0006fG-NA; Sat, 02 Feb 2019 11:35:54 -0500 Received: from [176.228.60.248] (port=3436 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gpyGm-0003zR-Qb; Sat, 02 Feb 2019 11:35:54 -0500 Date: Sat, 02 Feb 2019 18:35:27 +0200 Message-Id: <83ftt6w3lc.fsf@gnu.org> From: Eli Zaretskii To: Alex Branham In-reply-to: <87womi9mua.fsf@gmail.com> (message from Alex Branham on Sat, 02 Feb 2019 10:28:13 -0600) Subject: Re: bug#34290: [PATCH] checkdoc byte compile warnings References: <87zhre9opq.fsf@gmail.com> <83imy2w4xt.fsf@gnu.org> <87womi9mua.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34290 Cc: 34290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Cc: 34290@debbugs.gnu.org > Date: Sat, 02 Feb 2019 10:28:13 -0600 > > On Sat 02 Feb 2019 at 10:06, Eli Zaretskii wrote: > > > AFAIU, declare-function is useful when the function in question is > > auto-loaded, but we don't want to load its package unconditionally, > > e.g. because that function is used only in a small part of the package > > being compiled. None of which seems to be the case here, or did I > > miss something? > > I was just following with what the file was already doing. More than > happy to require lisp-mnt top-level though, patch attached. Thanks, this looks good. Let's wait for a few days for additional comments, if someone would like to voice them. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 08 17:28:07 2019 Received: (at 34290-done) by debbugs.gnu.org; 8 Feb 2019 22:28:07 +0000 Received: from localhost ([127.0.0.1]:40265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gsEcx-0001wC-4p for submit@debbugs.gnu.org; Fri, 08 Feb 2019 17:28:07 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:42190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gsEcv-0001vi-N7 for 34290-done@debbugs.gnu.org; Fri, 08 Feb 2019 17:28:06 -0500 Received: by mail-ot1-f42.google.com with SMTP id v23so8474692otk.9 for <34290-done@debbugs.gnu.org>; Fri, 08 Feb 2019 14:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=mlCgIkDxj8pbJyZxxg4KIYkgCd2EcaG0shjUsD31Zfk=; b=lwUGTpj5NQnoK+XrFl8HGwuwQ+TB1dFe287KKzWMtGGC/EfbDK4pPte6XVDBryOcKu 5ig8s8IAF/vnooT5lS5eZEwj6ZJyx7FW3ztmrdaH2rtyitcAOMRzIf2P7u7wU1rzZiFg VEP9rC8INCiVUYE6XBXI1EkzDdKThj4Go2pXCZV9gUYBR+NYQAvRvDYG0IPJqAjeyyFE CCtfm/a4icLPLD2IDEcdqNNaaJ5vlMIHBZnGmhN2SsLpjp5eqRUgDde/wPCW5sCEXFKj opHtvi/S9GIEYQsUqQsb0rb7wryqpunTLQ4N04ZISr/J282ho/ZruCZfHFcS/Mvu7++B /Dew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=mlCgIkDxj8pbJyZxxg4KIYkgCd2EcaG0shjUsD31Zfk=; b=LN6DuIyiXz/q4IDCfErCQ4WLNFxapsRplbNj1N5dBlvSATyoKae2UDzIRIkX8mvr4y 9tAz1Jf1s14Ow8gOx4ZqmZ5g22cFw58L/vS2qkYehavolPfJQNT5M343Ebi8qqPE4m+W z+g2IgsjLL6n4nWiOjzKUG+iVudE+mioF8VXSRaCSaZ+kl0jYQ4Q85s3i/aGKidr1Adi m5V+QUjEda0bbtPGPReAmeP3XOC+9fph4VijL4pkR6luTHXr+bp4AS8cWgDGXVhgcAcK y+hn1kFuxqLPzgPSMMYNuknjHYgaiY1kd5XgAlqEJHQmMxL+KAgibMv9iPktiXVXxaML 1PGg== X-Gm-Message-State: AHQUAuZBj/F6gkDA8QC1s7R8LWk3vc5OJBgj5uV3EV9Gh3lVxDSdar1P He4ZjEptIWlEMl0qQ3+TtDILCe7hsFw= X-Google-Smtp-Source: AHgI3IaXw4l6c/gTut2d3GAu879JEs84kSsM+G8tmBhLrhkJukCyx5Q47ECGOhBuJI+DcF2+imHClQ== X-Received: by 2002:a9d:7f8b:: with SMTP id t11mr7584136otp.351.1549664879598; Fri, 08 Feb 2019 14:27:59 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id k22sm1609512otj.25.2019.02.08.14.27.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 14:27:58 -0800 (PST) References: <87zhre9opq.fsf@gmail.com> <83imy2w4xt.fsf@gnu.org> <87womi9mua.fsf@gmail.com> <83ftt6w3lc.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: Eli Zaretskii Subject: Re: bug#34290: [PATCH] checkdoc byte compile warnings In-reply-to: <83ftt6w3lc.fsf@gnu.org> Date: Fri, 08 Feb 2019 16:27:57 -0600 Message-ID: <87pns1oqz6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34290-done Cc: 34290-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat 02 Feb 2019 at 10:35, Eli Zaretskii wrote: > Thanks, this looks good. Let's wait for a few days for additional > comments, if someone would like to voice them. Pushed as 1e155dcc8dcbaed926a1574bc543d404d2859866 From unknown Sat Jun 21 10:25:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Mar 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator