From unknown Sun Jun 22 17:09:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3429 <3429@debbugs.gnu.org> To: bug#3429 <3429@debbugs.gnu.org> Subject: Status: 23.0.91; solar.el: solar seasons variable should not be a constant Reply-To: bug#3429 <3429@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:09:46 +0000 retitle 3429 23.0.91; solar.el: solar seasons variable should not be a cons= tant reassign 3429 emacs submitter 3429 Teemu Likonen severity 3429 normal thanks From tlikonen@iki.fi Sun May 31 06:58:42 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 31 May 2009 13:58:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL,FVGT_m_MULTI_ODD, IMPRONONCABLE_2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4VDwbxi007503 for ; Sun, 31 May 2009 06:58:38 -0700 Received: from mail.gnu.org ([199.232.76.166]:42239 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MAlYa-0001AO-B0 for emacs-pretest-bug@gnu.org; Sun, 31 May 2009 09:58:36 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MAlYT-0006fm-Gu for emacs-pretest-bug@gnu.org; Sun, 31 May 2009 09:58:35 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:43290 helo=kirsi1.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAlYS-0006f8-Ow for emacs-pretest-bug@gnu.org; Sun, 31 May 2009 09:58:29 -0400 Received: from mithlond.arda.local (80.220.180.181) by kirsi1.inet.fi (8.5.014) id 49F6055A014979E9; Sun, 31 May 2009 16:58:27 +0300 Received: from dtw by mithlond.arda.local with local (Exim 4.69) (envelope-from ) id 1MAlYQ-0002Aa-NB; Sun, 31 May 2009 16:58:26 +0300 From: Teemu Likonen To: emacs-pretest-bug@gnu.org Cc: rfrancoise@debian.org Subject: 23.0.91; solar.el: solar seasons variable should not be a constant Date: Sun, 31 May 2009 16:58:26 +0300 Message-ID: <878wkdpe65.fsf@iki.fi> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: Quoted-Printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) This commit made solar-?-hemi-seasons constants: commit 7ac202f6ec47df634066e61cc4cf17705257d9dc Author: Glenn Morris Date: 2008-03-15 02:55:06 +0000 (solar-n-hemi-seasons, solar-s-hemi-seasons): Make constants. (solar-sunrise-sunset): Rename some local variables for clarity. (sunrise-sunset): Use zerop. (solar-mean-equinoxes/solstices): Doc fix. What is the rationale for that? They were defvars before. As the doc of "defconst" says "The intent is that neither programs nor users should ever change this value." Having solar seasons constants is not sensible because it's very useful to localize the solar seasons' names, and I'm trying to do exactly that with my Finnish localized holidays: http://www.emacswiki.org/emacs/suomalainen-kalenteri.el Yes, I can localize solar season by putting this in my ~/.emacs: (eval-after-load 'solar '(setq solar-n-hemi-seasons '("Kev=E4tp=E4iv=E4ntasaus" "Kes=E4p=E4= iv=E4nseisaus" "Syysp=E4iv=E4ntasaus" "Talvip=E4iv=E4= nseisaus") solar-s-hemi-seasons '("Syysp=E4iv=E4ntasaus" "Talvip=E4iv=E4= nseisaus" "Kev=E4tp=E4iv=E4ntasaus" "Kes=E4p=E4= iv=E4nseisaus"))) But this is not nice and it's difficult for external packages to localize those variables. I'd suggest making them defvas again (or defcustoms). From rgm@gnu.org Wed Jun 3 23:39:16 2009 Received: (at 3429-done) by emacsbugs.donarmstrong.com; 4 Jun 2009 06:39:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-8.3 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n546dC2W028104 for <3429-done@emacsbugs.donarmstrong.com>; Wed, 3 Jun 2009 23:39:14 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MC6bX-0008El-4D; Thu, 04 Jun 2009 02:39:11 -0400 From: Glenn Morris To: 3429-done@debbugs.gnu.org Subject: Re: bug#3429: 23.0.91; solar.el: solar seasons variable should not be a constant References: <878wkdpe65.fsf@iki.fi> X-Spook: NORAD weapons of mass destruction Firewalls kilderkin X-Ran: M6f@GV!;-,I)GNACf3(v]CH87de!vd+(`@n8c,9`e03Z^DHZfp1$c"QL(dlF^460gS+ndk X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 04 Jun 2009 02:39:10 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii OK, it's a defcustom. From unknown Sun Jun 22 17:09:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Jul 2009 14:24:18 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator