GNU bug report logs - #34285
grep.c should #include <strings.h>

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34285: closed (grep.c should #include <strings.h>)
Date: Sun, 03 Feb 2019 06:49:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 2 Feb 2019 22:48:47 -0800
with message-id <1ee9a30a-5ab3-7f66-2d1d-59fa43bd0c22 <at> cs.ucla.edu>
and subject line Re: bug#34285: grep.c should #include <strings.h>
has caused the debbugs.gnu.org bug report #34285,
regarding grep.c should #include <strings.h>
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34285: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34285
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: DAVID MONNIAUX <david.monniaux <at> univ-grenoble-alpes.fr>
To: bug-grep <at> gnu.org
Subject: grep.c should #include <strings.h>
Date: Sat, 2 Feb 2019 10:08:55 +0100 (CET)

[Message part 3 (text/plain, inline)]

grep.c should #include <strings.h> because it uses strcasecmp, and POSIX says it is declared in <strings.h> 

Not doing so results in a warning about an undeclared function on some systems (including Kalray k1c), thus possibly in incorrect code being generated. 


Directeur de recherche au CNRS, laboratoire VERIMAG, équipe PACSS 
http://www-verimag.imag.fr/~monniaux/ 

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: DAVID MONNIAUX <david.monniaux <at> univ-grenoble-alpes.fr>,
 34285-done <at> debbugs.gnu.org
Subject: Re: bug#34285: grep.c should #include <strings.h>
Date: Sat, 2 Feb 2019 22:48:47 -0800

[Message part 6 (text/plain, inline)]

DAVID MONNIAUX wrote:
> grep.c should #include <strings.h> because it uses strcasecmp, and POSIX says it is declared in <strings.h>

Thanks for reporting that. I fixed it as part of installing the attached patches.

[0001-build-update-gnulib-submodule-to-latest.patch (text/x-patch, attachment)]

[0002-grep-fix-grep.c-includes.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.