From unknown Sun Jun 22 08:05:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34280] [PATCH] gnu: Remove Go 1.9. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Feb 2019 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34280 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 34280@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154903918917366 (code B ref -1); Fri, 01 Feb 2019 16:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Feb 2019 16:39:49 +0000 Received: from localhost ([127.0.0.1]:55197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpbr2-0004W2-CL for submit@debbugs.gnu.org; Fri, 01 Feb 2019 11:39:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpbr0-0004Vn-AM for submit@debbugs.gnu.org; Fri, 01 Feb 2019 11:39:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:56189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpbqq-0001sY-QG for submit@debbugs.gnu.org; Fri, 01 Feb 2019 11:39:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbqo-0001gC-H6 for guix-patches@gnu.org; Fri, 01 Feb 2019 11:39:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpbqf-0001rA-J3 for guix-patches@gnu.org; Fri, 01 Feb 2019 11:39:30 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:32799) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpbqf-0001qs-51 for guix-patches@gnu.org; Fri, 01 Feb 2019 11:39:25 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 38D49218FD; Fri, 1 Feb 2019 11:39:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Feb 2019 11:39:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=wYdACBRzgBi92B2/BDQEEfK TYQZs1gSY2iHmSwYTowk=; b=vZ3ww5iTfLk6OKScyCMafyZbc59Lc5V0f7Dpqwj 7T19VlC5e0ozN2iRqmLXpbkHnfZc3VyvS+kjiq8NtBFGjD+ObxBp7QsYJj3eCNbY S3c4RaZchsSRllxOMVs/5xumt46z1CZ8cnUdTdg9soFtwyK2nB0lktd7Wka+k4BT 31vI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wYdACBRzgBi92B2/B DQEEfKTYQZs1gSY2iHmSwYTowk=; b=J+7c2VtBYi0zsBbA8TF2QJcv6TfGCZIT9 aM9sEhVlKASCAeNjeWcaSs5pMoVB0E7eT1hYwnjYsALIgHUJAZRAhnEzPXm3RWwx YIfjXlU+GwqFW4NBv5h+7IPlempXhw89voNYk+0225eTiUtd1UBckp89LFMU+Qar DbILQBG7BTmPqWglQqtWU1nLCn10nWP5WFnE8Jfm8p880NCar1Dk3Ai0mjBgNiWr Rg7Qjn+y3/CvYab4r5LExRlFWKRKJeHuwF+9cbZ8UldY86cflZKgQh/dC2mZvCQE WiftmMUtG63q6amzByBORyXBoJfYemEdCcEg6BFt1IfjnDVzF79Xg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeekgdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepnfgvoh cuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuffhomhgr ihhnpehtvghsthhshhhuthguohifnhhunhhigidrqdhnvghtpdhtvghsthgvgihtrhgrfh hilhgvshhrrggtvgdrqdhnvghtpdgtohhnthgrihhnvghrrddqnhgvthdpghhithhhuhgs rdgtohhmpdhgohhoghhlvggrphhishdrtghomhdptghonhhtrghinhgvrhdrnhgvthdpgh holhgrnhhgrdhorhhgpdhlugdqlhhinhhugidrqdhnvghtnecukfhppeektddrvdduhedr udeigedrvddtieenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrh hirdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from jasmine.lan (unknown [80.215.164.206]) by mail.messagingengine.com (Postfix) with ESMTPA id AC401E44A4 for ; Fri, 1 Feb 2019 11:39:22 -0500 (EST) From: Leo Famulari Date: Fri, 1 Feb 2019 17:39:17 +0100 Message-Id: <44056f4feec2eaccda588572e7f2e954cc788b41.1549039116.git.leo@famulari.name> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) We can wait to push this patch until there is another reason to change the Go compiler, but I am submitting it now in case anyone else is working on Go in Guix. * gnu/packages/golang.scm (go-1.9): Remove variable. (go-1.11): Inherit from go-1.4 and consolidate the inherited build phases from go-1.9. Go 1.11 should be essentially unchanged with this commit, although the derivation is different. --- gnu/packages/golang.scm | 224 ++++++++-------------------------------- 1 file changed, 43 insertions(+), 181 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index cedfabe5bf..6947ec39f9 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -223,11 +223,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (supported-systems '("x86_64-linux" "i686-linux" "armhf-linux" "aarch64-linux")) (license license:bsd-3))) -(define-public go-1.9 +(define-public go-1.11 (package (inherit go-1.4) (name "go") - (version "1.9.7") + (version "1.11.5") (source (origin (method url-fetch) @@ -235,13 +235,24 @@ in the style of communicating sequential processes (@dfn{CSP}).") name version ".src.tar.gz")) (sha256 (base32 - "08kpy874x0rx43zpyv5kwd8xj2ma91xm33i0ka2v1v788px18a2q")))) + "0gllmbjvp12iszwils8id78mvjxwviwf98lh2gdkb236n4mz07mw")))) (arguments (substitute-keyword-arguments (package-arguments go-1.4) ((#:phases phases) `(modify-phases ,phases + ;; XXX Work around the Go 1.11.5 tarbomb. + ;; + (add-after 'unpack 'tarbomb-workaround + (lambda _ + (chdir "..") + (delete-file-recursively "gocache") + (delete-file-recursively "tmp") + #t)) + (replace 'chdir + (lambda _ + (chdir "go/src") + #t)) (replace 'prebuild - ;; TODO: Most of this could be factorized with Go 1.4. (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")) (ld (string-append (assoc-ref inputs "libc") "/lib")) @@ -251,43 +262,48 @@ in the style of communicating sequential processes (@dfn{CSP}).") (string-append (assoc-ref inputs "tzdata") "/share/zoneinfo")) (output (assoc-ref outputs "out"))) - ;; Removing net/ tests, which fail when attempting to access - ;; network resources not present in the build container. (for-each delete-file + ;; Removing net/ tests, which fail when attempting to access + ;; network resources not present in the build container. '("net/listen_test.go" "net/parse_test.go" - "net/cgo_unix_test.go")) + "net/cgo_unix_test.go" + ;; A side effect of these test scripts is testing + ;; cgo. Attempts at using cgo flags and + ;; directives with these scripts as specified + ;; here (https://golang.org/cmd/cgo/) have not + ;; worked. The tests continue to state that they + ;; can not find crt1.o despite being present. + "cmd/go/testdata/script/list_compiled_imports.txt" + "cmd/go/testdata/script/mod_case_cgo.txt" + ;; https://github.com/golang/go/issues/24884 + "os/user/user_test.go")) (substitute* "os/os_test.go" (("/usr/bin") (getcwd)) (("/bin/pwd") (which "pwd")) (("/bin/sh") (which "sh"))) + (substitute* "cmd/vendor/golang.org/x/sys/unix/syscall_unix_test.go" + (("/usr/bin") "/tmp")) + ;; Add libgcc to runpath (substitute* "cmd/link/internal/ld/lib.go" (("!rpath.set") "true")) - (substitute* "cmd/go/internal/work/build.go" + (substitute* "cmd/go/internal/work/gccgo.go" (("cgoldflags := \\[\\]string\\{\\}") (string-append "cgoldflags := []string{" "\"-rpath=" gcclib "\"" "}")) + (("\"-lgcc_s\", ") + (string-append + "\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", "))) + (substitute* "cmd/go/internal/work/gc.go" (("ldflags = setextld\\(ldflags, compiler\\)") (string-append "ldflags = setextld(ldflags, compiler)\n" "ldflags = append(ldflags, \"-r\")\n" - "ldflags = append(ldflags, \"" gcclib "\")\n")) - (("\"-lgcc_s\", ") - (string-append - "\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", "))) - - ;; XXX Commit 65fa2b615b72c1fa61a7 in the Go repo. We do this - ;; without a patch because ((guix packages) patch-and-repack) - ;; resets file mtimes, and parts of Go's test suite rely on - ;; those timestamps. - ;; - (substitute* "cmd/internal/objfile/elf.go" - (("PT_LOAD") - "PT_LOAD && p.Flags&elf.PF_X != 0")) + "ldflags = append(ldflags, \"" gcclib "\")\n"))) ;; Disable failing tests: these tests attempt to access ;; commands or network resources which are neither available @@ -322,9 +338,6 @@ in the style of communicating sequential processes (@dfn{CSP}).") ("syscall/exec_linux_test.go" "(.+)(TestCloneNEWUSERAndRemapNoRootDisableSetgroups.+)"))) - (substitute* "../misc/cgo/testsanitizers/test.bash" - (("(CC=)cc" all var) (string-append var "gcc"))) - ;; fix shebang for testar script ;; note the target script is generated at build time. (substitute* "../misc/cgo/testcarchive/carchive_test.go" @@ -342,19 +355,10 @@ in the style of communicating sequential processes (@dfn{CSP}).") (add-before 'build 'set-bootstrap-variables (lambda* (#:key outputs inputs #:allow-other-keys) ;; Tell the build system where to find the bootstrap Go. - (let ((go (assoc-ref inputs "go")) - (out (assoc-ref outputs "out"))) + (let ((go (assoc-ref inputs "go"))) (setenv "GOROOT_BOOTSTRAP" go) - (setenv "PATH" - (string-append out "/bin:" - (dirname (getcwd)) "/bin:" - (getenv "PATH"))) - - ;; XXX: The following variables seem unrelated. (setenv "GOGC" "400") - (setenv "GO_TEST_TIMEOUT_SCALE" "9999") #t))) - (replace 'build (lambda* (#:key inputs outputs #:allow-other-keys) ;; FIXME: Some of the .a files are not bit-reproducible. @@ -375,6 +379,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (src (string-append (assoc-ref outputs "tests") "/share/" ,name "-" ,version))) (delete-file-recursively "../pkg/bootstrap") + ;; Prevent installation of the build cache, which contains + ;; store references to most of the tools used to build Go and + ;; would unnecessarily increase the size of Go's closure if it + ;; was installed. + (delete-file-recursively "../pkg/obj") (mkdir-p src) (copy-recursively "../test" (string-append src "/test")) @@ -402,153 +411,6 @@ in the style of communicating sequential processes (@dfn{CSP}).") ,@(package-native-inputs go-1.4))) (supported-systems %supported-systems))) -(define-public go-1.11 - (package - (inherit go-1.9) - (name "go") - (version "1.11.5") - (source - (origin - (method url-fetch) - (uri (string-append "https://storage.googleapis.com/golang/" - name version ".src.tar.gz")) - (sha256 - (base32 - "0gllmbjvp12iszwils8id78mvjxwviwf98lh2gdkb236n4mz07mw")))) - (arguments - (substitute-keyword-arguments (package-arguments go-1.9) - ((#:phases phases) - `(modify-phases ,phases - ;; XXX Work around the Go 1.11.5 tarbomb. - ;; - (add-after 'unpack 'tarbomb-workaround - (lambda _ - (chdir "..") - (delete-file-recursively "gocache") - (delete-file-recursively "tmp") - #t)) - (replace 'chdir - (lambda _ - (chdir "go/src") - #t)) - (replace 'prebuild - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")) - (ld (string-append (assoc-ref inputs "libc") "/lib")) - (loader (car (find-files ld "^ld-linux.+"))) - (net-base (assoc-ref inputs "net-base")) - (tzdata-path - (string-append (assoc-ref inputs "tzdata") "/share/zoneinfo")) - (output (assoc-ref outputs "out"))) - - (for-each delete-file - ;; Removing net/ tests, which fail when attempting to access - ;; network resources not present in the build container. - '("net/listen_test.go" - "net/parse_test.go" - "net/cgo_unix_test.go" - ;; A side effect of these test scripts is testing - ;; cgo. Attempts at using cgo flags and - ;; directives with these scripts as specified - ;; here (https://golang.org/cmd/cgo/) have not - ;; worked. The tests continue to state that they - ;; can not find crt1.o despite being present. - "cmd/go/testdata/script/list_compiled_imports.txt" - "cmd/go/testdata/script/mod_case_cgo.txt" - ;; https://github.com/golang/go/issues/24884 - "os/user/user_test.go")) - - (substitute* "os/os_test.go" - (("/usr/bin") (getcwd)) - (("/bin/pwd") (which "pwd")) - (("/bin/sh") (which "sh"))) - - (substitute* "cmd/vendor/golang.org/x/sys/unix/syscall_unix_test.go" - (("/usr/bin") "/tmp")) - - ;; Add libgcc to runpath - (substitute* "cmd/link/internal/ld/lib.go" - (("!rpath.set") "true")) - (substitute* "cmd/go/internal/work/gccgo.go" - (("cgoldflags := \\[\\]string\\{\\}") - (string-append "cgoldflags := []string{" - "\"-rpath=" gcclib "\"" - "}")) - (("\"-lgcc_s\", ") - (string-append - "\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", "))) - (substitute* "cmd/go/internal/work/gc.go" - (("ldflags = setextld\\(ldflags, compiler\\)") - (string-append - "ldflags = setextld(ldflags, compiler)\n" - "ldflags = append(ldflags, \"-r\")\n" - "ldflags = append(ldflags, \"" gcclib "\")\n"))) - - ;; Disable failing tests: these tests attempt to access - ;; commands or network resources which are neither available - ;; nor necessary for the build to succeed. - (for-each - (match-lambda - ((file regex) - (substitute* file - ((regex all before test_name) - (string-append before "Disabled" test_name))))) - '(("net/net_test.go" "(.+)(TestShutdownUnix.+)") - ("net/dial_test.go" "(.+)(TestDialTimeout.+)") - ("os/os_test.go" "(.+)(TestHostname.+)") - ("time/format_test.go" "(.+)(TestParseInSydney.+)") - ("time/format_test.go" "(.+)(TestParseInLocation.+)") - ("os/exec/exec_test.go" "(.+)(TestEcho.+)") - ("os/exec/exec_test.go" "(.+)(TestCommandRelativeName.+)") - ("os/exec/exec_test.go" "(.+)(TestCatStdin.+)") - ("os/exec/exec_test.go" "(.+)(TestCatGoodAndBadFile.+)") - ("os/exec/exec_test.go" "(.+)(TestExitStatus.+)") - ("os/exec/exec_test.go" "(.+)(TestPipes.+)") - ("os/exec/exec_test.go" "(.+)(TestStdinClose.+)") - ("os/exec/exec_test.go" "(.+)(TestIgnorePipeErrorOnSuccess.+)") - ("syscall/syscall_unix_test.go" "(.+)(TestPassFD\\(.+)") - ("os/exec/exec_test.go" "(.+)(TestExtraFiles/areturn.+)") - ("cmd/go/go_test.go" "(.+)(TestCoverageWithCgo.+)") - ("cmd/go/go_test.go" "(.+)(TestTwoPkgConfigs.+)") - ("os/exec/exec_test.go" "(.+)(TestOutputStderrCapture.+)") - ("os/exec/exec_test.go" "(.+)(TestExtraFiles.+)") - ("os/exec/exec_test.go" "(.+)(TestExtraFilesRace.+)") - ("net/lookup_test.go" "(.+)(TestLookupPort.+)") - ("syscall/exec_linux_test.go" - "(.+)(TestCloneNEWUSERAndRemapNoRootDisableSetgroups.+)"))) - - ;; fix shebang for testar script - ;; note the target script is generated at build time. - (substitute* "../misc/cgo/testcarchive/carchive_test.go" - (("#!/usr/bin/env") (string-append "#!" (which "env")))) - - (substitute* "net/lookup_unix.go" - (("/etc/protocols") (string-append net-base "/etc/protocols"))) - (substitute* "net/port_unix.go" - (("/etc/services") (string-append net-base "/etc/services"))) - (substitute* "time/zoneinfo_unix.go" - (("/usr/share/zoneinfo/") tzdata-path)) - (substitute* (find-files "cmd" "\\.go") - (("/lib(64)?/ld-linux.*\\.so\\.[0-9]") loader)) - #t))) - ;; Prevent installation of the build cache, which contains store - ;; references to most of the tools used to build Go and would - ;; unnecessarily increase the size of Go's closure if it was - ;; installed. - ;; TODO This should be moved into the 'install' phase when Go 1.9 is - ;; removed. - (add-before 'install 'delete-extraneous-files - (lambda _ - (delete-file-recursively "../pkg/obj") - #t)) - (replace 'set-bootstrap-variables - (lambda* (#:key outputs inputs #:allow-other-keys) - ;; Tell the build system where to find the bootstrap Go. - (let ((go (assoc-ref inputs "go"))) - (setenv "GOROOT_BOOTSTRAP" go) - (setenv "GOGC" "400") - #t))))))))) - (define-public go go-1.11) (define-public go-github-com-alsm-ioprogress -- 2.20.1 From unknown Sun Jun 22 08:05:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34280] [PATCH] gnu: Remove Go 1.9. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Mar 2019 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34280 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 34280@debbugs.gnu.org Received: via spool by 34280-submit@debbugs.gnu.org id=B34280.155172718923355 (code B ref 34280); Mon, 04 Mar 2019 19:20:02 +0000 Received: (at 34280) by debbugs.gnu.org; 4 Mar 2019 19:19:49 +0000 Received: from localhost ([127.0.0.1]:60203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0t7r-00064b-23 for submit@debbugs.gnu.org; Mon, 04 Mar 2019 14:19:48 -0500 Received: from flashner.co.il ([178.62.234.194]:45216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0t7p-00064O-F1 for 34280@debbugs.gnu.org; Mon, 04 Mar 2019 14:19:45 -0500 Received: from localhost (unknown [31.210.177.221]) by flashner.co.il (Postfix) with ESMTPSA id 25A9F401CD; Mon, 4 Mar 2019 19:19:39 +0000 (UTC) Date: Mon, 4 Mar 2019 21:19:37 +0200 From: Efraim Flashner Message-ID: <20190304191937.GB5771@macbook41> References: <44056f4feec2eaccda588572e7f2e954cc788b41.1549039116.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2B/JsCI69OhZNC5r" Content-Disposition: inline In-Reply-To: <44056f4feec2eaccda588572e7f2e954cc788b41.1549039116.git.leo@famulari.name> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --2B/JsCI69OhZNC5r Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 01, 2019 at 05:39:17PM +0100, Leo Famulari wrote: > We can wait to push this patch until there is another reason to change > the Go compiler, but I am submitting it now in case anyone else is > working on Go in Guix. >=20 > * gnu/packages/golang.scm (go-1.9): Remove variable. > (go-1.11): Inherit from go-1.4 and consolidate the inherited build > phases from go-1.9. >=20 > Go 1.11 should be essentially unchanged with this commit, although the > derivation is different. >=20 There's been no nay saying for a month, I think if nothing's using go@1.9 it's safe to remove --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --2B/JsCI69OhZNC5r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlx9ekkACgkQQarn3Mo9 g1F55RAAn6tXYWZ/NKjE1efxE4hN7+92FSCOFfZ4SkoEyWGBPmLoiDsETZ+uEG1m fU8uAKOGV4gtyBNamtJj416eRbSR1j4I8Wb3LjaD3vUnQtDYEHDdvuhS1sm69snJ XNA9TGdirkSPu0Md/0aXUhQ26Cp5GQxuT+41AiPL+yy/hb4IijtmBZnxisEIGyIM r3y2yqO3kC1gss+qpo5YrVDZkkLRoAezY3dxcfXm5Ca+z1JbuP4EsUDd5Ccp+wkk wPuKgbm51QYHInefaZ4h/o8vyyAUSY0MPMBlRmnSGTnw6niDBgsNk9tndfDZIXpj CiBFIeUrtvQ3VJSvm33cgTdCNmz97hicPopDe83Ql+yYm8VW4QKS630iDTT1j/sV wSwI6UV3gS1DUoQrpgy8XH5/Bm40tPtpYZ7wXbki3r+pjJzpm1EBJ9T412g/fqTQ EIyySOySnMGnLq7Jj8QjsMWXmhKnrUva9M97CWVCquy2m0e/jE71Cw+jGpDiLvUv MLQa6u3Wuc+UGb+IYnREuBa1KbxmPFNAX1SXiRJ38vIdkQ+q2osGXiCUA+r4ijM8 e5ecMf9tj4aMVD/dHRazRvwm9oZre0MIuPX7K1hlkXfK3IJoTm9iS8qy4FmaYHwE M866L6iZ0odFgAv1qIcKpzwMXV5M6lZQlZImeOaPtd/aWK7s4kc= =+AVY -----END PGP SIGNATURE----- --2B/JsCI69OhZNC5r-- From unknown Sun Jun 22 08:05:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#34280] [PATCH] gnu: Remove Go 1.9. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Mar 2019 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34280 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 34280@debbugs.gnu.org Received: via spool by 34280-submit@debbugs.gnu.org id=B34280.155172824725042 (code B ref 34280); Mon, 04 Mar 2019 19:38:02 +0000 Received: (at 34280) by debbugs.gnu.org; 4 Mar 2019 19:37:27 +0000 Received: from localhost ([127.0.0.1]:60232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0tOw-0006Vq-T1 for submit@debbugs.gnu.org; Mon, 04 Mar 2019 14:37:27 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:53101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0tOu-0006Vc-4X for 34280@debbugs.gnu.org; Mon, 04 Mar 2019 14:37:25 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AF9241BBE; Mon, 4 Mar 2019 14:37:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 04 Mar 2019 14:37:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=cbkNhfMJSm6Llw6kucry7Xmy G37Enfn1aPcIU1w/TCg=; b=EUARlydLxza5WVexmBD9immFX/T67drCsVl7eK2W 8nLtt7YXbolsgXEuKQPpcHuEoBx2kpZjtu0H7jS86qSwRd9M0CTq3zbAg88Ba8jQ noadtalr6dSdBheOHwwqHpmHvUAGorRu9qUDl7qPG0W5YePOKvqSo7mSXQ5rWD+w iqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=cbkNhf MJSm6Llw6kucry7XmyG37Enfn1aPcIU1w/TCg=; b=tz31V8NoH7xO1c38iwGjCR BSk0Pge4ejK2sGHDkQgb0CwqdCz08obLTAqUZ46ZyzgrK2WRiOY8aoGtKpD5xdWx Mn2cgo0BjVDbOsRpay6KTJL9s1qgx/FGWVX5Vsy1ckeeCBKJOK2meFK731SYTKQb nNYypfMPCSq49v+kMsX2qOECy/Fb++bQkAYHlnrfUcvRIYIR0eOyzdGxFEh0wtqs dTKkeqT0MIgSn92oy03CR+c9vd77mqnCHCGb++zdYvZ+Mg1x3PZyllrn2FdP2xbV oru2x3TiyD5Urmio7c9FIureRwU0e2TxG46aZ5ZdjBfPKd81mHW3/lygRK1NuM2g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfedugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesghdtreertdervdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejie druddvgedrvddtvddrudefjeenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgr mhhulhgrrhhirdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 0016E10336; Mon, 4 Mar 2019 14:37:15 -0500 (EST) Date: Mon, 4 Mar 2019 14:37:13 -0500 From: Leo Famulari Message-ID: <20190304193713.GA22643@jasmine.lan> References: <44056f4feec2eaccda588572e7f2e954cc788b41.1549039116.git.leo@famulari.name> <20190304191937.GB5771@macbook41> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <20190304191937.GB5771@macbook41> User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 04, 2019 at 09:19:37PM +0200, Efraim Flashner wrote: > There's been no nay saying for a month, I think if nothing's using > go@1.9 it's safe to remove Thanks, I've been waiting until we had another reason to rebuild all the Go packages. For example, an update to Go 1.12. I'm trying that now. --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlx9fmIACgkQJkb6MLrK fwhzgxAAxDErJzUfBLvT3+X2L0926I44RRmJpHUjnU4jlkvT0L2bQJgPVBDWVZFJ CTUyU4mdW5WuxJVC4Xgi6B5Fh3Bp/jxmII8EbKV4gmHLGSTHb9hkyeXm73b6W2g9 LzBYH7cD32mkQ/rmd/VFE3VUenhHmzPXVZkwdJsDDvbgIrNMZ90Tt8hgIpQSona9 qmv623wVh0b03Pv2gZ1img8hfrWmHbArC8HcpoZ4+JmkzDOqZ7yXoOY5wZqipYhD ijQpWE6Ahn56lUkGUaTnZ9lv/7pAz/w97GbEVLAr+Id6X7MbWhzRBvuDKWheGOkw 5XnNlTCJ2ZWL6zFLzkhO7I5A1J8vksSgCJdrPJglRa5ziybfINu26qolNYKI/a9C VebWr1fUTvHkp3S8nxt+3Z6/L1vPPJG/inTi6pe9i9ADT5esyj1XsJ+UHqajXtv4 lMyEuG6k70FyOZNr8wDZLEoObAFSz5GYGWqpTzzVyYN14WDQUsSEwEdGY4Cahokk vZ2R9ESfWqn3HEjxBhxNAihLpTkbwaG9yASxnNkNNMhriC/Ztz0+nBFZLSAPB7ny UIzfXhdkdhQW+z9ROAF4NY/QV3qRsHAHGh2LDXLFPkgVSN5SNq6cd02nemqdZJTF dC2zBLFQVO2aJadtehxR6XDo4EpsBjO57nEGbK0rY9lIrjWrfRI= =DoEP -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc-- From unknown Sun Jun 22 08:05:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Famulari Subject: bug#34280: closed ([PATCH] gnu: Remove Go 1.9.) Message-ID: References: <2cfd783f-66eb-4da3-98ab-96cd1a22c6c4@www.fastmail.com> <44056f4feec2eaccda588572e7f2e954cc788b41.1549039116.git.leo@famulari.name> X-Gnu-PR-Message: they-closed 34280 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 34280@debbugs.gnu.org Date: Sat, 20 Apr 2019 21:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1555796222-12878-1" This is a multi-part message in MIME format... ------------=_1555796222-12878-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #34280: [PATCH] gnu: Remove Go 1.9. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 34280@debbugs.gnu.org. --=20 34280: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34280 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1555796222-12878-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 34280-done) by debbugs.gnu.org; 20 Apr 2019 21:36:13 +0000 Received: from localhost ([127.0.0.1]:46925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHxef-0003KX-DU for submit@debbugs.gnu.org; Sat, 20 Apr 2019 17:36:13 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:56859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHxeb-0003KI-Cj for 34280-done@debbugs.gnu.org; Sat, 20 Apr 2019 17:36:11 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 392645F2 for <34280-done@debbugs.gnu.org>; Sat, 20 Apr 2019 17:36:03 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute6.internal (MEProxy); Sat, 20 Apr 2019 17:36:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ajgrf.com; h= mime-version:message-id:date:from:to:subject:content-type; s= fm2; bh=j64oqvIF8Wj3MWtTui2lTS/E/ShX/a8/z+2xSs6XoGs=; b=ObVUjEXF KNDg/LwUyZUI9GI5EEh3WMAKSgXlgMS7NBorl1KdZ6D57tl8bNAdKqB4/vcOjLH4 VZzQEGO1Uv3bJpj/Kq+iUrrABso8f4fyBSz/WK3h4gNk71JT4d4OSy2cAqH+Fg40 5OVHXpalanIdTTsm6R1ArS6OVoTIl7d670+PagGpwYT2GKMMPHVmuBnfZFzAm86O 2AMywb66h4nS5NlJEuZOGyMhwqAn5SC9tlAk2jN5VUy2XsGIiKqCOffReGBE+9iD jBLKvn9ch1NYuyIZfDAZhkmj/3pUg6fq4VJauHIy3vkpCi6lxUTeezSPaxJb0r3c R9y0z9C2dwduWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=j64oqvIF8Wj3MWtTui2lTS/E/ShX/ a8/z+2xSs6XoGs=; b=2ZC0jNi7ZA4kmtXUYG3DlKBjBuMex+YR8y7Obbqtu0/bq nUM8TiNx/LdY4OVbXWvG0AQpKJSsdUJUPfC4hu+JPUsHV6N0/RpkyBZ8u4JsEq1r +tw6DJlWWeXwTHgxl7QMBkYwSk7kuhKsD8vyrdnQP2vFyIGN2pf+022gL3vDWGTY A3U/S0qUtNYr5do5/wxsUkRMXhOJBrQVE7wmsiXR0P3Ap/AIwNev1SFzW84Ju+1C Y+7PEXYhT4KRlPbi7MdnK5f56b2g8erBqhmyINyPFJvAPojyO6SEd5nDiMrB4Qvv ckvBG1o9ObUP2qhqsY0z1b8lsl0wynX62ZyMfwwgQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgedugdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre ertdenucfhrhhomhepfdetlhgvgicuifhrihhffhhinhdfuceorgesrghjghhrfhdrtgho mheqnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrsegrjhhgrhhfrdgtohhmnecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4B7B7D48E2; Sat, 20 Apr 2019 17:36:02 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-443-g918f9d3-fmstable-20190416v3 Mime-Version: 1.0 X-Me-Personality: 27775493 Message-Id: <2cfd783f-66eb-4da3-98ab-96cd1a22c6c4@www.fastmail.com> Date: Sat, 20 Apr 2019 17:35:44 -0400 From: "Alex Griffin" To: 34280-done@debbugs.gnu.org Subject: [PATCH] gnu: Remove Go 1.9. Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34280-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) It looks to me like this was done in 5a14b913ad8513202077471539d41c51d9f271ee. -- Alex Griffin ------------=_1555796222-12878-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Feb 2019 16:39:49 +0000 Received: from localhost ([127.0.0.1]:55197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpbr2-0004W2-CL for submit@debbugs.gnu.org; Fri, 01 Feb 2019 11:39:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpbr0-0004Vn-AM for submit@debbugs.gnu.org; Fri, 01 Feb 2019 11:39:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:56189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpbqq-0001sY-QG for submit@debbugs.gnu.org; Fri, 01 Feb 2019 11:39:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbqo-0001gC-H6 for guix-patches@gnu.org; Fri, 01 Feb 2019 11:39:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpbqf-0001rA-J3 for guix-patches@gnu.org; Fri, 01 Feb 2019 11:39:30 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:32799) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpbqf-0001qs-51 for guix-patches@gnu.org; Fri, 01 Feb 2019 11:39:25 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 38D49218FD; Fri, 1 Feb 2019 11:39:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Feb 2019 11:39:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=wYdACBRzgBi92B2/BDQEEfK TYQZs1gSY2iHmSwYTowk=; b=vZ3ww5iTfLk6OKScyCMafyZbc59Lc5V0f7Dpqwj 7T19VlC5e0ozN2iRqmLXpbkHnfZc3VyvS+kjiq8NtBFGjD+ObxBp7QsYJj3eCNbY S3c4RaZchsSRllxOMVs/5xumt46z1CZ8cnUdTdg9soFtwyK2nB0lktd7Wka+k4BT 31vI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wYdACBRzgBi92B2/B DQEEfKTYQZs1gSY2iHmSwYTowk=; b=J+7c2VtBYi0zsBbA8TF2QJcv6TfGCZIT9 aM9sEhVlKASCAeNjeWcaSs5pMoVB0E7eT1hYwnjYsALIgHUJAZRAhnEzPXm3RWwx YIfjXlU+GwqFW4NBv5h+7IPlempXhw89voNYk+0225eTiUtd1UBckp89LFMU+Qar DbILQBG7BTmPqWglQqtWU1nLCn10nWP5WFnE8Jfm8p880NCar1Dk3Ai0mjBgNiWr Rg7Qjn+y3/CvYab4r5LExRlFWKRKJeHuwF+9cbZ8UldY86cflZKgQh/dC2mZvCQE WiftmMUtG63q6amzByBORyXBoJfYemEdCcEg6BFt1IfjnDVzF79Xg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeekgdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepnfgvoh cuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuffhomhgr ihhnpehtvghsthhshhhuthguohifnhhunhhigidrqdhnvghtpdhtvghsthgvgihtrhgrfh hilhgvshhrrggtvgdrqdhnvghtpdgtohhnthgrihhnvghrrddqnhgvthdpghhithhhuhgs rdgtohhmpdhgohhoghhlvggrphhishdrtghomhdptghonhhtrghinhgvrhdrnhgvthdpgh holhgrnhhgrdhorhhgpdhlugdqlhhinhhugidrqdhnvghtnecukfhppeektddrvdduhedr udeigedrvddtieenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrh hirdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from jasmine.lan (unknown [80.215.164.206]) by mail.messagingengine.com (Postfix) with ESMTPA id AC401E44A4 for ; Fri, 1 Feb 2019 11:39:22 -0500 (EST) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: Remove Go 1.9. Date: Fri, 1 Feb 2019 17:39:17 +0100 Message-Id: <44056f4feec2eaccda588572e7f2e954cc788b41.1549039116.git.leo@famulari.name> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) We can wait to push this patch until there is another reason to change the Go compiler, but I am submitting it now in case anyone else is working on Go in Guix. * gnu/packages/golang.scm (go-1.9): Remove variable. (go-1.11): Inherit from go-1.4 and consolidate the inherited build phases from go-1.9. Go 1.11 should be essentially unchanged with this commit, although the derivation is different. --- gnu/packages/golang.scm | 224 ++++++++-------------------------------- 1 file changed, 43 insertions(+), 181 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index cedfabe5bf..6947ec39f9 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -223,11 +223,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (supported-systems '("x86_64-linux" "i686-linux" "armhf-linux" "aarch64-linux")) (license license:bsd-3))) -(define-public go-1.9 +(define-public go-1.11 (package (inherit go-1.4) (name "go") - (version "1.9.7") + (version "1.11.5") (source (origin (method url-fetch) @@ -235,13 +235,24 @@ in the style of communicating sequential processes (@dfn{CSP}).") name version ".src.tar.gz")) (sha256 (base32 - "08kpy874x0rx43zpyv5kwd8xj2ma91xm33i0ka2v1v788px18a2q")))) + "0gllmbjvp12iszwils8id78mvjxwviwf98lh2gdkb236n4mz07mw")))) (arguments (substitute-keyword-arguments (package-arguments go-1.4) ((#:phases phases) `(modify-phases ,phases + ;; XXX Work around the Go 1.11.5 tarbomb. + ;; + (add-after 'unpack 'tarbomb-workaround + (lambda _ + (chdir "..") + (delete-file-recursively "gocache") + (delete-file-recursively "tmp") + #t)) + (replace 'chdir + (lambda _ + (chdir "go/src") + #t)) (replace 'prebuild - ;; TODO: Most of this could be factorized with Go 1.4. (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")) (ld (string-append (assoc-ref inputs "libc") "/lib")) @@ -251,43 +262,48 @@ in the style of communicating sequential processes (@dfn{CSP}).") (string-append (assoc-ref inputs "tzdata") "/share/zoneinfo")) (output (assoc-ref outputs "out"))) - ;; Removing net/ tests, which fail when attempting to access - ;; network resources not present in the build container. (for-each delete-file + ;; Removing net/ tests, which fail when attempting to access + ;; network resources not present in the build container. '("net/listen_test.go" "net/parse_test.go" - "net/cgo_unix_test.go")) + "net/cgo_unix_test.go" + ;; A side effect of these test scripts is testing + ;; cgo. Attempts at using cgo flags and + ;; directives with these scripts as specified + ;; here (https://golang.org/cmd/cgo/) have not + ;; worked. The tests continue to state that they + ;; can not find crt1.o despite being present. + "cmd/go/testdata/script/list_compiled_imports.txt" + "cmd/go/testdata/script/mod_case_cgo.txt" + ;; https://github.com/golang/go/issues/24884 + "os/user/user_test.go")) (substitute* "os/os_test.go" (("/usr/bin") (getcwd)) (("/bin/pwd") (which "pwd")) (("/bin/sh") (which "sh"))) + (substitute* "cmd/vendor/golang.org/x/sys/unix/syscall_unix_test.go" + (("/usr/bin") "/tmp")) + ;; Add libgcc to runpath (substitute* "cmd/link/internal/ld/lib.go" (("!rpath.set") "true")) - (substitute* "cmd/go/internal/work/build.go" + (substitute* "cmd/go/internal/work/gccgo.go" (("cgoldflags := \\[\\]string\\{\\}") (string-append "cgoldflags := []string{" "\"-rpath=" gcclib "\"" "}")) + (("\"-lgcc_s\", ") + (string-append + "\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", "))) + (substitute* "cmd/go/internal/work/gc.go" (("ldflags = setextld\\(ldflags, compiler\\)") (string-append "ldflags = setextld(ldflags, compiler)\n" "ldflags = append(ldflags, \"-r\")\n" - "ldflags = append(ldflags, \"" gcclib "\")\n")) - (("\"-lgcc_s\", ") - (string-append - "\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", "))) - - ;; XXX Commit 65fa2b615b72c1fa61a7 in the Go repo. We do this - ;; without a patch because ((guix packages) patch-and-repack) - ;; resets file mtimes, and parts of Go's test suite rely on - ;; those timestamps. - ;; - (substitute* "cmd/internal/objfile/elf.go" - (("PT_LOAD") - "PT_LOAD && p.Flags&elf.PF_X != 0")) + "ldflags = append(ldflags, \"" gcclib "\")\n"))) ;; Disable failing tests: these tests attempt to access ;; commands or network resources which are neither available @@ -322,9 +338,6 @@ in the style of communicating sequential processes (@dfn{CSP}).") ("syscall/exec_linux_test.go" "(.+)(TestCloneNEWUSERAndRemapNoRootDisableSetgroups.+)"))) - (substitute* "../misc/cgo/testsanitizers/test.bash" - (("(CC=)cc" all var) (string-append var "gcc"))) - ;; fix shebang for testar script ;; note the target script is generated at build time. (substitute* "../misc/cgo/testcarchive/carchive_test.go" @@ -342,19 +355,10 @@ in the style of communicating sequential processes (@dfn{CSP}).") (add-before 'build 'set-bootstrap-variables (lambda* (#:key outputs inputs #:allow-other-keys) ;; Tell the build system where to find the bootstrap Go. - (let ((go (assoc-ref inputs "go")) - (out (assoc-ref outputs "out"))) + (let ((go (assoc-ref inputs "go"))) (setenv "GOROOT_BOOTSTRAP" go) - (setenv "PATH" - (string-append out "/bin:" - (dirname (getcwd)) "/bin:" - (getenv "PATH"))) - - ;; XXX: The following variables seem unrelated. (setenv "GOGC" "400") - (setenv "GO_TEST_TIMEOUT_SCALE" "9999") #t))) - (replace 'build (lambda* (#:key inputs outputs #:allow-other-keys) ;; FIXME: Some of the .a files are not bit-reproducible. @@ -375,6 +379,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (src (string-append (assoc-ref outputs "tests") "/share/" ,name "-" ,version))) (delete-file-recursively "../pkg/bootstrap") + ;; Prevent installation of the build cache, which contains + ;; store references to most of the tools used to build Go and + ;; would unnecessarily increase the size of Go's closure if it + ;; was installed. + (delete-file-recursively "../pkg/obj") (mkdir-p src) (copy-recursively "../test" (string-append src "/test")) @@ -402,153 +411,6 @@ in the style of communicating sequential processes (@dfn{CSP}).") ,@(package-native-inputs go-1.4))) (supported-systems %supported-systems))) -(define-public go-1.11 - (package - (inherit go-1.9) - (name "go") - (version "1.11.5") - (source - (origin - (method url-fetch) - (uri (string-append "https://storage.googleapis.com/golang/" - name version ".src.tar.gz")) - (sha256 - (base32 - "0gllmbjvp12iszwils8id78mvjxwviwf98lh2gdkb236n4mz07mw")))) - (arguments - (substitute-keyword-arguments (package-arguments go-1.9) - ((#:phases phases) - `(modify-phases ,phases - ;; XXX Work around the Go 1.11.5 tarbomb. - ;; - (add-after 'unpack 'tarbomb-workaround - (lambda _ - (chdir "..") - (delete-file-recursively "gocache") - (delete-file-recursively "tmp") - #t)) - (replace 'chdir - (lambda _ - (chdir "go/src") - #t)) - (replace 'prebuild - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")) - (ld (string-append (assoc-ref inputs "libc") "/lib")) - (loader (car (find-files ld "^ld-linux.+"))) - (net-base (assoc-ref inputs "net-base")) - (tzdata-path - (string-append (assoc-ref inputs "tzdata") "/share/zoneinfo")) - (output (assoc-ref outputs "out"))) - - (for-each delete-file - ;; Removing net/ tests, which fail when attempting to access - ;; network resources not present in the build container. - '("net/listen_test.go" - "net/parse_test.go" - "net/cgo_unix_test.go" - ;; A side effect of these test scripts is testing - ;; cgo. Attempts at using cgo flags and - ;; directives with these scripts as specified - ;; here (https://golang.org/cmd/cgo/) have not - ;; worked. The tests continue to state that they - ;; can not find crt1.o despite being present. - "cmd/go/testdata/script/list_compiled_imports.txt" - "cmd/go/testdata/script/mod_case_cgo.txt" - ;; https://github.com/golang/go/issues/24884 - "os/user/user_test.go")) - - (substitute* "os/os_test.go" - (("/usr/bin") (getcwd)) - (("/bin/pwd") (which "pwd")) - (("/bin/sh") (which "sh"))) - - (substitute* "cmd/vendor/golang.org/x/sys/unix/syscall_unix_test.go" - (("/usr/bin") "/tmp")) - - ;; Add libgcc to runpath - (substitute* "cmd/link/internal/ld/lib.go" - (("!rpath.set") "true")) - (substitute* "cmd/go/internal/work/gccgo.go" - (("cgoldflags := \\[\\]string\\{\\}") - (string-append "cgoldflags := []string{" - "\"-rpath=" gcclib "\"" - "}")) - (("\"-lgcc_s\", ") - (string-append - "\"-Wl,-rpath=" gcclib "\", \"-lgcc_s\", "))) - (substitute* "cmd/go/internal/work/gc.go" - (("ldflags = setextld\\(ldflags, compiler\\)") - (string-append - "ldflags = setextld(ldflags, compiler)\n" - "ldflags = append(ldflags, \"-r\")\n" - "ldflags = append(ldflags, \"" gcclib "\")\n"))) - - ;; Disable failing tests: these tests attempt to access - ;; commands or network resources which are neither available - ;; nor necessary for the build to succeed. - (for-each - (match-lambda - ((file regex) - (substitute* file - ((regex all before test_name) - (string-append before "Disabled" test_name))))) - '(("net/net_test.go" "(.+)(TestShutdownUnix.+)") - ("net/dial_test.go" "(.+)(TestDialTimeout.+)") - ("os/os_test.go" "(.+)(TestHostname.+)") - ("time/format_test.go" "(.+)(TestParseInSydney.+)") - ("time/format_test.go" "(.+)(TestParseInLocation.+)") - ("os/exec/exec_test.go" "(.+)(TestEcho.+)") - ("os/exec/exec_test.go" "(.+)(TestCommandRelativeName.+)") - ("os/exec/exec_test.go" "(.+)(TestCatStdin.+)") - ("os/exec/exec_test.go" "(.+)(TestCatGoodAndBadFile.+)") - ("os/exec/exec_test.go" "(.+)(TestExitStatus.+)") - ("os/exec/exec_test.go" "(.+)(TestPipes.+)") - ("os/exec/exec_test.go" "(.+)(TestStdinClose.+)") - ("os/exec/exec_test.go" "(.+)(TestIgnorePipeErrorOnSuccess.+)") - ("syscall/syscall_unix_test.go" "(.+)(TestPassFD\\(.+)") - ("os/exec/exec_test.go" "(.+)(TestExtraFiles/areturn.+)") - ("cmd/go/go_test.go" "(.+)(TestCoverageWithCgo.+)") - ("cmd/go/go_test.go" "(.+)(TestTwoPkgConfigs.+)") - ("os/exec/exec_test.go" "(.+)(TestOutputStderrCapture.+)") - ("os/exec/exec_test.go" "(.+)(TestExtraFiles.+)") - ("os/exec/exec_test.go" "(.+)(TestExtraFilesRace.+)") - ("net/lookup_test.go" "(.+)(TestLookupPort.+)") - ("syscall/exec_linux_test.go" - "(.+)(TestCloneNEWUSERAndRemapNoRootDisableSetgroups.+)"))) - - ;; fix shebang for testar script - ;; note the target script is generated at build time. - (substitute* "../misc/cgo/testcarchive/carchive_test.go" - (("#!/usr/bin/env") (string-append "#!" (which "env")))) - - (substitute* "net/lookup_unix.go" - (("/etc/protocols") (string-append net-base "/etc/protocols"))) - (substitute* "net/port_unix.go" - (("/etc/services") (string-append net-base "/etc/services"))) - (substitute* "time/zoneinfo_unix.go" - (("/usr/share/zoneinfo/") tzdata-path)) - (substitute* (find-files "cmd" "\\.go") - (("/lib(64)?/ld-linux.*\\.so\\.[0-9]") loader)) - #t))) - ;; Prevent installation of the build cache, which contains store - ;; references to most of the tools used to build Go and would - ;; unnecessarily increase the size of Go's closure if it was - ;; installed. - ;; TODO This should be moved into the 'install' phase when Go 1.9 is - ;; removed. - (add-before 'install 'delete-extraneous-files - (lambda _ - (delete-file-recursively "../pkg/obj") - #t)) - (replace 'set-bootstrap-variables - (lambda* (#:key outputs inputs #:allow-other-keys) - ;; Tell the build system where to find the bootstrap Go. - (let ((go (assoc-ref inputs "go"))) - (setenv "GOROOT_BOOTSTRAP" go) - (setenv "GOGC" "400") - #t))))))))) - (define-public go go-1.11) (define-public go-github-com-alsm-ioprogress -- 2.20.1 ------------=_1555796222-12878-1--