GNU bug report logs - #34279
guix-install.sh: uses /bin/bash shebang

Previous Next

Package: guix;

Reported by: Claes Wallin (韋嘉誠) <clacke <at> lysator.liu.se>

Date: Fri, 1 Feb 2019 16:12:02 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Claes Wallin (韋嘉誠)
 <clacke <at> lysator.liu.se>
Subject: bug#34279: closed (Re: bug#34279: guix-install.sh: uses /bin/bash
 shebang)
Date: Tue, 05 Feb 2019 11:05:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#34279: guix-install.sh: uses /bin/bash shebang

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34279 <at> debbugs.gnu.org.

-- 
34279: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34279
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Claes Wallin (韋嘉誠) <clacke <at> lysator.liu.se>
Cc: 34279-done <at> debbugs.gnu.org
Subject: Re: bug#34279: guix-install.sh: uses /bin/bash shebang
Date: Tue, 05 Feb 2019 12:04:44 +0100
Ludovic Courtès <ludo <at> gnu.org> skribis:

> What about something like this:
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index 8eb5214049..dc8de2fe92 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  # GNU Guix --- Functional package management for GNU
>  # Copyright © 2017 sharlatan <sharlatanus <at> gmail.com>
>  # Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
> @@ -19,6 +19,13 @@
>  # You should have received a copy of the GNU General Public License
>  # along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>  
> +# We require Bash but for portability we'd rather not use /bin/bash or
> +# /usr/bin/env in the shebang, hence this hack.
> +if [ "x$BASH_VERSION" = "x" ]
> +then
> +    exec bash "$0" "$@"
> +fi

Pushed as f5fdc54d3a0845d0590c181d3bd6016f22765431.

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Claes Wallin (韋嘉誠) <clacke <at> lysator.liu.se>
To: bug-guix <at> gnu.org
Subject: guix-install.sh: uses /bin/bash shebang
Date: Fri, 1 Feb 2019 16:35:56 +0100
This means ./guix-install.sh doesn't work on e.g. NixOS. :-)

Please use /usr/bin/env bash.

The manual workaround is obvious, but this is a thousand-papercuts bug.



This bug report was last modified 6 years and 108 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.