From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 01 09:14:08 2019 Received: (at submit) by debbugs.gnu.org; 1 Feb 2019 14:14:08 +0000 Received: from localhost ([127.0.0.1]:53916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpZa4-0000Pn-7l for submit@debbugs.gnu.org; Fri, 01 Feb 2019 09:14:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpZa2-0000PM-R2 for submit@debbugs.gnu.org; Fri, 01 Feb 2019 09:14:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:57539) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpZZw-0004BH-5m for submit@debbugs.gnu.org; Fri, 01 Feb 2019 09:14:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpZZv-0006vU-6G for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 09:13:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpZZr-00048N-Dy for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 09:13:57 -0500 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:41567) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpZZn-0003rB-HK for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 09:13:53 -0500 Received: by mail-lj1-x232.google.com with SMTP id k15-v6so5918282ljc.8 for ; Fri, 01 Feb 2019 06:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=1B0MxRPytYq730hwWCeMvN1/58x4X8l7mLDg116ey+M=; b=fWraZW3S8eBKDLTXXweUS7QQYCyFOyoynbAKB81adqz8TevkoQDe6NOpn8ZMpAQCwO VyMA8a0YBlOQkAdbSsJglRRELptGLlDZD1xY4qnt2S8cna5Cgm7xc0NTed1qGjeRqTlu avGxJ7iaMoOGlQJgQMPa+q2xqKieOMJqMUnTZQ2kB1HMo6MJYNwLZtVPTl0Dw4sJnqof rOqBmqDgSOitS5x+ZDABvBfJjtJGol0OnMKkOz97sI1Z1SVK8+qU5gAzOTm8Q1bTyCc/ d+PGGFZO0OuXiz27sfqLX4mC5TArMGMzuTV6je80E8gLkVYXvi6cfS+i9/HKZCLMLWzk 7SQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=1B0MxRPytYq730hwWCeMvN1/58x4X8l7mLDg116ey+M=; b=EBvHduUhzy4RyVsq/8AeGd3GR4PRTegGoaYnRidP/Pg5vNy7WlxHgp+yrOOME2ZTAZ qXBERnTHvqjGvAGWUnY9eGG7ZnxTjGskWOlGhgK7yemnDJaurMoVSNIeCDrAkfawRtxZ QtfnAo6KGYzZNlWN2CUM8v7J9v2XmlrFGMYeeTacIq5VNqZYWlb9kyOoA0WNdTGNyhTu jsu/045uRaOJ4yTDBHRALejacis6cibDGCa0wo17Nlz2uf2JokkAWIZPVRYWx0jfvZEn qUdiQo4H3qDWt2XcADUaLluJkuQq+RGlR+XqC5QdW/5klrAcnXsBTSPNb3ig0QoaoANI w7TA== X-Gm-Message-State: AJcUukcdWsjWmP/Nccc+Uzs117efXEQg/7d/Lc1PBFHKAausOjN9tXDF AGUf2cR4A0TOMTS1r0Bux3b9KtUS3Vx25ECJ4lugjC+KPrU= X-Google-Smtp-Source: ALg8bN55IkHQiIJpQjNHoYojsnbDc6oWRRRwbl0h4fIiFXC1i1hyBv721UVxfux6Oo3rHLVSHBkx5MJZLbDG7MW+RIM= X-Received: by 2002:a2e:8007:: with SMTP id j7-v6mr32009575ljg.50.1549030403032; Fri, 01 Feb 2019 06:13:23 -0800 (PST) MIME-Version: 1.0 From: Nicholas Drozd Date: Fri, 1 Feb 2019 08:13:10 -0600 Message-ID: Subject: [PATCH] * src/callproc.c (call-process/region): Fix docstring arg formatting To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::232 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --- src/callproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/callproc.c b/src/callproc.c index d4558387cf..f8036f51ef 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -237,7 +237,7 @@ DESTINATION can also have the form (REAL-BUFFER STDERR-FILE); in that case, t (mix it with ordinary output), or a file name string. Fourth arg DISPLAY non-nil means redisplay buffer as output is inserted. -Remaining arguments are strings passed as command arguments to PROGRAM. +Remaining ARGS are strings passed as command arguments to PROGRAM. If executable PROGRAM can't be found as an executable, `call-process' signals a Lisp error. `call-process' reports errors in execution of @@ -1033,7 +1033,7 @@ STDERR-FILE may be nil (discard standard error output), t (mix it with ordinary output), or a file name string. Sixth arg DISPLAY non-nil means redisplay buffer as output is inserted. -Remaining args are passed to PROGRAM at startup as command args. +Remaining ARGS are passed to PROGRAM at startup as command arguments. If BUFFER is 0, `call-process-region' returns immediately with value nil. Otherwise it waits for PROGRAM to terminate -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 01 10:14:55 2019 Received: (at 34274) by debbugs.gnu.org; 1 Feb 2019 15:14:55 +0000 Received: from localhost ([127.0.0.1]:55127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpaWt-0002JS-2p for submit@debbugs.gnu.org; Fri, 01 Feb 2019 10:14:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpaWp-0002JA-8v for 34274@debbugs.gnu.org; Fri, 01 Feb 2019 10:14:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpaWi-00036c-Br; Fri, 01 Feb 2019 10:14:46 -0500 Received: from [176.228.60.248] (port=4469 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gpaWh-0000kO-Pr; Fri, 01 Feb 2019 10:14:44 -0500 Date: Fri, 01 Feb 2019 17:14:32 +0200 Message-Id: <83bm3vy207.fsf@gnu.org> From: Eli Zaretskii To: Nicholas Drozd In-reply-to: (message from Nicholas Drozd on Fri, 1 Feb 2019 08:13:10 -0600) Subject: Re: bug#34274: [PATCH] * src/callproc.c (call-process/region): Fix docstring arg formatting References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34274 Cc: 34274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Nicholas Drozd > Date: Fri, 1 Feb 2019 08:13:10 -0600 > > --- > src/callproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/callproc.c b/src/callproc.c > index d4558387cf..f8036f51ef 100644 > --- a/src/callproc.c > +++ b/src/callproc.c > @@ -237,7 +237,7 @@ DESTINATION can also have the form (REAL-BUFFER > STDERR-FILE); in that case, > t (mix it with ordinary output), or a file name string. > > Fourth arg DISPLAY non-nil means redisplay buffer as output is inserted. > -Remaining arguments are strings passed as command arguments to PROGRAM. > +Remaining ARGS are strings passed as command arguments to PROGRAM. > > If executable PROGRAM can't be found as an executable, `call-process' > signals a Lisp error. `call-process' reports errors in execution of > @@ -1033,7 +1033,7 @@ STDERR-FILE may be nil (discard standard error output), > t (mix it with ordinary output), or a file name string. > > Sixth arg DISPLAY non-nil means redisplay buffer as output is inserted. > -Remaining args are passed to PROGRAM at startup as command args. > +Remaining ARGS are passed to PROGRAM at startup as command arguments. Thanks, but this seems to replace one wording with an equivalent one, and no rationale was provided as to why. Could you please provide your motivation for the changes? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 04 18:56:14 2019 Received: (at 34274) by debbugs.gnu.org; 4 Feb 2019 23:56:14 +0000 Received: from localhost ([127.0.0.1]:59917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqo61-0006Go-SD for submit@debbugs.gnu.org; Mon, 04 Feb 2019 18:56:14 -0500 Received: from mail-lj1-f179.google.com ([209.85.208.179]:37095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqo60-0006Gb-6A for 34274@debbugs.gnu.org; Mon, 04 Feb 2019 18:56:12 -0500 Received: by mail-lj1-f179.google.com with SMTP id t18-v6so1439765ljd.4 for <34274@debbugs.gnu.org>; Mon, 04 Feb 2019 15:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ZbupGPj04a+S5dKCTUxaQ4NaR/itcCJJWpUT2YjUgw=; b=fiMorQ42tPSXLeYNpxEEiEcA/Wf+SWZLzgaP43quVf4PG1EsOnDFpHEBjESqPoOlCT q6iulkIewuG1ecMb8o4Uqa6IR2Ie+jCStQxQjI9iLT6MgpJ/YGTojrnZM0Enbk3MXbRN rdoc+oOLP2HHGz+ZatjFWLN5jTd0vLtM60ENou0dyzG4kiTG2pp97/tDNwgw2RjA2OZl tD5M32JxZ3fW0H7BVfvL16eMKQeDXhIDRMdJ2eR0G4YqPaFotoE4VhdcHXmUf/oToco+ gPGcFAzxvJc3/hb2q8bJxpfxZMCyYNgCoT6uDqNRkqO4XMIntxwUlOVbKFuinr3kU7fu R4vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ZbupGPj04a+S5dKCTUxaQ4NaR/itcCJJWpUT2YjUgw=; b=R2aDQdIHUbUXfCDh+kwl51QZMtaxbfOcNKrjEyVc+5D5V6VmILQCVahqzHORyLtaHf +4sFsZwM3G2MZ5+k2nbcqImaIGj0Y1VnZpUSmgwPgwXpGXhLvAg8hwo85q9NRjW+JC94 UHGJW+11BB+q/LRr8dIxbSfiVbhRINeYVyd0XBE0msXF5XJ3qPext0Q/hIVEg5cFjXWE fw3To/TNMfxpik1mpz0x+1OkUO3vIDwO8LZXj260DJekfgvvMWp1DdDUgReVfp2NF+fR VceFcF4il8T44xm9qnxZScsZFTvD0LxeQO/0oBsyA2ipMvl0FdYvA7U77Ur5mMko2ISM Zryg== X-Gm-Message-State: AHQUAuaYbIg7+qcdO2rUPBkHWLmA1fB+y6i5qckzn09E1qNwgmpNWRRP WunyVCRvd1oWzDbD680i8PYFRblqMPooJoa0RwU= X-Google-Smtp-Source: AHgI3IYiEAvDyif2e54dwuk5dgvMZO53wEBBqfwlQJ9cMhS5e87rI4RPXmCqjtV9QX/Lxe2UCgHZqcfc1yiLrQDEdf4= X-Received: by 2002:a2e:6503:: with SMTP id z3-v6mr1129226ljb.153.1549324565712; Mon, 04 Feb 2019 15:56:05 -0800 (PST) MIME-Version: 1.0 References: <83bm3vy207.fsf@gnu.org> In-Reply-To: <83bm3vy207.fsf@gnu.org> From: Nicholas Drozd Date: Mon, 4 Feb 2019 17:55:51 -0600 Message-ID: Subject: Re: bug#34274: [PATCH] * src/callproc.c (call-process/region): Fix docstring arg formatting To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34274 Cc: 34274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The usual docstring convention is to put arg names in CAPS, making it easier to find mentions of the arguments, especially by text search. Right now if you search the docstring of call-process for ARGS, you won't find anything. There's "remaining arguments", but it's up to the reader to figure out that that refers to ARGS. This change just makes it easier to navigate. In the second case I also changed "command args" to "command arguments". This change is unimportant; I just thought it looks nicer. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 08 03:47:46 2019 Received: (at 34274-done) by debbugs.gnu.org; 8 Feb 2019 08:47:46 +0000 Received: from localhost ([127.0.0.1]:38895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gs1p3-00053h-Q4 for submit@debbugs.gnu.org; Fri, 08 Feb 2019 03:47:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gs1p2-00053T-9Q for 34274-done@debbugs.gnu.org; Fri, 08 Feb 2019 03:47:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs1ox-0001fw-2w; Fri, 08 Feb 2019 03:47:39 -0500 Received: from [176.228.60.248] (port=2609 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gs1os-0006po-0g; Fri, 08 Feb 2019 03:47:39 -0500 Date: Fri, 08 Feb 2019 10:47:30 +0200 Message-Id: <834l9er7j1.fsf@gnu.org> From: Eli Zaretskii To: Nicholas Drozd In-reply-to: (message from Nicholas Drozd on Mon, 4 Feb 2019 17:55:51 -0600) Subject: Re: bug#34274: [PATCH] * src/callproc.c (call-process/region): Fix docstring arg formatting References: <83bm3vy207.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34274-done Cc: 34274-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Nicholas Drozd > Date: Mon, 4 Feb 2019 17:55:51 -0600 > Cc: 34274@debbugs.gnu.org > > The usual docstring convention is to put arg names in CAPS, making it > easier to find mentions of the arguments, especially by text search. > Right now if you search the docstring of call-process for ARGS, you > won't find anything. There's "remaining arguments", but it's up to the > reader to figure out that that refers to ARGS. This change just makes > it easier to navigate. > > In the second case I also changed "command args" to "command > arguments". This change is unimportant; I just thought it looks nicer. Thanks, I fixed these doc strings in the spirit of your suggestions. From unknown Mon Aug 18 08:26:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Mar 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator