From unknown Mon Aug 18 00:08:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34262 <34262@debbugs.gnu.org> To: bug#34262 <34262@debbugs.gnu.org> Subject: Status: [PATCH]Add: nkf Reply-To: bug#34262 <34262@debbugs.gnu.org> Date: Mon, 18 Aug 2025 07:08:03 +0000 retitle 34262 [PATCH]Add: nkf reassign 34262 guix-patches submitter 34262 Yoshinori Arai severity 34262 normal tag 34262 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 31 01:43:51 2019 Received: (at submit) by debbugs.gnu.org; 31 Jan 2019 06:43:51 +0000 Received: from localhost ([127.0.0.1]:52117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gp64l-000629-8j for submit@debbugs.gnu.org; Thu, 31 Jan 2019 01:43:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gp64j-00061v-FI for submit@debbugs.gnu.org; Thu, 31 Jan 2019 01:43:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:45267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gp64d-0007Sm-E9 for submit@debbugs.gnu.org; Thu, 31 Jan 2019 01:43:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gp64c-0001kX-DJ for guix-patches@gnu.org; Thu, 31 Jan 2019 01:43:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gp64a-0007Qu-Lz for guix-patches@gnu.org; Thu, 31 Jan 2019 01:43:42 -0500 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:33739) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gp64Y-0007Jv-Qa for guix-patches@gnu.org; Thu, 31 Jan 2019 01:43:39 -0500 Received: by mail-pg1-x529.google.com with SMTP id z11so973418pgu.0 for ; Wed, 30 Jan 2019 22:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=v0rn0U7nx6nZ8JLZcRU+RYMd5M+flA2mIbyqvnCDrnY=; b=WSCqoRzgtlqpjZ8zys4J4TtvCkcvjtwXST6akZgVuTDP6kQZUJtCtvonmhPQBNdpdk /nYx+RZq+OMC4Fb8AlCeQmEtBQEThANSCA9fhlXePdjy79QW3kjbsqPkfV7Ri1bJZwd7 VVsYyU1L7HgccMHUwgiV9cynRjcpdPS5TIKSKXjUuf7/oyCqFBYnMpelL0yKXhP4wcTT On57dzKWY9EJOH2CWnYPEACpsP4CzEZIHSZZY9zajjPJ7bRQE8vYYqTEbisrtj+2DaHa unhNXszA/mi+SKJodskqVAudfiS+X3u/g8ctNsbslr6QXly1zp1bXr352p+Lm8kfXt6F zKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=v0rn0U7nx6nZ8JLZcRU+RYMd5M+flA2mIbyqvnCDrnY=; b=EFHhHI77UIOvyoS1UqPIzt+kMZviy6iGJ5C7G2RUcaxxYJUo5tSLqhaPBMOnB/e/2r U1w0i35HHgtqXWMGbYLi0YldgwFJV+eoA8y3U0DY1OaSImQohgRobJlAhakSnDtGTbU/ HMlYkIOJy2kluEhuTLADroY+/Ezpq5ILokO0tO2gwyHDp/1WTxZrjhagE7rJp9YZSP40 KR3TksmGfkVsk0FiO62QmJHuztfLRREKoM02Xw9/fbAZ/or4rDuNo9GA0kh+OkPXcQnZ ctdI3CO27Pd3gVjCh2DM3dLiwyMfeywRS9GTYzaGwKF1oapYE2Dg1OeFnq87LE6+hAnU /Rxw== X-Gm-Message-State: AJcUukfQlQf71lLpes9km59hLZCri+iZF8fuEsefT1XNGhmW+83fDMAp 6oQnKds6Fd/upz/KRllCHRUEgAMN+GQ= X-Google-Smtp-Source: ALg8bN6iO8OJc2adGnopTHEgTiiStsohIrScXul1S9faTu01m6ZbY9WN+CvI6ta+RYdC4B02wIUBQQ== X-Received: by 2002:a63:82c6:: with SMTP id w189mr30709058pgd.344.1548917009382; Wed, 30 Jan 2019 22:43:29 -0800 (PST) Received: from localhost ([2409:11:4a40:3600:afd4:3247:4a32:242a]) by smtp.gmail.com with ESMTPSA id c7sm8744464pfh.18.2019.01.30.22.43.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 22:43:28 -0800 (PST) Date: Thu, 31 Jan 2019 15:43:26 +0900 From: Yoshinori Arai To: guix-patches@gnu.org Subject: [PATCH]Add: nkf Message-ID: <20190131064326.ndndwqf23yirdoup@WaraToNora> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::529 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 1 file changed, 38 insertions(+) gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++ modified gnu/packages/textutils.scm @@ -794, 3 +794, 41 @@ Chinese and Simplified Chinese, supporting character-level conversion, phrase-level conversion, variant conversion, and regional idioms among M [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kumagusu08[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (kumagusu08[at]gmail.com) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) 1 file changed, 38 insertions(+) gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++ modified gnu/packages/textutils.scm @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character-level conversion, phrase-level conversion, variant conversion, and regional idioms among Mainland China, Taiwan, and Hong-Kong.") (license license:asl2.0))) + +(define-public nkf + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2") + (revision "1")) + (package + (name "nkf") + (version "2.1.5") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/nurse/nkf.git") + (commit commit))) + (file-name (string-append name version)) + (sha256 + (base32 + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; test for perl module + #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic" + (string-append "prefix=" %output)) + #:phases + (modify-phases %standard-phases + (delete 'configure) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (man1 (string-append out "/share/man/man1")) + (man1j (string-append out "/share/man/ja/man1"))) + (install-file "nkf" bin) + (install-file "nkf.1" man1) + (install-file "nkf.1j" man1j) + #t)))))) + (home-page "https://ja.osdn.net/projects/nkf/") + (synopsis "Network Kanji Filter") + (description "Nkf is a yet another kanji code converter among networks, hosts and terminals. It converts input kanji code to designated kanji code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.") + (license license:zlib)))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 31 09:55:35 2019 Received: (at 34262) by debbugs.gnu.org; 31 Jan 2019 14:55:35 +0000 Received: from localhost ([127.0.0.1]:53129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpDkd-0007Vn-60 for submit@debbugs.gnu.org; Thu, 31 Jan 2019 09:55:35 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:21512 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpDka-0007Vd-TG for 34262@debbugs.gnu.org; Thu, 31 Jan 2019 09:55:33 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1548946527; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=85dKUjIyFsNS1FVmKBeWyZODy4Y=; b=BSloM+lM9gkDVNBzOQF9HKXIbyWUjzn7bMvlyQ+IiJMKQCMo8n3v/FWUJR0gaFvy lDrqDPxrFh7jFsQxIEntZf1C22EKEaHuq6ntksgQ8y9chIs5Sisovo+g2pwY8WhN 9b1gc3bh6WpNq1rScwYoXo4ax1Mk8eX2m8+xvOb31CNeZAgY91oZYfC/XynSiMFz vakqAODTWG8BSghejx6IV82B3RNS94mv6Zs4xuP8nEyfANhAgzjmHA30T0Lmnb8N z+86t1l0m+vyJ7aAkKKoKDGLggp7GWxkCrilg3AYShxP+FxC+wd0VzAKgyjtOMtk OLpOcYzao4umAe9UnG+f0Q==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.3 cv=bMpo382Z c=1 sm=1 tr=0 a=c4ELDkRixJ9967ke8+/osA==:117 a=c4ELDkRixJ9967ke8+/osA==:17 a=KGjhK52YXX0A:10 a=3JhidrIBZZsA:10 a=zSv6zi-ZgakA:10 a=pGLkceISAAAA:8 a=BlBlPAFMAAAA:8 a=_OJA4_MHAAAA:20 a=YJYmlWn9AAAA:8 a=RCFBDPLQl7jikfr3sdMA:9 a=CjuIK1q_8ugA:10 a=ik4qjawTckcJLx-ReMoA:9 a=dbtXwXiIqXDxxSNf8wWO:22 a=1jzlMsT2ksTeFbNwC4-K:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp02.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.99.100] ([97.116.99.100:60520] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id A7/36-19119-E5C035C5; Thu, 31 Jan 2019 09:55:26 -0500 Date: Thu, 31 Jan 2019 08:55:19 -0600 From: Eric Bavier To: Yoshinori Arai Subject: Re: [bug#34262] [PATCH]Add: nkf Message-ID: <20190131085519.23d47ee2@centurylink.net> In-Reply-To: <20190131064326.ndndwqf23yirdoup@WaraToNora> References: <20190131064326.ndndwqf23yirdoup@WaraToNora> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/eWvpAQXWijAF2_YSIUGLHTL"; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34262 Cc: 34262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/eWvpAQXWijAF2_YSIUGLHTL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Thanks for the patch! Just a few nitpicks below: On Thu, 31 Jan 2019 15:43:26 +0900 Yoshinori Arai wrote: > 1 file changed, 38 insertions(+) > gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++ >=20 > modified gnu/packages/textutils.scm > @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character= -level conversion, > phrase-level conversion, variant conversion, and regional idioms among > Mainland China, Taiwan, and Hong-Kong.") > (license license:asl2.0))) > + > +(define-public nkf > + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2") Could you add a comment about how this commit relates to the 2.1.5 release? I see the github page doesn't seem to make actual releases, or even tag. Would it make any sense to download the tarballs available at https://ja.asdn.net/projects/nkf instead? > + (revision "1")) > + (package > + (name "nkf") > + (version "2.1.5") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nurse/nkf.git") > + (commit commit))) > + (file-name (string-append name version)) Rather than string-append use the 'git-file-name' procedure. > + (sha256 > + (base32 > + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"= )))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; test for perl module > + #:make-flags (list "CC=3Dgcc" "CFLAGS=3D-O2 -Wall -pedantic" > + (string-append "prefix=3D" %output)) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'install The Makefile's 'install' target seems like it might do what we want. Is that not the case? > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (man1 (string-append out "/share/man/man1")) > + (man1j (string-append out "/share/man/ja/man1"))) > + (install-file "nkf" bin) > + (install-file "nkf.1" man1) > + (install-file "nkf.1j" man1j) > + #t)))))) > + (home-page "https://ja.osdn.net/projects/nkf/") > + (synopsis "Network Kanji Filter") > + (description "Nkf is a yet another kanji code converter among netw= orks, hosts and terminals. It converts input kanji code to designated kanji= code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.") > + (license license:zlib)))) 'is a yet' -> 'is yet' Use double-space after end-of-sentence period. Also, make sure to run 'guix lint knf' Could you send an updated patch? Thanks, `~Eric --Sig_/eWvpAQXWijAF2_YSIUGLHTL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlxTDFcACgkQ/XPKxxnT JWb2UA//THmkVEJ2Z1b9UeBjVrGtpUqFMNM5c5sDR9+a4dBXGvX2Awxop+lNnuVy Z1Iv6QEF1n/uygXYszA1wAuLTqW+eO4eYSAUDjy1PrHr3IEaKvk7poK1+g8TjMgX KkGGWBNiDI9VLvgcxenzMIquHFeOQp4t48EnDbBBayKqVgFpAfiSILrAp7aJ5/da EhawzKsZij9OqKmA+QDAP8+oSGfKvcpxBOvW6mU8yT49lcjf6rLBWayVZ89pMKur SSRvp5KGTXR5X+Ptrdpio24VqgWd6kHAOFf5qzxmWSZrzahwmqwr7vgCwIMPbZve fB7HYRMD2byUAbevZ4LiqkxnCVlo9Y41AWJwhlZL719sju2G0ieMezW9CWfkjbkH tlZkbLCAv7D9MLLNN4lFrhRfw4zgbSgteLLPMXAmXYtbmW2x/ddjaWB5MGRyWkaZ dsiLW7iOw7ZIY/hqEVYmUexLyodhW9ahTxgniTETtFyK3aYT47syXjXuMjKQGXpM JKMg9dWIuzlvFkgX+xsXFmW6LtmcpYAKCTzGjPJcvOaQeIeOuEyAdlz3g+ti9m3w QfF5qR0RVoVEeY7VE8wtSbwHMDoZimpwylASiH/ltjAYgqsQsLLUjcMwuNrAbAmY MrgA9AWEjY7VdB8SBsf7E9HCDKVgyktU/IpA7WPEMzh3bKQNmMs= =EavR -----END PGP SIGNATURE----- --Sig_/eWvpAQXWijAF2_YSIUGLHTL-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 31 23:03:21 2019 Received: (at 34262) by debbugs.gnu.org; 1 Feb 2019 04:03:21 +0000 Received: from localhost ([127.0.0.1]:53588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpQ2w-0003re-7A for submit@debbugs.gnu.org; Thu, 31 Jan 2019 23:03:19 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:41830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpQ2t-0003rK-5F for 34262@debbugs.gnu.org; Thu, 31 Jan 2019 23:03:16 -0500 Received: by mail-pf1-f195.google.com with SMTP id b7so2499301pfi.8 for <34262@debbugs.gnu.org>; Thu, 31 Jan 2019 20:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r1TsLtj6F99Swb5m9H5CGQHuSc5qQgyu8gnOB5xpaJc=; b=WYwtjD6oy+g55aNs2oCamLn7aH7yHdZFQlUWpb6uS876PIJrPEf51xS4knnIjOCA5l QhiP1XV4vFuM7/9WmlMhq84W22fjVL8paAgobtiGAZb1USHBOzMjsDQf+OW0sGlWfk2e WJi1LjA8wInQusrG2xryrVlcqAp2xr93TW+Kt8hzvhuCR1eWA/qszfRhjAp5NVzt6qWK /iwQxbWX72ZLA1EonukCDvrKhel/h3NpKr4BTsiu9VqCaLiLT1SbbbamUhw43fRNJSoy pwy8ygDsT93nBLoRb7aEaFNGiQ0QC0ztm6/7enWhJPYz9Q/rwv2wMEc81Ui1QUCIvvFQ x2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r1TsLtj6F99Swb5m9H5CGQHuSc5qQgyu8gnOB5xpaJc=; b=deNAwDBQd7bW5WtvUYH/Ia3EmX7+AwmRDLxCCPRdSBrQCeauMLjoyBj3EDoh3fMQP0 H7kNOfh6Oyj2rWpQru8eduADMBhPbXcydmDJHNdQpoZ9vm61+519B+sST1je+RhHuQo4 5Apmuo687KdO3SfshTsh1RNZS55uKLcVVQuVSFWAbdh1dqcR1v/9wVjdg7DGWAjcE1rf TZrlrd+jOR5fcS7h6Spe13dKE0qGR/PThcXiISCwECRNmq0LHr5ZIHGzsMlIz3vDBK8c pNz6MnAiwfO1dQ+Ytf/C4hk6EcWExJeVYOhsrWBRlolLsHU1jJnb3oJchrid+G1iRK7J L/bQ== X-Gm-Message-State: AJcUukdZw3ruk4yTnvlxl82RAX4yhvj9y81mxwtkqwKd6XgJnP0Dmh9n I0z1yxcSG0J+WVhYvw/VZUk= X-Google-Smtp-Source: ALg8bN5lMejPz2mPxYDKU814+4r/sfmVLy1pLGoXWNRd9tRGwgsjQSbjrTNofzYqPXn58hYZwxhDgg== X-Received: by 2002:a62:c21c:: with SMTP id l28mr37234694pfg.74.1548993788577; Thu, 31 Jan 2019 20:03:08 -0800 (PST) Received: from localhost ([2409:11:4a40:3600:afd4:3247:4a32:242a]) by smtp.gmail.com with ESMTPSA id p2sm7966588pfb.28.2019.01.31.20.03.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 20:03:07 -0800 (PST) Date: Fri, 1 Feb 2019 13:03:05 +0900 From: Yoshinori Arai To: Eric Bavier Subject: Re: [bug#34262] [PATCH]Add: nkf Message-ID: <20190201040305.luu56jkwndye2zrv@WaraToNora> References: <20190131064326.ndndwqf23yirdoup@WaraToNora> <20190131085519.23d47ee2@centurylink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131085519.23d47ee2@centurylink.net> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 34262 Cc: 34262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Jan 31, 2019 at 08:55:19AM -0600, Eric Bavier wrote: > Thanks for the patch! Just a few nitpicks below: > > On Thu, 31 Jan 2019 15:43:26 +0900 > Yoshinori Arai wrote: > > > 1 file changed, 38 insertions(+) > > gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++ > > > > modified gnu/packages/textutils.scm > > @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character-level conversion, > > phrase-level conversion, variant conversion, and regional idioms among > > Mainland China, Taiwan, and Hong-Kong.") > > (license license:asl2.0))) > > + > > +(define-public nkf > > + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2") > > Could you add a comment about how this commit relates to the 2.1.5 > release? I see the github page doesn't seem to make actual releases, > or even tag. Would it make any sense to download the tarballs > available at https://ja.asdn.net/projects/nkf instead? > > > + (revision "1")) > > + (package > > + (name "nkf") > > + (version "2.1.5") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/nurse/nkf.git") > > + (commit commit))) > > + (file-name (string-append name version)) > > Rather than string-append use the 'git-file-name' procedure. > > > + (sha256 > > + (base32 > > + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly")))) > > + (build-system gnu-build-system) > > + (arguments > > + `(#:tests? #f ; test for perl module > > + #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic" > > + (string-append "prefix=" %output)) > > + #:phases > > + (modify-phases %standard-phases > > + (delete 'configure) > > + (replace 'install > > The Makefile's 'install' target seems like it might do what we want. > Is that not the case? > > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (bin (string-append out "/bin")) > > + (man1 (string-append out "/share/man/man1")) > > + (man1j (string-append out "/share/man/ja/man1"))) > > + (install-file "nkf" bin) > > + (install-file "nkf.1" man1) > > + (install-file "nkf.1j" man1j) > > + #t)))))) > > + (home-page "https://ja.osdn.net/projects/nkf/") > > + (synopsis "Network Kanji Filter") > > + (description "Nkf is a yet another kanji code converter among networks, hosts and terminals. It converts input kanji code to designated kanji code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.") > > + (license license:zlib)))) > > 'is a yet' -> 'is yet' > > Use double-space after end-of-sentence period. > > Also, make sure to run 'guix lint knf' > > Could you send an updated patch? > > Thanks, > `~Eric Hello, I updated and made format patch. >From aab08237d2ece4a1f190522d1357b5b9e872ce57 Mon Sep 17 00:00:00 2001 From: Yoshinori Arai Date: Fri, 1 Feb 2019 12:55:46 +0900 Subject: [PATCH] Add nkf --- gnu/packages/textutils.scm | 42 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm index d2f84420c..34aae6361 100644 --- a/gnu/packages/textutils.scm +++ b/gnu/packages/textutils.scm @@ -794,3 +794,45 @@ Chinese and Simplified Chinese, supporting character-level conversion, phrase-level conversion, variant conversion, and regional idioms among Mainland China, Taiwan, and Hong-Kong.") (license license:asl2.0))) + +(define-public nkf + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2") + (revision "1")) + (package + (name "nkf") + ;;look at https://ja.osdn.net/projects/nkf/scm/git/nkf/ + (version "2.1.5") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/nurse/nkf.git") + (commit commit))) + (file-name (string-append name version)) + (sha256 + (base32 + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; test for perl module + #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic" + (string-append "prefix=" %output)) + #:phases + (modify-phases %standard-phases + (delete 'configure) + ;; mkdir can't create directory + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (man1 (string-append out "/share/man/man1")) + (man1j (string-append out "/share/man/ja/man1"))) + (install-file "nkf" bin) + (install-file "nkf.1" man1) + (install-file "nkf.1j" man1j) + #t)))))) + (home-page "https://ja.osdn.net/projects/nkf/") + (synopsis "Network Kanji Filter") + (description "Nkf is yet another kanji code converter among networks, +hosts and terminals. It converts input kanji code to designated kanji code +such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.") + (license license:zlib)))) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 25 23:18:00 2019 Received: (at 34262-done) by debbugs.gnu.org; 26 Feb 2019 04:18:00 +0000 Received: from localhost ([127.0.0.1]:52131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyUBr-00021Y-Lw for submit@debbugs.gnu.org; Mon, 25 Feb 2019 23:17:59 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyUBq-00021I-GB for 34262-done@debbugs.gnu.org; Mon, 25 Feb 2019 23:17:59 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 37215204B9; Mon, 25 Feb 2019 23:17:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 25 Feb 2019 23:17:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=NiWhWo68/JJfkaZnZ29eUR9J krNiiVubBp4hgwj01rM=; b=lDtUucAWcV7au5Vx87mbh9gPXeTcP9F7DcaS38Il mtZQn/XNFBT2QUb5UixRfDwogfK5jCywaz66F306MKW9x1QMVGglIEi80XAdG+m2 F9QbQzwTM9zPiFb7GgbI5baOOQl3z/BW0hk8+YfS1OlizLBB+06qe6BEzWtndx+p Rb0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=NiWhWo 68/JJfkaZnZ29eUR9JkrNiiVubBp4hgwj01rM=; b=D8cWLEEiiEkoKwHOYj3XRv y3ckV0sOpAspQv5AT4YFrcAZmij2CBfkA8G+ShBDQzWnakDi5pF2bs3a6iQ9h2VM 9Rpet96+jqtcbMWE4lHlyd96WHjUWKPWqftNDPMxupF6BpMss8l1jujPDGw1JMsU iky4dSEqLokfcX6svVZzQqpotOerRvzgSW5o80xZ/K7J06GA0kPQ4097Pkllaojz dxw57e0vZru8tiayGBkBDOyOqH/M7qPOLr26JmRXikmvljm+fkOyr+gO3VJWLfHG +6kz0hm4DUFjKniFIOT2Hvu3kPZ7VhbQ5ecNWplnj1+FNI/A11iktGDbmmPO//IA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrudekgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehgtderredtredvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucffohhmrghinh epghhithhhuhgsrdgtohhmpdhoshgunhdrnhgvthenucfkphepjeeirdduvdegrddvtddv rddufeejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnh grmhgvnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 20600E425A; Mon, 25 Feb 2019 23:17:52 -0500 (EST) Date: Mon, 25 Feb 2019 23:17:51 -0500 From: Leo Famulari To: Yoshinori Arai Subject: Re: [bug#34262] [PATCH]Add: nkf Message-ID: <20190226041751.GA15689@jasmine.lan> References: <20190131064326.ndndwqf23yirdoup@WaraToNora> <20190131085519.23d47ee2@centurylink.net> <20190201040305.luu56jkwndye2zrv@WaraToNora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline In-Reply-To: <20190201040305.luu56jkwndye2zrv@WaraToNora> User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34262-done Cc: Eric Bavier , 34262-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From aab08237d2ece4a1f190522d1357b5b9e872ce57 Mon Sep 17 00:00:00 2001 > From: Yoshinori Arai > Date: Fri, 1 Feb 2019 12:55:46 +0900 > Subject: [PATCH] Add nkf >=20 > --- > gnu/packages/textutils.scm | 42 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) Thank you! I made the changes shown below and pushed as 933ac939d6d2de64c43e068e7c0ebfaaaf2dcdd8 diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm index 2d3a090056..71f03b7568 100644 1 gnu: Add nkf. --- a/gnu/packages/textutils.scm +++ b/gnu/packages/textutils.scm @@ -800,14 +800,16 @@ Mainland China, Taiwan, and Hong-Kong.") (revision "1")) (package (name "nkf") - ;;look at https://ja.osdn.net/projects/nkf/scm/git/nkf/ + ;; The commits corresponding to specific versions are published + ;; here: + ;; https://ja.osdn.net/projects/nkf/scm/git/nkf/ (version "2.1.5") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/nurse/nkf.git") (commit commit))) - (file-name (string-append name version)) + (file-name (git-file-name name version)) (sha256 (base32 "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))= )) @@ -815,21 +817,11 @@ Mainland China, Taiwan, and Hong-Kong.") (arguments `(#:tests? #f ; test for perl module #:make-flags (list "CC=3Dgcc" "CFLAGS=3D-O2 -Wall -pedantic" - (string-append "prefix=3D" %output)) + (string-append "prefix=3D" %output) + "MKDIR=3Dmkdir -p") #:phases (modify-phases %standard-phases - (delete 'configure) - ;; mkdir can't create directory - (replace 'install - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin")) - (man1 (string-append out "/share/man/man1")) - (man1j (string-append out "/share/man/ja/man1"))) - (install-file "nkf" bin) - (install-file "nkf.1" man1) - (install-file "nkf.1j" man1j) - #t)))))) + (delete 'configure)))) ; No ./configure script (home-page "https://ja.osdn.net/projects/nkf/") (synopsis "Network Kanji Filter") (description "Nkf is yet another kanji code converter among networks, --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlx0ve8ACgkQJkb6MLrK fwghDg//W7etn9HsjfCw2D2FYNKGwkjVd16R0WQc0p9EBh4l84iRHUZjIJuc+hcu ANze0tMBSWFR1JK4BQsjKWXwzmh9KVUEN0lQyo7Yv1OrcyuPXWPTJNr2JxnjI8wY lZjS5sd80wHkqPZVBj2L3ocIm5vTmzRkvFtYK6rXgxGT18POLWRCklzsSryzINpm GVbn84w1ruj/nGzRpBgTNCD9N4A5ul2suKPRSuQ8QPxhCWLdtDQ7t63hYZObh2tR pEHE+J1Xhg9m8kFLyZL88IAJVp2IDyV5WwkcjPLKkr7fGV47jeww24x/91AuWLxP 7DhdPj2rSZh6hWOIq64Vepsl+86NuAVRfgQ1EIUbzv8/IFBsNk1q1IXdD+6YDy/G SCrwTdE9SwYSvuKgYOi+rBg2NVyJN+2JxsAdMQt8cUX79JdADk/U7LMzsnuBo6YQ bUIu2tfgGwNUzVxKGHudLAhJrsTlk+3uUt/Dq8v3DaADHWQeQPjG0cn/QwXIXfMb yQVJTXN/J9bW4/YL8liN9LP2wbFz0/1/lHyFLKt1xrBQIGy0shC6U4qhkc9GYMd3 Kzqg+hQQspSR00uB/KNjsslbV2UiVaU8HRsimFu2UV/89iTykzzUrlr+851a67Df 7d5JY/WChZFgsPSpB5okBeVvG8OPc+9u8adls5pI6Z2oKun8BJM= =4FLl -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8-- From unknown Mon Aug 18 00:08:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Mar 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator