Subject: Re: bug#34252: 27.0.50; rmail-get-new-mail fails

From: Glenn Morris <[email-masked]>
Date: Tue, 29 Jan 2019 19:34:46 -0500

John wrote:

> in case of reading a mail box on a nfs-mounted disk

It's hard to see how that could make a difference to Rmail.

> --- a/lisp/mail/rmail.el
> +++ b/lisp/mail/rmail.el
> @@ -1902,7 +1902,7 @@ rmail-parse-url
>             (host  (substring file (or (match-end 2)
>                                        (+ 3 (match-end 1))))))
>  
> -       (if (rmail-remote-proto-p proto)
> +       (if (and proto (rmail-remote-proto-p proto))

It's not possible for proto to be nil here.

>             (if (not pass)
>                 (when rmail-remote-password-required
>                   (setq got-password (not (rmail-have-password)))
> @@ -1913,7 +1913,7 @@ rmail-parse-url
>               ;; does not really like it, in spite of the movemail spec.
>               (setq file (concat proto "://" user "@" host))))
>  
> -       (if (rmail-movemail-variant-p 'emacs)
> +       (if (and proto (rmail-movemail-variant-p 'emacs))

Or here.

>             (if (string-equal proto "pop")
>                 (list (concat "po:" user ":" host)
>                       proto
> @@ -2072,7 +2072,7 @@ rmail-insert-inbox-text
>                    ;; If we just read the password, most likely it is
>                    ;; wrong.  Otherwise, see if there is a specific
>                    ;; reason to think that the problem is a wrong passwd.
> -                  (if (and (rmail-remote-proto-p proto)
> +                  (if (and proto (rmail-remote-proto-p proto)

Here I think you may be correct.