From unknown Thu Aug 14 17:28:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3425 <3425@debbugs.gnu.org> To: bug#3425 <3425@debbugs.gnu.org> Subject: Status: 23.0.94; Please make flyspell-generic-check-word-predicate a hook Reply-To: bug#3425 <3425@debbugs.gnu.org> Date: Fri, 15 Aug 2025 00:28:16 +0000 retitle 3425 23.0.94; Please make flyspell-generic-check-word-predicate a h= ook reassign 3425 emacs submitter 3425 Lennart Borgman severity 3425 wishlist thanks From lennart.borgman@gmail.com Sat May 30 12:52:05 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 30 May 2009 19:52:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4UJq1cp032706 for ; Sat, 30 May 2009 12:52:02 -0700 Received: from mail.gnu.org ([199.232.76.166]:42888 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MAUb2-0003zU-JM for emacs-pretest-bug@gnu.org; Sat, 30 May 2009 15:52:00 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MAUb1-0001jA-Rz for emacs-pretest-bug@gnu.org; Sat, 30 May 2009 15:52:00 -0400 Received: from mail-fx0-f169.google.com ([209.85.220.169]:40185) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAUb0-0001ir-MR for emacs-pretest-bug@gnu.org; Sat, 30 May 2009 15:51:58 -0400 Received: by fxm17 with SMTP id 17so7524480fxm.42 for ; Sat, 30 May 2009 12:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=GMIM8PEdy3FpGGxYXfdwGIObQsrpy/QUCh41+FHiXOE=; b=iteijdJmu+WodlM3H9ur6aCx1F0VdLy3xQ4CY5Pi8XhwCgKP0+Ct79mJ5uU2ik5sn8 4StG7SweRynQeav6cvntOGdyAlaRY5kVHs/b2+fbtHtJmYd4eHGjcOD+SlKMqndzwpgw Nq2SmI3S1E6Z+tOxwUsP1HffOIVMNooQqDVpA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=SJ5braYYuPTedunmx8EkPaI2K37K+AHdW/Rl6A6uBaAQBKPedp9UQaIMYTVBtRj0l/ BdHafQJjsvmHxSb/91Wr49ihr8BHgyLcGTPl2bhwMNIslyjgOQmMdnKmULXnvflAZXUh TX1gfBF9dxk+HkL9Tmhuwh44fE85KPwWQKi+I= MIME-Version: 1.0 Received: by 10.239.164.83 with SMTP id s19mr299590hbd.110.1243713117394; Sat, 30 May 2009 12:51:57 -0700 (PDT) Date: Sat, 30 May 2009 21:51:57 +0200 Message-ID: Subject: 23.0.94; Please make flyspell-generic-check-word-predicate a hook From: Lennart Borgman To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) I suggest that flyspell-generic-check-word-predicate is made a hook. It is quite inconventient to add new checks as it currently most be a function. There is for example a question on EmacsWiki for how to avoid checking words in an URL. That would be a good candidate to add to a hook. Converting it is easy. It is just replacing the lines below (and (fboundp flyspell-generic-check-word-predicate) (not (funcall flyspell-generic-check-word-predicate)))) with (run-hook-with-args-until-success flyspell-generic-check-word-predicate)) As hooks are defined now old code will continue to work. In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-23 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From rgm@gnu.org Wed Jun 17 00:29:42 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Jun 2009 07:29:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5H7TcQa018381 for ; Wed, 17 Jun 2009 00:29:39 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MGpaT-00005k-JR; Wed, 17 Jun 2009 03:29:37 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19000.39777.414084.568239@fencepost.gnu.org> Date: Wed, 17 Jun 2009 03:29:37 -0400 From: Glenn Morris To: control Subject: control message Sender: Glenn Morris tags 3196 moreinfo unreproducible reassign 3221 emacs,ns reassign 3256 emacs,ns tags 3264 moreinfo reassign 3269 emacs,cc-mode close 3269 reassign 3281 emacs,w32 tags 3291 moreinfo severity 3310 minor close 3319 severity 3327 minor tags 3330 moreinfo unreproducible reassign 3331 emacs,ns close 3331 reassign 3351 emacs,ns severity 3350 minor reassign 3397 emacs,ns severity 3425 wishlist close 3448 reassign 3459 emacs,ns severity 3462 wishlist tags 3467 wontfix reassign 3500 emacs,ns merge 3234 3483 severity 3540 wishlist reassign 3452 emacs,w32 severity 3577 minor reassign 3581 emacs,ns reassign 3583 emacs,ns merge 3588 3593 reassign 3588 emacs,ns reassign 3589 emacs,ns reassign 3478 emacs22,w32 close 3146 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 21:55:20 2017 Received: (at control) by debbugs.gnu.org; 18 Feb 2017 02:55:20 +0000 Received: from localhost ([127.0.0.1]:44004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cevB9-0001O4-My for submit@debbugs.gnu.org; Fri, 17 Feb 2017 21:55:19 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:36394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cevB7-0001Np-PM; Fri, 17 Feb 2017 21:55:18 -0500 Received: by mail-io0-f194.google.com with SMTP id q20so721544ioi.3; Fri, 17 Feb 2017 18:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/p/Ca7HVlhoNGWCFLE0ObykFXub99rRxBXgYzRVc2YY=; b=rr3mnt90wWkhFEJGNE/6h4dpxXfeTY34bqEW6r0Lwco+Bl2pyFmax1xNQ/1g+6xS3F koutRMKX5VREwgW+PsMzIgy4+SbZspJNeeA0h+PdRMtYSJ7wwxjHQegBxa9rn2Cpal6p MCVy5I8wr8K2LM+3t/KIlNMa81b3hefIgvJ/XGwapVh9YFF8z0QvenoxTtt1/BpLtdHJ q8WfYIFSZOJUx+ay7bjQQtRoIix+dyAIpQL+fHeeD4fHJw1SlqTUN3mXlvCYrBIPz86J FlQx+6XNP4fulbbI/ZEXHvB3fKUlGD4CM1hjz8twaIQQtNqFJzYtYBDocqH8bYcaV3QR u7vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/p/Ca7HVlhoNGWCFLE0ObykFXub99rRxBXgYzRVc2YY=; b=YRyS7IlWIvdnpqoNBmbU8eN3a7xQ0yg0E8iFipRDmF6HOPyV6VmzwvM89+h9TI8JvD T9f3NustJihkh89yRHmkv0LkJe9rtQcBqeWs1kjmvMbpFXF2jCwfQsHYbNRkU4M24sUn dMkLbx8skWMt1S4yts4NhF8fkwJSHQG0hZLNYou7W4DAGu0Tyuafk8CkNzlXe3nV6Eg2 lfeds35nvpKrqjv/YEnIH0YMCjj8lSf/36ExKgihPGyITHsGwL0bcFhzh3uINdsTLeF7 hWlolVyP4XveGhSnPG5bWAH/xGu+YwajmS7yHBLiS2qX7/DAe+BXwTyKZNMrdGEgXmx6 u6xQ== X-Gm-Message-State: AMke39n20Va0ecw5uh84RBezFGz3AB7UMp4id524X4vbQOVNwQx0UHMzixOfBfMWrveUqA== X-Received: by 10.107.59.148 with SMTP id i142mr10915732ioa.84.1487386512174; Fri, 17 Feb 2017 18:55:12 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id d128sm1482708ite.23.2017.02.17.18.55.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Feb 2017 18:55:11 -0800 (PST) From: npostavs@users.sourceforge.net To: Hong Xu Subject: Re: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. References: <20170216213026.5591-1-hong@topbug.net> <877f4pg5ez.fsf@topbug.net> Date: Fri, 17 Feb 2017 21:56:22 -0500 In-Reply-To: <877f4pg5ez.fsf@topbug.net> (Hong Xu's message of "Thu, 16 Feb 2017 14:03:00 -0800") Message-ID: <87y3x4jjft.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control Cc: 25765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) tags 25765 fixed close 25765 26.1 # With this patch, new checks can be added via add-function close 3425 26.1 quit Hong Xu writes: > On 2017-02-16 Thu 13:36 GMT-0800, Noam Postavsky wrote: > >> On Thu, Feb 16, 2017 at 4:30 PM, Hong Xu wrote: >> >> I don't think that's the right fix, rather the fboundp should be >> replaced with functionp. > > I agree. I've attached a new version of this patch. > Thanks, pushed to master [1: a83b66923c]. 1: 2017-02-17 21:50:46 -0500 a83b66923cfb71bb477d7a1f426f7426f91917da Avoid errors when flyspell-generic-check-word-predicate is a lambda. From unknown Thu Aug 14 17:28:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 Mar 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator