GNU bug report logs - #34246
[PATCH 0/3] Improve the upower-service style.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#34246: closed (Re: [bug#34246] [PATCH 0/3] Improve the
 upower-service style.)
Date: Sat, 16 Feb 2019 22:16:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34246: [PATCH 0/3] Improve the upower-service style.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34246 <at> debbugs.gnu.org.

-- 
34246: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34246
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34246-done <at> debbugs.gnu.org
Subject: Re: [bug#34246] [PATCH 0/3] Improve the upower-service style.
Date: Sat, 16 Feb 2019 22:15:43 +0000

[Message part 3 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello!
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> These patches update the style of the upower-service. Improving and
>> documenting the <upower-configuration> record, and deprecating the
>> upower-service procedure.
>>
>> Directly using record types as default values for service types, along
>> with default values for the fields in the record type is generally more
>> flexible and configurable than using procedures for service
>> configuration. It means that the configuration for the service can be
>> changed programatically by generating new configuration based off of the
>> original configuration, rather than having to rerun the procedure that
>> created the configuration in the first place.
>>
>>
>> Christopher Baines (3):
>>   services: Improve the upower-configuration record.
>>   services: Improve the upower-service-type.
>>   services: desktop: Deprecate the upower-service procedure.
>
> All three patches LGTM.  Thanks for taking the time to do this!  :-)

Great, I've pushed these patches to master now :)

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Improve the upower-service style.
Date: Tue, 29 Jan 2019 15:28:48 +0000

[Message part 6 (text/plain, inline)]

These patches update the style of the upower-service. Improving and
documenting the <upower-configuration> record, and deprecating the
upower-service procedure.

Directly using record types as default values for service types, along
with default values for the fields in the record type is generally more
flexible and configurable than using procedures for service
configuration. It means that the configuration for the service can be
changed programatically by generating new configuration based off of the
original configuration, rather than having to rerun the procedure that
created the configuration in the first place.


Christopher Baines (3):
  services: Improve the upower-configuration record.
  services: Improve the upower-service-type.
  services: desktop: Deprecate the upower-service procedure.

 doc/guix.texi            | 79 ++++++++++++++++++++++++++--------
 gnu/services/desktop.scm | 92 +++++++++++++++++++++++++++-------------
 2 files changed, 123 insertions(+), 48 deletions(-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.