GNU bug report logs - #34240
[PATCH 0/5] Gnome printing improvements

Previous Next

Full log

Message #46 received at 34240-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34240-done <at> debbugs.gnu.org
Subject: Re: [bug#34240] [PATCH 4/5] gnu: Add system-config-printer.
Date: Wed, 13 Feb 2019 08:21:04 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/gnome.scm (system-config-printer): New variable.
> […]
>> +    (arguments
>> +     `(#:imported-modules ((guix build python-build-system)
>> +                           ,@%glib-or-gtk-build-system-modules)
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'patch-Makefile.am
>> +           (lambda _
>> +             ;; The Makefile generates some scripts, so set a valid shebang
>> +             (substitute* "Makefile.am"
>> +               (("/bin/bash") (which "bash")))
>> +             #t))
> […]
>> +         (add-before 'configure 'bootstrap
>> +           (lambda _
>> +             ;; Run ./bootstrap as otherwise the build fails with
>> +             ;; automake-1.15: command not found
>> +             (invoke "./bootstrap")
>> +             #t))
>
> The build system already provides a “bootstrap” phase, so maybe it would
> be better to delete “configure” in “patch-Makefile.am” to activate the
> bootstrap phase.
>
> Otherwise looks good to me.  Thanks!

Great, I've made that change to the system-config-printer phases and
pushed these patches now.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.