GNU bug report logs - #34233
27.0.50; defvar in comment

Previous Next

Full log

Message #27 received at 34233 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 34233 <at> debbugs.gnu.org,
 Sebastian Miele <sebastian.miele <at> gmail.com>,
 Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#34233: 27.0.50; defvar in comment
Date: Thu, 11 Jul 2019 15:45:24 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:

>> +                     ;; Top-level.
>> +                     (and (zerop (car syntax))
>> +                          ;; Not in a comment.
>> +                          (null (nth 4 syntax))
>> +                          ;; Not in a string.
>> +                          (null (nth 3 syntax)))))
>>                   (push var vars))))
>>          `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp)))))

[...]

> There is already a function for this particular case:
> syntax-ppss-toplevel-pos.

Are you referring to just the (car syntax) bit or the nth 4/3 bit (which
are the same as nth 8, apparently?  (And which I've now committed.)
Feel free to touch it up if you want to, but I couldn't convince myself
that they were equivalent...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.