From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Sebastian Miele Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jan 2019 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 34233@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154867700131080 (code B ref -1); Mon, 28 Jan 2019 12:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2019 12:03:21 +0000 Received: from localhost ([127.0.0.1]:48274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1go5dJ-00085D-27 for submit@debbugs.gnu.org; Mon, 28 Jan 2019 07:03:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1go2e2-0003VO-S8 for submit@debbugs.gnu.org; Mon, 28 Jan 2019 03:51:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:45394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1go2dx-0004mf-Cr for submit@debbugs.gnu.org; Mon, 28 Jan 2019 03:51:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go2dw-0000oG-9i for bug-gnu-emacs@gnu.org; Mon, 28 Jan 2019 03:51:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go2du-0004lN-FJ for bug-gnu-emacs@gnu.org; Mon, 28 Jan 2019 03:51:48 -0500 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]:38064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1go2du-0004kS-8K for bug-gnu-emacs@gnu.org; Mon, 28 Jan 2019 03:51:46 -0500 Received: by mail-qt1-x843.google.com with SMTP id p17so17404407qtl.5 for ; Mon, 28 Jan 2019 00:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=kOnQ0Pb9xFE0BUfWfJTH6objzUu9bTV72t3Ctz4iwL4=; b=PAjhjC85wIVPanKokSvPhK3Dsb8+Khl/V4eYc8WlJBEKi1TFtl53B9anCxJFuvShCk iLn2iAfdLRre+DLzl8bAGcNDVOgiPjtf0AF7YUWlpgnCtu/zt20hPjvv8dRY1cTEutVN jRQdU6U7SsNYXkFmmr9mVAmwc7OnmCkS71tPIcR0elJmAmkjiXO26WCqHifaXGLmiKHI fBShJczL4hb1uP9LAma0ogECql7v5b5IA5ujPF9NYrq8fBUBO8oz9z1SYKmyDktUasvL KfJOOoGhXCfeW3ppXPc0eAoYL41T62L/wIQR3pnyR/9sNEafr84u/Mb0tQXpZZdOv5E7 VKSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kOnQ0Pb9xFE0BUfWfJTH6objzUu9bTV72t3Ctz4iwL4=; b=WUDaVSv6aetWBGdACDLL0cnFwkDe9UbOIyhaW9uwYbuPIlBivEEkXi/y+PlfSknS6E vjbnWASW7rbYtICK1ZK5s0TWaOqWTnrJMJkZZ9+Y8Do0Izrnl7VeT5nzZDJFe/eYaFva y+zJt57G4XBJZMM/KtK00iA8I0bSgVJN1n5HxSyxoHCwlqvraU2f7wVG5VDJ1xTqsoIL BF3noffMgdw6Aj7zCxEVhIVA2BTG/cWzblADadVYboM3yqQLd0FqoV/+obGKv9Rd69hB mBR16g2s72Kq4gi5zk5XW/Rj89lZ5UQUgEdK/lCCbY4auYDsJZrbEhNpHqI3MFh7SaSN /law== X-Gm-Message-State: AJcUukcwjirTA7ZFRMdbDbU2VOJMZeJ/XhTUT4ke3VoVzrvF/dFc6Gv4 FyhWSbelNuzNqwsNIkegwdxNKRUemScxFltFUK9d1yXP X-Google-Smtp-Source: ALg8bN6t0T0VuevJULzjtflsTHob7wg1iATemUsEZiBM/ggdSAEbU2qieUpXoueZ49d8yErLD/K7M+GFYDQjqpS5Ij4= X-Received: by 2002:a0c:e010:: with SMTP id j16mr19463829qvk.111.1548665503921; Mon, 28 Jan 2019 00:51:43 -0800 (PST) MIME-Version: 1.0 From: Sebastian Miele Date: Mon, 28 Jan 2019 09:51:32 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::843 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Mon, 28 Jan 2019 07:03:19 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) ;; Start ./src/emacs -Q, put this into *scratch*, do not remove this ;; "(defvar x)" in this comment, and C-x C-e the following two ;; expressions in turn: ;; (setq lexical-binding t) (let ((x 42)) (lambda () x)) ;; ;; Value: (closure (x t) nil x) ;; Expected: (closure ((x . 42) t) nil x) In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.4) of 2019-01-28 built on tisch Repository revision: d81aa8516ef6df79d6d602d4f732d8a65bf1677c Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Arch Linux Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Mark set next-line: End of buffer [4 times] Mark set t (closure (x t) nil x) Quit Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD JSON CANNOT_DUMP LCMS2 GMP Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 45259 7117) (symbols 48 5860 1) (strings 32 14881 1022) (string-bytes 1 490862) (vectors 16 9474) (vector-slots 8 117324 9510) (floats 8 19 155) (intervals 56 279 0) (buffers 992 12)) From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2019 18:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Miele Cc: 34233@debbugs.gnu.org, Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.156269589217981 (code B ref 34233); Tue, 09 Jul 2019 18:12:02 +0000 Received: (at 34233) by debbugs.gnu.org; 9 Jul 2019 18:11:32 +0000 Received: from localhost ([127.0.0.1]:34152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkuaS-0004fx-G8 for submit@debbugs.gnu.org; Tue, 09 Jul 2019 14:11:32 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkuaQ-0004fp-AH for 34233@debbugs.gnu.org; Tue, 09 Jul 2019 14:11:30 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkuaL-00081w-Pj; Tue, 09 Jul 2019 20:11:28 +0200 From: Lars Ingebrigtsen References: Date: Tue, 09 Jul 2019 20:11:25 +0200 In-Reply-To: (Sebastian Miele's message of "Mon, 28 Jan 2019 09:51:32 +0100") Message-ID: <87o923qdrm.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sebastian Miele writes: > ; ; Start ./src/emacs -Q, put this into *scratch*, do not remove this > ;; "(defvar x)" in this comment, and C-x C-e the following two > ;; expressions in turn: > ;; > (setq lexical-binding t) > (let [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sebastian Miele writes: > ;; Start ./src/emacs -Q, put this into *scratch*, do not remove this > ;; "(defvar x)" in this comment, and C-x C-e the following two > ;; expressions in turn: > ;; > (setq lexical-binding t) > (let ((x 42)) (lambda () x)) > ;; > ;; Value: (closure (x t) nil x) > ;; Expected: (closure ((x . 42) t) nil x) I can confirm that this bug is still present. Stefan, do you know what's going on here? That a commented-out (defvar) before the eval-ed form has any effect is rather surprising... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2019 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.156269896315099 (code B ref 34233); Tue, 09 Jul 2019 19:03:01 +0000 Received: (at 34233) by debbugs.gnu.org; 9 Jul 2019 19:02:43 +0000 Received: from localhost ([127.0.0.1]:34214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkvNy-0003vT-U3 for submit@debbugs.gnu.org; Tue, 09 Jul 2019 15:02:43 -0400 Received: from mout.web.de ([212.227.15.3]:38481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkvNw-0003vG-SV for 34233@debbugs.gnu.org; Tue, 09 Jul 2019 15:02:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562698952; bh=JrVmheGTz0m31ANweoff7TNoRTeYPbBTeMoU4NpJTAk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=KEEPCKokDzLWD3K0GCikFDKktNyZsMy+JJ04gdO8HyuKNBXpO6/qdDaHKl1CU6Jr4 OXLXanFPL6Q7EmBtJnp3CaK4dVoDIlJ1ZYvQia9bKGmlIvPfLjrY/85ANWH/bcv6hL tkdn1e7I5cD4Jup5vLJ86BG4LPMpYnx6J23naM2o= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.216.191.242]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MI5yY-1hmaOp0LVu-003yJJ; Tue, 09 Jul 2019 20:49:17 +0200 From: Michael Heerdegen References: <87o923qdrm.fsf@mouse.gnus.org> Date: Tue, 09 Jul 2019 20:49:11 +0200 In-Reply-To: <87o923qdrm.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Jul 2019 20:11:25 +0200") Message-ID: <875zobdowo.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:+KuCYA/+hdPMFO3dNd8tFiYFoSN9A7suNMIy88zYujnQTINyYwE pzGvOaHbbnJqbi9pa0Z4x7OMm+qPFLpQTIzbIRHsepkW9bJX4EG4sCRxaIbnDzSDvfZlYxL LgS4teONzHrA5mFTXXZw+ddal6F2Xffbc/wFVFLQhHo2efufnWHKhDySrPouxZxOkG7XTzV So5Y7cSQew2xn5il3Hhww== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OrjKFiHGBp4=:/zvNUuEahejY9hS2xrp4QO jfvp9AlB+C44WJvTQU9EXuhTVmGRvUSUZV/hJeOi7OM3pTeBVdTbKBJJXdELgSonBVjGpmHDg 5C56huNCSu/3fcUmPsCz97ZXOTlKQZ3UWZLDWJZLl+ZZZ4W9Zqs0An2cVKP5+oRiBdQjZUCXy N39wQLmbhlxpRtSmdbQ2T6RgZmiH3Vks5bBKqzXZbtq2+mceuhsWgnxW49YYJ8aJCol1kPc5m j/EbTetLM3/bvukyka2SBTAUfN86xvkdr5rnIEjeURhHXIip1VuHSgHVamCTaKzZX8GeyZ+c/ F3aZOLgGXJv2FGmkRdvp9jPJOjTCit8U/Ti0n2jCUqLQixPcNDNxhWQsZztaEDgvZxBeaplhV XGnHErU8MrUfefidGnmvX1W3L+j30v3wo+8TCDTLamSnEfiDtNQdk6O1U7jImYuyJySDS2wTN Rlx7LF0BXQ0NVCQT5lDysOKbagNlSG7UxmAewHyxRoZzp4bCIMoQ7c+bgJg+huPFoDVpJBAXr y93jdrdPwynm57XkXUgr/Qp2hr/hVfbEitkRGcJHIObFHzQLob+bLzZ2iZthbncnggkNtbj+v fX3mIIc6WzegclZYetl5AR7HkCxdgY0fqZrCKU4HNPPuAiMvtlLWIe8o3ugE390BOZ4Bsjulj XVkz6rx64u02yBZAUO8sEcALP3xrQT0Gjcb7bQ6brNNk6w5aamtB6eDL6crcrsVJmt+m5hnNA yw7l6KKh9p8+0ZEkuese9VUbGJMiDehmzCXM+nw6zDDFmD12yNOnmBe6vSBQsNfaFzBIUmgOk 5bNt9cKymgRQVEbcw8auZBlGdwKNlOAr51yBitqnBjlhcJo2zyH/Ft0WvBb2jBlEO4OUOH4v+ VAu2Rvuj8PFz33/djoUzZc22+5TnEt5aJALNXovbR1Q3ivXSDVKP0g0AEv5vCVwNL+FbyAtHX yyqV5xCa2n8LS9jgi9i9C5bkI1W/v2FO9D45FFUVKAfVuGC8Z8+d5e5/t7JFrYazgBzNLlS6Y EJV2po9hQb1DtzpPhMmV2prPap7tC7DjFThOAd/nelnK+vnRJxMqdcy93PCE87OeBFHcaaYeq eTND7AYY223KMbv5IZAseM4dvhCnCk795pe X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Sebastian Miele writes: > > > ;; Start ./src/emacs -Q, put this into *scratch*, do not remove this > > ;; "(defvar x)" in this comment, and C-x C-e the following two > > ;; expressions in turn: > > ;; > > (setq lexical-binding t) > > (let ((x 42)) (lambda () x)) > > ;; > > ;; Value: (closure (x t) nil x) > > ;; Expected: (closure ((x . 42) t) nil x) > > I can confirm that this bug is still present. > > Stefan, do you know what's going on here? That a commented-out (defvar) > before the eval-ed form has any effect is rather surprising... This is `eval-sexp-add-defvars' not checking if defvars are really code. Michael. From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.156275894026881 (code B ref 34233); Wed, 10 Jul 2019 11:43:01 +0000 Received: (at 34233) by debbugs.gnu.org; 10 Jul 2019 11:42:20 +0000 Received: from localhost ([127.0.0.1]:34935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlAzM-0006zV-6X for submit@debbugs.gnu.org; Wed, 10 Jul 2019 07:42:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:36180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlAzK-0006zN-8b for 34233@debbugs.gnu.org; Wed, 10 Jul 2019 07:42:18 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlAzD-0008Jq-66; Wed, 10 Jul 2019 13:42:13 +0200 From: Lars Ingebrigtsen References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXa2djt7eyjoZ/k5OL+ //79/f3Ozcu+vbvUGkYsAAACbUlEQVQ4jbWPQY/bIBCFh0WBayjr3WuWSuYKQeucI/UHxHV3eyWx CleHaJm/38HaVlXV3tqJjZT38d4bw6e/DPx7cDF7Y2q25e03oGiCV2q8/0PUZfeftjq+3Hfq2L2o o3pR6mXsuu44fulGoEXGsaOD1hpV9/OAcZWaOoZf2Ahk7byaVOg6HVZxZR1FKa2U95ruB0Ws+YhQ lOp8mJra3uC1Hn3rUJ4FPWn6T4Te8Bx8iwOvp4n0QIhuB6b96u1g9DTPwXnwIfjANScLdQIn3Tnt mQPVHrZtcUqDnk5bz3jYauD0bGFq1knDc+BnDm7LuGuyage1KdDMnU6nLUuOicSAB9AuTCHA9kT3 4TwLnkJKWmzIwjcENvG8YVwMbhbRJSYiSQBaw0m8PgyCz3FwaR4ag+iBeQDGYT7HNMxcJC7mB0qE LVUxYFEMwyNUASk+JJfgAZgL8CpeJYF4wxQhrSxA8hTzFq/fzkuSoqYoq6s8UWjUQM3DkHOOi0h1 wDkvcxKO3CKKKOPtVnNMOeYKGA8pugjzTCqmLCUdGDFK5DHR13wVj4d9fjzkijXiInHIbb9E5fVa r0tfMdvaLIQjgIBHKQeUWC5YsdTcJ6yyEoElStpJ1l2PtVhpF8RKKwS41Xrtn2xvS7HZNEaEKkDu P8jL57LfX9BYNLJUakIiy7I87eyut9YWUw2tkGtCRDgcqDkXNIVeYn2h76Ef1Frxcil3xVqDpjem VbStbsuu7z9SEmm2WCxmbeBw16Y57ooxxVBeM2Gl8h1ZemNNG4KNWCqnCkTzY2zT1qEoqqZpl1eX pYpWbvr3eQ9bc4h9B6WuB3+i6A6mAAAAAElFTkSuQmCC Date: Wed, 10 Jul 2019 13:42:10 +0200 In-Reply-To: <875zobdowo.fsf@web.de> (Michael Heerdegen's message of "Tue, 09 Jul 2019 20:49:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > This is `eval-sexp-add-defvars' not checking if defvars are really code. So is this the correct solution? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > This is `eval-sexp-add-defvars' not checking if defvars are really code. So is this the correct solution? diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index cb1b17b447..0e99cb9ac0 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -1179,7 +1179,13 @@ eval-sexp-add-defvars (let ((var (intern (match-string 1)))) (and (not (special-variable-p var)) (save-excursion - (zerop (car (syntax-ppss (match-beginning 0))))) + (let ((syntax (syntax-ppss (match-beginning 0)))) + ;; Top-level. + (and (zerop (car syntax)) + ;; Not in a comment. + (null (nth 4 syntax)) + ;; Not in a string. + (null (nth 3 syntax))))) (push var vars)))) `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) (Those ppss things really should have accessors. :-)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Michael Heerdegen , 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.15627593923382 (code B ref 34233); Wed, 10 Jul 2019 11:50:02 +0000 Received: (at 34233) by debbugs.gnu.org; 10 Jul 2019 11:49:52 +0000 Received: from localhost ([127.0.0.1]:34945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlB6e-0000sS-86 for submit@debbugs.gnu.org; Wed, 10 Jul 2019 07:49:52 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:35492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlB6c-0000s9-0z for 34233@debbugs.gnu.org; Wed, 10 Jul 2019 07:49:50 -0400 Received: by mail-io1-f54.google.com with SMTP id m24so4060401ioo.2 for <34233@debbugs.gnu.org>; Wed, 10 Jul 2019 04:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=JPFjjckE/7NotZCaBxXh+XGvAYsXoL7QsuUpq3pauJE=; b=GOQUuVYesMEbI0/DB90naM++818y2ZbdzKCAk/tIK146pJo0O6XBGc1i2wk3UIUNZ7 LYZqTReuiondZUc2S9fVQyrMTOJRglKZgIwyhV/kpceazXN3ptDfDbRM99PAgsSnU11E B8lfM22F5yqtjiPiTRH1JylisS8Gx7GF62OipXCd+mk+I6BE/7HHpRXB2OXiSmoJob2p iAqVCX39PiJYOckFdcjwjjz4kYQ5MTQeODDMnHKChbPDdiGjRGTwYIrtq9aOBUyhAUX/ 2iVqoMjWgfssQF0RvsmXry1DV15PTDvjGDNwEVlsX4erogn6G9N1A5PQ0cW+PLGIxNYt H8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=JPFjjckE/7NotZCaBxXh+XGvAYsXoL7QsuUpq3pauJE=; b=oJtpVSV/WC9L/B42qfo7Wsm6NRfKwJOsJBmXZcPt4jTXe8feM+kM2DLmPI3MXVxbCl 7e/gSYfS2xemzP36NDe90/2q404rtwOSNJjV3/ZI7rleqh0XX/ttNnXvJGHw0RYOE5D3 CV4zzfTASQmosFPOaI0n9BE4sqEXtSFcSqEDQuAdHymsYrWzrIlk81Qi7+qJHc2N7psj EUzieOfa1ayMQ6Ivh04FUIcqGSVOJv2pmtDEbTuSdunyxBoCdWSJ4vFkuY9cgjIazAal cn8++hXsy1YMhiMCaX8EiAToZC4Dul1XauN2mSNT0gEPuXzU262BEKtq+JVoN8k22DvQ fqUg== X-Gm-Message-State: APjAAAV5TFyrCbh0bES28Hkt8lCe7hEv9jWGw+tqXUTKC0RZvnsinh+h pnER7Cu91RLSTRarTWjqr7g= X-Google-Smtp-Source: APXvYqzEJnBo82YsEf4saw+8BNC9nRLQWbD7kSdD1FG+0eFc1epU0CHmEWIgl5udIddrpn7BXpZNEA== X-Received: by 2002:a02:3093:: with SMTP id q141mr34888837jaq.128.1562759384311; Wed, 10 Jul 2019 04:49:44 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id s4sm2359649iop.25.2019.07.10.04.49.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jul 2019 04:49:43 -0700 (PDT) From: Noam Postavsky References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> Date: Wed, 10 Jul 2019 07:49:43 -0400 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 10 Jul 2019 13:42:10 +0200") Message-ID: <87y3161548.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Lars Ingebrigtsen writes: > Michael Heerdegen writes: > >> This is `eval-sexp-add-defvars' not checking if defvars are really code. > > So is this the correct solution? > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/pr [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.54 listed in list.dnswl.org] 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Lars Ingebrigtsen writes: > Michael Heerdegen writes: > >> This is `eval-sexp-add-defvars' not checking if defvars are really code. > > So is this the correct solution? > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index cb1b17b447..0e99cb9ac0 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -1179,7 +1179,13 @@ eval-sexp-add-defvars > (let ((var (intern (match-string 1)))) > (and (not (special-variable-p var)) > (save-excursion > - (zerop (car (syntax-ppss (match-beginning 0))))) > + (let ((syntax (syntax-ppss (match-beginning 0)))) > + ;; Top-level. > + (and (zerop (car syntax)) > + ;; Not in a comment. > + (null (nth 4 syntax)) > + ;; Not in a string. > + (null (nth 3 syntax))))) > (push var vars)))) > `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) > > (Those ppss things really should have accessors. :-)) There is already a function for this particular case: syntax-ppss-toplevel-pos. From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 21:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.15627934488443 (code B ref 34233); Wed, 10 Jul 2019 21:18:02 +0000 Received: (at 34233) by debbugs.gnu.org; 10 Jul 2019 21:17:28 +0000 Received: from localhost ([127.0.0.1]:36710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlJxv-0002C7-RW for submit@debbugs.gnu.org; Wed, 10 Jul 2019 17:17:28 -0400 Received: from mout.web.de ([212.227.15.4]:52741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlJxu-0002Bu-9c for 34233@debbugs.gnu.org; Wed, 10 Jul 2019 17:17:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562793426; bh=bLM0SmXnVNM4B0rorsTupm4SYLE5PrVMFQcAWEtONXM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=La3XPJ/6LHpXs7kURsQaF4Eb+7Md+C00jklyGnbBK3IqktBhHHdf9/B96OO66voj9 NGtvPVqRfxjRYqpqOX+aMuVtdW8Q7wtkKcepfyt3WgNK7TchNc4PkM1xc0drEWkwC4 jiF3tf8hy1V2Lgw1k2LbyMCvz696WMC8vG4gLynI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([92.208.178.213]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MQt6E-1hudsy2XjK-00UFfr; Wed, 10 Jul 2019 23:17:06 +0200 From: Michael Heerdegen References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> Date: Wed, 10 Jul 2019 23:17:02 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 10 Jul 2019 13:42:10 +0200") Message-ID: <87y315k2sx.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oDthPwmbnkHTWqOw/LZUPjTm6b8g1hxZsRepNN60qIq962bn6iS mH/J/ikZU5RkMM+RXFZirY1UFKUCUlQeyO51aDbJ/FS70si27FkRu9ydxzxlVgWgQ75wU11 8ywKohdqxI5B6HR+qyIW++sLKddR8N9SN/vABGkmPUOzPRcgnuRodhtcRR+a34MEcPP/sk6 NrJLd1l9dFPFPYLbe2Zqg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2t6NN+uR/0k=:XdYx0xnW6P1QGKuvXvcTvB mkIoLMWgUlsTjXuCuVVUuDYFFqvVFPRsk7y/OSfrJfbjgHj05NwwT3rrnn5bKag8TG3QmjTNv QkiYrvQKUHWxXPwAIMOe7p7e/MNh6Xjq5S8GEq8hYKvXKaA1/tvAo2LhvmJ4Dqt4M07Ho96nH fI7LLM8cOmPEFC9pmP3cwd7lGuIbZjrNraybvta7g3DgrATGZqdE2neYNP6eNycimIMMeHpgA l70LloKH04fvXtr1S5aL2sM0bFQvE4oAE7MM9e0s84ahkEYZ8/3IUrF8gZej9GVlRuogDlV55 MEb0y1qFKH7J9Zvzr5UzROola4Jq+vzbzSfH0aPY8YSh44yaA4GynRspylR9ErnrBZYIYlbfw WOIyRvAKg5Vtue0J5iEshHVr2E+cN6yUTvvHRNxpWj5ffnI717VxrL+Xe/a9OKr3hY2l7184F 4BdxoARXxTEf6QBhqSGZKfYhDyV4EHP8NHfjqcM3RZUfYmrBm1DgpQu2/CFJzbjhZ6+v/ecx4 Oyxl3ZOl92Pr2+0Xksau+CjWPLrZk8VqdPAQnpYhcW493cXp1Qq1/BXLRxW3yi46j5pZvx2Ys ikfWJxOX9RsX+D7GtEHzxo7neUYt3dCbV3SEFz8ABnFxDbNYwiArdbEYW1otSxeBaVGA3x5bW K+oAR/y60UTSSRYdzA5Ip1pY28EheBw07QqhzZAwmFN8Bc9Jl2t9y3TNTiB48bMWO2E62QO0O lKdAs2EqgRgvou15w0o51MylVAqycQiHj7vTj6gR9HgoPfoQ61sT7RbkbkXXCgq65V8kBRT2f EC5RT2wapyR9s/ViekijrrhPOrSS1YluOM+WiCiGlLXV3bLrrxx6vcduGUFn49utG1cldjHLZ VeKbojwb0DOWBL3yjmCTC06nIOQI1Zq2j0kDs2FA861ug4bGNDR6LAbSEiHV7kUrIiI88ZQK0 JcL1R/N9Ftx5E5I3hjIyKbjerhg17oWBav4Z1vN+FMnRTska/T7JxbXvaGpZ50iPzmkl2KMOw r9bRu7sTkLK1Qqr3nXkmqrTInRbdsTM8OEk/tcyj5iROLghbcFV17Qr9fDMsMHtKrxAtuoSNk Qb4vVlaHrjgXIZ6en4mEsvvyYY+XauJEzZR X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > So is this the correct solution? > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index cb1b17b447..0e99cb9ac0 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -1179,7 +1179,13 @@ eval-sexp-add-defvars > (let ((var (intern (match-string 1)))) > (and (not (special-variable-p var)) > (save-excursion > - (zerop (car (syntax-ppss (match-beginning 0))))) > + (let ((syntax (syntax-ppss (match-beginning 0)))) > + ;; Top-level. > + (and (zerop (car syntax)) > + ;; Not in a comment. > + (null (nth 4 syntax)) > + ;; Not in a string. > + (null (nth 3 syntax))))) > (push var vars)))) > `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) Yes, I think so, plus Noam's suggestion. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 11 09:42:27 2019 Received: (at control) by debbugs.gnu.org; 11 Jul 2019 13:42:27 +0000 Received: from localhost ([127.0.0.1]:37168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZL9-00051X-3i for submit@debbugs.gnu.org; Thu, 11 Jul 2019 09:42:27 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZL6-00051O-Jy for control@debbugs.gnu.org; Thu, 11 Jul 2019 09:42:25 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlZL3-00045S-2e for control@debbugs.gnu.org; Thu, 11 Jul 2019 15:42:22 +0200 Date: Thu, 11 Jul 2019 15:42:20 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #34233 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 34233 fixed close 34233 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 34233 fixed close 34233 27.1 quit From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Noam Postavsky Cc: Michael Heerdegen , 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.156285273121241 (code B ref 34233); Thu, 11 Jul 2019 13:46:01 +0000 Received: (at 34233) by debbugs.gnu.org; 11 Jul 2019 13:45:31 +0000 Received: from localhost ([127.0.0.1]:37174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZO6-0005WJ-Kk for submit@debbugs.gnu.org; Thu, 11 Jul 2019 09:45:30 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZO4-0005U5-Lh for 34233@debbugs.gnu.org; Thu, 11 Jul 2019 09:45:29 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlZO0-00046H-BU; Thu, 11 Jul 2019 15:45:26 +0200 From: Lars Ingebrigtsen References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> <87y3161548.fsf@gmail.com> Date: Thu, 11 Jul 2019 15:45:24 +0200 In-Reply-To: <87y3161548.fsf@gmail.com> (Noam Postavsky's message of "Wed, 10 Jul 2019 07:49:43 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: >> + ; ; Top-level. >> + (and (zerop (car syntax)) >> + ;; Not in a comment. >> + (null (nth 4 syntax)) >> + ;; Not in a string. >> + (null (nth 3 syntax))))) >> (push var vars)))) >> `(progn ,@(mapcar [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: >> + ;; Top-level. >> + (and (zerop (car syntax)) >> + ;; Not in a comment. >> + (null (nth 4 syntax)) >> + ;; Not in a string. >> + (null (nth 3 syntax))))) >> (push var vars)))) >> `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) [...] > There is already a function for this particular case: > syntax-ppss-toplevel-pos. Are you referring to just the (car syntax) bit or the nth 4/3 bit (which are the same as nth 8, apparently? (And which I've now committed.) Feel free to touch it up if you want to, but I couldn't convince myself that they were equivalent... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 11 09:45:34 2019 Received: (at control) by debbugs.gnu.org; 11 Jul 2019 13:45:34 +0000 Received: from localhost ([127.0.0.1]:37177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZOA-0005ZG-15 for submit@debbugs.gnu.org; Thu, 11 Jul 2019 09:45:34 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlZO8-0005XH-69 for control@debbugs.gnu.org; Thu, 11 Jul 2019 09:45:32 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlZO5-00046P-Jo for control@debbugs.gnu.org; Thu, 11 Jul 2019 15:45:31 +0200 Date: Thu, 11 Jul 2019 15:45:29 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #34233 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 34233 fixed close 34233 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 34233 fixed close 34233 27.1 quit From unknown Sat Jun 14 03:54:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34233: 27.0.50; defvar in comment Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jul 2019 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Michael Heerdegen , 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.15630685798763 (code B ref 34233); Sun, 14 Jul 2019 01:43:02 +0000 Received: (at 34233) by debbugs.gnu.org; 14 Jul 2019 01:42:59 +0000 Received: from localhost ([127.0.0.1]:43648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmTXW-0002HH-Ls for submit@debbugs.gnu.org; Sat, 13 Jul 2019 21:42:58 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:34568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmTXU-0002H4-Ax for 34233@debbugs.gnu.org; Sat, 13 Jul 2019 21:42:56 -0400 Received: by mail-io1-f50.google.com with SMTP id k8so28465850iot.1 for <34233@debbugs.gnu.org>; Sat, 13 Jul 2019 18:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uyeidaO2toyhP6MLA4rj/0RCHGf3EQdjY04GGMzeYLg=; b=kx6cnzRBD6RgUM7ihs7Eg4jYnIytkjgJCuUYB5wJI3/RFzEbxdMFGIaUdTJO80SHbE wPs8yy2nQBeQzZV7NFTs5pt7oLeh/wodBdwkYdssQRN1e/jn7nrUywH7W4gc5R1eNCrY up8MswXVTUkwnqr9UysM4KkuhbQp+FPt56QklkE7GZZ3tFd5x5WarUkHN/OtzbUVTa2f wVicEhAUPwbDASlDL8hxH3HeVfDPnLtu8hkexEvWEHYRovuAXDzzb7Os8yESdOi88K99 6T2XuMzWyUp1IveRoCoFrj6UTAsNTERkykLhoTq/tInq8KIAXVAZ1+d6kpoe2wZJ6sn8 GTRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uyeidaO2toyhP6MLA4rj/0RCHGf3EQdjY04GGMzeYLg=; b=tLFLBxHnrlc1f3H0YNvn3r3UKhUB6QF9NBxYDp4Zbd3fwCGHegE474zIuIlmUKa/nu G+LzJfWeIV+YNnDNG3OzDvMmBfF8PDYvw/GeYTcniSuOwyPCi+6BI0Q7obNxzMz73XFX bTNsn6zuJHD+et6yqx0NEOGycbGQmMJwMI8hVogwNMOSnZeKb4OdfHIQvOe8eGJeyBkM c8ci7rmUcs7hZFRjvoZnYOuQF2yjjbZIdqBsROPxDC3idX8M9ZsI4RPz7EOcMjNdU8BI 4TfL/WXrgkfh5mQo8l+sEZ1hSufm9PmH0BHlKgGfHT5Lm4rMmZsQMWs7x3zVlocnsg1q VuRQ== X-Gm-Message-State: APjAAAU5bZjlzyi/P9bsqyIgik9LGGkwAniPz1E8i7ZWQRX2CHMN4iud IVxU+tkXiAO6iC38IpI/H2I= X-Google-Smtp-Source: APXvYqw/oqD+9zdrZ3Vc21iPbeLnWHCENp1sF1wqwswuSXC7R9cos7PhTOenUTJaG1l63V+xv3UsGQ== X-Received: by 2002:a02:7f15:: with SMTP id r21mr20767371jac.120.1563068570552; Sat, 13 Jul 2019 18:42:50 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id y5sm13540840ioc.86.2019.07.13.18.42.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Jul 2019 18:42:49 -0700 (PDT) From: Noam Postavsky References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> <87y3161548.fsf@gmail.com> Date: Sat, 13 Jul 2019 21:42:48 -0400 In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 11 Jul 2019 15:45:24 +0200") Message-ID: <87ims51jdz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> There is already a function for this particular case: >> syntax-ppss-toplevel-pos. > > Are you referring to just the (car syntax) bit or the nth 4/3 bit (which > are the same as nth 8, apparently? (And which I've now committed.) > Feel free to touch it up if you want to, but I couldn't convince myself > that they were equivalent... Okay, done. 5d713c89e9 2019-07-13T21:25:10-04:00 "Use syntax-ppss-toplevel-pos for defvar search (Bug#34233)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d713c89e923fbc3192719792090cc40327b13a2