GNU bug report logs - #34225
27.0.50; Add passwd backups to etc-passwd-generic-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34225: closed (27.0.50; Add passwd backups to etc-passwd-generic-mode)
Date: Mon, 28 Jan 2019 20:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 28 Jan 2019 22:19:39 +0200
with message-id <87pnsg357o.fsf <at> mail.linkov.net>
and subject line Re: bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode
has caused the debbugs.gnu.org bug report #34225,
regarding 27.0.50; Add passwd backups to etc-passwd-generic-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34225: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34225
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Add passwd backups to etc-passwd-generic-mode
Date: Sun, 27 Jan 2019 22:34:03 +0200

[Message part 3 (text/plain, inline)]

Tags: patch

I don't know why backups /etc/passwd- use the suffix ‘-’ instead of ‘~’
but comparing these files with their backups I noticed the difference
in their font-lock highlighting, thus this patch:

[generic-x.etc-passwd-generic-mode.patch (text/x-diff, inline)]

diff --git a/lisp/generic-x.el b/lisp/generic-x.el
index 014379fba9..dd61402015 100644
--- a/lisp/generic-x.el
+++ b/lisp/generic-x.el
@@ -1490,7 +1490,7 @@ etc-passwd-generic-mode
      '("^\\([^:]+\\):\\([^:]*\\):\\([0-9]+\\):\\(.*\\)$"
        (1 font-lock-type-face)
        (4 font-lock-variable-name-face))))
-  '("/etc/passwd\\'" "/etc/group\\'")
+  '("/etc/passwd-?\\'" "/etc/group-?\\'" "/etc/shadow-?\\'")
   (list
    (function
     (lambda ()

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 34225-done <at> debbugs.gnu.org
Subject: Re: bug#34225: 27.0.50; Add passwd backups to etc-passwd-generic-mode
Date: Mon, 28 Jan 2019 22:19:39 +0200

>>> I don't know why backups /etc/passwd- use the suffix '-' instead of '~'
>>
>> It does?  I seem to be unable to reproduce this:
>>
>>   (make-backup-file-name "/etc/passwd")
>>     => "/etc/passwd~"
>>
>> What am I missing?
>
> These are non-Emacs backups. See eg "man 5 shadow".
>
>     /etc/shadow-
>     Backup file for /etc/shadow.
>
>     Note that this file is used by the tools of the shadow toolsuite,
>     but not by all user and password management tools.

Yes, and "man 5 passwd" shows the same:

       /etc/passwd-
           Backup file for /etc/passwd.

So I installed the patch to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.