GNU bug report logs - #34222
[PATCH 00/15] Add ruby-rubocop and dependencies.

Previous Next

Full log

Message #91 received at 34222 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 34222 <at> debbugs.gnu.org
Subject: Re: [bug#34222] [PATCH 08/15] gnu: Add ruby-rest-client.
Date: Sun, 27 Jan 2019 18:34:06 +0100

Christopher Baines <mail <at> cbaines.net> writes:

> Required for ruby-ast.
>
> * gnu/packages/ruby.scm (ruby-rest-client): New variable.

[…]

> +       (modify-phases %standard-phases
> +         (add-before 'check 'fix-dependencies
> +           (lambda _
> +             (substitute* "rest-client.gemspec"
> +               ((".*rubocop.*") "\n")
> +               ((".*pry.*") "\n"))
> +             #t))

Could you please add a comment here why this is necessary?

> +    (description
> +     "@code{rest-client} provides a simple HTTP and REST client for Ruby,
> +inspired by the Sinatra microframework style of specifying actions: get, put,
> +post, delete.")

I would wrap “get”, “put”, “post”, and “delete” in @code{…}.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.