GNU bug report logs - #34222
[PATCH 00/15] Add ruby-rubocop and dependencies.

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34222 <at> debbugs.gnu.org
Subject: [bug#34222] [PATCH 08/15] gnu: Add ruby-rest-client.
Date: Sun, 27 Jan 2019 18:51:36 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Required for ruby-ast.
>>
>> * gnu/packages/ruby.scm (ruby-rest-client): New variable.
>
> […]
>
>> +       (modify-phases %standard-phases
>> +         (add-before 'check 'fix-dependencies
>> +           (lambda _
>> +             (substitute* "rest-client.gemspec"
>> +               ((".*rubocop.*") "\n")
>> +               ((".*pry.*") "\n"))
>> +             #t))
>
> Could you please add a comment here why this is necessary?

I've updated the patch to say:

+         (add-before 'check 'remove-unnecessary-development-dependencies
+           (lambda _
+             (substitute* "rest-client.gemspec"
+               ;; Remove rubocop as it's unused. Rubocop also indirectly
+               ;; depends on this package through ruby-parser and ruby-ast so
+               ;; this avoids a dependency loop.
+               ((".*rubocop.*") "\n")
+               ;; Remove pry as it's unused, it's a debugging tool
+               ((".*pry.*") "\n"))

Hopefully that is a bit clearer.

>> +    (description
>> +     "@code{rest-client} provides a simple HTTP and REST client for Ruby,
>> +inspired by the Sinatra microframework style of specifying actions: get, put,
>> +post, delete.")
>
> I would wrap “get”, “put”, “post”, and “delete” in @code{…}.

Ok, I've updated the patch to do this now.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.