GNU bug report logs - #34217
[PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates.

Previous Next

Full log

Message #94 received at 34217 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 34217 <at> debbugs.gnu.org
Subject: Re: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba.
Date: Fri, 08 Feb 2019 17:19:45 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> writes:
>
>>> +    (propagated-inputs
>>> +     (map (lambda (input)
>>> +            (if (string=? (car input) "ruby-cucumber")
>>> +                `("ruby-cucumber" ,ruby-cucumber-without-tests)
>>> +                input))
>>> +          (package-propagated-inputs ruby-aruba)))
>>
>> This is really nit-picking, I haven't tried it out myself and I haven't
>> used it much myself, but I think this could be written more elegant with
>> match-lambda [syntax errors might be included]:
>>
>>  (map (match-lambda
>>        (("ruby-cucumber" . pkg)
>>           `("ruby-cucumber" ,ruby-cucumber-without-tests))
>> 	(input input)
>> ...)
>
> Or like this
>
>     `(("ruby-cucumber" ,ruby-cucumber-without-tests)
>       ,@(alist-delete "ruby-cucumber"
>                       (package-propagated-inputs ruby-aruba)))

Yep, that looks good to me, thanks :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.