GNU bug report logs - #34217
[PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates.

Previous Next

Full log

View this message in rfc822 format

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 34217 <at> debbugs.gnu.org
Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba.
Date: Sun, 3 Feb 2019 23:18:22 +0100

On Sun, 27 Jan 2019 11:49:56 +0000
Christopher Baines <mail <at> cbaines.net> wrote:

> These packages are mutually dependant, so I've put them in one commit.
> 
> * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables.

You missed to add the "...-without-tests" variables here.

[...]

> +(define-public ruby-aruba
> +  (package
> +    (name "ruby-aruba")
> +    (version "0.14.7")

There is another update since yesterday:
0.14.8 - February 02, 2019 (169 KB) 

[..]

> +;; A version of ruby-aruba without tests run so that circular
> dependencies can +;; be avoided.
> +(define ruby-aruba-without-tests
> +  (package
> +    (inherit ruby-aruba)
> +    (arguments '(#:tests? #f))
> +    (propagated-inputs
> +     (map (lambda (input)
> +            (if (string=? (car input) "ruby-cucumber")
> +                `("ruby-cucumber" ,ruby-cucumber-without-tests)
> +                input))
> +          (package-propagated-inputs ruby-aruba)))

This is really nit-picking, I haven't tried it out myself and I haven't
used it much myself, but I think this could be written more elegant with
match-lambda [syntax errors might be included]:

 (map (match-lambda
       (("ruby-cucumber" . pkg)
          `("ruby-cucumber" ,ruby-cucumber-without-tests))
	(input input)
...)



Björn

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.