GNU bug report logs - #34217
[PATCH 00/11] Add ruby-cucumber along with dependencies and a couple of updates.

Previous Next

Full log

View this message in rfc822 format

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 34217 <at> debbugs.gnu.org
Subject: [bug#34217] [PATCH 03/11] gnu: Add ruby-ruby-progressbar.
Date: Sun, 3 Feb 2019 22:40:22 +0100

On Sun, 27 Jan 2019 11:49:48 +0000
Christopher Baines <mail <at> cbaines.net> wrote:

> * gnu/packages/ruby.scm (ruby-ruby-progressbar): New variable.
> ---
>  gnu/packages/ruby.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 808b2d8686..15382de017 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -2507,6 +2507,28 @@ rate.")
>      (home-page "https://github.com/paul/progress_bar")
>      (license license:wtfpl2)))
>  
> +(define-public ruby-ruby-progressbar
> +  (package
> +    (name "ruby-ruby-progressbar")

Although we do not have a specific section about Ruby packages, I would
stick to the rules for Python packages:

https://www.gnu.org/software/guix/manual/en/guix.html#Python-Modules

"If a project already contains the word python, we drop this; for
instance, the module python-dateutil is packaged under the names python-dateutil"

Thus, rename the package to just "ruby-progressbar".

Otherwise, LGTM.

Thanks,

Björn

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.