Subject: Re: [bug#34204] [PATCH 1/3] gnu: python-tornado: Update to 5.1.1.

From: Ricardo Wurmus <[email-masked]>
Date: Sat, 26 Jan 2019 14:34:14 +0100

Hi Mathieu,

> * gnu/packages/python-web.scm (python-tornado): Update to 5.1.1.

Thanks for the patch!

>  (define-public python-tornado
>    (package
>      (name "python-tornado")
> -    (version "4.5.1")
> +    (version "5.1.1")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "tornado" version))
>         (sha256
> -        (base32 "1zbkgcdfq81k298awrm8p0xwbwwn2p3nbizdglzfbkskhai082fv"))))
> +        (base32 "02clqk2116jbnq8lnaqmdw3p52nqrd9ib59r4xz2ll43fpcmhlaf"))))
>      (build-system python-build-system)
>      (arguments
>       '(;; FIXME: Two tests error out with:

The arguments field says:

    (arguments
     '(;; FIXME: Two tests error out with:
       ;; AssertionError: b'Error in atexit._run_exitfuncs:\nFileNotF[44 chars]ry\n' != b''
       ;; #:phases
       ;; (modify-phases %standard-phases
       ;;   (replace 'check
       ;;     (lambda _
       ;;       ;; 'setup.py test' hits an AssertionError on BSD-specific
       ;;       ;; "tornado/platform/kqueue.py". This is the supported method:
       ;;       (invoke- "python" "-m" "tornado.test")
       ;;       #t)))
       #:tests? #f))

Is this still the case or can we enable the tests?

A number of important packages depend on python-tornado, such as
python-matplotlib, jupyter, and python-scikit-image.  Since this is a
major version bump I wonder if you have tried building some of these
related packages to make sure they don’t fail.

(We can of course respond to breakage once we discover it when building
the new evaluations, but it would be nicer if we could have some
reassurance.)

-- 
Ricardo