From unknown Sun Jun 22 17:16:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34201: Make @setfilename optional in Texinfo files Resent-From: Gavin Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 25 Jan 2019 21:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34201 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 34201@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15484512801512 (code B ref -1); Fri, 25 Jan 2019 21:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jan 2019 21:21:20 +0000 Received: from localhost ([127.0.0.1]:45631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gn8uV-0000O8-4W for submit@debbugs.gnu.org; Fri, 25 Jan 2019 16:21:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gn8uL-0000N3-39 for submit@debbugs.gnu.org; Fri, 25 Jan 2019 16:21:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:56543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn8uF-0008Cq-JE for submit@debbugs.gnu.org; Fri, 25 Jan 2019 16:20:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn8uE-0005Ow-Al for bug-automake@gnu.org; Fri, 25 Jan 2019 16:20:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_20, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn8uC-00089i-LH for bug-automake@gnu.org; Fri, 25 Jan 2019 16:20:53 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:50721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gn8uC-00086c-7O for bug-automake@gnu.org; Fri, 25 Jan 2019 16:20:52 -0500 Received: by mail-wm1-x332.google.com with SMTP id n190so8116667wmd.0 for ; Fri, 25 Jan 2019 13:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:mime-version:content-disposition :user-agent; bh=q+sgwzzh3qxO8dUNZg8emI4BSTvKBUL89nQT6UKLcsc=; b=c1U+TIgbw/3SFGqBrF/YbiloozhFQHYEqPmS/FXsJiO1XGNIzJdZ8mMJEA4h6bqX9o 3d4aOf/ClJlI3CeMKrCaZT37nRRW+Ffmo5c5K4cnRQxxtijUfIYU/FuxsAJ6yoWPbGFl F2XHeTIa+44yOGkri2B5DsVzu0ico2WpWgn6kpFcebxbYnAtVISchDMuauhL5jD8gBYk 0pj+L/qW9Nh5RdAdDM9mV7c1hpBi2E9J8b0xIT4M4RiD0d5iAdsvv3EMPOjG/3RUXFaf 96F/8Xhn5mSYdKOhkXOGYaIAIP25jO8D9/dAkWq6kY6jsNpwPC5jrvebH7DaGatRMX3w X/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-disposition:user-agent; bh=q+sgwzzh3qxO8dUNZg8emI4BSTvKBUL89nQT6UKLcsc=; b=pHcOnjCK+5zv5XCbN123PUD2aqWIZGtnxwzbyAb+3G/vo9yLorCywC2R6BBoyEv0F5 8ca3yTi6FZ1zZc/qZxff6+z9hbUoOioV0AXU2w5W6vldif2Mj6j1bfx0vUR1E705pod6 YPBwx96uldL78EnmbxOAl+ib/t6mgP7NFSsbMgxHqgEqLw/d9VLsEtgAz+eUzWZI7Bob Ri5UIwoDIvZ4wIWKQofdxS8QMZRUeq2lWR21sNDKFK28xCWi9BKNTcuGmnnISc3/pq0C HUL8Pgfds/Na1CIdPdxDStd6fTLLPUKyJRHq6YbS85Pyclj8AGfXqJAeFPtZ4gXEH+Kf cdGg== X-Gm-Message-State: AHQUAuaOn6hayHJRjulViNG55K8gSL70uCYw7MNmBJBxU2R6/SwrVszQ Eos+zMgMlr2N9vsYLFp6TXCOT+ic X-Google-Smtp-Source: AHgI3IZjoeWAxoefa8aqkWgT6lmC32dQjTUjfBwfHPBUam6+sg84EyDoA7yZ2kWV5QQzBMKOzuA7bQ== X-Received: by 2002:a1c:1b8d:: with SMTP id b135mr8285244wmb.115.1548451249084; Fri, 25 Jan 2019 13:20:49 -0800 (PST) Received: from darkstar.example.net (55.37.198.146.dyn.plus.net. [146.198.37.55]) by smtp.gmail.com with ESMTPSA id x81sm66072547wmg.17.2019.01.25.13.20.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 13:20:48 -0800 (PST) From: Gavin Smith X-Google-Original-From: Gavin Smith Received: from darkstar.example.net (localhost [127.0.0.1]) by darkstar.example.net (8.14.9/8.14.9) with ESMTP id x0PLMYQP023343 for ; Fri, 25 Jan 2019 21:22:39 GMT Received: (from g@localhost) by darkstar.example.net (8.14.9/8.14.9/Submit) id x0PLMYKL023339 for bug-automake@gnu.org; Fri, 25 Jan 2019 21:22:34 GMT Date: Fri, 25 Jan 2019 21:22:33 +0000 Message-ID: <20190125212233.GA19274@darkstar.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::332 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: @setfilename should not be required to occur inside Texinfo files, as it makes it harder to get them working. Earlier on this: https://lists.gnu.org/archive/html/automake/2015-09/msg00000.html Here is a patch. I added a test which is passing now, but it wasn't passing when I first added the test, so am not sure if it is written correctly. I based it on the existing test t/txinfo-setfilename [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (gavinsmith0123[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gavinsmith0123[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) @setfilename should not be required to occur inside Texinfo files, as it makes it harder to get them working. Earlier on this: https://lists.gnu.org/archive/html/automake/2015-09/msg00000.html Here is a patch. I added a test which is passing now, but it wasn't passing when I first added the test, so am not sure if it is written correctly. I based it on the existing test t/txinfo-setfilename-repeated.sh. It says GPL version 2 in the licence because that's what was in the existing tests, although they should probably all be version 3. ChangeLog entry: Do not require @setfilename in Texinfo files. * bin/automake.in (scan_texinfo_file): Derive name of info file from name of input file if no @setfilename line occurs in the file. * t/texinfo-no-setfilename.sh: New test. diff --git a/bin/automake.in b/bin/automake.in index b4ae8f4..01e6a58 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -3083,8 +3083,10 @@ sub scan_texinfo_file if (! $outfile) { - err_am "'$filename' missing \@setfilename"; - return; + # Replace a .texi extension with .info + $outfile = basename($filename); + $outfile =~ s/\.[^.]+$//; + $outfile .= '.info'; } return ($outfile, $vfile); diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 84dd29a..32fca84 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -1214,6 +1214,7 @@ t/txinfo-no-clutter.sh \ t/txinfo-no-extra-dist.sh \ t/txinfo-no-installinfo.sh \ t/txinfo-no-repeated-targets.sh \ +t/txinfo-no-setfilename.sh \ t/txinfo-other-suffixes.sh \ t/txinfo-override-infodeps.sh \ t/txinfo-override-texinfo-tex.sh \ diff --git a/t/txinfo-no-setfilename.sh b/t/txinfo-no-setfilename.sh new file mode 100644 index 0000000..3ef1730 --- /dev/null +++ b/t/txinfo-no-setfilename.sh @@ -0,0 +1,35 @@ +#! /bin/sh +# Copyright (C) 2019 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check Texinfo files work without a @setfilename line + +. test-init.sh + +cat > Makefile.am << 'END' +info_TEXINFOS = file.texi +END + +cat > file.texi << 'END' +contents +END + +$ACLOCAL +$AUTOMAKE --add-missing + + +grep 'file.info:' Makefile.in + +: From unknown Sun Jun 22 17:16:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34201: Make @setfilename optional in Texinfo files Resent-From: Gavin Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 31 Mar 2019 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34201 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 34201@debbugs.gnu.org Cc: Automake Mailing List Received: via spool by 34201-submit@debbugs.gnu.org id=B34201.155403924624385 (code B ref 34201); Sun, 31 Mar 2019 13:35:02 +0000 Received: (at 34201) by debbugs.gnu.org; 31 Mar 2019 13:34:06 +0000 Received: from localhost ([127.0.0.1]:37847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAaay-0006Kp-P9 for submit@debbugs.gnu.org; Sun, 31 Mar 2019 09:34:06 -0400 Received: from mail-it1-f171.google.com ([209.85.166.171]:36769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAaan-0006KO-4x for 34201@debbugs.gnu.org; Sun, 31 Mar 2019 09:33:55 -0400 Received: by mail-it1-f171.google.com with SMTP id y10so9005805itc.1 for <34201@debbugs.gnu.org>; Sun, 31 Mar 2019 06:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WjZVTFpF4IpJ/qNfiF+vHpfLJuUIzNMR4bdNA7Xv7Cc=; b=b3yQ0FJok13gOQVwrzEY4cZSv9X3kqzoAzUZMMGp8fTymMSFKMjCawQ/6t6Wci0PZq aH34eEw7CkhKoTLpgeJGWLLkSVy8luiFxJH1r1r5WJ3k1SkMq7UWUyZVV+2ACqNNEN5a kELLBbyJR7WDTTk0I5HOAFkqpeyJgoRd8E7BsXntBbKkASWIFUXXHxr5a8UUmOUUQuyZ fBo5UwTVOQWll88GoI3Sr7lF+iNAUUzlRQ9xlYI8X+AviiOfHIZ7n31kp0KXCNSu9EUh KxiHW8SoX8rK50Jkuy4wfCHG9b5QI1kWSliSJ+trEotw4SKpfFZM8eJ2Gs1VhVkVu2dM U/Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WjZVTFpF4IpJ/qNfiF+vHpfLJuUIzNMR4bdNA7Xv7Cc=; b=oBF+IxHZecommuV/KhmdlbDaf6AQ1PBaG5mRZ1+ZiZBQ8t4eY5McYxo0AqjYAQv0Fw HzNx6nhRpYMN+V01noYWT8M3cxSl1+XTih7KfNNeFZh62Iu/JwsMCYCxjpW6ZyFJrGzk ItdId0AFXDHsJssgRdes5RpsiAAnaGS2bJcSjk3tYBJ1OB+AOFqfaX3cpx5dM9pGbgsR 2gsKErtHyAbp6C5fPhthZRZ+b3jmH/xvZZvSBtmIJcMUiqQx0MXZv6aw03v1+qaK/ZfF wtDJtnTZqwfQvP/5uDWsbOcwYDL2wx3Ino8PBttMzKzs8EO/o5zpg+vfsEedUu44Tiu0 razg== X-Gm-Message-State: APjAAAXVvgTq5ke4dG6R4S9EwbISzwDXEiwBN24fqQ8Z0fxOjFSB7Hhn c3VRmvjBtZbylJXGlB3yIk+FNssaG2JvWpgyI+iedw== X-Google-Smtp-Source: APXvYqyf05oY9N8zOGuSMZMRzAstgbufSfu7cXfiIf+T/KTv1vMkepFTgORv/5b+osxLK2XoOv7X2tGUGgZuX/8WGC0= X-Received: by 2002:a24:3c4c:: with SMTP id m73mr12538658ita.23.1554039219421; Sun, 31 Mar 2019 06:33:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8604:0:0:0:0:0 with HTTP; Sun, 31 Mar 2019 06:33:38 -0700 (PDT) In-Reply-To: <20190125212233.GA19274@darkstar.lan> References: <20190125212233.GA19274@darkstar.lan> From: Gavin Smith Date: Sun, 31 Mar 2019 14:33:38 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Is there anybody who has time to look at this issue? The requirement for a @setfilename line is an unnecessary hurdle to getting Texinfo and Automake working together. It has been unnecessary for several years now. I have a copyright assignment in place for Automake with the FSF, so all that would be needed would be for someone to have a look at this patch and apply it for the next Automake release. On 1/25/19, Gavin Smith wrote: > @setfilename should not be required to occur inside Texinfo files, as it > makes it harder to get them working. > > Earlier on this: > https://lists.gnu.org/archive/html/automake/2015-09/msg00000.html > > Here is a patch. I added a test which is passing now, but it wasn't > passing when I first added the test, so am not sure if it is written > correctly. I based it on the existing test > t/txinfo-setfilename-repeated.sh. > > It says GPL version 2 in the licence because that's what was in the > existing tests, although they should probably all be version 3. > > ChangeLog entry: > > Do not require @setfilename in Texinfo files. > > * bin/automake.in (scan_texinfo_file): Derive name of info file from > name of input file if no @setfilename line occurs in the file. > * t/texinfo-no-setfilename.sh: New test. > > diff --git a/bin/automake.in b/bin/automake.in > index b4ae8f4..01e6a58 100644 > --- a/bin/automake.in > +++ b/bin/automake.in > @@ -3083,8 +3083,10 @@ sub scan_texinfo_file > > if (! $outfile) > { > - err_am "'$filename' missing \@setfilename"; > - return; > + # Replace a .texi extension with .info > + $outfile = basename($filename); > + $outfile =~ s/\.[^.]+$//; > + $outfile .= '.info'; > } > > return ($outfile, $vfile); > diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk > index 84dd29a..32fca84 100644 > --- a/t/list-of-tests.mk > +++ b/t/list-of-tests.mk > @@ -1214,6 +1214,7 @@ t/txinfo-no-clutter.sh \ > t/txinfo-no-extra-dist.sh \ > t/txinfo-no-installinfo.sh \ > t/txinfo-no-repeated-targets.sh \ > +t/txinfo-no-setfilename.sh \ > t/txinfo-other-suffixes.sh \ > t/txinfo-override-infodeps.sh \ > t/txinfo-override-texinfo-tex.sh \ > diff --git a/t/txinfo-no-setfilename.sh b/t/txinfo-no-setfilename.sh > new file mode 100644 > index 0000000..3ef1730 > --- /dev/null > +++ b/t/txinfo-no-setfilename.sh > @@ -0,0 +1,35 @@ > +#! /bin/sh > +# Copyright (C) 2019 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2, or (at your option) > +# any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Check Texinfo files work without a @setfilename line > + > +. test-init.sh > + > +cat > Makefile.am << 'END' > +info_TEXINFOS = file.texi > +END > + > +cat > file.texi << 'END' > +contents > +END > + > +$ACLOCAL > +$AUTOMAKE --add-missing > + > + > +grep 'file.info:' Makefile.in > + > +: > > > > From unknown Sun Jun 22 17:16:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34201: [PATCH] automake: do not require @setfilename in Texinfo files References: <20190125212233.GA19274@darkstar.lan> In-Reply-To: <20190125212233.GA19274@darkstar.lan> Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 02 Sep 2019 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34201 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: automake-patches@gnu.org, Gavin Smith , Karl Berry , 36921@debbugs.gnu.org, 34201@debbugs.gnu.org Received: via spool by 34201-submit@debbugs.gnu.org id=B34201.156744526713689 (code B ref 34201); Mon, 02 Sep 2019 17:28:02 +0000 Received: (at 34201) by debbugs.gnu.org; 2 Sep 2019 17:27:47 +0000 Received: from localhost ([127.0.0.1]:58918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4q7H-0003Yd-FW for submit@debbugs.gnu.org; Mon, 02 Sep 2019 13:27:47 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4q7G-0003YI-3y; Mon, 02 Sep 2019 13:27:46 -0400 Received: by mail-wr1-f67.google.com with SMTP id s18so14802690wrn.1; Mon, 02 Sep 2019 10:27:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9W6jnCMnYAVRVDhOJJrhR/GcADCsN5wvZ6MySnMikIo=; b=r4lFDNpdO3l6nFVIWsgaZfuU/UOhdImywgLx4xyfu5JF0b8n1HJnNA6PCBdVN1CzBm DI56P9cMgafh6zNEwFWf69UvrpdfWzqkZu3szyXbLJMH3eIPA1wbVWFM+W1xFLJWsU8q CkizWyQMYMy24g21RMjX585Ht10pojzOPQNE9ihsGP4AsZ9T4P57NXmZLT6NmXHZU19C cCeuyDO2C5z1ZayoCaHWS4XRJzoAUGVE7OcZLRfCLAqrawE6KlRdBHW2uTm7lw0gnNh+ FJ/5/zR7+N65ZRmVPoyDgg0iuqVShig1uREfwBSmGpsVAYr0wUthyY9/T8FkESVr9TAq oDpQ== X-Gm-Message-State: APjAAAWZglvMrhqaX8aR/j9nKaU6y96/JxBP2sXGuZRP2o+MUaF5FibR D6gkrujzXnldZTWAKhl8OUc+SP3sz9oBVwePfME= X-Google-Smtp-Source: APXvYqzCROhEjEzGXEjfA8cG/VRmk9GuvpmCqVdb39eJse3eyxmmyiNSIczAkXPmkWbRWuT2ROx/KOzv/eLuv7/NVOY= X-Received: by 2002:a05:6000:108e:: with SMTP id y14mr8802018wrw.344.1567445260386; Mon, 02 Sep 2019 10:27:40 -0700 (PDT) MIME-Version: 1.0 From: Jim Meyering Date: Mon, 2 Sep 2019 10:27:28 -0700 Message-ID: Content-Type: multipart/mixed; boundary="000000000000f3ed240591954910" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000f3ed240591954910 Content-Type: text/plain; charset="UTF-8" Gavin Smith proposed a patch for this back in http://bugs.gnu.org/34201 Another reference to the problem: http://bugs.gnu.org/36921 In the attached (in Gavin's name), I've added a NEWS entry and adjusted the ChangeLog entry. Will push in a day or so if no comment. --000000000000f3ed240591954910 Content-Type: application/octet-stream; name="automake-relax-setfilename.diff" Content-Disposition: attachment; filename="automake-relax-setfilename.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k02odsc50 RnJvbSAzMDlhNmM0NzdlZWM4MGI4NDcwNzg2OTkzMDNjNjVjY2Q3Nzg3ZWIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYXZpbiBTbWl0aCA8Z2F2aW5zbWl0aDAxMjNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI1IEF1ZyAyMDE5IDIxOjA3OjU4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g YXV0b21ha2U6IGRvIG5vdCByZXF1aXJlIEBzZXRmaWxlbmFtZSBpbiBUZXhpbmZvIGZpbGVzCgpU ZXhpbmZvIG5vIGxvbmdlciByZXF1aXJlcyBhIEBzZXRmaWxlbmFtZSBkaXJlY3RpdmUgaW4gZWFj aAoudGV4aSBmaWxlLCBzbyBhdXRvbWFrZSBub3cgYWxzbyByZWxheGVzIGl0cyByZXN0cmljdGlv bi4KKiBiaW4vYXV0b21ha2UuaW4gKHNjYW5fdGV4aW5mb19maWxlKTogRGVyaXZlIG5hbWUgb2Yg aW5mbyBmaWxlIGZyb20KbmFtZSBvZiBpbnB1dCBmaWxlIGlmIG5vIEBzZXRmaWxlbmFtZSBsaW5l IG9jY3VycyBpbiB0aGUgZmlsZS4KKiB0L3R4aW5mby1uby1zZXRmaWxlbmFtZS5zaDogTmV3IHRl c3QuCiogdC9saXN0LW9mLXRlc3RzLm1rOiBBZGQgaXQuCiogTkVXUzogTWVudGlvbiBpdC4KCkZp eGVzIGF1dG9tYWtlIGJ1Z3MgIzM2OTIxIGFuZCAjMzQyMDEuCi0tLQogTkVXUyAgICAgICAgICAg ICAgICAgICAgICAgfCAgNCArKysrCiBiaW4vYXV0b21ha2UuaW4gICAgICAgICAgICB8ICA4ICsr KysrLS0tCiB0L2xpc3Qtb2YtdGVzdHMubWsgICAgICAgICB8ICAxICsKIHQvdHhpbmZvLW5vLXNl dGZpbGVuYW1lLnNoIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDQg ZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBt b2RlIDEwMDY0NCB0L3R4aW5mby1uby1zZXRmaWxlbmFtZS5zaAoKZGlmZiAtLWdpdCBhL05FV1Mg Yi9ORVdTCmluZGV4IDhkNmViM2FhZS4uOGJiNTcxMzNmIDEwMDY0NAotLS0gYS9ORVdTCisrKyBi L05FV1MKQEAgLTY0LDYgKzY0LDEwIEBACgogTmV3IGluID8uPy4/OgoKKyogTWlzY2VsbGFuZW91 cyBjaGFuZ2VzCisKKyAgLSBhdXRvbWFrZSBubyBsb25nZXIgcmVxdWlyZXMgYSBAc2V0ZmlsZW5h bWUgaW4gZWFjaCAudGV4aSBmaWxlCisKICogQnVncyBmaXhlZAoKICAgLSBXaGVuIGNsZWFuaW5n IHRoZSBjb21waWxlZCBweXRob24gZmlsZXMsICdcbicgaXMgbm90IHVzZWQgYW55bW9yZSBpbiB0 aGUKZGlmZiAtLWdpdCBhL2Jpbi9hdXRvbWFrZS5pbiBiL2Jpbi9hdXRvbWFrZS5pbgppbmRleCBi NGFlOGY0M2YuLjA2ZjRlZTliMiAxMDA2NDQKLS0tIGEvYmluL2F1dG9tYWtlLmluCisrKyBiL2Jp bi9hdXRvbWFrZS5pbgpAQCAtMSw3ICsxLDcgQEAKICMhQFBFUkxAIC13CiAjIGF1dG9tYWtlIC0g Y3JlYXRlIE1ha2VmaWxlLmluIGZyb20gTWFrZWZpbGUuYW0gICAgICAgICAgICAtKi0gcGVybCAt Ki0KICMgQGNvbmZpZ3VyZV9pbnB1dEAKLSMgQ29weXJpZ2h0IChDKSAxOTk0LTIwMTggRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjIENvcHlyaWdodCAoQykgMTk5NC0yMDE5IEZyZWUg U29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgoKICMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKICMgaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkK QEAgLTMwODMsOCArMzA4MywxMCBAQCBzdWIgc2Nhbl90ZXhpbmZvX2ZpbGUKCiAgIGlmICghICRv dXRmaWxlKQogICAgIHsKLSAgICAgIGVycl9hbSAiJyRmaWxlbmFtZScgbWlzc2luZyBcQHNldGZp bGVuYW1lIjsKLSAgICAgIHJldHVybjsKKyAgICAgICMgUmVwbGFjZSBhIC50ZXhpIGV4dGVuc2lv biB3aXRoIC5pbmZvCisgICAgICAkb3V0ZmlsZSA9IGJhc2VuYW1lKCRmaWxlbmFtZSk7CisgICAg ICAkb3V0ZmlsZSA9fiBzL1wuW14uXSskLy87CisgICAgICAkb3V0ZmlsZSAuPSAnLmluZm8nOwog ICAgIH0KCiAgIHJldHVybiAoJG91dGZpbGUsICR2ZmlsZSk7CmRpZmYgLS1naXQgYS90L2xpc3Qt b2YtdGVzdHMubWsgYi90L2xpc3Qtb2YtdGVzdHMubWsKaW5kZXggODRkZDI5YWYwLi4zMmZjYTg0 MzYgMTAwNjQ0Ci0tLSBhL3QvbGlzdC1vZi10ZXN0cy5taworKysgYi90L2xpc3Qtb2YtdGVzdHMu bWsKQEAgLTEyMTQsNiArMTIxNCw3IEBAIHQvdHhpbmZvLW5vLWNsdXR0ZXIuc2ggXAogdC90eGlu Zm8tbm8tZXh0cmEtZGlzdC5zaCBcCiB0L3R4aW5mby1uby1pbnN0YWxsaW5mby5zaCBcCiB0L3R4 aW5mby1uby1yZXBlYXRlZC10YXJnZXRzLnNoIFwKK3QvdHhpbmZvLW5vLXNldGZpbGVuYW1lLnNo IFwKIHQvdHhpbmZvLW90aGVyLXN1ZmZpeGVzLnNoIFwKIHQvdHhpbmZvLW92ZXJyaWRlLWluZm9k ZXBzLnNoIFwKIHQvdHhpbmZvLW92ZXJyaWRlLXRleGluZm8tdGV4LnNoIFwKZGlmZiAtLWdpdCBh L3QvdHhpbmZvLW5vLXNldGZpbGVuYW1lLnNoIGIvdC90eGluZm8tbm8tc2V0ZmlsZW5hbWUuc2gK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwLi4zZWYxNzMwZGUKLS0tIC9kZXYv bnVsbAorKysgYi90L3R4aW5mby1uby1zZXRmaWxlbmFtZS5zaApAQCAtMCwwICsxLDM1IEBACisj ISAvYmluL3NoCisjIENvcHlyaWdodCAoQykgMjAxOSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24s IEluYy4KKyMKKyMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0 cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdh cmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiwgb3IgKGF0IHlvdXIgb3B0aW9uKQorIyBh bnkgbGF0ZXIgdmVyc2lvbi4KKyMKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRo ZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5U WTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElU WSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyMKKyMgWW91IHNob3VsZCBo YXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMg YWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cuZ251Lm9y Zy9saWNlbnNlcy8+LgorCisjIENoZWNrIFRleGluZm8gZmlsZXMgd29yayB3aXRob3V0IGEgQHNl dGZpbGVuYW1lIGxpbmUKKworLiB0ZXN0LWluaXQuc2gKKworY2F0ID4gTWFrZWZpbGUuYW0gPDwg J0VORCcKK2luZm9fVEVYSU5GT1MgPSBmaWxlLnRleGkKK0VORAorCitjYXQgPiBmaWxlLnRleGkg PDwgJ0VORCcKK2NvbnRlbnRzCitFTkQKKworJEFDTE9DQUwKKyRBVVRPTUFLRSAtLWFkZC1taXNz aW5nCisKKworZ3JlcCAnZmlsZS5pbmZvOicgTWFrZWZpbGUuaW4KKworOgotLSAKMi4yMS4wLjEz NS5nNmUwY2M2Nzc2MQoK --000000000000f3ed240591954910-- From unknown Sun Jun 22 17:16:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34201: [PATCH] automake: do not require @setfilename in Texinfo files Resent-From: Mathieu Lirzin Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Tue, 03 Sep 2019 07:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34201 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Jim Meyering Cc: 34201@debbugs.gnu.org, Gavin Smith , 36921@debbugs.gnu.org, automake-patches@gnu.org, Karl Berry Received: via spool by 34201-submit@debbugs.gnu.org id=B34201.1567497242918 (code B ref 34201); Tue, 03 Sep 2019 07:55:02 +0000 Received: (at 34201) by debbugs.gnu.org; 3 Sep 2019 07:54:02 +0000 Received: from localhost ([127.0.0.1]:59262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i53dZ-0000EY-F8 for submit@debbugs.gnu.org; Tue, 03 Sep 2019 03:54:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i53dX-0000E6-48; Tue, 03 Sep 2019 03:53:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i53dR-00025H-MT; Tue, 03 Sep 2019 03:53:53 -0400 Received: from lputeaux-658-1-176-181.w92-154.abo.wanadoo.fr ([92.154.111.181]:37908 helo=herbrand) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i53dR-0005Nk-6r; Tue, 03 Sep 2019 03:53:53 -0400 From: Mathieu Lirzin References: Date: Tue, 03 Sep 2019 09:53:34 +0200 In-Reply-To: (Jim Meyering's message of "Mon, 2 Sep 2019 10:27:28 -0700") Message-ID: <87lfv54xz5.fsf@nereide.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Jim, Jim Meyering writes: > Gavin Smith proposed a patch for this back in http://bugs.gnu.org/34201 > Another reference to the problem: http://bugs.gnu.org/36921 > > In the attached (in Gavin's name), I've added a NEWS entry and > adjusted the ChangeLog entry. Will push in a day or so if no comment. Thanks for taking care of this. :-) > From 309a6c477eec80b847078699303c65ccd7787eb0 Mon Sep 17 00:00:00 2001 > From: Gavin Smith > Date: Sun, 25 Aug 2019 21:07:58 -0700 > Subject: [PATCH] automake: do not require @setfilename in Texinfo files > > Texinfo no longer requires a @setfilename directive in each > .texi file, so automake now also relaxes its restriction. > * bin/automake.in (scan_texinfo_file): Derive name of info file from > name of input file if no @setfilename line occurs in the file. > * t/txinfo-no-setfilename.sh: New test. > * t/list-of-tests.mk: Add it. > * NEWS: Mention it. > > Fixes automake bugs #36921 and #34201. > --- Not really important but HACKING recommends a slightly different style. --8<---------------cut here---------------start------------->8--- topic: brief description (this is the "summary line") Here goes a more detailed explanation of why the commit is needed, and a general overview of what it does, and how. This section should almost always be provided, possibly only with the expection of obvious fixes or very trivial changes. And if the detailed explanation is quite long or detailed, you can want to break it in more paragraphs. Then you can add references to relevant mailing list discussions (if any), with proper links. But don't take this as an excuse for writing incomplete commit messages! The "distilled" conclusions reached in such discussions should have been placed in the paragraphs above. Finally, here you can thank people that motivated or helped the change. So, thanks to John Doe for bringing up the issue, and to J. Random Hacker for providing suggestions and testing the patch. --8<---------------cut here---------------end--------------->8--- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 From unknown Sun Jun 22 17:16:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34201: [PATCH] automake: do not require @setfilename in Texinfo files Resent-From: Gavin Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 14 Sep 2019 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34201 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Jim Meyering Cc: 34201@debbugs.gnu.org, 36921@debbugs.gnu.org, automake-patches@gnu.org, Karl Berry Received: via spool by 34201-submit@debbugs.gnu.org id=B34201.156846451114973 (code B ref 34201); Sat, 14 Sep 2019 12:36:02 +0000 Received: (at 34201) by debbugs.gnu.org; 14 Sep 2019 12:35:11 +0000 Received: from localhost ([127.0.0.1]:45994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i97Gf-0003tJ-Q7 for submit@debbugs.gnu.org; Sat, 14 Sep 2019 08:35:10 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:36944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i97Ge-0003t1-2I; Sat, 14 Sep 2019 08:35:08 -0400 Received: by mail-io1-f66.google.com with SMTP id b19so8612516iob.4; Sat, 14 Sep 2019 05:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=14hInx47uLZa4wkIxoKEgr9Qc5WWNQsi7l9pL1yu/Os=; b=OtkZhUReQZg0tfiK3HSiMFG08uKIKato26IXlr9rSBEb9DujXCMNmcUZerlXb3/KA4 8A2JSs/KA3bPSCaRQa/bQaRfg8pzSwFgSNluMOtWW8DEBl/MZf0zddXaQlucXtht9aie BOt/WQChPAFvagxrGEwktA1xRpOoig/u+c60t8d45rP7YBg+YBAT4s6wA6Qs0PCxqN8Y RV4ihbxnjDIqEYLqKSNJTbma9PePIIY/1jhQnOVDkMi0DbBQZBke06roZ+uxq1dOCK+j f7zhoFZRZ0ibMFAI+fRWwxpJVoXiURcSSigA9N8Gn2draPgcYvl1j+D9xXbY/wyP3mqu L6fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=14hInx47uLZa4wkIxoKEgr9Qc5WWNQsi7l9pL1yu/Os=; b=kIrppQsd2nu5kI1Q66RQ+N+SX2eKKCrBn6cQfUhR8sf9SL/mOYCm2/TZhsqPcR5foH AAhHkd6b2nG/tyohJNXZaenx+YL2psyD9K4LHkwwRI1w/tETsi5/hxoX22cKnBd9zTmB 8esX9bZ35XxcnlIDeNsRuoSJpxXMcN4hzDbOjZg3GrrBrBRkumdIIdTD3Vm3ghOzx5m6 RLeMh187xoIeVB3bqA3Uj+MEyJKuEYjN4C3bBSeOlk9kXLdr14ju4HnNE3/niOwzTpYu oeSHdhte7vyOiCsGAvR1dMqZL9HD9hR5/RIXYEd/8XvazYXZXUjrVq4lYiUhzdrZyVax yhcw== X-Gm-Message-State: APjAAAWCEq1SjPIbXBq68xXVT19p9H0uvjkBis6PNDq/rktCMxJunqKo lKetN7HsH1utvEUfiL3c8BQLABbIDU3LfOZz4Bs= X-Google-Smtp-Source: APXvYqwkOgDp0MatVVgGATmggk8StDl6yX4ae9/II0KwfKqKRlxRuJZ4Lfn6MCPSg43PS9aSTt3AmYoOrAmcsWoMOko= X-Received: by 2002:a5d:97cf:: with SMTP id k15mr5734802ios.151.1568464502300; Sat, 14 Sep 2019 05:35:02 -0700 (PDT) MIME-Version: 1.0 References: <20190125212233.GA19274@darkstar.lan> In-Reply-To: From: Gavin Smith Date: Sat, 14 Sep 2019 13:34:35 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Sep 2, 2019 at 6:28 PM Jim Meyering wrote: > > Gavin Smith proposed a patch for this back in http://bugs.gnu.org/34201 > Another reference to the problem: http://bugs.gnu.org/36921 > > In the attached (in Gavin's name), I've added a NEWS entry and > adjusted the ChangeLog entry. Will push in a day or so if no comment. Thanks for taking the time to look at this. From unknown Sun Jun 22 17:16:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34201: [PATCH] automake: do not require @setfilename in Texinfo files Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 15 Sep 2019 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34201 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Gavin Smith Cc: 34201@debbugs.gnu.org, 36921@debbugs.gnu.org, automake-patches@gnu.org, Karl Berry Received: via spool by 34201-submit@debbugs.gnu.org id=B34201.156856664325331 (code B ref 34201); Sun, 15 Sep 2019 16:58:02 +0000 Received: (at 34201) by debbugs.gnu.org; 15 Sep 2019 16:57:23 +0000 Received: from localhost ([127.0.0.1]:48685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Xpz-0006aO-0A for submit@debbugs.gnu.org; Sun, 15 Sep 2019 12:57:23 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Xpx-0006a4-Iz; Sun, 15 Sep 2019 12:57:21 -0400 Received: by mail-wr1-f65.google.com with SMTP id r3so6361202wrj.6; Sun, 15 Sep 2019 09:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXMzBONpUvfGfbs+ufp/4+biPOvIMC1/OHwgAH1eCnc=; b=EIGRbTU/7lxBoptD+ndTso0U1PkENYq6QlReHhCBpOd458N+px0/6Q/9cqSxrEQ7jw xHENXdeRpqLSx6zS2GyfYHOT5ZmKlngRPQGctY+Ra0g+kOPzrqw9Nijgua8CiRPbatRa cdYnPw2C4Z7sxgyMJI+LGOl6v9v8ijFXgftm4OL0l0JRHV+B6e42eUweonoAgdM3YPDx S89ZM5LPniDKuNHvv9kCGSfSrhfEcrU6ZqY++LcqcnkYbTOlUFI8qvewUU6mvSC2E3zz M2pCwBdt7BjjhSlf72d8KQOwqyZQM+ygXwsqbXhYN+GpUc1hR949T/ZCPdE6VJWpU7uK /cLQ== X-Gm-Message-State: APjAAAWsLoIglRma9fB19nfMoOMhmRpKNCx8jF4fEvbA9ztaIY9g1+wT KjzuiqPoH8lKNKpQzwqvB929ZtdGyzv/ryt91fQ= X-Google-Smtp-Source: APXvYqy6wgY41j3h6epo3ZZdRkqK2kgCaw+h0imC5IvmOOaAqapVCeBundcpYwTpqe5tniWPxRRrPNpDuyy6SLnreA4= X-Received: by 2002:a5d:4c48:: with SMTP id n8mr2148138wrt.192.1568566635723; Sun, 15 Sep 2019 09:57:15 -0700 (PDT) MIME-Version: 1.0 References: <20190125212233.GA19274@darkstar.lan> In-Reply-To: From: Jim Meyering Date: Sun, 15 Sep 2019 09:57:03 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sat, Sep 14, 2019 at 5:35 AM Gavin Smith wrote: > On Mon, Sep 2, 2019 at 6:28 PM Jim Meyering wrote: > > > > Gavin Smith proposed a patch for this back in http://bugs.gnu.org/34201 > > Another reference to the problem: http://bugs.gnu.org/36921 > > > > In the attached (in Gavin's name), I've added a NEWS entry and > > adjusted the ChangeLog entry. Will push in a day or so if no comment. > > Thanks for taking the time to look at this. Oh! Thanks for the reminder. I've just pushed that. From unknown Sun Jun 22 17:16:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gavin Smith Subject: bug#34201: closed () Message-ID: References: <202102150224.11F2O2e1003541@freefriends.org> <20190125212233.GA19274@darkstar.lan> X-Gnu-PR-Message: they-closed 34201 X-Gnu-PR-Package: automake Reply-To: 34201@debbugs.gnu.org Date: Mon, 15 Feb 2021 02:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1613355902-8779-1" This is a multi-part message in MIME format... ------------=_1613355902-8779-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #34201: Make @setfilename optional in Texinfo files which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 34201@debbugs.gnu.org. --=20 34201: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34201 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1613355902-8779-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 34201-done) by debbugs.gnu.org; 15 Feb 2021 02:24:06 +0000 Received: from localhost ([127.0.0.1]:37052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBTYT-0002GR-UV for submit@debbugs.gnu.org; Sun, 14 Feb 2021 21:24:06 -0500 Received: from freefriends.org ([96.88.95.60]:38926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBTYS-0002GJ-I5 for 34201-done@debbugs.gnu.org; Sun, 14 Feb 2021 21:24:04 -0500 X-Envelope-From: karl@freefriends.org X-Envelope-To: <34201-done@debbugs.gnu.org> Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 11F2O3xu003543 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <34201-done@debbugs.gnu.org>; Sun, 14 Feb 2021 19:24:04 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 11F2O2e1003541; Sun, 14 Feb 2021 19:24:02 -0700 Date: Sun, 14 Feb 2021 19:24:02 -0700 Message-Id: <202102150224.11F2O2e1003541@freefriends.org> From: Karl Berry To: 34201-done@debbugs.gnu.org Subject: X-Spam-Score: 3.7 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Content analysis details: (3.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [96.88.95.60 listed in list.dnswl.org] 2.3 EMPTY_MESSAGE Message appears to have no textual parts and no Subject: text 2.0 BLANK_SUBJECT Subject is present but empty 1.6 BODY_EMPTY No body text in message X-Debbugs-Envelope-To: 34201-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [96.88.95.60 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.3 EMPTY_MESSAGE Message appears to have no textual parts and no Subject: text -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty 1.6 BODY_EMPTY No body text in message ------------=_1613355902-8779-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Jan 2019 21:21:20 +0000 Received: from localhost ([127.0.0.1]:45631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gn8uV-0000O8-4W for submit@debbugs.gnu.org; Fri, 25 Jan 2019 16:21:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gn8uL-0000N3-39 for submit@debbugs.gnu.org; Fri, 25 Jan 2019 16:21:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:56543) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn8uF-0008Cq-JE for submit@debbugs.gnu.org; Fri, 25 Jan 2019 16:20:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn8uE-0005Ow-Al for bug-automake@gnu.org; Fri, 25 Jan 2019 16:20:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_20, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn8uC-00089i-LH for bug-automake@gnu.org; Fri, 25 Jan 2019 16:20:53 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:50721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gn8uC-00086c-7O for bug-automake@gnu.org; Fri, 25 Jan 2019 16:20:52 -0500 Received: by mail-wm1-x332.google.com with SMTP id n190so8116667wmd.0 for ; Fri, 25 Jan 2019 13:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:mime-version:content-disposition :user-agent; bh=q+sgwzzh3qxO8dUNZg8emI4BSTvKBUL89nQT6UKLcsc=; b=c1U+TIgbw/3SFGqBrF/YbiloozhFQHYEqPmS/FXsJiO1XGNIzJdZ8mMJEA4h6bqX9o 3d4aOf/ClJlI3CeMKrCaZT37nRRW+Ffmo5c5K4cnRQxxtijUfIYU/FuxsAJ6yoWPbGFl F2XHeTIa+44yOGkri2B5DsVzu0ico2WpWgn6kpFcebxbYnAtVISchDMuauhL5jD8gBYk 0pj+L/qW9Nh5RdAdDM9mV7c1hpBi2E9J8b0xIT4M4RiD0d5iAdsvv3EMPOjG/3RUXFaf 96F/8Xhn5mSYdKOhkXOGYaIAIP25jO8D9/dAkWq6kY6jsNpwPC5jrvebH7DaGatRMX3w X/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-disposition:user-agent; bh=q+sgwzzh3qxO8dUNZg8emI4BSTvKBUL89nQT6UKLcsc=; b=pHcOnjCK+5zv5XCbN123PUD2aqWIZGtnxwzbyAb+3G/vo9yLorCywC2R6BBoyEv0F5 8ca3yTi6FZ1zZc/qZxff6+z9hbUoOioV0AXU2w5W6vldif2Mj6j1bfx0vUR1E705pod6 YPBwx96uldL78EnmbxOAl+ib/t6mgP7NFSsbMgxHqgEqLw/d9VLsEtgAz+eUzWZI7Bob Ri5UIwoDIvZ4wIWKQofdxS8QMZRUeq2lWR21sNDKFK28xCWi9BKNTcuGmnnISc3/pq0C HUL8Pgfds/Na1CIdPdxDStd6fTLLPUKyJRHq6YbS85Pyclj8AGfXqJAeFPtZ4gXEH+Kf cdGg== X-Gm-Message-State: AHQUAuaOn6hayHJRjulViNG55K8gSL70uCYw7MNmBJBxU2R6/SwrVszQ Eos+zMgMlr2N9vsYLFp6TXCOT+ic X-Google-Smtp-Source: AHgI3IZjoeWAxoefa8aqkWgT6lmC32dQjTUjfBwfHPBUam6+sg84EyDoA7yZ2kWV5QQzBMKOzuA7bQ== X-Received: by 2002:a1c:1b8d:: with SMTP id b135mr8285244wmb.115.1548451249084; Fri, 25 Jan 2019 13:20:49 -0800 (PST) Received: from darkstar.example.net (55.37.198.146.dyn.plus.net. [146.198.37.55]) by smtp.gmail.com with ESMTPSA id x81sm66072547wmg.17.2019.01.25.13.20.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 13:20:48 -0800 (PST) From: Gavin Smith X-Google-Original-From: Gavin Smith Received: from darkstar.example.net (localhost [127.0.0.1]) by darkstar.example.net (8.14.9/8.14.9) with ESMTP id x0PLMYQP023343 for ; Fri, 25 Jan 2019 21:22:39 GMT Received: (from g@localhost) by darkstar.example.net (8.14.9/8.14.9/Submit) id x0PLMYKL023339 for bug-automake@gnu.org; Fri, 25 Jan 2019 21:22:34 GMT Date: Fri, 25 Jan 2019 21:22:33 +0000 To: bug-automake@gnu.org Subject: Make @setfilename optional in Texinfo files Message-ID: <20190125212233.GA19274@darkstar.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::332 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: @setfilename should not be required to occur inside Texinfo files, as it makes it harder to get them working. Earlier on this: https://lists.gnu.org/archive/html/automake/2015-09/msg00000.html Here is a patch. I added a test which is passing now, but it wasn't passing when I first added the test, so am not sure if it is written correctly. I based it on the existing test t/txinfo-setfilename [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (gavinsmith0123[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gavinsmith0123[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) @setfilename should not be required to occur inside Texinfo files, as it makes it harder to get them working. Earlier on this: https://lists.gnu.org/archive/html/automake/2015-09/msg00000.html Here is a patch. I added a test which is passing now, but it wasn't passing when I first added the test, so am not sure if it is written correctly. I based it on the existing test t/txinfo-setfilename-repeated.sh. It says GPL version 2 in the licence because that's what was in the existing tests, although they should probably all be version 3. ChangeLog entry: Do not require @setfilename in Texinfo files. * bin/automake.in (scan_texinfo_file): Derive name of info file from name of input file if no @setfilename line occurs in the file. * t/texinfo-no-setfilename.sh: New test. diff --git a/bin/automake.in b/bin/automake.in index b4ae8f4..01e6a58 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -3083,8 +3083,10 @@ sub scan_texinfo_file if (! $outfile) { - err_am "'$filename' missing \@setfilename"; - return; + # Replace a .texi extension with .info + $outfile = basename($filename); + $outfile =~ s/\.[^.]+$//; + $outfile .= '.info'; } return ($outfile, $vfile); diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 84dd29a..32fca84 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -1214,6 +1214,7 @@ t/txinfo-no-clutter.sh \ t/txinfo-no-extra-dist.sh \ t/txinfo-no-installinfo.sh \ t/txinfo-no-repeated-targets.sh \ +t/txinfo-no-setfilename.sh \ t/txinfo-other-suffixes.sh \ t/txinfo-override-infodeps.sh \ t/txinfo-override-texinfo-tex.sh \ diff --git a/t/txinfo-no-setfilename.sh b/t/txinfo-no-setfilename.sh new file mode 100644 index 0000000..3ef1730 --- /dev/null +++ b/t/txinfo-no-setfilename.sh @@ -0,0 +1,35 @@ +#! /bin/sh +# Copyright (C) 2019 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check Texinfo files work without a @setfilename line + +. test-init.sh + +cat > Makefile.am << 'END' +info_TEXINFOS = file.texi +END + +cat > file.texi << 'END' +contents +END + +$ACLOCAL +$AUTOMAKE --add-missing + + +grep 'file.info:' Makefile.in + +: ------------=_1613355902-8779-1--