Subject: bug#34200: closed (Re: [bug#34200] [PATCH] gnu: Add stoken.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 26 Jan 2019 23:50:02 +0000

Your bug report

#34200: [PATCH] gnu: Add stoken.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34200: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34200
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34200] [PATCH] gnu: Add stoken.
From: Eric Bavier <[email-masked]>
To: Ricardo Wurmus <[email-masked]>, [email-masked]
Date: Sat, 26 Jan 2019 17:48:54 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sat, 26 Jan 2019 14:53:49 +0100
Ricardo Wurmus <[email-masked]> wrote:

> Hi Eric,
> 
> thanks for the patch!
> 
> > * gnu/packages/crypto.scm (stoken): New variable.  
> […]
> > +    (home-page "https://stoken.sf.net")  
> 
> Sourceforge home pages don’t seem to support HTTPS.

Hm, transcription error, I guess.

> 
> > +    (synopsis "Software Token for cryptographic authentication")
> > +    (description
> > +     "@code{stoken} is a tokencode generator compatible with RSA SecurID
> > +128-bit (AES) tokens.  This package contains a standalong command-line program
> > +that allows for importing token seeds, generating tokencodes, and various
> > +utility/testing functions.")
> > +    (license license:lgpl2.1+)))  
> 
> “standalong” should be “standalone”; I’d also separate the term
> “tokencodes”.

Done.

> 
> Other than that it looks good to me!

Thanks for the review, Ricardo!

Pushed with fixes to master in c2ab3b84398df0b26e6127ea0c336a39e8950d17.

`~Eric

Subject: [PATCH] gnu: Add stoken.
From: [email-masked]
To: [email-masked]
Cc: Eric Bavier <[email-masked]>
Date: Fri, 25 Jan 2019 13:31:27 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Eric Bavier <[email-masked]>

* gnu/packages/crypto.scm (stoken): New variable.
---
 gnu/packages/crypto.scm | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 2c63e53191..a41543289c 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox>
 ;;; Copyright © 2016, 2017, 2018 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2016, 2017 Nils Gillmann <[email-masked]>
-;;; Copyright © 2016, 2017 Eric Bavier <[email-masked]>
+;;; Copyright © 2016, 2017, 2019 Eric Bavier <[email-masked]>
 ;;; Copyright © 2017 Pierre Langlois <[email-masked]>
 ;;; Copyright © 2018 Efraim Flashner <[email-masked]>
 ;;; Copyright © 2018 Arun Isaac <[email-masked]>
@@ -902,3 +902,29 @@ Features:
 @end itemize\n")
       (home-page "https://github.com/bitcoin-core/secp256k1")
       (license license:unlicense))))
+
+(define-public stoken
+  (package
+    (name "stoken")
+    (version "0.92")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/stoken/"
+                                  "stoken-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0npgr6y85gzwksy8jkwa4yzvqwjprwnplx3yiw3ayk4f0ldlhaxa"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("nettle" ,nettle)
+       ("libxml2" ,libxml2)))
+    (home-page "https://stoken.sf.net")
+    (synopsis "Software Token for cryptographic authentication")
+    (description
+     "@code{stoken} is a tokencode generator compatible with RSA SecurID
+128-bit (AES) tokens.  This package contains a standalong command-line program
+that allows for importing token seeds, generating tokencodes, and various
+utility/testing functions.")
+    (license license:lgpl2.1+)))
-- 
2.20.1