GNU bug report logs - #34196
27.0.50; tramp hangs on wrong password with global-auto-revert-mode

Previous Next

Package: emacs;

Reported by: Aaron Jensen <aaronjensen <at> gmail.com>

Date: Fri, 25 Jan 2019 15:38:01 UTC

Severity: normal

Tags: fixed

Found in version 27.0.50

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log


Message #51 received at 34196 <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 34196 <at> debbugs.gnu.org
Subject: Error in auto-revert-buffers: Wrong type argument
Date: Wed, 13 Feb 2019 13:00:43 -0600
Hi Michael -

The fix for this bug seems to cause issues if default-directory is nil
for any buffer. In particular, you get a wrong type argument where
auto-revert-buffers is expecting a string instead of nil.

This change fixes the issue for me:

Thanks,
Alex

diff --git a/lisp/autorevert.el b/lisp/autorevert.el
index 150693baf1..318b10d4a8 100644
--- a/lisp/autorevert.el
+++ b/lisp/autorevert.el
@@ -773,7 +773,8 @@ the timer when no buffers need to be checked."
                        (mapcar
                         (lambda (buf)
                           (with-current-buffer buf
-                            (and (or (not (file-remote-p default-directory))
+                            (and default-directory
+                                 (or (not (file-remote-p default-directory))
                                      (file-remote-p default-directory nil t))
                                  buf)))
                         bufs)))




This bug report was last modified 6 years and 102 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.