GNU bug report logs - #34194
[PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34194: closed ([PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.)
Date: Fri, 01 Feb 2019 19:55:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 02 Feb 2019 01:23:41 +0530
with message-id <cu78syzs2t6.fsf <at> systemreboot.net>
and subject line Re: [bug#34194] [PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.
has caused the debbugs.gnu.org bug report #34194,
regarding [PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34194: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34194
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.
Date: Fri, 25 Jan 2019 16:59:04 +0530

[Message part 3 (text/plain, inline)]

I have packaged mkmcc's gnuplot-mode. We already have another
gnuplot-mode (bruceravel's gnuplot-mode) packaged for Guix. But
bruceravel's gnuplot-mode does not seem to be maintained. mkmcc's
gnuplot-mode is a separate project and is somewhat better
maintained. So, it could be of use to Guix users.

[0001-gnu-Add-emacs-mkmcc-gnuplot-mode.patch (text/x-patch, inline)]

From 40f6d899c87923a5967a2aa9138b490e7b119229 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac <at> systemreboot.net>
Date: Fri, 25 Jan 2019 16:52:40 +0530
Subject: [PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.

* gnu/packages/emacs-xyz.scm (emacs-mkmcc-gnuplot-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bd084bd2d8..2db372fe07 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16,7 +16,7 @@
 ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2016, 2017, 2018, 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2016, 2017, 2018 Alex Vong <alexvong1995 <at> gmail.com>
-;;; Copyright © 2016, 2017, 2018 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2016, 2017, 2018, 2019 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2017, 2018 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2017, 2018, 2019 Clément Lassieur <clement <at> lassieur.org>
@@ -12970,3 +12970,25 @@ comments.")
       (description "This package provides an Emacs major mode which acts as a
 front end to mpc, a client for the @dfn{Music Player Daemon} (MPD).")
       (license license:gpl3+))))
+
+(define-public emacs-mkmcc-gnuplot-mode
+  (package
+    (name "emacs-mkmcc-gnuplot-mode")
+    (version "1.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mkmcc/gnuplot-mode")
+             (commit "601f6392986f0cba332c87678d31ae0d0a496ce7")))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256
+        (base32
+         "14f0yh1rjqc3337j4sbqzfb7pjim2c8a7wk1a73xkrdkmjn82vgb"))))
+    (build-system emacs-build-system)
+    (home-page "https://mkmcc.github.io/software/gnuplot-mode.html")
+    (synopsis "Minimal emacs major mode for editing gnuplot scripts")
+    (description "@code{emacs-mkmcc-gnuplot-mode} is a minimal emacs major
+mode for editing gnuplot scripts.  It only provides syntax highlighting,
+indentation and a command to plot the file.")
+    (license license:gpl3+)))
-- 
2.19.2

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 34194-done <at> debbugs.gnu.org
Subject: Re: [bug#34194] [PATCH] gnu: Add emacs-mkmcc-gnuplot-mode.
Date: Sat, 02 Feb 2019 01:23:41 +0530

[Message part 7 (text/plain, inline)]

>> +    (description "@code{emacs-mkmcc-gnuplot-mode} is a minimal emacs major
>> +mode for editing gnuplot scripts.  It only provides syntax highlighting,
>> +indentation and a command to plot the file.")
>
> Maybe 's/only//'?  LGTM, anyway.

I made this change and pushed to master. Thanks for the review!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.