Subject: Re: [bug#34189] [PATCH] gnu: Add arcan.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 04 Mar 2019 15:10:49 +0100

Hello,

L  p R n  d n    <[email-masked]> skribis:

>> I think that “LGPL” means ’lgpl2.0+’ though, not ‘lgpl2.0’.  Could you
>> check whether source files that have a GPL or LGPL license header carry
>> the “or any later version” wording?
>
> From what I found, there are both lgpl2.0 and lgpl2.0+ in the package so
> I put both. I also added public-domain license as it seems quite a few
> files use it.

OK.

>> And the changes that were needed:
>>
>> diff --git a/gnu/local.mk b/gnu/local.mk
>> index 1ea8069308..97962110c4 100644
>> --- a/gnu/local.mk
>> +++ b/gnu/local.mk
>> @@ -65,6 +65,7 @@ GNU_SYSTEM_MODULES =				\
>>    %D%/packages/antivirus.scm			\
>>    %D%/packages/apl.scm				\
>>    %D%/packages/apr.scm				\
>> +  %D%/packages/arcan.scm			\
>>    %D%/packages/aspell.scm			\
>>    %D%/packages/assembly.scm			\
>>    %D%/packages/astronomy.scm			\
>> diff --git a/gnu/packages/arcan.scm b/gnu/packages/arcan.scm
>> index 9ff72a429b..e706f11edf 100644
>> --- a/gnu/packages/arcan.scm
>> +++ b/gnu/packages/arcan.scm
>> @@ -21,8 +21,6 @@
>>    #:use-module (guix git-download)
>>    #:use-module ((guix licenses) #:prefix license:)
>>    #:use-module (guix packages)
>> -  #:use-module (guix utils)

I re-added these changes.

> From d6c6aeb76c97c8f7a3eb68a115bf2cb59715bac2 Mon Sep 17 00:00:00 2001
> From: Lprndn <[email-masked]>
> Date: Thu, 24 Jan 2019 13:29:21 +0100
> Subject: [PATCH] gnu: Add arcan.
>
> * gnu/packages/arcan.scm: New file.

Applied (with the changes above).  I confirm that it builds for me on
x86_64-linux.

> From 4517b292cc36382ee0b855e3a5caf6c3ba5f4c2d Mon Sep 17 00:00:00 2001
> From: Lprndn <[email-masked]>
> Date: Thu, 24 Jan 2019 13:34:26 +0100
> Subject: [PATCH] gnu: Add arcan-sdl.
>
> * gnu/packages/arcan.scm (arcan-sdl): New variable.

Applied.

> From a0a69b664c3ada7522f42b8ea28ad08d8f39a5d4 Mon Sep 17 00:00:00 2001
> From: Lprndn <[email-masked]>
> Date: Thu, 24 Jan 2019 13:39:06 +0100
> Subject: [PATCH] gnu: Add xarcan.
>
> * gnu/packages/arcan.scm (xarcan): New variable.

[...]

> +(define-public xarcan
> +  (package
> +    (name "xarcan")
> +    (version "0.5.4")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (file-name (git-file-name name version))
> +       (uri (git-reference
> +             (url "https://github.com/letoram/xarcan.git")
> +             (commit "8e6ee029388326cfe5cddeffe482eb3702e9b7f3")))
> +       (sha256
> +        (base32 "0zng7cs6733mnf0p6g5wv02981f2sf567n56csax6cmzb8fpamym"))))

Please use ‘git-version’ for the ‘version’ field, like you did for
‘arcan’.

> +    (home-page "https://arcan-fe.com")
> +    (synopsis "Patched Xserver that bridges connections to Arcan")
> +    (description "Patched Xserver that bridges connections to Arcan.")

Please expound the description a bit—see
<https://gnu.org/s/guix/manual/en/html_node/Synopses-and-Descriptions.html>.

Sorry that this is taking so long, but at least we’re making progress!
:-)

Ludo’.