GNU bug report logs - #34188
[PATCH] gnu: Add ELPA.

Previous Next

Full log

Message #8 received at 34188 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: ericbavier <at> centurylink.net
Cc: Eric Bavier <bavier <at> cray.com>, 34188 <at> debbugs.gnu.org
Subject: Re: [bug#34188] [PATCH] gnu: Add ELPA.
Date: Tue, 05 Feb 2019 12:19:05 +0100

Hello,

ericbavier <at> centurylink.net skribis:

> From: Eric Bavier <bavier <at> cray.com>
>
> * gnu/packages/maths.scm (elpa, elpa-openmpi): New variables.

[...]

> +    (arguments
> +     `(#:configure-flags
> +       `(;"--enable-openmp"

No OpenMP support, yet the ‘setup-tests’ phase sets OMP_NUM_THREADS.
Did you mean to uncomment it?

> +         "--with-mpi=no"
> +         ;; ELPA unfortunately does not support runtime dispatch, so we can
> +         ;; only enable the "generic" kernels.  See the "Cross compilation"
> +         ;; section of INSTALL.md.
> +         "--enable-generic"
> +         "--disable-sse" "--disable-sse-assembly" ;Require SSE3
> +         "--disable-avx" "--disable-avx2" "--disable-avx512"

For a future patch, do you think you can enable function
multi-versioning (FMV) for this code using the scripts at
<https://github.com/clearlinux/make-fmv-patch>?  That’d be pretty cool.

> +    (synopsis "Eigenvalue solvers for symmetric matrices")
> +    (description
> +     "The ELPA library provides efficient and scalable direct eigensolvers for
> +symmetric matrices.")
> +    (license license:lgpl3)))

v3 only?

Also, should we add a ‘supported-systems’ field or is it supposed to
work on any architecture?

Apart from that it LGTM, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.