Subject: Re: [bug#34175] [PATCH 4/4] gnu: Add efilinux.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 23 Jan 2019 09:12:08 +0100

Danny Milosavljevic <[email-masked]> writes:

> * gnu/packages/efi.scm (efilinux): New variable.
[…]
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc"
> +             (string-append "INCDIR=" (assoc-ref %build-inputs "gnu-efi")
> +                            "/include")
> +             (string-append "LIBDIR=" (assoc-ref %build-inputs "gnu-efi")
> +                            "/lib"))

Nitpick: I’d use a let binding for (assoc-ref %build-inputs "gnu-efi").

> +       #:tests? #f ; No tests exist.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "efilinux.efi"
> +                           (string-append (assoc-ref outputs "out")
> +                           "/libexec"))

The indentation of "/libexec" is off.

Otherwise LGTM.

-- 
Ricardo