Subject: [bug#34175] [PATCH 1/4] gnu: Add gnu-efi.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 23 Jan 2019 09:05:53 +0100

Hi Danny,

> * gnu/packages/efi.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
[…]
> diff --git a/gnu/packages/efi.scm b/gnu/packages/efi.scm
> new file mode 100644
> index 000000000..3a92370ef
> --- /dev/null
> +++ b/gnu/packages/efi.scm
> @@ -0,0 +1,52 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Danny Milosavljevic <[email-masked]>

It’s 2019.

> +(define-public gnu-efi
> +  (package
> +    (name "gnu-efi")
> +    (version "3.0.9")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/gnu-efi/"
> +                           name "-" version ".tar.bz2"))
> +       (sha256
> +        (base32
> +         "1w3p4aqlc5j93q44la7dc8cr3hky20zvsd0h0k2lyzhwmrzfl5b7"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; None exist.
> +       #:make-flags
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (synopsis "EFI toolchain")
> +    (description "This package provides an EFI (Extensible Firmware
> +Interface) toolchain for building programs that can run in the
> +environment presented by Intel's EFI.")
> +    (home-page "https://directory.fsf.org/wiki/GNU_EFI")
> +    ;; FIXME: https://metadata.ftp-master.debian.org/changelogs/main/g/gnu-efi/gnu-efi_3.0.9-1_copyright
> +    (license license:gpl2)))

What does the FIXME tell us to do?  Should this be

   ;; The code can be distributed under the terms of either license
   (license (list license:gpl2+ license:expat))

-- 
Ricardo