GNU bug report logs - #34165
[PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 34165 <at> debbugs.gnu.org, Carl Dong <contact <at> carldong.me>
Subject: [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.
Date: Mon, 28 Jan 2019 14:39:35 +0100

Hi Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> [1] https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97867fa#commitcomment-32085478
>
> https://codereview.qt-project.org/#/c/243636/4/src/tools/rcc/rcc.cpp,unified contains the following patch:
>
> ...
> 228	228	         const QDateTime lastModified = m_fileInfo.lastModified();
> 	229	229	         quint64 lastmod = quint64(lastModified.isValid() ? lastModified.toMSecsSinceEpoch() : 0);
> 	230	230	         static const quint64 sourceDate = 1000 * qgetenv("QT_RCC_SOURCE_DATE_OVERRIDE").toULongLong(
> );
> 	231	231	         if (sourceDate != 0)
> 	232	232	             lastmod = sourceDate;
> 		233	+        static const quint64 sourceDate2 = 1000 * qgetenv("SOURCE_DATE_EPOCH").toULongLong();
> 		234	+        if (sourceDate2 != 0)
> 		235	+            lastmod = sourceDate2;

Nice, so maybe we don’t need to change anything and just wait for the
next Qt version?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.