GNU bug report logs - #34165
[PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.

Previous Next

Package: guix-patches;

Reported by: Carl Dong <contact <at> carldong.me>

Date: Mon, 21 Jan 2019 20:26:03 UTC

Owned by: bavier <at> member.fsf.org

Severity: normal

Tags: patch

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

Full log

Message #27 received at 34165 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 34165 <at> debbugs.gnu.org,
 Carl Dong <contact <at> carldong.me>
Subject: Re: [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt
 deterministic.
Date: Mon, 28 Jan 2019 12:07:20 +0100

[Message part 1 (text/plain, inline)]
Hi,

> > https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97867fa  
> 
> This is a bit unfortunate.  It seems to me that the original intent of
> the patch was to support SOURCE_DATE_EPOCH as the commit message
> mentions that variable’s specification.  Pity that it is now a custom Qt
> variable.

I asked them and they said [1]:

>There was a policy to prefix variables with QT_ and I did not want to discuss more with the reviewer.
>But later, this was merged:
>https://codereview.qt-project.org/#/c/243636/4/src/tools/rcc/rcc.cpp,unified

[1] https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97867fa#commitcomment-32085478

https://codereview.qt-project.org/#/c/243636/4/src/tools/rcc/rcc.cpp,unified contains the following patch:

...
228	228	         const QDateTime lastModified = m_fileInfo.lastModified();
	229	229	         quint64 lastmod = quint64(lastModified.isValid() ? lastModified.toMSecsSinceEpoch() : 0);
	230	230	         static const quint64 sourceDate = 1000 * qgetenv("QT_RCC_SOURCE_DATE_OVERRIDE").toULongLong(
);
	231	231	         if (sourceDate != 0)
	232	232	             lastmod = sourceDate;
		233	+        static const quint64 sourceDate2 = 1000 * qgetenv("SOURCE_DATE_EPOCH").toULongLong();
		234	+        if (sourceDate2 != 0)
		235	+            lastmod = sourceDate2;

[Message part 2 (application/pgp-signature, inline)]
This bug report was last modified 6 years and 112 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.