GNU bug report logs - #34153
[PATCH] Update fish to 3.0.0.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Meiyo Peng <meiyo <at> disroot.org>
Subject: bug#34153: closed (Re: [bug#34153] [PATCH] Update fish to 3.0.0.)
Date: Mon, 28 Jan 2019 22:14:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34153: [PATCH] Update fish to 3.0.0.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34153 <at> debbugs.gnu.org.

-- 
34153: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34153
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Meiyo Peng <meiyo <at> disroot.org>
Cc: 34153-done <at> debbugs.gnu.org
Subject: Re: [bug#34153] [PATCH] Update fish to 3.0.0.
Date: Mon, 28 Jan 2019 23:13:21 +0100

Hello Meiyo,

Meiyo Peng <meiyo <at> disroot.org> skribis:

> This patch series updates fish shell to 3.0.0 and enable fish to source
> /etc/profile using fish-foreign-env.

I don’t use Fish so I don’t really have an opinion but it looks
reasonable to me.  If it breaks, users will yell at you anyway.  ;-)

>>From 8d20b9d62d0d6c6c9c572b5871d0063c8b4fdf07 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Sun, 6 Jan 2019 22:11:36 +0800
> Subject: [PATCH 1/3] gnu: fish: Update to 3.0.0.
>
> * gnu/packages/shells.scm (fish): Update to 3.0.0.
>   [source]: Remove dead URL.
>   [inputs]: Remove bc.  Replace python-wrapper with python.
>   [arguments]: Remove configure-flags.  Enable fish to source
>   /etc/fish/config.fish.  Enable completions, functions and configurations
>   in user's and system's guix profiles.

[...]

>>From da8487fe9b9a0a0308f7b929f9e95e8e8297de26 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Sun, 20 Jan 2019 21:41:21 +0800
> Subject: [PATCH 2/3] gnu: Add fish-foreign-env.
>
> * gnu/packages/shells.scm (fish-foreign-env): New variable.

[...]

>>From aadeb9dea8aff0db8a339cc11d006abff4736fdb Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Sun, 20 Jan 2019 21:42:15 +0800
> Subject: [PATCH 3/3] gnu: fish: Use fish-foreign-env to source /etc/profile.
>
> * gnu/packages/shells.scm (fish): Use fish-foreign-env to source /etc/profile
>   when user logs in.

Applied all three patches.  Thanks for working on it!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Meiyo Peng <meiyo <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update fish to 3.0.0.
Date: Mon, 21 Jan 2019 16:19:29 +0800

[Message part 4 (text/plain, inline)]

Hi,

This patch series updates fish shell to 3.0.0 and enable fish to source
/etc/profile using fish-foreign-env.

[0001-gnu-fish-Update-to-3.0.0.patch (text/x-patch, attachment)]

[0002-gnu-Add-fish-foreign-env.patch (text/x-patch, attachment)]

[0003-gnu-fish-Use-fish-foreign-env-to-source-etc-profile.patch (text/x-patch, attachment)]

[Message part 8 (text/plain, inline)]

--
Meiyo Peng
https://www.pengmeiyu.com/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.