From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 20 10:18:12 2019 Received: (at submit) by debbugs.gnu.org; 20 Jan 2019 15:18:12 +0000 Received: from localhost ([127.0.0.1]:39094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glErU-0003zB-F2 for submit@debbugs.gnu.org; Sun, 20 Jan 2019 10:18:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glErR-0003yt-C2 for submit@debbugs.gnu.org; Sun, 20 Jan 2019 10:18:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:46660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glErM-00036r-6B for submit@debbugs.gnu.org; Sun, 20 Jan 2019 10:18:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glErL-00067C-5U for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2019 10:18:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glErK-00034w-Eh for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2019 10:18:03 -0500 Received: from forward100o.mail.yandex.net ([37.140.190.180]:55644) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glErK-00031Q-50 for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2019 10:18:02 -0500 Received: from mxback15g.mail.yandex.net (mxback15g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:94]) by forward100o.mail.yandex.net (Yandex) with ESMTP id 69EC14AC0D63 for ; Sun, 20 Jan 2019 18:17:58 +0300 (MSK) Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [2a02:6b8:0:1a2d::28]) by mxback15g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id bw1rHdpQsX-HwQqCMMZ; Sun, 20 Jan 2019 18:17:58 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xuchunyang.me; s=mail; t=1547997478; bh=jqekd3ZDsM/Ie/bx5wrmLh9avocdojNyeDCnqmbOzZ8=; h=From:To:Subject:Date:Message-ID; b=226BLpc6g7s4SD2hy+9uBNepesUnv9jizznoi5ClsJ6dvOJSXPT704vbfEQ4UupZE a16DgmZrAEyXEtxyw0/qc8UowKrF4IVZrrwPKSAtcc3cNKP4yQml0P4MpfJxd11tEi 5hnOlHpaqpile7qmTNxnb5Z1707hY+sUKzc7YCMU= Authentication-Results: mxback15g.mail.yandex.net; dkim=pass header.i=@xuchunyang.me Received: by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id bmnFxCz0wZ-Hso8RSxZ; Sun, 20 Jan 2019 18:17:56 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) From: Xu Chunyang To: bug-gnu-emacs@gnu.org Subject: 27.0.50; M-x describe-package groovy-mode breaks Date: Sun, 20 Jan 2019 23:17:38 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 37.140.190.180 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I've setup Melpa, C-h P groovy-mode breaks, here is the backtrace Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil) #f(compiled-function (pkg) #)(groovy-mode) apply(#f(compiled-function (pkg) #) groovy-mode) describe-package-1(groovy-mode) describe-package(groovy-mode) funcall-interactively(describe-package groovy-mode) call-interactively(describe-package nil nil) command-execute(describe-package) By evaluating describe-package-1 to get detailed Backtrace (I didn't paste it since it is very long), it seems the error is caused by the "last" expression of describe-package-1: (insert readme-string) when readme-string is nil. I notice Melpa fails to provide the readme file, this URL is 404 https://melpa.org/packages/groovy-mode-readme.txt -- In GNU Emacs 27.0.50 Repository revision: 436c225f1b8ca48fa7c7e769fe6b7055f37af95d Repository branch: master Windowing system distributor 'Apple', version 10.3.1671 System Description: Mac OS X 10.14.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 05 18:08:22 2019 Received: (at 34147) by debbugs.gnu.org; 5 Feb 2019 23:08:22 +0000 Received: from localhost ([127.0.0.1]:33862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gr9pF-0007EZ-MI for submit@debbugs.gnu.org; Tue, 05 Feb 2019 18:08:21 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:44633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gr9pE-0007EK-VS for 34147@debbugs.gnu.org; Tue, 05 Feb 2019 18:08:21 -0500 Received: by mail-qt1-f179.google.com with SMTP id n32so5889157qte.11 for <34147@debbugs.gnu.org>; Tue, 05 Feb 2019 15:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=tN10o0IqhdlJ0wmSEPddXU9LSlO13yh06Mu7vFkvvfI=; b=gLId3KijuT6DN8IIF/fno5QoFfHe2b19rbbjwZ+hBFmqabWgqvO9n1oeqSJDE9U7yH 6Q8u6DD1MKEGBqX5ndlegPFsYNGyokTj/178N0j4PPQqStKRkbbiqco8h/tFCogY8VQq bpvYdQPS+bei8DQqX1OkFHK956PWnl59mxtNMMPaqmotwcACOM22vkwDkhfiYxanywxu taVnZIq+i7Moih7L2dCngzSdC/WmnzVf4BbQKDwebP9hiEpjOWt84103bjW7iC9JJjjp +ifE06punz4C2ig7Xc+7cBoHgTysmEp/rlPBfDtEYIyP/seRDySaJSwROpsuX0TOAOBD EF2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=tN10o0IqhdlJ0wmSEPddXU9LSlO13yh06Mu7vFkvvfI=; b=N32RlTLjjmJ9Pl08Aq5TyP49lX+tRSe88x9wM3LtJlJ90ur6UqWrIs3rAFbWUEFeHM 9vcuRNSxJkUry0yzk2vbf5ZQw3nmXykmSNEubtoZNsGV/FuLgtAOlaksNeDRBpQWbkmP AD4dn65M1tuC52thA+Z5Nj4GO93mjIqRgqEM7F4GvOeWZZtALlqwTKU2v8WcUr1jxReQ 0FHlIhmiRaEGOQDRVThl9AyK6Z0tnaGrUA9GgsSXpd+XSLmDcOzzq34r5aq3C1xHLc9A zBUyDutdJg0QGIyqnPgbMfNrszBaq+DQfL55FsVKsOw94u8MUkBlG1JMRYzzkCazDvUV 2Q4w== X-Gm-Message-State: AHQUAubeEy8cBddAyp1QmpXc74SthDU/JXsCuTwMdu7CxL6eUdGbaZ+i VHxNtB4DfNj+rVIsqpKNHTRTyd+Q X-Google-Smtp-Source: AHgI3IadMnITf/jiDrm4dBXalAQKGi6unaBoVvUScwYyVw5l0JDKyyQlU6QyEvLf6DwVpiuto+gWGA== X-Received: by 2002:a0c:b8a9:: with SMTP id y41mr4613332qvf.216.1549408095250; Tue, 05 Feb 2019 15:08:15 -0800 (PST) Received: from hideo ([181.170.211.157]) by smtp.gmail.com with ESMTPSA id 32sm19249286qto.55.2019.02.05.15.08.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 15:08:14 -0800 (PST) From: Federico Tedin To: Xu Chunyang Subject: Re: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks Date: Tue, 05 Feb 2019 20:08:11 -0300 Message-ID: <878syt96lg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34147 Cc: 34147@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > By evaluating describe-package-1 to get detailed Backtrace (I didn't > paste it since it is very long), it seems the error is caused by the > "last" expression of describe-package-1: > > (insert readme-string) > > when readme-string is nil. > > I notice Melpa fails to provide the readme file, this URL is 404 > > https://melpa.org/packages/groovy-mode-readme.txt It looks like when a package doesn't provide a 'Commentary' field, the xyz-readme.txt file isn't generated by MELPA (see https://github.com/melpa/package-build/blob/master/package-build.el#L382). Other packages without 'Commentary' (in no particular order): - instapaper - javap-mode - tdd-status-mode-line - jknav - runtests Using C-h P on these packages will trigger the same error. I guess we could replace: (insert readme-string) with: (when readme-string (insert readme-string)) or: (if readme-string (insert readme-string) (insert "This package does not provide a description.")) to cover cases where the xyz-readme.txt file for the package doesn't exist. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 12 20:39:23 2019 Received: (at 34147) by debbugs.gnu.org; 13 Mar 2019 00:39:23 +0000 Received: from localhost ([127.0.0.1]:40858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3rvW-0001a0-Sw for submit@debbugs.gnu.org; Tue, 12 Mar 2019 20:39:23 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:36320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3rvV-0001Zn-7J for 34147@debbugs.gnu.org; Tue, 12 Mar 2019 20:39:21 -0400 Received: by mail-qt1-f181.google.com with SMTP id b3so56478qtj.3 for <34147@debbugs.gnu.org>; Tue, 12 Mar 2019 17:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BZRbqj6WS5eGPWzSHDkzhIgHqx5JVGbqu5Q8kadGzIQ=; b=Dv0ouL9InbnOsZgHHbdUlSaSMQmdCxlpNkzwqPjKUa8I/aOPUfsej57mE7lsc/jiTP lgJ2jroLd10Ea15iO5oFZ0f0KJWpmvK5iDP9h6iNF3oqss+OGsCV5BYXRnBYpGgs/SKc can/jNQGJHsVW/tkEgSG6mgS3EduIwKcClVwkkWp1wu8yMS/p98SbvsbfQooU/rYdgax i3Pw2aHV9gk1Gu2qcqo70zHfyUQx7zNcQTJflh0PvT3yWdEEF+/GrQKM/Elbh+x61BsI Fo5DIJaE9kyolMALSX2cCMZc4cvzn3TtiuwlceBp/LB8ErXv/VCdUFsVy+EMGV15V2T6 1y3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BZRbqj6WS5eGPWzSHDkzhIgHqx5JVGbqu5Q8kadGzIQ=; b=RHyvDA59E1zG4euVB9+AZJ2Lovi49fN9cDVY/hbRZOpIiDzVDS2XgGvztGEZWX/7UZ 7kAv/A4BfgKgHokdb5bXKw4OaRFai0kb0g7SSiz09/cmcZ3+iFkBbOhRp61OJruNEf0G A/xGPP38mGeL0cVkeYpg2HSZ5QfQKisrNCTcg90PuHOmmuqBaTwmFA2EHnoLV/dCf1xf +4MTUEvbWw88tZCIxBAj8XgCXKi1EEHv28FxJln2uVsI1tq/iWUcjSL9UEXRCrL7JE8h 8mqLDrUCXLvybzQV569r6JCf8i6UtEQfF2NMnCDc/QtNLyLdzDmx3qIFfcK+NzhPcMZ/ eORA== X-Gm-Message-State: APjAAAXuNszsYUA3+wvlKWdy0Rk+TXCzKeVE8r3eJQU4e2j3RyHbSFZZ ThIcxCNnRsboy58gS9rlfLsW7w1C/Ac= X-Google-Smtp-Source: APXvYqwX/vnHX97KaQRV9Zi3atPSi6YepuOC7FZJnvHeUgd7SR7Nv0wC4kIMI2MB2hUkCduChwiYWA== X-Received: by 2002:ac8:2945:: with SMTP id z5mr32352359qtz.100.1552437555169; Tue, 12 Mar 2019 17:39:15 -0700 (PDT) Received: from hideo ([181.170.211.157]) by smtp.gmail.com with ESMTPSA id b10sm7323650qtb.93.2019.03.12.17.39.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 17:39:14 -0700 (PDT) From: Federico Tedin To: Xu Chunyang Subject: Re: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks References: <878syt96lg.fsf@gmail.com> Date: Tue, 12 Mar 2019 21:39:11 -0300 In-Reply-To: <878syt96lg.fsf@gmail.com> (Federico Tedin's message of "Tue, 05 Feb 2019 20:08:11 -0300") Message-ID: <87wol34ngw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34147 Cc: 34147@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I'm attaching a small patch with the changes I suggested above. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=package.patch Content-Description: patch >From b842f54518a6565edd78a363b65e8a8b690dbdf8 Mon Sep 17 00:00:00 2001 From: Federico Tedin Date: Tue, 12 Mar 2019 21:34:31 -0300 Subject: [PATCH 1/1] Correctly handle packages without description in describe-package * lisp/emacs-lisp/package.el (describe-package-1): Do not call insert if package description is nil (Bug#34147). --- lisp/emacs-lisp/package.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 5e8864ec73..ad1fb363f1 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2482,7 +2482,8 @@ describe-package-1 (insert ?\n))) (setq readme-string (buffer-string)) t) - (insert readme-string)) + (when readme-string + (insert readme-string))) )))) (defun package-install-button-action (button) -- 2.17.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 22 00:10:12 2019 Received: (at 34147-done) by debbugs.gnu.org; 22 Mar 2019 04:10:12 +0000 Received: from localhost ([127.0.0.1]:53921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7BVU-00013k-6y for submit@debbugs.gnu.org; Fri, 22 Mar 2019 00:10:12 -0400 Received: from mail01.iro.umontreal.ca ([132.204.25.201]:50362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h7BVS-00013S-HK for 34147-done@debbugs.gnu.org; Fri, 22 Mar 2019 00:10:10 -0400 Received: from mail01.iro.umontreal.ca (mail01.iro.umontreal.ca [127.0.0.1]) by mail01.iro.umontreal.ca (Postfix) with ESMTP id 4EA718133106 for <34147-done@debbugs.gnu.org>; Fri, 22 Mar 2019 00:10:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; h=content-type:content-type:mime-version:user-agent:in-reply-to :date:date:references:message-id:subject:subject:to:from:from; s=dkim; t=1553227803; x=1554091804; bh=XwSTwmyRXiT316nMFz1prBYZ Jq8dT50iOEW2hP72U0U=; b=bOUKESUClBxwTcHPC2iYaGi8pSVHBgUQRTNj7Ttt la8EuXLfHDcW63eTBszQs07SeZZJuFSNYVepdl1Ya0McrtrogwZ5WKOmVIZGZs75 mowx0zz+lsrcNPMenh+2DZuYXqVzcKAUPF5u9ZO8D2jLfcfpH+N2nwKDECCxhs+Z GTHp0WYnUKLzkkU2Fxn5zAMkn8WfKNoCbUVS1J153U9arzxCm6O3REe07gvC6XzA /v99ld5KG3PlV7/pwFxy7HWMp/dACqNUVi4brd3BOD9jd78Z2oByVZqvtRqUbFS/ Ss1znTDFRFSURB4W/ilZTat2WN4Zc9y1+baK81EZs5dfWA== X-Virus-Scanned: amavisd-new at iro.umontreal.ca Received: from mail01.iro.umontreal.ca ([127.0.0.1]) by mail01.iro.umontreal.ca (mail01.iro.umontreal.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cL5I9QApJ5a3 for <34147-done@debbugs.gnu.org>; Fri, 22 Mar 2019 00:10:03 -0400 (EDT) Received: from pastel (75-119-242-252.dsl.teksavvy.com [75.119.242.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A5F3D81330EE; Fri, 22 Mar 2019 00:10:03 -0400 (EDT) From: Stefan Monnier To: Federico Tedin Subject: Re: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks Message-ID: References: <878syt96lg.fsf@gmail.com> <87wol34ngw.fsf@gmail.com> Date: Fri, 22 Mar 2019 00:10:02 -0400 In-Reply-To: <87wol34ngw.fsf@gmail.com> (Federico Tedin's message of "Tue, 12 Mar 2019 21:39:11 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34147-done Cc: Xu Chunyang , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Version:27.1 > I'm attaching a small patch with the changes I suggested above. Pushed, but inserting a fall back text. Thank you very much, Stefan From unknown Fri Jun 20 20:11:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 19 Apr 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator