From unknown Fri Sep 05 11:00:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34134: 27.0.50; process-contact for accepted sockets broken Resent-From: Mathew Handugan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2019 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34134 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 34134@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154789411820692 (code B ref -1); Sat, 19 Jan 2019 10:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jan 2019 10:35:18 +0000 Received: from localhost ([127.0.0.1]:37321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkny9-0005Nf-B7 for submit@debbugs.gnu.org; Sat, 19 Jan 2019 05:35:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkkV3-0008Ie-8D for submit@debbugs.gnu.org; Sat, 19 Jan 2019 01:53:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:33849) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkkUx-00029u-R0 for submit@debbugs.gnu.org; Sat, 19 Jan 2019 01:52:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkkUw-00074v-VA for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 01:52:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkkUw-00026U-5x for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 01:52:54 -0500 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:32992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkkUv-00024e-MC for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 01:52:54 -0500 Received: by mail-qt1-x833.google.com with SMTP id l11so17859631qtp.0 for ; Fri, 18 Jan 2019 22:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=handugan.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=AymvcgT2LoYM7otdAGXEtZKVpojvc1Wo4xArcMhOOp8=; b=OLeBfT9ltM2uuK0mXxCvW+wOijmoVSo2cdIICdiy6LeYy1UNC2e0J19oTfHxeGIgq8 qLo0SduvrZx4ZaO644XOFLCta7Npzl4HedKQocpuOlFhFieA+aePNqmvF3iL6OwPPXdV /iHC9VIgv8JSYvnqYEABFo/YQih4PdRoL7EJf68zdePPYTQvmUUeJezXJDasTKXz+C8r k0bmIz/tnoeaKJNQSuzMMrdS0LwTSNdqaXYzC/8NodDeWwDDtBgAzPG6ztaO4YWSBJJJ fU0GYhrvbJSyGP0Rk8Vh9RXch1o2qRBYA1g/5gsNG7Ph00EewTdD2+hLVWy1aKMEP4iI m/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=AymvcgT2LoYM7otdAGXEtZKVpojvc1Wo4xArcMhOOp8=; b=NXT8Z1MulyLny+vO9Cw/iURGdj3Mi1QRvep/qBXoEtsspHuwcl7svAGyytvYre9YIV Wd25TUr5HsIhZApiTUZcArawds5t9axK7vfLw7HJ07BJdMtRjALyjb356rYkJekrdqb8 +rZZHUZ9iVfrJuUEGnsLLrPdUeMNLE24Uzi+J7tL+Z40bPaSKC7gn6boKYq+UIfDiZEo Osc3eTQuuVp1IZQ+9m63C8WZWvBPl7Xq4qIC4x7NuImfeikXNO0Q13aetNzSXbW1zNPF 3wwOO8StNKlTsoeiJaUeRit+W4npz4rQ+pAGMl+yWUoJuud2D9nQBf3USA7fo412MPay up4g== X-Gm-Message-State: AJcUukc1IREKille/1JYf6lretq0c4n+t3HitRg74rkuqBn65DKZDp7j uD04qB2xFhSqxfrUe3TWC86GZnUdd4M20079PP/IMuZpjTaBzg== X-Google-Smtp-Source: ALg8bN5L3PHHhaeqfo5KxHxvoZ/4iIT/QgbWOk+kE8UnpsFXCzZUlrqW8M5gVKKdy6TLNk7Q2RtsyEGxN0ApPDNuL/U= X-Received: by 2002:ac8:1712:: with SMTP id w18mr18798651qtj.76.1547880771091; Fri, 18 Jan 2019 22:52:51 -0800 (PST) MIME-Version: 1.0 From: Mathew Handugan Date: Fri, 18 Jan 2019 22:52:41 -0800 Message-ID: Content-Type: multipart/alternative; boundary="0000000000008417ed057fca13be" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::833 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Sat, 19 Jan 2019 05:35:14 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000008417ed057fca13be Content-Type: text/plain; charset="UTF-8" Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c causes accepted sockets to store 't as :host instead of the string-formatted peer IP address. This manifests as (process-contact proc) returning something like (t 55269) instead of the expected: ("192.168.2.13" 55269) my clumsy attempt at a simple example: (defun echo-server-filter (proc string) (print (format "%s %s" (process-contact proc) string))) (progn (setq echo-server-port 10000) (make-network-process :name "echo-server" :family 'ipv4 :service echo-server-port :filter 'echo-server-filter :sentinel 'echo-server-filter :server 't) (let ((client-process (open-network-stream "echo-client" "*echo-client*" "localhost" echo-server-port))) (process-send-string client-process "hello world\n") (sleep-for 1) (delete-process client-process)) (delete-process "echo-server") ) --0000000000008417ed057fca13be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c =C2=A0= causes accepted sockets to store 't as :host instead of the string-form= atted peer IP address.

This manifests as
=C2=A0(process-contact = proc)
returning something like
=C2=A0(t 55269)

instead of the = expected:
=C2=A0("192.168.2.13" 55269)

my clumsy attemp= t at a simple example:

(defun echo-server-filter (proc string) (prin= t (format "%s %s" (process-contact proc) string)))
(progn
= =C2=A0 (setq echo-server-port 10000)
=C2=A0 (make-network-process :name = "echo-server" :family 'ipv4 :service echo-server-port :filter= 'echo-server-filter :sentinel 'echo-server-filter :server 't)<= br>=C2=A0 (let ((client-process (open-network-stream "echo-client"= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"*echo-client*" "localhost= " echo-server-port)))
=C2=A0 =C2=A0 (process-send-string client-pro= cess "hello world\n")
=C2=A0 =C2=A0 (sleep-for 1)
=C2=A0 = =C2=A0 (delete-process client-process))
=C2=A0 (delete-process "ech= o-server")
=C2=A0 )


--0000000000008417ed057fca13be-- From unknown Fri Sep 05 11:00:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#34134: 27.0.50; process-contact for accepted sockets broken Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jan 2019 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34134 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mathew Handugan , Paul Eggert Cc: 34134@debbugs.gnu.org Received: via spool by 34134-submit@debbugs.gnu.org id=B34134.154840366317768 (code B ref 34134); Fri, 25 Jan 2019 08:08:01 +0000 Received: (at 34134) by debbugs.gnu.org; 25 Jan 2019 08:07:43 +0000 Received: from localhost ([127.0.0.1]:44476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmwWd-0004cW-4r for submit@debbugs.gnu.org; Fri, 25 Jan 2019 03:07:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmwWb-0004cK-PB for 34134@debbugs.gnu.org; Fri, 25 Jan 2019 03:07:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmwWW-0002rW-6m; Fri, 25 Jan 2019 03:07:36 -0500 Received: from [176.228.60.248] (port=4356 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gmwWV-0008VX-MJ; Fri, 25 Jan 2019 03:07:36 -0500 Date: Fri, 25 Jan 2019 10:07:32 +0200 Message-Id: <837eet6tyz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mathew Handugan on Fri, 18 Jan 2019 22:52:41 -0800) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Mathew Handugan > Date: Fri, 18 Jan 2019 22:52:41 -0800 > > Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c causes accepted sockets to store 't as :host > instead of the string-formatted peer IP address. > > This manifests as > (process-contact proc) > returning something like > (t 55269) > > instead of the expected: > ("192.168.2.13" 55269) Thanks. Paul, could you please take a look at this? From unknown Fri Sep 05 11:00:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mathew Handugan Subject: bug#34134: closed (Re: bug#34134: 27.0.50; process-contact for accepted sockets broken) Message-ID: References: <6edec1e6-bbbb-f55a-6b95-a5c068d91a35@cs.ucla.edu> X-Gnu-PR-Message: they-closed 34134 X-Gnu-PR-Package: emacs Reply-To: 34134@debbugs.gnu.org Date: Wed, 30 Jan 2019 23:14:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1548890043-4502-1" This is a multi-part message in MIME format... ------------=_1548890043-4502-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #34134: 27.0.50; process-contact for accepted sockets broken which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 34134@debbugs.gnu.org. --=20 34134: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34134 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1548890043-4502-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 34134-done) by debbugs.gnu.org; 30 Jan 2019 23:14:01 +0000 Received: from localhost ([127.0.0.1]:52023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1goz3Q-0001AI-K2 for submit@debbugs.gnu.org; Wed, 30 Jan 2019 18:14:00 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1goz3O-0001A5-H6 for 34134-done@debbugs.gnu.org; Wed, 30 Jan 2019 18:13:59 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0238A161095; Wed, 30 Jan 2019 15:13:53 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 4KNkwtRWdCLW; Wed, 30 Jan 2019 15:13:52 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1089C16112F; Wed, 30 Jan 2019 15:13:52 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4YUrt0aFfovh; Wed, 30 Jan 2019 15:13:51 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C91E8161092; Wed, 30 Jan 2019 15:13:51 -0800 (PST) Subject: Re: bug#34134: 27.0.50; process-contact for accepted sockets broken To: Eli Zaretskii , Mathew Handugan References: <837eet6tyz.fsf@gnu.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <6edec1e6-bbbb-f55a-6b95-a5c068d91a35@cs.ucla.edu> Date: Wed, 30 Jan 2019 15:13:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <837eet6tyz.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------FF28FD76AE92DB6CAE68E0B1" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34134-done Cc: 34134-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------FF28FD76AE92DB6CAE68E0B1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/25/19 12:07 AM, Eli Zaretskii wrote: >> From: Mathew Handugan >> Date: Fri, 18 Jan 2019 22:52:41 -0800 >> >> Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c causes accepted sockets to store 't as :host >> instead of the string-formatted peer IP address. >> >> This manifests as >> (process-contact proc) >> returning something like >> (t 55269) >> >> instead of the expected: >> ("192.168.2.13" 55269) > Thanks. Paul, could you please take a look at this? Thanks for reporting the bug, especially the test case. I reproduce the problem and fixed it by installing the attached patch into the emacs-26 branch on Savannah. --------------FF28FD76AE92DB6CAE68E0B1 Content-Type: text/x-patch; name="0001-Fix-process-contact-bug-with-TCP-connections.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-process-contact-bug-with-TCP-connections.patch" >From 16d92c9748fe0eb75ec20a1117700525538b5bd0 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 30 Jan 2019 15:11:17 -0800 Subject: [PATCH] Fix process-contact bug with TCP connections This fixes a regression from Emacs 25.3 (Bug#34134). * src/process.c (server_accept_connection): Set host correctly, fixing a bug introduced in 2017-09-16T21:29:18Z!eggert@cs.ucla.edu when working around a GCC bug. --- src/process.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/process.c b/src/process.c index 7f32150e8e..d8acd139c0 100644 --- a/src/process.c +++ b/src/process.c @@ -4724,19 +4724,24 @@ server_accept_connection (Lisp_Object server, int channel) service = Qnil; Lisp_Object args[11]; int nargs = 0; - AUTO_STRING (procname_format_in, "%s <%d.%d.%d.%d:%d>"); - AUTO_STRING (procname_format_in6, "%s <[%x:%x:%x:%x:%x:%x:%x:%x]:%d>"); + #define HOST_FORMAT_IN "%d.%d.%d.%d" + #define HOST_FORMAT_IN6 "%x:%x:%x:%x:%x:%x:%x:%x" + AUTO_STRING (host_format_in, HOST_FORMAT_IN); + AUTO_STRING (host_format_in6, HOST_FORMAT_IN6); + AUTO_STRING (procname_format_in, "%s <"HOST_FORMAT_IN":%d>"); + AUTO_STRING (procname_format_in6, "%s <["HOST_FORMAT_IN6"]:%d>"); AUTO_STRING (procname_format_default, "%s <%d>"); switch (saddr.sa.sa_family) { case AF_INET: { args[nargs++] = procname_format_in; - nargs++; + args[nargs++] = host_format_in; unsigned char *ip = (unsigned char *)&saddr.in.sin_addr.s_addr; service = make_number (ntohs (saddr.in.sin_port)); for (int i = 0; i < 4; i++) args[nargs++] = make_number (ip[i]); + host = Fformat (5, args + 1); args[nargs++] = service; } break; @@ -4745,11 +4750,12 @@ server_accept_connection (Lisp_Object server, int channel) case AF_INET6: { args[nargs++] = procname_format_in6; - nargs++; + args[nargs++] = host_format_in6; DECLARE_POINTER_ALIAS (ip6, uint16_t, &saddr.in6.sin6_addr); service = make_number (ntohs (saddr.in.sin_port)); for (int i = 0; i < 8; i++) args[nargs++] = make_number (ip6[i]); + host = Fformat (9, args + 1); args[nargs++] = service; } break; -- 2.20.1 --------------FF28FD76AE92DB6CAE68E0B1-- ------------=_1548890043-4502-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Jan 2019 10:35:18 +0000 Received: from localhost ([127.0.0.1]:37321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkny9-0005Nf-B7 for submit@debbugs.gnu.org; Sat, 19 Jan 2019 05:35:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkkV3-0008Ie-8D for submit@debbugs.gnu.org; Sat, 19 Jan 2019 01:53:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:33849) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkkUx-00029u-R0 for submit@debbugs.gnu.org; Sat, 19 Jan 2019 01:52:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkkUw-00074v-VA for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 01:52:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkkUw-00026U-5x for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 01:52:54 -0500 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:32992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkkUv-00024e-MC for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 01:52:54 -0500 Received: by mail-qt1-x833.google.com with SMTP id l11so17859631qtp.0 for ; Fri, 18 Jan 2019 22:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=handugan.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=AymvcgT2LoYM7otdAGXEtZKVpojvc1Wo4xArcMhOOp8=; b=OLeBfT9ltM2uuK0mXxCvW+wOijmoVSo2cdIICdiy6LeYy1UNC2e0J19oTfHxeGIgq8 qLo0SduvrZx4ZaO644XOFLCta7Npzl4HedKQocpuOlFhFieA+aePNqmvF3iL6OwPPXdV /iHC9VIgv8JSYvnqYEABFo/YQih4PdRoL7EJf68zdePPYTQvmUUeJezXJDasTKXz+C8r k0bmIz/tnoeaKJNQSuzMMrdS0LwTSNdqaXYzC/8NodDeWwDDtBgAzPG6ztaO4YWSBJJJ fU0GYhrvbJSyGP0Rk8Vh9RXch1o2qRBYA1g/5gsNG7Ph00EewTdD2+hLVWy1aKMEP4iI m/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=AymvcgT2LoYM7otdAGXEtZKVpojvc1Wo4xArcMhOOp8=; b=NXT8Z1MulyLny+vO9Cw/iURGdj3Mi1QRvep/qBXoEtsspHuwcl7svAGyytvYre9YIV Wd25TUr5HsIhZApiTUZcArawds5t9axK7vfLw7HJ07BJdMtRjALyjb356rYkJekrdqb8 +rZZHUZ9iVfrJuUEGnsLLrPdUeMNLE24Uzi+J7tL+Z40bPaSKC7gn6boKYq+UIfDiZEo Osc3eTQuuVp1IZQ+9m63C8WZWvBPl7Xq4qIC4x7NuImfeikXNO0Q13aetNzSXbW1zNPF 3wwOO8StNKlTsoeiJaUeRit+W4npz4rQ+pAGMl+yWUoJuud2D9nQBf3USA7fo412MPay up4g== X-Gm-Message-State: AJcUukc1IREKille/1JYf6lretq0c4n+t3HitRg74rkuqBn65DKZDp7j uD04qB2xFhSqxfrUe3TWC86GZnUdd4M20079PP/IMuZpjTaBzg== X-Google-Smtp-Source: ALg8bN5L3PHHhaeqfo5KxHxvoZ/4iIT/QgbWOk+kE8UnpsFXCzZUlrqW8M5gVKKdy6TLNk7Q2RtsyEGxN0ApPDNuL/U= X-Received: by 2002:ac8:1712:: with SMTP id w18mr18798651qtj.76.1547880771091; Fri, 18 Jan 2019 22:52:51 -0800 (PST) MIME-Version: 1.0 From: Mathew Handugan Date: Fri, 18 Jan 2019 22:52:41 -0800 Message-ID: Subject: 27.0.50; process-contact for accepted sockets broken To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000008417ed057fca13be" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::833 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 19 Jan 2019 05:35:14 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000008417ed057fca13be Content-Type: text/plain; charset="UTF-8" Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c causes accepted sockets to store 't as :host instead of the string-formatted peer IP address. This manifests as (process-contact proc) returning something like (t 55269) instead of the expected: ("192.168.2.13" 55269) my clumsy attempt at a simple example: (defun echo-server-filter (proc string) (print (format "%s %s" (process-contact proc) string))) (progn (setq echo-server-port 10000) (make-network-process :name "echo-server" :family 'ipv4 :service echo-server-port :filter 'echo-server-filter :sentinel 'echo-server-filter :server 't) (let ((client-process (open-network-stream "echo-client" "*echo-client*" "localhost" echo-server-port))) (process-send-string client-process "hello world\n") (sleep-for 1) (delete-process client-process)) (delete-process "echo-server") ) --0000000000008417ed057fca13be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c =C2=A0= causes accepted sockets to store 't as :host instead of the string-form= atted peer IP address.

This manifests as
=C2=A0(process-contact = proc)
returning something like
=C2=A0(t 55269)

instead of the = expected:
=C2=A0("192.168.2.13" 55269)

my clumsy attemp= t at a simple example:

(defun echo-server-filter (proc string) (prin= t (format "%s %s" (process-contact proc) string)))
(progn
= =C2=A0 (setq echo-server-port 10000)
=C2=A0 (make-network-process :name = "echo-server" :family 'ipv4 :service echo-server-port :filter= 'echo-server-filter :sentinel 'echo-server-filter :server 't)<= br>=C2=A0 (let ((client-process (open-network-stream "echo-client"= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"*echo-client*" "localhost= " echo-server-port)))
=C2=A0 =C2=A0 (process-send-string client-pro= cess "hello world\n")
=C2=A0 =C2=A0 (sleep-for 1)
=C2=A0 = =C2=A0 (delete-process client-process))
=C2=A0 (delete-process "ech= o-server")
=C2=A0 )


--0000000000008417ed057fca13be-- ------------=_1548890043-4502-1--