GNU bug report logs - #34123
A patch to fix reading EOF characters in non-interactive mode

Previous Next

Package: emacs;

Reported by: Shawn Presser <shawnpresser <at> gmail.com>

Date: Fri, 18 Jan 2019 10:48:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Shawn Presser <shawnpresser <at> gmail.com>, 34123 <at> debbugs.gnu.org
Subject: bug#34123: A patch to fix reading EOF characters in non-interactive mode
Date: Wed, 19 Aug 2020 12:57:18 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> And I think that's true?  It happens here in read_minibuf_noninteractive:
>
>   if (len || c == '\n' || c == '\r')
>     {
>       val = make_string (line, len);
>       xfree (line);
>     }
>   else
>     {
>       xfree (line);
>       error ("Error reading from stdin");
>     }
>
> So I think that error can only happen on an end-of-file?  Anybody
> objecting to changing that to and end-of-file error?

There were no objections, so I've now done this in Emacs 28.  (It didn't
seem NEWS-worthy, so I didn't add a NEWS item.)

Witch that change, I think Noam's approach to handling EOF characters in
non-interactive Emacsen should work fine, so I'm closing this bug
report.  If more work needs to be done here, please respond and we'll
reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 355 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.