From unknown Fri Jun 20 07:18:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34114 <34114@debbugs.gnu.org> To: bug#34114 <34114@debbugs.gnu.org> Subject: Status: 27.0.50: pdumper and themes with Emacs daemon Reply-To: bug#34114 <34114@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:20 +0000 retitle 34114 27.0.50: pdumper and themes with Emacs daemon reassign 34114 emacs submitter 34114 Karl Otness severity 34114 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 06:16:25 2019 Received: (at submit) by debbugs.gnu.org; 17 Jan 2019 11:16:25 +0000 Received: from localhost ([127.0.0.1]:34199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk5er-00015A-HE for submit@debbugs.gnu.org; Thu, 17 Jan 2019 06:16:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk5eo-00014w-Qv for submit@debbugs.gnu.org; Thu, 17 Jan 2019 06:16:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:59855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gk5ej-0003R2-JK for submit@debbugs.gnu.org; Thu, 17 Jan 2019 06:16:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk5ed-0004Ue-Px for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 06:16:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gk5ec-0003DH-5y for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 06:16:11 -0500 Received: from mail-it1-x129.google.com ([2607:f8b0:4864:20::129]:38810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gk5eb-0003Ar-R9 for bug-gnu-emacs@gnu.org; Thu, 17 Jan 2019 06:16:10 -0500 Received: by mail-it1-x129.google.com with SMTP id h65so625182ith.3 for ; Thu, 17 Jan 2019 03:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=gdMjvTP7ztUdTr4pDFo+xL0K/JK81BpEjldMMDElEmw=; b=j+yzBgV0CloE4+eoOwlK5JSmphtMJK/sugjPUvxk0CsAteaKemFjyhACUym6f5L51m TYzVNqYWHydkUBsrAodtaj+58J4k8eueHtCDfChkfUg80qgFeTivprqqvJXh979p6oPB y1vQ/0DTr6vxpnRmcEOUS7a/RIz936Pi1C92sDkK9MiCEzSSnNID19I2Z5N31uGvdj4i 0DXgituIDHkKi9oggjjIVLTIGXPmQY9vbx9sK7o0E2hJhnUVBVIrP/I6J6Av0+fsG5J4 X4kTPOMfBgt2J+hByNvK/iVhMKp7phd/vI1tcI6pGhR93BPrRyZN/UrdGM3e2xy7BkU0 aFmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=gdMjvTP7ztUdTr4pDFo+xL0K/JK81BpEjldMMDElEmw=; b=B8tbgql3qlSZ6Zop8BTPzgUmPdCwq3eryscIUvEm/zyuaqSJwFtsEGoy2lG9vmMunC x2GsTVv0//SzCu5lw4HLXv2tUN85DFGyBF2nb0SoYDqYef+rIw66SR4/7JvklKVSdf+3 92p/Oggdn6u6irhxmsxShqtBZWZAD/P+BM95IY9hoOgAeHm9YoCxjnyFQD/pn/1y1Qvp VP8kTWEAQmIIxUAs3AbO/MAc+WKfr0m6npWJvipvzOhpxD5B1HD7xx0nvLhwMXqvLpJa VKbW2iZ4gXlEsQxDs3HWw4F+WI9n/nMvHUCox0pQA9BS48LoHT5DNASVR2eYOwkoYLdZ 4SdQ== X-Gm-Message-State: AJcUukcnZjVKHdzQnjEaDuejXJMG7eJVCmUum+p4ohjimnOWzOzbfUQY BqRNYN+GE41X2pr/SpAtk4mqhYws2mw= X-Google-Smtp-Source: ALg8bN6j5UNe6czXqZAQW0hnJnYM/AmcSHGpqAv99lVaYcwG4+Vzp+GOZTW02Nhk+SU+WEHQLk+qag== X-Received: by 2002:a02:c891:: with SMTP id m17mr4627102jao.45.1547723768029; Thu, 17 Jan 2019 03:16:08 -0800 (PST) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com. [209.85.166.177]) by smtp.gmail.com with ESMTPSA id 79sm548579itx.11.2019.01.17.03.16.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 03:16:07 -0800 (PST) Received: by mail-it1-f177.google.com with SMTP id h193so608566ita.5 for ; Thu, 17 Jan 2019 03:16:06 -0800 (PST) X-Received: by 2002:a24:64b:: with SMTP id 72mr8023643itv.59.1547723766405; Thu, 17 Jan 2019 03:16:06 -0800 (PST) MIME-Version: 1.0 From: Karl Otness Date: Thu, 17 Jan 2019 11:15:54 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: 27.0.50: pdumper and themes with Emacs daemon To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::129 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I have some issues with theme loading with recent master (978cf88) in daemon mode. The problem seems to have been introduced with pdumper in d12e5d00. This is on an Arch Linux system. After starting an Emacs daemon I see messages about invalid faces: "face-attribute: Invalid face: tooltip". The error seems to be signaled from xfaces.c:1866 and called through `frame-notice-user-settings', and `frame-set-background-mode' all working with the initial frame F1. After connecting my first (graphical GTK) client some of my theme settings have not been applied. In my case, the default face is plain black text. Doing another manual `load-theme' fixes the settings. To reproduce with recent master, load a theme in init.el for example "(load-theme 'wombat)", start a new daemon (I was using fg-daemon) and connect a client. The messages buffer should have the error message. I manage to reproduce with an init.el that is just the `load-theme' call. I'm also getting a crash with `report-emacs-bug' that looks like bug#34051, so here are the features manually: "XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD JSON CANNOT_DUMP LCMS2 GMP" Thanks, Karl From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 15:02:10 2019 Received: (at 34114) by debbugs.gnu.org; 17 Jan 2019 20:02:10 +0000 Received: from localhost ([127.0.0.1]:35356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkDrd-00063a-P3 for submit@debbugs.gnu.org; Thu, 17 Jan 2019 15:02:10 -0500 Received: from mail-lj1-f179.google.com ([209.85.208.179]:44666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkDrb-000638-Ut for 34114@debbugs.gnu.org; Thu, 17 Jan 2019 15:02:08 -0500 Received: by mail-lj1-f179.google.com with SMTP id k19-v6so9617073lji.11 for <34114@debbugs.gnu.org>; Thu, 17 Jan 2019 12:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qa0B6qQ84BCa2gq9wViGtxLNKd3inkFf5L5b9UAFwiA=; b=YmwIy9DIpT1chCOnK4Hk2bmRzK5sZSicjD0e32o7bgr0uuK1i2hfSLDVEKaTWB8QUz XKWNs7yLCuP7rbS2JF5cyoCCuPDG18iY2UCL0f0iTZkLDitR83T/iCTJ1zKSj0nC2dWm mYEhFaiuESICp/n/8t82r8ZX5R61flfbzvUiMVcQqsjuEPISmUPvdW5/V0YVVCO67W6T BTHU0AlY2185U+5nFkRXlkeqH1Ljkpe3y3yIJUv7qrsONpz+fiQ+j+fr6UsFps90t/G4 U8YS7ElVjBhEjuBJawtXCuQiyhtWfwq3oKno/8AcD/PQmE50xra1F/8IevJtcEZIRD2Z YuUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qa0B6qQ84BCa2gq9wViGtxLNKd3inkFf5L5b9UAFwiA=; b=BnnEJxddd3k5/Lw9b/xW5Rvmsh4PjKHNYmPs1OjISe9WkCWMndtMFgpTL+xFMQnQtN w0+fUFu8owithWDvV7JIj2uF172gZGI6l6YHoa3HKl1mkJcqgRz9cYbxR2dGg/lH+FcG HFFqnDsCMUa+Xc1pSlTscpQTRlr+dixf5gJL3lu/C5NPTgpFR+DCRSmWx9F9s5YNStZw vqvm0kCdhp9wsbgaISZEupR68EKcrOlJaC5QCWYiGc2MNh9OOKDklS4p7scuc+PGUNgv lRruvZs3Ci8aBn0Vww+DB4clq0GsX6XumS3bXAOVce3b3nCqlHdxc8ngFpn6s8FuU7Xd AghQ== X-Gm-Message-State: AJcUukf1Q5gt6+5lc1cpVYbXDbgjRk0QTga6ATmEE4L4c+aOZEct9Kyn SB/Y1A9lMCVSl9Yaxo1aq/W0uaNZ1YrC1062ZnH+2rnh X-Google-Smtp-Source: ALg8bN578YJHTZrq0gUD2oM1s4v7aojmulNEeXiZQrGfesC/lP68K989bWfjZSejyB07cEQ5hLxZkbpmRwmztbra1Cc= X-Received: by 2002:a2e:5303:: with SMTP id h3-v6mr11046188ljb.35.1547755320818; Thu, 17 Jan 2019 12:02:00 -0800 (PST) MIME-Version: 1.0 From: Kaushal Modi Date: Thu, 17 Jan 2019 15:01:23 -0500 Message-ID: Subject: 27.0.50: pdumper and themes with Emacs daemon To: 34114@debbugs.gnu.org, Daniel Colascione Content-Type: multipart/alternative; boundary="00000000000018c8df057facde6e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000018c8df057facde6e Content-Type: text/plain; charset="UTF-8" Hello, I ended up on the exact same issue today which I reported on the devel mailing list: https://lists.gnu.org/r/emacs-devel/2019-01/msg00361.html. I'll be now tracking this issue here. Please CC me in all the replies. -- Kaushal Modi --00000000000018c8df057facde6e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I en= ded up on the exact same issue today which I reported on the devel mailing = list: https://lists.gnu.org/r/emacs-devel/2019-01/msg00361.html.
<= br>
I'll be now tracking this issue here. Please CC me in all= the replies.
--
Kaushal Modi
--00000000000018c8df057facde6e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 15:39:12 2019 Received: (at 34114) by debbugs.gnu.org; 17 Jan 2019 20:39:12 +0000 Received: from localhost ([127.0.0.1]:35364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkERT-0006sm-SL for submit@debbugs.gnu.org; Thu, 17 Jan 2019 15:39:12 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:46506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkERQ-0006sU-PO for 34114@debbugs.gnu.org; Thu, 17 Jan 2019 15:39:09 -0500 Received: by mail-lf1-f52.google.com with SMTP id y14so8817249lfg.13 for <34114@debbugs.gnu.org>; Thu, 17 Jan 2019 12:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=5nMI2UdfgGKF5oXXRMi1UeY927IVzME61ICBYMCJBpg=; b=Wo1cT5briZVpH0QHDX7fGiUA0OBjN0SCBOsnpGTbPNh2Ld32YJ2FNEXyom5jMnWSiL V2QISU89aHfJp08lTt8jaBN0RFKjK1BG/1dZ+caIUWz4+KEJ5HoisbQGkX9Px51Dkzdy 0fSkEqLzo0bgwQcygKf9B6q3rnnkZHPrzMLSVBSPRYIKaFG2dbrafeCibkVeVwLHtrGa Ym0OcpoyMf5Kc3VZx+gO1iwa2hS9nOqll3r8RLe42L43OM66K644Y9fDodrwoPth0hJv wyTJ1VzSpr4xkc2cBApcYOeJhIu35tL4l/PMaSJ3MD6Yh5ICDsRVfAOA5FYjx9klmFaP gKRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=5nMI2UdfgGKF5oXXRMi1UeY927IVzME61ICBYMCJBpg=; b=Dada6TkBmZ0lHZNePDquW/ac+wSuu9rRKXWGdGPeNORz0GMQ+AmOf8Ycd1tvotZawl qCCxCOUf95znGEm5Zcbj76sEkryzvfCHWRXnKSJVwLiPv3rbPUhPFMlnB7RPPKLk3GSj UGjojNDIU8v3B6WzH87B3xnIhPkpvuDUuqpkoOCXl8PcNfVSadb98b0SF28S1qAt9SNo pFltBK9rSrti4JII6NKLBy/E7jSg8cC3IMIn/A6LCi+zb/WsC9A2utHRjATzUNT+97LL wYum9Dba7otxq3QSbV8T1WUtj/F+AjE+J9qVuSPSvbkmSotQN1s5DQSEpEMCYQNUA9u9 4yng== X-Gm-Message-State: AJcUukeduZlBo3I5Ow424Qmbm4UohkAOlXk4s3K7dpe6+d8tZ3W5o1if PLxVYp6z5fTYXTLPstwzKyfPeEToNpJndLQnhV+hxjSg X-Google-Smtp-Source: ALg8bN52P6L4bbd4RSKDZHXurOWP8kafJrdSOvWEmv7sA4jV09QbhVn7q5lMadwUY3ofw9YD9rZFtFJDYDZK/mYgTi0= X-Received: by 2002:a19:a86:: with SMTP id 128mr10715242lfk.139.1547757542163; Thu, 17 Jan 2019 12:39:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kaushal Modi Date: Thu, 17 Jan 2019 15:38:25 -0500 Message-ID: Subject: Re: 27.0.50: pdumper and themes with Emacs daemon To: 34114@debbugs.gnu.org, Daniel Colascione Content-Type: multipart/alternative; boundary="0000000000007fcf08057fad623f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007fcf08057fad623f Content-Type: text/plain; charset="UTF-8" Hello Daniel, I am replying to your suggestion from https://lists.gnu.org/r/emacs-devel/2019-01/msg00372.html in this debbugs thread: > It's worth testing this sort of weirdness with --with-dumping=unexec too. I recompiled emacs master with --with-dumping=unexec added to configure. With that, my theme is loading correctly as before, and also that tooltip face warning went away. -- Kaushal Modi --0000000000007fcf08057fad623f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Daniel,
=

I am replying to your suggestion from https://lists.gnu.org/= r/emacs-devel/2019-01/msg00372.html in this debbugs thread:
<= br>
> It's worth testing this sort of weirdness with --wit= h-dumping=3Dunexec too.

I reco= mpiled emacs master with --with-dumping=3Dunexec added to configure.
<= div>
With that, my theme is loading correctly as before, and = also that tooltip face warning went away.

--<= br>Kaushal Modi
--0000000000007fcf08057fad623f-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 18:02:35 2019 Received: (at 34114) by debbugs.gnu.org; 18 Jan 2019 23:02:35 +0000 Received: from localhost ([127.0.0.1]:37150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkd9n-0005hp-FO for submit@debbugs.gnu.org; Fri, 18 Jan 2019 18:02:35 -0500 Received: from mail-io1-f50.google.com ([209.85.166.50]:33599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkd9l-0005hY-Cg for 34114@debbugs.gnu.org; Fri, 18 Jan 2019 18:02:33 -0500 Received: by mail-io1-f50.google.com with SMTP id t24so12172338ioi.0 for <34114@debbugs.gnu.org>; Fri, 18 Jan 2019 15:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i2wDRq75bbbCzepEfKdT6a2Q2a7f73H6CGZO1i7qcq0=; b=hNxvuNaFWVT7ZdhwMxD0zwS6JNYmcn0rjaGhkeHRl73yCqN7RTgzSrky5t7BLVqgK3 AskPKAGwJtF6/uw+nbxYlT4jqgHsh1hhVUknLoj01kqsPvz8I4z6Jex0DpTzS2uljH7G WmjX/5DrYLQVgVkHb3mY3onJMV7qe98W9BD37KEjAJifaVHe/4saSiNixFzd9jPDEBNe bbFjX0maNuHKEtcHEOE4CiKTBvHks/tKFVImrcV/4h9IPw6BjdPuUNta53uSMEd7XqNw MxtcunJvQjC/xJSYxZ3L8DZo06kEfazbUAIy7b2eaSpjbKaVX2kVel1dqz0IaOqBkKs6 Sl2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i2wDRq75bbbCzepEfKdT6a2Q2a7f73H6CGZO1i7qcq0=; b=p2vI8PP2UaTt3ascxHuPhAgTjxgd2MY3v0uW+yu0Zq6XIRIoA/YNeqNi8Wjxtr27Sp 2D81gUQv9iY9QByKwceYb0yEPO/tuoUf98Kw/ZkHAwU8exzu5UcBMU1xDBgt06z7X55c YGiFAV3uyPDSz7Il/m8kShn2zNGvk7z912eACx5EHTCE6n8tWOW7RnKtLR5HegReZ5ii taeIypIyaRsx4++hMKwYFkCWTFytvTxHDVCp9xF6/lUrvT7qbxVSB8s1NdYpj9dxpQQF g558PPIWlmaGvcNSg7sLY3QzkyPXw+0HmbFNQZ8xaKD1J7prMUeDXAwoqKMJyptPjapZ 5CzQ== X-Gm-Message-State: AJcUukf+jg87qEMOo/hwHdLDynmQykty9RPLqMSFgUx6X5PP9x40V3El gHhhrTouNZi0/m0H+F1ptPy2vz2weVA= X-Google-Smtp-Source: ALg8bN6HEN/HqlwyeSIl4z/YX86XrrPo8JsEHoW3ndq+FypOuo71T1kzpj74E4Y0/QtA9brQ2UZCtQ== X-Received: by 2002:a6b:dc18:: with SMTP id s24mr11106915ioc.139.1547852547269; Fri, 18 Jan 2019 15:02:27 -0800 (PST) Received: from mail-it1-f170.google.com (mail-it1-f170.google.com. [209.85.166.170]) by smtp.gmail.com with ESMTPSA id a18sm2837310itc.32.2019.01.18.15.02.26 for <34114@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 15:02:26 -0800 (PST) Received: by mail-it1-f170.google.com with SMTP id z7so9099210iti.0 for <34114@debbugs.gnu.org>; Fri, 18 Jan 2019 15:02:26 -0800 (PST) X-Received: by 2002:a02:6915:: with SMTP id e21mr12329206jac.142.1547852546111; Fri, 18 Jan 2019 15:02:26 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Karl Otness Date: Fri, 18 Jan 2019 23:02:14 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: 34114@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: Daniel Colascione , Kaushal Modi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think I have found a change that fixes this issue. I haven't tested it too thoroughly, but it seems to work for me. The change is to call init_faces_initial from init_display_interactive even when Emacs is running as daemon. In init_display_interactive in dispnew.c moving the lines: > /* Set up faces of the initial terminal frame. */ > if (!noninteractive && NILP (Vinitial_window_system)) > init_faces_initial (); from the end of the function so that they occur before the early return in the IS_DAEMON check (around line 6039) seems to fix the theme loading problem. Thanks, Karl From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 18:24:16 2019 Received: (at 34114) by debbugs.gnu.org; 18 Jan 2019 23:24:16 +0000 Received: from localhost ([127.0.0.1]:37161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkdUl-0006CJ-R3 for submit@debbugs.gnu.org; Fri, 18 Jan 2019 18:24:15 -0500 Received: from dancol.org ([96.126.100.184]:34500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkdUj-0006CA-GR for 34114@debbugs.gnu.org; Fri, 18 Jan 2019 18:24:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:In-Reply-To:Message-ID:Subject:Date; bh=GdUoG0FBzQUHClqM/C4vU0eZ59EKTXhDXWAkxXpVqK4=; b=K4mlFKWndYgplkW31r6kzTml5qSfR1fqtBPVLsGp048IvC5Rh+HZVjnPIs3IyRTyT15DdsfBIC3swsGn12YaqUxz+kSxBPsPcegfFjrg8phHKZsLZOwUED4fURs5RFpildVcPF0NLJYd1tu/vTzq4XnPZeHY2+x/I+GBVAgztEqQ2FicVGcIZf6Yg+sEoay1lX2Js9z3h229iIgdoJt/jk+JxxUocyEa6A82sQpXyUrRYCPm9xqvRXhqsutgnSdt4BHoa+9tuDNrXRvc65aIrMkkR4VdvjPpjXkDv+KmEJdWos9U7VukNcCgL/DMbZM/+h+2irfPnaABZHz4+XjnMw==; Received: from [2607:fb90:5443:9936:b42a:54d9:dd4a:257a] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gkdUg-00013X-R5; Fri, 18 Jan 2019 15:24:11 -0800 Date: Fri, 18 Jan 2019 18:23:33 -0500 Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon Message-ID: X-Android-Message-ID: In-Reply-To: From: Daniel Colascione To: Karl Otness Importance: Normal X-Priority: 3 X-MSMail-Priority: Normal MIME-Version: 1.0 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Looks reasonable to me. Want to install it? Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, Kaushal Modi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Looks reasonable to me. Want to install it? Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag PGRpdiBkaXI9J2F1dG8nPkxvb2tzIHJlYXNvbmFibGUgdG8gbWUuIFdhbnQgdG8gaW5zdGFsbCBp dD88L2Rpdj4= From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 18:37:55 2019 Received: (at 34114) by debbugs.gnu.org; 18 Jan 2019 23:37:55 +0000 Received: from localhost ([127.0.0.1]:37166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkdhz-0006VE-2Q for submit@debbugs.gnu.org; Fri, 18 Jan 2019 18:37:55 -0500 Received: from mail-io1-f53.google.com ([209.85.166.53]:43025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkdhx-0006V1-2v for 34114@debbugs.gnu.org; Fri, 18 Jan 2019 18:37:53 -0500 Received: by mail-io1-f53.google.com with SMTP id b23so12178178ios.10 for <34114@debbugs.gnu.org>; Fri, 18 Jan 2019 15:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u1eUfpP3K+BMcgz4/hmwUV9pkdFUymOzGO0ngTUqSaM=; b=qv4BZ4qmPpxdtZoRG6YOxY9uUBl1c6n0en7dJo+52oR/Wtr02l8mKx8JbU4stABQFV 2XbCfo8AhDppSsVrhnTJlK5mpi9T/A0FTPz4olPGy0x2eh3zieqfhMzCb4xrJicZKSJk I3h7+morGQd9vsKIgQy3asWG02z/FVpIdzZioyu3YVE+EeXqWTaNl/72xxn5tpkJvqx0 CujiopxYs2mZLTjURZ3Q+TQGunG/6l53xELiZYjF5DViDkv43pVGCVmIcFtXZBKqotxZ 7i78kk4FSumvuSnGKabITWHNgGymqHSEa+tp3pjDwLkIeA6chXFhxeHouAcEceYYwmn9 B+XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u1eUfpP3K+BMcgz4/hmwUV9pkdFUymOzGO0ngTUqSaM=; b=RDcfnCF/5fR7+Ill7tFxSqkJK+Dal3iBHKJew7VWwPukqUF0hsJ06WkCl/mpI8HXMB OUKq6AKM+Q9X6ZA1X8WHdiLg7khtMgTMNh+mjKPVIAOXbv64/BVJTm0dhCkIt0u8+LYZ n94PljUVrTRLpFT5YbuuRutQbbDdZoQF2Zhg8xeJg4KE/bPNaLlKODQ/KNpZSdEWldXO 3X15Z+GeDa+TUaVKnID5sDZ64HAkQHNfHbwyNzetFysU8bzp8YMnKpt8dLOLyoRtVxeo DuXQRzmFyh4Gl34Dr40wwRVZfqBr0ud2UQMnX29z0AcDNzm4ElkmgC6TEPjGNTuAO2ZV bDVw== X-Gm-Message-State: AJcUukeygAwWBvdBjwn0h0buhSaf2hSC63CT/QkWCNBJLCuuird3655d +eXsVXW8UkuYkZRmgcG8ojGUuEQsem8= X-Google-Smtp-Source: ALg8bN76ilLhN8MKHXyajF7Mbdjr6XGbfZBZqR0jdEVhzrqg4i1yJDY9rMKvrnm5zB9sMSfj7DfGTw== X-Received: by 2002:a6b:d803:: with SMTP id y3mr12254040iob.247.1547854666983; Fri, 18 Jan 2019 15:37:46 -0800 (PST) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com. [209.85.166.175]) by smtp.gmail.com with ESMTPSA id u126sm2751707ita.1.2019.01.18.15.37.45 for <34114@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 15:37:46 -0800 (PST) Received: by mail-it1-f175.google.com with SMTP id z7so9186267iti.0 for <34114@debbugs.gnu.org>; Fri, 18 Jan 2019 15:37:45 -0800 (PST) X-Received: by 2002:a24:64b:: with SMTP id 72mr12059986itv.59.1547854665578; Fri, 18 Jan 2019 15:37:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Karl Otness Date: Fri, 18 Jan 2019 23:37:33 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Daniel Colascione Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) If you could take care that I would appreciate it. I haven't done the copyright paperwork. Thanks, Karl On Fri, Jan 18, 2019 at 11:24 PM Daniel Colascione wrote: > > Looks reasonable to me. Want to install it? From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 18:50:23 2019 Received: (at 34114) by debbugs.gnu.org; 18 Jan 2019 23:50:23 +0000 Received: from localhost ([127.0.0.1]:37171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkdu3-0006ml-8w for submit@debbugs.gnu.org; Fri, 18 Jan 2019 18:50:23 -0500 Received: from dancol.org ([96.126.100.184]:34924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkdtz-0006ma-KY for 34114@debbugs.gnu.org; Fri, 18 Jan 2019 18:50:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:In-Reply-To:Message-ID:Subject:Date; bh=MTRvitC43a4P5wd5+FWFWPslXEDgATuV84YJt5bjUGE=; b=pWt+a3TJX8cTrL4cpu1aM+tOy9RK/xeWO5SE4VUA8bwRmizG/ZdqnJCcJ5LSxhtTTYssevy7t5AuEOTsUl7H3AH6UsvgjAbx8ubfIQAWvRFNGrgFlLJkY9hkh/wtiKHUUOlW23XAtW0uCwJvrRfJaJotDwtuAkAzzm2kW52YIF7fGNYlpLzkw+eiVBtmfTDCNlz6aMed5EYUvtc8qSmOJl3kkb8PUm6YIM9ofcTil2/Gi/TVxYhyglAibFLbYUPDm5L1xQ4e7e1HnifKqcpnQlorNnySiQSmn1E5ty4jV+KKLdPsuzsOowWMhcxQohuFQT7qHC1E+RANjEzCx89/ug==; Received: from [2607:fb90:5443:9936:b42a:54d9:dd4a:257a] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gkdtw-0001FJ-QN; Fri, 18 Jan 2019 15:50:17 -0800 Date: Fri, 18 Jan 2019 18:49:38 -0500 Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon Message-ID: <78748460-d8a4-47fb-8eec-cd97b1fdc0e2@email.android.com> X-Android-Message-ID: <78748460-d8a4-47fb-8eec-cd97b1fdc0e2@email.android.com> In-Reply-To: From: Daniel Colascione To: Karl Otness Importance: Normal X-Priority: 3 X-MSMail-Priority: Normal MIME-Version: 1.0 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Should fall under the de minimus exception to paperwork requirements Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Should fall under the de minimus exception to paperwork requirements Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag PGRpdiBkaXI9J2F1dG8nPlNob3VsZCBmYWxsIHVuZGVyIHRoZSBkZSBtaW5pbXVzIGV4Y2VwdGlv biB0byBwYXBlcndvcmsgcmVxdWlyZW1lbnRzPC9kaXY+ From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 19:09:40 2019 Received: (at 34114) by debbugs.gnu.org; 19 Jan 2019 00:09:40 +0000 Received: from localhost ([127.0.0.1]:37176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkeCh-0007Fq-V6 for submit@debbugs.gnu.org; Fri, 18 Jan 2019 19:09:40 -0500 Received: from mail-it1-f172.google.com ([209.85.166.172]:56140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkeCg-0007FR-0m for 34114@debbugs.gnu.org; Fri, 18 Jan 2019 19:09:38 -0500 Received: by mail-it1-f172.google.com with SMTP id m62so9228185ith.5 for <34114@debbugs.gnu.org>; Fri, 18 Jan 2019 16:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CDa1Sm4AgLvbPhMMDRGaJsBTabKV+M2X9okTE68cLe8=; b=f1vnKDfPZkSYAz9U6MvbvbKpfGz2h+8Y3F2K2HuWAybPltK93ODQzvwqTP8bvP36Di Rf+BjSlOElop4rvomGVWcODSloEqiE4VvqTIog+XhVvu3ZkfmBNI4MrOkBg8Vf+cFSgT DIVYaXSysE6Q75huJKQV+MOI52X2s1xYunHuImUR+d2nWBl5PCtSb3vqC88MhUIK4CLJ YNcvUprPNAuMSsy8yZCdEj+8VX6fxodylqmrewFI9LafOd5SxIWYk5pOXWu80KpeKhIJ NJ4jJH8lss1AmVpW58FdQimPmOGZ9kr36bs+mpSIMaugCnLL07Y2WJRrEAK69qujGNV+ sDYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CDa1Sm4AgLvbPhMMDRGaJsBTabKV+M2X9okTE68cLe8=; b=B/Wp7CVGyI5d7ljtWD0FnsMgCpN86raBYt4UlF7nH5/HmSm+RC5lYc6NZTGYUVkeWY RU6E4laYugBmvIT2bE7G9lyiWR2yLUUiI5ioGJzaMRwZnKlDap1k0HOaBGb37bMZI1c2 JDy09/us3izlv0PpTq/VZMBZRk8uOGaGWcAakQ3nT060jMT5Owm6o9olzxygB/C2JAsb cFnpYR0o2zi0LJaqg66Kpj9+ByHHiPTmgGZ8TN4Snw64fOH6Y9l0PFc6EwwHmbzZ9ZyU ZLnVspsIXoMWzNTTEpNtHTEaoMAlcstHBQMvFLBPGPwxD38o1hgn+XUugaGbfreBtVsI HjYg== X-Gm-Message-State: AJcUukftxpuGBrc/wnbh5nasB19Tc7srxbyHUQdKnNeXf1BtMF8dxd3K oP93Y86uzA5+fybya6OdLtGHcpoA08c= X-Google-Smtp-Source: ALg8bN5FRpxrfPlhvVp2kQZ10IHMX8ZaMGjQ+U1EqOb91eMcwJ/4HOk319GUpGmCBKTnG3JU6Y6u9Q== X-Received: by 2002:a24:5946:: with SMTP id p67mr12792400itb.46.1547856572148; Fri, 18 Jan 2019 16:09:32 -0800 (PST) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com. [209.85.166.44]) by smtp.gmail.com with ESMTPSA id r63sm13947432ita.2.2019.01.18.16.09.30 for <34114@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 16:09:31 -0800 (PST) Received: by mail-io1-f44.google.com with SMTP id m19so12239512ioh.3 for <34114@debbugs.gnu.org>; Fri, 18 Jan 2019 16:09:30 -0800 (PST) X-Received: by 2002:a6b:fd13:: with SMTP id c19mr11898119ioi.249.1547856570619; Fri, 18 Jan 2019 16:09:30 -0800 (PST) MIME-Version: 1.0 References: <78748460-d8a4-47fb-8eec-cd97b1fdc0e2@email.android.com> In-Reply-To: <78748460-d8a4-47fb-8eec-cd97b1fdc0e2@email.android.com> From: Karl Otness Date: Sat, 19 Jan 2019 00:09:18 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Daniel Colascione Content-Type: multipart/mixed; boundary="0000000000000e4423057fc4710c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000e4423057fc4710c Content-Type: text/plain; charset="UTF-8" I might have exhausted those limits as well with a few other changes. I've prepared and attached a patch that makes the change I described above, but I'm not sure if it can be installed as-is without the copyright paperwork. Thanks, Karl On Fri, Jan 18, 2019 at 11:50 PM Daniel Colascione wrote: > > Should fall under the de minimus exception to paperwork requirements --0000000000000e4423057fc4710c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Initialize-faces-in-daemon-mode-with-pdumper-Bug-341.patch" Content-Disposition: attachment; filename="0001-Initialize-faces-in-daemon-mode-with-pdumper-Bug-341.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jr2pp5b60 RnJvbSA2Yzg1MDYzODUxZjgzZTUxNTMyMDEzYTM1NGMwZjFjZTMyOWQwNzBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJsIE90bmVzcyA8a2FybEBrYXJsb3RuZXNzLmNvbT4KRGF0 ZTogRnJpLCAxOCBKYW4gMjAxOSAyMzo1Njo0NCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIEluaXRp YWxpemUgZmFjZXMgaW4gZGFlbW9uIG1vZGUgd2l0aCBwZHVtcGVyIChCdWcjMzQxMTQpCgoqIHNy Yy9kaXNwbmV3LmMgKGluaXRfZGlzcGxheV9pbnRlcmFjdGl2ZSk6IENhbGwgaW5pdF9mYWNlc19p bml0aWFsCmluIGRhZW1vbiBtb2RlLgotLS0KIHNyYy9kaXNwbmV3LmMgfCA4ICsrKystLS0tCiAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy9kaXNwbmV3LmMgYi9zcmMvZGlzcG5ldy5jCmluZGV4IDg4NzgzY2Q1ZGEuLjIyNmY0 NzMxY2QgMTAwNjQ0Ci0tLSBhL3NyYy9kaXNwbmV3LmMKKysrIGIvc3JjL2Rpc3BuZXcuYwpAQCAt NjAzMyw2ICs2MDMzLDEwIEBAIGluaXRfZGlzcGxheV9pbnRlcmFjdGl2ZSAodm9pZCkKICAgICB9 CiAjZW5kaWYgLyogU0lHV0lOQ0ggKi8KIAorICAvKiBTZXQgdXAgZmFjZXMgb2YgdGhlIGluaXRp YWwgdGVybWluYWwgZnJhbWUuICAqLworICBpZiAoIW5vbmludGVyYWN0aXZlICYmIE5JTFAgKFZp bml0aWFsX3dpbmRvd19zeXN0ZW0pKQorICAgIGluaXRfZmFjZXNfaW5pdGlhbCAoKTsKKwogICAv KiBJZiBydW5uaW5nIGFzIGEgZGFlbW9uLCBubyBuZWVkIHRvIGluaXRpYWxpemUgYW55IGZyYW1l cy90ZXJtaW5hbCwKICAgICAgZXhjZXB0IG9uIFdpbmRvd3MsIHdoZXJlIHdlIGF0IGxlYXN0IHdh bnQgdG8gaW5pdGlhbGl6ZSBpdC4gICovCiAjaWZuZGVmIFdJTkRPV1NOVApAQCAtNjE3NiwxMCAr NjE4MCw2IEBAIGluaXRfZGlzcGxheV9pbnRlcmFjdGl2ZSAodm9pZCkKICAgfQogCiAgIGNhbGN1 bGF0ZV9jb3N0cyAoWEZSQU1FIChzZWxlY3RlZF9mcmFtZSkpOwotCi0gIC8qIFNldCB1cCBmYWNl cyBvZiB0aGUgaW5pdGlhbCB0ZXJtaW5hbCBmcmFtZS4gICovCi0gIGlmICghbm9uaW50ZXJhY3Rp dmUgJiYgTklMUCAoVmluaXRpYWxfd2luZG93X3N5c3RlbSkpCi0gICAgaW5pdF9mYWNlc19pbml0 aWFsICgpOwogfQogCiB2b2lkCi0tIAoyLjIwLjEKCg== --0000000000000e4423057fc4710c-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 19 02:06:59 2019 Received: (at 34114) by debbugs.gnu.org; 19 Jan 2019 07:06:59 +0000 Received: from localhost ([127.0.0.1]:37246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkkiY-0000De-VC for submit@debbugs.gnu.org; Sat, 19 Jan 2019 02:06:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkkiX-0000DQ-20 for 34114@debbugs.gnu.org; Sat, 19 Jan 2019 02:06:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkkiR-0005r4-NN; Sat, 19 Jan 2019 02:06:51 -0500 Received: from [176.228.60.248] (port=3504 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gkkhm-000426-Km; Sat, 19 Jan 2019 02:06:51 -0500 Date: Sat, 19 Jan 2019 09:05:48 +0200 Message-Id: <83va2lazzn.fsf@gnu.org> From: Eli Zaretskii To: Karl Otness In-reply-to: (message from Karl Otness on Fri, 18 Jan 2019 23:02:14 +0000) Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Karl Otness > Date: Fri, 18 Jan 2019 23:02:14 +0000 > Cc: Kaushal Modi > > I think I have found a change that fixes this issue. I haven't tested > it too thoroughly, but it seems to work for me. The change is to call > init_faces_initial from init_display_interactive even when Emacs is > running as daemon. > > In init_display_interactive in dispnew.c moving the lines: > > > /* Set up faces of the initial terminal frame. */ > > if (!noninteractive && NILP (Vinitial_window_system)) > > init_faces_initial (); > > from the end of the function so that they occur before the early > return in the IS_DAEMON check (around line 6039) seems to fix the > theme loading problem. Thanks for identifying the code that's involved in this. However, I'm not yet sure the solution you propose is the correct one. The way the code is written, it relies on the faces of the initial frame to be initialized when Emacs is built, and then recorded in the dumped Emacs. With the pdumper approach, the record should be in the emacs.pdmp file, and I'd expect it to be restored from there. Why isn't this working? If we want to repeat this initialization in the daemon when it starts up, I'd like first to better understand the considerations for this kind of situations: when we should fix such problems by recording and restoring them to/from the dump file, and when we should run the initialization code anew in the dumped Emacs. The latter might mean we cause more trouble elsewhere, because a lot of the code that runs during startup expects stuff done in temacs to be available and ready to use, not recomputed anew. Daniel, can you comment on this aspect of the problem, including on the more general issue? In any case, if the proposed change is installed, it should not affect the unexeced Emacs, so it IMO should be conditioned on dumped_with_pdumper_p. Unexeced Emacs should continue behaving as it did before. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 21 18:00:00 2019 Received: (at 34114) by debbugs.gnu.org; 21 Jan 2019 23:00:00 +0000 Received: from localhost ([127.0.0.1]:40637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gliXw-0004gU-7y for submit@debbugs.gnu.org; Mon, 21 Jan 2019 18:00:00 -0500 Received: from dancol.org ([96.126.100.184]:37610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gliXs-0004gI-4Z for 34114@debbugs.gnu.org; Mon, 21 Jan 2019 17:59:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=N9sP/gu0zIsBsZHE9M3QSlfA9pqJkcV5wpcOF6pbbPo=; b=jC1npAsSb5yt5DAX9v6Vnhc6EyfDYT/JKBlmaiGEP+JcQ6ijZGCZKQFfdrhZSwNfRl7EqtAEG3qsDVrazdcB31RmkWH2i6JQ57YrRa/t+zp3ARE1MplQ/aUvdkHr4fr6zOU0M3aA4XxudOy26HWtPRTxVilnOBsh3L7NzUp+5sK4zFlgNK4q+EF+7IKqKw6JFkX5w1JNmtHappA4tAgQNDUTcMUn2DH201nafc2b3NaAVT5lbnaQUIz5Xy3OkaB9HrrPoJt3JDhaTpnJ0SWgI/6nkvfLr3ZcVfGokeENY5jc7TrTeBCWqKqfrRMs71BJfN3B2Npl8ZtePJmrphWskg==; Received: from [2604:4080:1321:9a00:281a:fe2d:5d87:d563] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gliXp-00070e-QC; Mon, 21 Jan 2019 14:59:53 -0800 Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Eli Zaretskii , Karl Otness References: <83va2lazzn.fsf@gnu.org> From: Daniel Colascione Message-ID: <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> Date: Mon, 21 Jan 2019 17:59:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <83va2lazzn.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/19/19 2:05 AM, Eli Zaretskii wrote: >> From: Karl Otness >> Date: Fri, 18 Jan 2019 23:02:14 +0000 >> Cc: Kaushal Modi >> >> I think I have found a change that fixes this issue. I haven't tested >> it too thoroughly, but it seems to work for me. The change is to call >> init_faces_initial from init_display_interactive even when Emacs is >> running as daemon. >> >> In init_display_interactive in dispnew.c moving the lines: >> >>> /* Set up faces of the initial terminal frame. */ >>> if (!noninteractive && NILP (Vinitial_window_system)) >>> init_faces_initial (); >> >> from the end of the function so that they occur before the early >> return in the IS_DAEMON check (around line 6039) seems to fix the >> theme loading problem. > > Thanks for identifying the code that's involved in this. > > However, I'm not yet sure the solution you propose is the correct > one. The way the code is written, it relies on the faces of the > initial frame to be initialized when Emacs is built, and then recorded > in the dumped Emacs. With the pdumper approach, the record should be > in the emacs.pdmp file, and I'd expect it to be restored from there. > > Why isn't this working? > > If we want to repeat this initialization in the daemon when it starts > up, I'd like first to better understand the considerations for this > kind of situations: when we should fix such problems by recording and > restoring them to/from the dump file, and when we should run the > initialization code anew in the dumped Emacs. The latter might mean > we cause more trouble elsewhere, because a lot of the code that runs > during startup expects stuff done in temacs to be available and ready > to use, not recomputed anew. > > Daniel, can you comment on this aspect of the problem, including on > the more general issue? > > In any case, if the proposed change is installed, it should not affect > the unexeced Emacs, so it IMO should be conditioned on > dumped_with_pdumper_p. Unexeced Emacs should continue behaving as it > did before. In general, we should try do as much work as possible in the initial dump, just as we do in unexeced Emacs. Frames, however, are special because we can't actually save and restore frames. Any frame object comes back, after pdumper load, as an all-nil object. Since faces are attached to frames, and since after pdumper load, we have all-new frames, we need to re-add the default faces. Kaushal's change seems like the right sort of fix. All of this is very confusing and we should probably totally rethink it after we remove unexec. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 22 11:29:43 2019 Received: (at 34114) by debbugs.gnu.org; 22 Jan 2019 16:29:43 +0000 Received: from localhost ([127.0.0.1]:41567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glyvm-0005MM-PY for submit@debbugs.gnu.org; Tue, 22 Jan 2019 11:29:42 -0500 Received: from mail-lf1-f46.google.com ([209.85.167.46]:39622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glyvl-0005M9-Hb for 34114@debbugs.gnu.org; Tue, 22 Jan 2019 11:29:42 -0500 Received: by mail-lf1-f46.google.com with SMTP id n18so18538717lfh.6 for <34114@debbugs.gnu.org>; Tue, 22 Jan 2019 08:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bbc0CAPnL3nJd/jMS+RbnqWCo5yD58IzjelSSGcvGac=; b=hqaAU8RkTHjiX8J3IbUogvvUtnGrJJF1Qw6188SnskdR4deXFljolCxDnUbb2N38rC T2MwvOjJq38gYAw8jmJpQu0Rggk2heFF8CQABB+y32fO9GlQz6zjbWyt2owU58djJUmj yTGd7C98sIFA7h4cqGpJzDIxh0lQwI3J9FKlPgno05pScPqt8KNO/CRZtB0Tf2xbpWEq jVJYPPxI7n1eNSN4rSyA8UPnTeu//ESZeLi7IzXu33y58QFQgWsONHGXY4cHeQZXGL6X 2XIQh+TzilnbOTRCRp1yTPazuBmN0zo/YzZzmTre7AfML61tXyZSp2W4CwW0wGVbOJ/4 QgZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bbc0CAPnL3nJd/jMS+RbnqWCo5yD58IzjelSSGcvGac=; b=BRUYhUX9FAxU+oRFo6s8VvQRrdxRoBK+B3PCpU4U+FIOfZArtZ6gWm+lnslxRZgqf7 1zEojbohzknuezYwTrcYKM5k9xg6/JCMHlEhIlQib9+WY3IXDmvyyTJpSf3FzTtMrn6f tFWf+RUIBafeARt/QFZV+jxrir7Zvr2Lc01pDlkt68ExNq1aZh1CIpjIBu2zCquGsE9f Af1K9XD7sqMqFHN11gY2maSUwzqwjNwl0rS+bxyEKG3HAWtXx/DSl85b9KaaNUaZU6LE WiXXE+mX2P5hDjnhWlbKWW+d7MC5YY8r0ynsKMwZ/oDfXoJ4zQQ1uIVOBjjhO6zZ9+/X UMPw== X-Gm-Message-State: AJcUukc47z4AgHtE7htoXG3REEiPBQ58wCIyPrg9pCjUVXTdcLHv3fdG ivMhU7QepVBR6X0aBrMceA2y0cIJRXegXs7aj1o= X-Google-Smtp-Source: ALg8bN50w/F22hFU1eagzYpY07ZRx+/MxUkCJ1nc+bGkwTRkJZqbbls7y9FGVssNqUjgL+BNo7NHod2B0Z/7UBZgRUU= X-Received: by 2002:a19:920a:: with SMTP id u10mr16286765lfd.122.1548174575189; Tue, 22 Jan 2019 08:29:35 -0800 (PST) MIME-Version: 1.0 References: <83va2lazzn.fsf@gnu.org> <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> In-Reply-To: <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> From: Kaushal Modi Date: Tue, 22 Jan 2019 11:28:57 -0500 Message-ID: Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Daniel Colascione Content-Type: multipart/alternative; boundary="0000000000009aca1505800e7be3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: Eli Zaretskii , 34114@debbugs.gnu.org, Karl Otness X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009aca1505800e7be3 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 21, 2019 at 5:59 PM Daniel Colascione wrote: Kaushal's change seems like > the right sort of fix. That was Karl :) I am simply using unexec for now. --0000000000009aca1505800e7be3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Jan 21, 2019 at 5:59 PM Daniel Colascione <dancol@dancol.org> wrote:

Kaushal's change seems lik= e
the right sort of fix.

That was Karl :)=C2= =A0

I am simply using unexec for now.
--0000000000009aca1505800e7be3-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 22 13:37:08 2019 Received: (at 34114) by debbugs.gnu.org; 22 Jan 2019 18:37:08 +0000 Received: from localhost ([127.0.0.1]:41591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm0v5-0001vS-Pg for submit@debbugs.gnu.org; Tue, 22 Jan 2019 13:37:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm0v3-0001us-Nb for 34114@debbugs.gnu.org; Tue, 22 Jan 2019 13:37:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm0ux-0007qy-Iu; Tue, 22 Jan 2019 13:36:59 -0500 Received: from [176.228.60.248] (port=4296 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1glzB5-0006YA-7O; Tue, 22 Jan 2019 11:45:31 -0500 Date: Tue, 22 Jan 2019 18:45:20 +0200 Message-Id: <8336pkabfj.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione In-reply-to: <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> (message from Daniel Colascione on Mon, 21 Jan 2019 17:59:46 -0500) Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon References: <83va2lazzn.fsf@gnu.org> <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Cc: 34114@debbugs.gnu.org, kaushal.modi@gmail.com > From: Daniel Colascione > Date: Mon, 21 Jan 2019 17:59:46 -0500 > > In general, we should try do as much work as possible in the initial > dump, just as we do in unexeced Emacs. Frames, however, are special > because we can't actually save and restore frames. Any frame object > comes back, after pdumper load, as an all-nil object. What is special about frames that precludes them from being recorded by the pdumper? Since the startup code is written under the assumption that a frame is available with some minimal functionality, I'm afraid this face issue could be the tip of a large iceberg. E.g., many customizations in users' .emacs files might stop working if we don't have an initial frame like we had in unexeced version. > All of this is very confusing and we should probably totally rethink > it after we remove unexec. I wholeheartedly agree. Unexec was invented to record loaded Lisp code, but with time it ended up accruing a lot of stuff that is only tangentially related to Lisp, or even not at all. However, rearranging all that and removing all the cruft we no longer need is a formidable job, so I think we should embark on that only after we have a reliable baseline, a pdumper version that works as well as the unexeced one. And it will take us some time to find and fix any remaining bugs and then become convinced that we've reached that goal. So I'd like first to have a pdumper version that works as close to the unexec version, and only after that start moving/removing the initialization code from temacs to emacs. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 22 20:41:45 2019 Received: (at 34114) by debbugs.gnu.org; 23 Jan 2019 01:41:45 +0000 Received: from localhost ([127.0.0.1]:41825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm7Y1-0003Ks-97 for submit@debbugs.gnu.org; Tue, 22 Jan 2019 20:41:45 -0500 Received: from dancol.org ([96.126.100.184]:59850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm7Xz-0003Kj-0w for 34114@debbugs.gnu.org; Tue, 22 Jan 2019 20:41:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=b63X3JcBYTikuhnrNhq6yKfMlDK256KS6NfYHK1SAV4=; b=avn0qbVnGpNsq7GDl2+xgJzfbrwCBCHuxlSfOhz7pvuzDGL4oxEhwMB3FBB9BkYA8NbNG7uKM9c1WnCguF/m614e/n83l/u+ANlRBRoW1+5meIJQ5goPzja4vpBQ70Z/3ggEXgRRhQpD4X/3eapDmyfVLZP2LdgbSS6A/FQTyD88uxClJPKIjMr0cRq7O790gLEIikq6Q5VsldXrC5VS3t47EcGnBAE/PVotp15Cq+ce6ZaF5JKZffaDxb9lyMLYyWK328PuVSX/OueTmO1H0+pELO10ssOMaXkVRKrkO2+YiSFxQDDHN2o3C54wQd8RvjQhdlCjervWFOTBs3miSA==; Received: from [2604:4080:1321:9a00:f455:12b4:e650:5d75] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gm7Xw-0005HW-C4; Tue, 22 Jan 2019 17:41:40 -0800 Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Eli Zaretskii References: <83va2lazzn.fsf@gnu.org> <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> <8336pkabfj.fsf@gnu.org> From: Daniel Colascione Message-ID: <8f223d05-fd50-4ea8-c92e-6dd574642175@dancol.org> Date: Tue, 22 Jan 2019 17:41:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <8336pkabfj.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/22/19 8:45 AM, Eli Zaretskii wrote: >> Cc: 34114@debbugs.gnu.org, kaushal.modi@gmail.com >> From: Daniel Colascione >> Date: Mon, 21 Jan 2019 17:59:46 -0500 >> >> In general, we should try do as much work as possible in the initial >> dump, just as we do in unexeced Emacs. Frames, however, are special >> because we can't actually save and restore frames. Any frame object >> comes back, after pdumper load, as an all-nil object. > > What is special about frames that precludes them from being recorded > by the pdumper? Frames contain instance-specific state, and I don't think it makes sense to try to pretend that individual frames survive from one Emacs invocation to another. We definitely want to record customizations that affect frames generally (like face definitions), but IMHO, we should do that in a way that doesn't depend on preserving any frame in particular. > Since the startup code is written under the > assumption that a frame is available with some minimal functionality, > I'm afraid this face issue could be the tip of a large iceberg. E.g., > many customizations in users' .emacs files might stop working if we > don't have an initial frame like we had in unexeced version. We do have an initial frame: we just make it anew when we start Emacs. When we set a face attribute, we set it for new frames as well by calling Finternal_set_lisp_face_attribute with frame being Qt, which ends up updating face-new-frame-defaults, which we do preserve in a pdumped image. If these defaults aren't being applied to frames we create after pdumper load, there's a bug. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 22 22:43:50 2019 Received: (at 34114) by debbugs.gnu.org; 23 Jan 2019 03:43:50 +0000 Received: from localhost ([127.0.0.1]:41846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm9SA-0006Ii-1c for submit@debbugs.gnu.org; Tue, 22 Jan 2019 22:43:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm9S7-0006IR-LC for 34114@debbugs.gnu.org; Tue, 22 Jan 2019 22:43:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm9Rz-00085R-RD; Tue, 22 Jan 2019 22:43:40 -0500 Received: from [176.228.60.248] (port=1277 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gm9Ry-00073q-FZ; Tue, 22 Jan 2019 22:43:39 -0500 Date: Wed, 23 Jan 2019 05:43:26 +0200 Message-Id: <83r2d482e9.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione In-reply-to: <8f223d05-fd50-4ea8-c92e-6dd574642175@dancol.org> (message from Daniel Colascione on Tue, 22 Jan 2019 17:41:34 -0800) Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon References: <83va2lazzn.fsf@gnu.org> <8604635d-af06-4ce6-320e-4f145c11bc37@dancol.org> <8336pkabfj.fsf@gnu.org> <8f223d05-fd50-4ea8-c92e-6dd574642175@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Cc: karl@karlotness.com, 34114@debbugs.gnu.org, kaushal.modi@gmail.com > From: Daniel Colascione > Date: Tue, 22 Jan 2019 17:41:34 -0800 > > > What is special about frames that precludes them from being recorded > > by the pdumper? > > Frames contain instance-specific state, and I don't think it makes sense > to try to pretend that individual frames survive from one Emacs > invocation to another. Sorry, I still don't think I understand: what is that instance-specific state, in terms of members of the frame object, or its attributes? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 22 23:05:51 2019 Received: (at 34114) by debbugs.gnu.org; 23 Jan 2019 04:05:51 +0000 Received: from localhost ([127.0.0.1]:41870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm9nS-0006uJ-Na for submit@debbugs.gnu.org; Tue, 22 Jan 2019 23:05:50 -0500 Received: from dancol.org ([96.126.100.184]:33680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm9nQ-0006uA-Pi for 34114@debbugs.gnu.org; Tue, 22 Jan 2019 23:05:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:In-Reply-To:Message-ID:Subject:Date; bh=fh5b8sXlsEl+Qx4MfRVXVWU3LMzjCAVjzk3Im1urBUw=; b=EMyahAqhD0t7DcHPwvrA6chcBbJ11dR4StJV7NNxnH/2PdRA3rfIq5oc5KWFBQkaXIj5j7zjAECiuCKM6Cm8SCOVXvpa9+9GTLAIX6f4B+3gcp0t1sjyGAuvNTKt5nqi+l6PPJiCLmfiyIXwhh+/41BWxYMlz7/g+bSzPkRAUUV3fj/vUc7kd8+APu9TEt/j3l3lg9TEJg5hSbjzw2ChkNLV3wGFSOLEYZy2+zgl6fAe3+uonCGoHnXGu0KHwT7CtKpY2cc2fOXORW89MDBHYWuelgTqSatQr/F7O1a0VANG4cKCvcS6nO06pp/k2dS0Ie29o0ZXOjxbTdOd9PrsLg==; Received: from [2607:fb90:8376:a485:92fe:90a8:be4e:d93c] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gm9nN-0005rV-0H; Tue, 22 Jan 2019 20:05:45 -0800 Date: Tue, 22 Jan 2019 20:05:40 -0800 Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon Message-ID: X-Android-Message-ID: In-Reply-To: <83r2d482e9.fsf@gnu.org> From: Daniel Colascione To: Eli Zaretskii Importance: Normal X-Priority: 3 X-MSMail-Priority: Normal MIME-Version: 1.0 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Jan 22, 2019 7:43 PM, Eli Zaretskii wrote: > Cc: karl@karlotness.com, 34114@debbugs.gnu.org, kaushal.modi@gmail.com > From: Daniel Colascione > Date: Tue, 22 Jan 2019 17:41:34 -0800 > > > What is special about frames that p [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.0 HTML_MESSAGE BODY: HTML included in message 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Jan 22, 2019 7:43 PM, Eli Zaretskii wrote: > Cc: karl@karlotness.com, 34114@debbugs.gnu.org, kaushal.modi@gmail.com > From: Daniel Colascione > Date: Tue, 22 Jan 2019 17:41:34 -0800 > > > What is special about frames that p [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.0 HTML_MESSAGE BODY: HTML included in message -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE PGRpdiBkaXI9J2F1dG8nPjxkaXY+PGJyPjxkaXYgY2xhc3M9ImdtYWlsX2V4dHJhIj48YnI+PGRp diBjbGFzcz0iZ21haWxfcXVvdGUiPk9uIEphbiAyMiwgMjAxOSA3OjQzIFBNLCBFbGkgWmFyZXRz a2lpICZsdDtlbGl6QGdudS5vcmcmZ3Q7IHdyb3RlOjxiciB0eXBlPSJhdHRyaWJ1dGlvbiI+PGJs b2NrcXVvdGUgY2xhc3M9InF1b3RlIiBzdHlsZT0ibWFyZ2luOjAgMCAwIC44ZXg7Ym9yZGVyLWxl ZnQ6MXB4ICNjY2Mgc29saWQ7cGFkZGluZy1sZWZ0OjFleCI+PHAgZGlyPSJsdHIiPiZndDsgQ2M6 IGthcmxAa2FybG90bmVzcy5jb20sIDM0MTE0QGRlYmJ1Z3MuZ251Lm9yZywga2F1c2hhbC5tb2Rp QGdtYWlsLmNvbQo8YnI+CiZndDsgRnJvbTogRGFuaWVsIENvbGFzY2lvbmUgJmx0O2RhbmNvbEBk YW5jb2wub3JnJmd0Owo8YnI+CiZndDsgRGF0ZTogVHVlLCAyMiBKYW4gMjAxOSAxNzo0MTozNCAt MDgwMAo8YnI+CiZndDsgCjxicj4KJmd0OyAmZ3Q7IFdoYXQgaXMgc3BlY2lhbCBhYm91dCBmcmFt ZXMgdGhhdCBwcmVjbHVkZXMgdGhlbSBmcm9tIGJlaW5nIHJlY29yZGVkCjxicj4KJmd0OyAmZ3Q7 IGJ5IHRoZSBwZHVtcGVyPwo8YnI+CiZndDsgCjxicj4KJmd0OyBGcmFtZXMgY29udGFpbiBpbnN0 YW5jZS1zcGVjaWZpYyBzdGF0ZSwgYW5kIEkgZG9uJ3QgdGhpbmsgaXQgbWFrZXMgc2Vuc2UgCjxi cj4KJmd0OyB0byB0cnkgdG8gcHJldGVuZCB0aGF0IGluZGl2aWR1YWwgZnJhbWVzIHN1cnZpdmUg ZnJvbSBvbmUgRW1hY3MgCjxicj4KJmd0OyBpbnZvY2F0aW9uIHRvIGFub3RoZXIuCjxicj4KCjxi cj4KU29ycnksIEkgc3RpbGwgZG9uJ3QgdGhpbmsgSSB1bmRlcnN0YW5kOiB3aGF0IGlzIHRoYXQK PGJyPgppbnN0YW5jZS1zcGVjaWZpYyBzdGF0ZSwgaW4gdGVybXMgb2YgbWVtYmVycyBvZiB0aGUg ZnJhbWUgb2JqZWN0LCBvcgo8YnI+Cml0cyBhdHRyaWJ1dGVzPwo8YnI+Cgo8L3A+PC9ibG9ja3F1 b3RlPjwvZGl2PjwvZGl2PjwvZGl2PjxkaXYgZGlyPSJhdXRvIj48YnI+PC9kaXY+PGRpdiBkaXI9 ImF1dG8iPkEgZnJhbWUgaXMgYWx3YXlzIGFzc29jaWF0ZWQgd2l0aCBhIHNwZWNpZmljIHB0eSwg c3BlY2lmaWMgWDExIHdpbmRvdywgc3BlY2lmaWMgd2luMzIgd2luZG93LCBldGMuIFRoZXNlIGNv bmNlcHRzIGRvIG5vdCBleGlzdCBhY3Jvc3MgZGlmZmVyZW50IGludm9jYXRpb25zIG9mIEVtYWNz LiBJIGRvbid0IHVuZGVyc3RhbmQgd2hhdCB5b3UgZG9uJ3QgdW5kZXJzdGFuZC4mbmJzcDs8L2Rp dj48ZGl2IGRpcj0iYXV0byI+PGRpdiBjbGFzcz0iZ21haWxfZXh0cmEiPjxkaXYgY2xhc3M9Imdt YWlsX3F1b3RlIj48YmxvY2txdW90ZSBjbGFzcz0icXVvdGUiIHN0eWxlPSJtYXJnaW46MCAwIDAg LjhleDtib3JkZXItbGVmdDoxcHggI2NjYyBzb2xpZDtwYWRkaW5nLWxlZnQ6MWV4Ij48cCBkaXI9 Imx0ciI+PGJyPgo8L3A+CjwvYmxvY2txdW90ZT48L2Rpdj48YnI+PC9kaXY+PC9kaXY+PC9kaXY+ From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 23 00:32:44 2019 Received: (at 34114) by debbugs.gnu.org; 23 Jan 2019 05:32:45 +0000 Received: from localhost ([127.0.0.1]:41897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmB9Y-0000te-Kd for submit@debbugs.gnu.org; Wed, 23 Jan 2019 00:32:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmB9W-0000tK-QU for 34114@debbugs.gnu.org; Wed, 23 Jan 2019 00:32:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmB9L-0004Wg-42; Wed, 23 Jan 2019 00:32:33 -0500 Received: from [176.13.6.54] (port=8226 helo=[10.130.42.54]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1gmB9I-0005kB-VR; Wed, 23 Jan 2019 00:32:30 -0500 Date: Wed, 23 Jan 2019 07:32:25 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Daniel Colascione From: Eli Zaretskii Message-ID: <92BA4FF9-C87A-4844-9114-7F716434681C@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On January 23, 2019 6:05:40 AM GMT+02:00, Daniel Colascione wrote: >=20 >=20 >=20 > On Jan 22, 2019 7:43 PM, Eli Zaretskii wrote: >=20 > > Cc: karl@karlotness=2Ecom, 34114@debbugs=2Egnu=2Eorg, > kaushal=2Emodi@gmail=2Ecom=20 > > From: Daniel Colascione =20 > > Date: Tue, 22 Jan 2019 17:41:34 -0800=20 > >=20 > > > What is special about frames that precludes them from being > recorded=20 > > > by the pdumper?=20 > >=20 > > Frames contain instance-specific state, and I don't think it makes > sense=20 > > to try to pretend that individual frames survive from one Emacs=20 > > invocation to another=2E=20 >=20 > Sorry, I still don't think I understand: what is that=20 > instance-specific state, in terms of members of the frame object, or=20 > its attributes?=20 >=20 >=20 > A frame is always associated with a specific pty, specific X11 window, > specific win32 window, etc=2E These concepts do not exist across > different invocations of Emacs=2E I don't understand what you don't > understand=2E=20 I didn't understand what you meant by "instance"=2E I think I do now -- y= ou mean output_method, output_data, and terminal members of struct frame? = If so, these are (trivially) figured out for the initial frame, they are se= t to special values=2E And we delete that initial frame during startup, as= soon as we can=2E So I don't think I understand the concerns=2E What spe= cific problems could be caused by retaining this initial frame? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 23 01:49:09 2019 Received: (at 34114) by debbugs.gnu.org; 23 Jan 2019 06:49:09 +0000 Received: from localhost ([127.0.0.1]:41915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmCLV-0002yM-8e for submit@debbugs.gnu.org; Wed, 23 Jan 2019 01:49:09 -0500 Received: from dancol.org ([96.126.100.184]:35946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmCLS-0002yD-9Q for 34114@debbugs.gnu.org; Wed, 23 Jan 2019 01:49:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:In-Reply-To:Message-ID:Subject:Date; bh=F/uQX6PEyxfx9a4FH8CEWhCi/TXj2ACX6pjPpfSh89Q=; b=khMfaJVmc3G30HXCSAHZWrgfjHcMT8NvOowogPQXWVMetMo4wcCEVspo6OxGD2ZjYSR2CAIYE+tJ6USCFfVXGrQOweGf66H+rpupBbQj/usZnCILQofYxgwhbBA/v6+gMK9o0u6/qr6O7GsChnUiTlCtzlUWzpuyXnv7xZEIJ865pah82jX8KKJ2FyeMQfT21kGUmYngDFNk4IBAEWUNBe+hWY/MBvN0b70TO9zRRL5CKs6FsrzBDHkY1JpV+ykBYaAkfdI/vbiMXJ5wswsqgIl/5s3C5qAREvH8k/RKxdyfjUuWBIsPo9oowXoimrr6ARKuIoRK51LeLEwVM5x6BQ==; Received: from [2607:fb90:364c:add7:9b53:ea98:90aa:bae0] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gmCLP-0006US-1J; Tue, 22 Jan 2019 22:49:03 -0800 Date: Tue, 22 Jan 2019 22:48:59 -0800 Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon Message-ID: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> X-Android-Message-ID: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> In-Reply-To: <92BA4FF9-C87A-4844-9114-7F716434681C@gnu.org> From: Daniel Colascione To: Eli Zaretskii Importance: Normal X-Priority: 3 X-MSMail-Priority: Normal MIME-Version: 1.0 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Jan 22, 2019 9:32 PM, Eli Zaretskii wrote: On January 23, 2019 6:05:40 AM GMT+02:00, Daniel Colascione wrote: > > > > On Jan 22, 2019 7:43 PM, Eli Zaretskii wrote: > > > Cc: karl@karlotness.com, 34114@debbugs [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.0 HTML_MESSAGE BODY: HTML included in message 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Jan 22, 2019 9:32 PM, Eli Zaretskii wrote: On January 23, 2019 6:05:40 AM GMT+02:00, Daniel Colascione wrote: > > > > On Jan 22, 2019 7:43 PM, Eli Zaretskii wrote: > > > Cc: karl@karlotness.com, 34114@debbugs [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.0 HTML_MESSAGE BODY: HTML included in message -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE PGRpdiBkaXI9J2F1dG8nPjxkaXY+PGJyPjxkaXYgY2xhc3M9ImdtYWlsX2V4dHJhIj48YnI+PGRp diBjbGFzcz0iZ21haWxfcXVvdGUiPk9uIEphbiAyMiwgMjAxOSA5OjMyIFBNLCBFbGkgWmFyZXRz a2lpICZsdDtlbGl6QGdudS5vcmcmZ3Q7IHdyb3RlOjxiciB0eXBlPSJhdHRyaWJ1dGlvbiI+PGJs b2NrcXVvdGUgY2xhc3M9InF1b3RlIiBzdHlsZT0ibWFyZ2luOjAgMCAwIC44ZXg7Ym9yZGVyLWxl ZnQ6MXB4ICNjY2Mgc29saWQ7cGFkZGluZy1sZWZ0OjFleCI+PHAgZGlyPSJsdHIiPk9uIEphbnVh cnkgMjMsIDIwMTkgNjowNTo0MCBBTSBHTVQrMDI6MDAsIERhbmllbCBDb2xhc2Npb25lICZsdDtk YW5jb2xAZGFuY29sLm9yZyZndDsgd3JvdGU6Cjxicj4KJmd0OyAKPGJyPgomZ3Q7IAo8YnI+CiZn dDsgCjxicj4KJmd0OyBPbiBKYW4gMjIsIDIwMTkgNzo0MyBQTSwgRWxpIFphcmV0c2tpaSAmbHQ7 ZWxpekBnbnUub3JnJmd0OyB3cm90ZToKPGJyPgomZ3Q7IAo8YnI+CiZndDsgJmd0OyBDYzoga2Fy bEBrYXJsb3RuZXNzLmNvbSwgMzQxMTRAZGViYnVncy5nbnUub3JnLAo8YnI+CiZndDsga2F1c2hh bC5tb2RpQGdtYWlsLmNvbSAKPGJyPgomZ3Q7ICZndDsgRnJvbTogRGFuaWVsIENvbGFzY2lvbmUg Jmx0O2RhbmNvbEBkYW5jb2wub3JnJmd0OyAKPGJyPgomZ3Q7ICZndDsgRGF0ZTogVHVlLCAyMiBK YW4gMjAxOSAxNzo0MTozNCAtMDgwMCAKPGJyPgomZ3Q7ICZndDsgCjxicj4KJmd0OyAmZ3Q7ICZn dDsgV2hhdCBpcyBzcGVjaWFsIGFib3V0IGZyYW1lcyB0aGF0IHByZWNsdWRlcyB0aGVtIGZyb20g YmVpbmcKPGJyPgomZ3Q7IHJlY29yZGVkIAo8YnI+CiZndDsgJmd0OyAmZ3Q7IGJ5IHRoZSBwZHVt cGVyPyAKPGJyPgomZ3Q7ICZndDsgCjxicj4KJmd0OyAmZ3Q7IEZyYW1lcyBjb250YWluIGluc3Rh bmNlLXNwZWNpZmljIHN0YXRlLCBhbmQgSSBkb24ndCB0aGluayBpdCBtYWtlcwo8YnI+CiZndDsg c2Vuc2UgCjxicj4KJmd0OyAmZ3Q7IHRvIHRyeSB0byBwcmV0ZW5kIHRoYXQgaW5kaXZpZHVhbCBm cmFtZXMgc3Vydml2ZSBmcm9tIG9uZSBFbWFjcyAKPGJyPgomZ3Q7ICZndDsgaW52b2NhdGlvbiB0 byBhbm90aGVyLiAKPGJyPgomZ3Q7IAo8YnI+CiZndDsgU29ycnksIEkgc3RpbGwgZG9uJ3QgdGhp bmsgSSB1bmRlcnN0YW5kOiB3aGF0IGlzIHRoYXQgCjxicj4KJmd0OyBpbnN0YW5jZS1zcGVjaWZp YyBzdGF0ZSwgaW4gdGVybXMgb2YgbWVtYmVycyBvZiB0aGUgZnJhbWUgb2JqZWN0LCBvciAKPGJy PgomZ3Q7IGl0cyBhdHRyaWJ1dGVzPyAKPGJyPgomZ3Q7IAo8YnI+CiZndDsgCjxicj4KJmd0OyBB IGZyYW1lIGlzIGFsd2F5cyBhc3NvY2lhdGVkIHdpdGggYSBzcGVjaWZpYyBwdHksIHNwZWNpZmlj IFgxMSB3aW5kb3csCjxicj4KJmd0OyBzcGVjaWZpYyB3aW4zMiB3aW5kb3csIGV0Yy4gVGhlc2Ug Y29uY2VwdHMgZG8gbm90IGV4aXN0IGFjcm9zcwo8YnI+CiZndDsgZGlmZmVyZW50IGludm9jYXRp b25zIG9mIEVtYWNzLiBJIGRvbid0IHVuZGVyc3RhbmQgd2hhdCB5b3UgZG9uJ3QKPGJyPgomZ3Q7 IHVuZGVyc3RhbmQuIAo8YnI+Cgo8YnI+CkkgZGlkbid0IHVuZGVyc3RhbmQgd2hhdCB5b3UgbWVh bnQgYnkgImluc3RhbmNlIi4mbmJzcDsgSSB0aGluayBJIGRvIG5vdyAtLSB5b3UgbWVhbiBvdXRw dXRfbWV0aG9kLCBvdXRwdXRfZGF0YSwgYW5kIHRlcm1pbmFsIG1lbWJlcnMgb2Ygc3RydWN0IGZy YW1lPyZuYnNwOyBJZiBzbywgdGhlc2UgYXJlICh0cml2aWFsbHkpIGZpZ3VyZWQgb3V0IGZvciB0 aGUgaW5pdGlhbCBmcmFtZSwgdGhleSBhcmUgc2V0IHRvIHNwZWNpYWwgdmFsdWVzLiZuYnNwOyBB bmQgd2UgZGVsZXRlIHRoYXQgaW5pdGlhbCBmcmFtZSBkdXJpbmcgc3RhcnR1cCwgYXMgc29vbiBh cyB3ZSBjYW4uJm5ic3A7IFNvIEkgZG9uJ3QgdGhpbmsgSSB1bmRlcnN0YW5kIHRoZSBjb25jZXJu cy4mbmJzcDsgV2hhdCBzcGVjaWZpYyBwcm9ibGVtcyBjb3VsZCBiZSBjYXVzZWQgYnkgcmV0YWlu aW5nIHRoaXMgaW5pdGlhbCBmcmFtZT8mbmJzcDs8L3A+PC9ibG9ja3F1b3RlPjwvZGl2PjwvZGl2 PjwvZGl2PjxkaXYgZGlyPSJhdXRvIj5XZSdkIHN0aWxsIG5lZWQgY29kZSB0byBzZXJpYWxpemUg ZnJhbWVzLiBBbmQgZm9yIHdoYXQ/IFdoYXQgd291bGQgd2UgZ2V0IHdpdGggdGhpcyBzY2hlbWU/ PC9kaXY+PGRpdiBkaXI9ImF1dG8iPjwvZGl2PjwvZGl2Pg== From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 24 10:12:10 2019 Received: (at 34114) by debbugs.gnu.org; 24 Jan 2019 15:12:10 +0000 Received: from localhost ([127.0.0.1]:44155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmgfq-0001cD-2g for submit@debbugs.gnu.org; Thu, 24 Jan 2019 10:12:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmgfo-0001bq-7j for 34114@debbugs.gnu.org; Thu, 24 Jan 2019 10:12:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmgfi-0008Mw-Oa; Thu, 24 Jan 2019 10:12:02 -0500 Received: from [176.228.60.248] (port=1244 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gmgfi-0003WH-CY; Thu, 24 Jan 2019 10:12:02 -0500 Date: Thu, 24 Jan 2019 17:11:56 +0200 Message-Id: <83lg3a6qf7.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione In-reply-to: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> (message from Daniel Colascione on Tue, 22 Jan 2019 22:48:59 -0800) Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon References: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, karl@karlotness.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Tue, 22 Jan 2019 22:48:59 -0800 > From: Daniel Colascione > Cc: karl@karlotness.com, 34114@debbugs.gnu.org, kaushal.modi@gmail.com > > We'd still need code to serialize frames. And for what? What would we get with this scheme? Smoother transition, perhaps? Anyway, I've compared the values of some important members of 'struct frame' after restoring from pdump, and didn't see any other problems. So Karl, could you please try the patch below, which is based on your idea, but with a quirk? And before you apply the patch, could you perhaps show C and Lisp backtraces from the errors you were seeing? I don't see those errors here when I try your recipe, and I'd like to better understand where the problem happens. Thanks. diff --git a/src/dispnew.c b/src/dispnew.c index 88783cd..1cafe29 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -6037,7 +6037,18 @@ init_display_interactive (void) except on Windows, where we at least want to initialize it. */ #ifndef WINDOWSNT if (IS_DAEMON) + { + /* Pdump'ed Emacs doesn't record the initial frame from temacs, + so the non-basic faces realized for that frame in temacs + aren't in emacs. This causes errors when users try to + customize those faces in their init file. The call to + init_faces_initial will realize these faces now. (Non-daemon + Emacs does this either near the end of this function or when + the GUI frame is created.) */ + if (dumped_with_pdumper_p ()) + init_faces_initial (); return; + } #endif /* If the user wants to use a window system, we shouldn't bother From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 24 14:22:58 2019 Received: (at 34114) by debbugs.gnu.org; 24 Jan 2019 19:22:59 +0000 Received: from localhost ([127.0.0.1]:44300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmkaY-00031z-DR for submit@debbugs.gnu.org; Thu, 24 Jan 2019 14:22:58 -0500 Received: from mail-io1-f41.google.com ([209.85.166.41]:38079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmkaU-00031i-9A for 34114@debbugs.gnu.org; Thu, 24 Jan 2019 14:22:55 -0500 Received: by mail-io1-f41.google.com with SMTP id l14so5715181ioj.5 for <34114@debbugs.gnu.org>; Thu, 24 Jan 2019 11:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IUIzPiNGzsOq5SHrVwOvn5wKB/aePhRJdbPv/MAOSxY=; b=0n1LDYHSEGlwj38FZhVVlQKZ5MwgutssaTaglVQbh4lhZhe5m9O1w+XWItSZzfQpWr Y64jQfNltjaufnR1wbd/fPcpfBAhNYRqqlU403UgCcWaKNoFwP2vvl+hXVx04aWLqssP q7gs9I+oBl50BTXbbcK540lnuQ6GXFB9IOpdOROCAiS+k/iXXIssCWztBxLm2YbDGe6a EXfc9VYLvma6oyLh373cfVoxYTBeopw+uyQjTHgC70jUD30g7jcuRFuS046u2nOZ5T5K cDlSXUzoR8iEMYQkWR4BOjaPZK9ZOsg7hGL1tFz6TuU1kEgg9QLt+vGLaoQiMS9PAMal tYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IUIzPiNGzsOq5SHrVwOvn5wKB/aePhRJdbPv/MAOSxY=; b=sS68rs79w9PhDid3Zvqv9k46bYzWmoiQhv0IZjDD8kKnzdd3Sxnclf/rgwgyKjES2s rtfchm6YSw7BXfrspmc40Ld9BsGN7gh+IIdTMTZxMd5g0O74hp6KL+jdtnigOYkQzhUd YFeiQ1i7LsdNTP+gwCTmF2Evobcs+6ZoUZ7sCzygXE8F98Or0bWeMF4O82U9nVy/ovMY Np7NxPvrJErZeTOANaBew0DZJZsT0Gl7tAivOLdN+SeigFYV5GsBf6ZIa0dcu/VUTlDV 8AyVmMes5+xxsnXdwIjfbyDbkpLNZnlAsBtHB53yKB1eMFX0xXLG64zjUOOWv5cyk5c4 cpZQ== X-Gm-Message-State: AJcUukcn2ADbhiNrFu+6zArXc31j8Pzr/+rXmsMHE0R4rflEXns5joGz G7noiQGyalrwHtgqSrYOUr1fgNadq2s= X-Google-Smtp-Source: AHgI3IYvwONFU7ADyzozNItxR/bajoWKocf0cc16Qm/myuJ20YB/HfQcoCHnVrxwrLV2MmXJaHNYPA== X-Received: by 2002:a5e:9e4a:: with SMTP id j10mr5403046ioq.165.1548357768037; Thu, 24 Jan 2019 11:22:48 -0800 (PST) Received: from mail-it1-f171.google.com (mail-it1-f171.google.com. [209.85.166.171]) by smtp.gmail.com with ESMTPSA id b25sm9117880iot.10.2019.01.24.11.22.46 for <34114@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 11:22:47 -0800 (PST) Received: by mail-it1-f171.google.com with SMTP id h193so6170038ita.5 for <34114@debbugs.gnu.org>; Thu, 24 Jan 2019 11:22:46 -0800 (PST) X-Received: by 2002:a24:a507:: with SMTP id k7mr2049284itf.98.1548357766299; Thu, 24 Jan 2019 11:22:46 -0800 (PST) MIME-Version: 1.0 References: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> <83lg3a6qf7.fsf@gnu.org> In-Reply-To: <83lg3a6qf7.fsf@gnu.org> From: Karl Otness Date: Thu, 24 Jan 2019 19:22:34 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114 Cc: 34114@debbugs.gnu.org, Daniel Colascione , Kaushal Modi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jan 24, 2019 at 3:12 PM Eli Zaretskii wrote: > So Karl, could you please try the patch below, which is based on your > idea, but with a quirk? That patch seems to fix the issue for me. Thanks for taking a look at it. > And before you apply the patch, could you perhaps show C and Lisp > backtraces from the errors you were seeing? I don't see those errors > here when I try your recipe, and I'd like to better understand where > the problem happens. As far as backtraces, here's the output I get when running with my init file containing just "(toggle-debug-on-error)" and "(load-theme 'wombat t)"= : > Error: (error (error "Invalid face" tooltip)) > (internal-get-lisp-face-attribute tooltip :family #) > (face-attribute tooltip :family #) > (face-attr-match-p tooltip (:inherit variable-pitch) #) > (frame-set-background-mode #) > (modify-frame-parameters nil ((menu-bar-lines . 1) (buried-buffer-list)= (buffer-list #) (unsplittable) (modeline . t) (width . 1= 0) (height . 9) (font . "tty") (background-color . "unspecified-bg") (foreg= round-color . "unspecified-fg"))) > (frame-notice-user-settings) > (#[0 "\11\203\10\0\306\11!\21\n\2042\0\13\2032\0\f\307\267\202'\0\310\3= 11\13!\312\"\210\313\314\13!!\315P\2021\0\314\316\317\13\320 \321 $!\22\15\= 204;\0\322\323\324\"\210\16!\204Q\0\16\"\203Q\0\16#\204Q\0\16\"\325=3D\203t= \0\16$\300=3D\204`\0\326\327\330\331\332 $\210\333\334!\203i\0\334 \210\333= \335!\203t\0\335\336 !\210\333\337!\203}\0\337 \210\15?\205\205\0\322\340!\= 207" [(("-cdac$" . 1.3)) default-directory auto-save-list-file-name auto-sa= ve-list-file-prefix system-type inhibit-startup-hooks abbreviate-file-name = #s(hash-table size 1 test eq rehash-size 1.5 rehash-threshold 0.8125 pureco= py t data (ms-dos 22)) make-directory file-name-directory t make-temp-name = expand-file-name "~" format "%s%d-%s~" emacs-pid system-name run-hooks emac= s-startup-hook term-setup-hook pc set-face-attribute default nil :font font= -spec fboundp frame-notice-user-settings frame-set-background-mode selected= -frame font-menu-add-default window-setup-hook frame-initial-frame initial-= window-system noninteractive face-font-rescale-alist] 6]) > (normal-top-level) The C backtrace is mostly just funcalls, but this is what I get from a breakpoint at xfaces.c:1866 which I think is where the actual error is signaled. > #0 0x00005555556b2764 in lface_from_face_name_no_resolve (f=3D0x555555e7= 6a30, face_name=3D..., signal_p=3Dtrue) at xfaces.c:1866 > #1 0x00005555556b27cb in lface_from_face_name (f=3D0x555555e76a30, face_= name=3D..., signal_p=3Dtrue) at xfaces.c:1884 > #2 0x00005555556b7acd in Finternal_get_lisp_face_attribute (symbol=3D...= , keyword=3D..., frame=3D...) at xfaces.c:3731 > #3 0x00005555557e9df7 in funcall_subr (subr=3D0x555555d6e7e0 , numargs=3D3, args=3D0x7fffffffbe10) at eval.c:294= 0 > #4 0x00005555557e98b7 in Ffuncall (nargs=3D4, args=3D0x7fffffffbe08) at = eval.c:2860 > #5 0x000055555583e47d in exec_byte_code (bytestr=3D..., vector=3D..., ma= xdepth=3D..., args_template=3D..., nargs=3D3, args=3D0x7fffffffc328) at byt= ecode.c:633 > #6 0x00005555557ea4e7 in funcall_lambda (fun=3D..., nargs=3D3, arg_vecto= r=3D0x7fffffffc310) at eval.c:3058 > #7 0x00005555557e98fb in Ffuncall (nargs=3D4, args=3D0x7fffffffc308) at = eval.c:2862 > #8 0x000055555583e47d in exec_byte_code (bytestr=3D..., vector=3D..., ma= xdepth=3D..., args_template=3D..., nargs=3D3, args=3D0x7fffffffc890) at byt= ecode.c:633 > #9 0x00005555557ea4e7 in funcall_lambda (fun=3D..., nargs=3D3, arg_vecto= r=3D0x7fffffffc878) at eval.c:3058 > #10 0x00005555557e98fb in Ffuncall (nargs=3D4, args=3D0x7fffffffc870) at = eval.c:2862 > #11 0x000055555583e47d in exec_byte_code (bytestr=3D..., vector=3D..., ma= xdepth=3D..., args_template=3D..., nargs=3D1, args=3D0x7fffffffce00) at byt= ecode.c:633 > #12 0x00005555557ea4e7 in funcall_lambda (fun=3D..., nargs=3D1, arg_vecto= r=3D0x7fffffffcdf8) at eval.c:3058 > #13 0x00005555557e98fb in Ffuncall (nargs=3D2, args=3D0x7fffffffcdf0) at = eval.c:2862 > #14 0x00005555557e90ab in call1 (fn=3D..., arg1=3D...) at eval.c:2711 > #15 0x00005555556b70b9 in update_face_from_frame_parameter (f=3D0x555555e= 76a30, param=3D..., new_value=3D...) at xfaces.c:3398 > #16 0x00005555555abead in Fmodify_frame_parameters (frame=3D..., alist=3D= ...) at frame.c:3236 > #17 0x00005555557e9dcb in funcall_subr (subr=3D0x555555d69ea0 , numargs=3D2, args=3D0x7fffffffd0d8) at eval.c:2937 > #18 0x00005555557e98b7 in Ffuncall (nargs=3D3, args=3D0x7fffffffd0d0) at = eval.c:2860 > #19 0x000055555583e47d in exec_byte_code (bytestr=3D..., vector=3D..., ma= xdepth=3D..., args_template=3D..., nargs=3D0, args=3D0x7fffffffd820) at byt= ecode.c:633 > #20 0x00005555557ea4e7 in funcall_lambda (fun=3D..., nargs=3D0, arg_vecto= r=3D0x7fffffffd820) at eval.c:3058 > #21 0x00005555557e98fb in Ffuncall (nargs=3D1, args=3D0x7fffffffd818) at = eval.c:2862 > #22 0x000055555583e47d in exec_byte_code (bytestr=3D..., vector=3D..., ma= xdepth=3D..., args_template=3D..., nargs=3D0, args=3D0x7fffffffdd00) at byt= ecode.c:633 > #23 0x00005555557ea4e7 in funcall_lambda (fun=3D..., nargs=3D0, arg_vecto= r=3D0x7fffffffdd00) at eval.c:3058 > #24 0x00005555557e98fb in Ffuncall (nargs=3D1, args=3D0x7fffffffdcf8) at = eval.c:2862 > #25 0x000055555583d4f1 in bcall0 (f=3D...) at bytecode.c:328 > #26 0x00005555557ebb26 in do_one_unbind (this_binding=3D0x7fffffffdd80, u= nwinding=3Dtrue, bindflag=3DSET_INTERNAL_UNBIND) at eval.c:3504 > #27 0x00005555557ebfea in unbind_to (count=3D5, value=3D...) at eval.c:36= 31 > #28 0x000055555583e566 in exec_byte_code (bytestr=3D..., vector=3D..., ma= xdepth=3D..., args_template=3D..., nargs=3D0, args=3D0x7fffffffe3b0) at byt= ecode.c:653 > #29 0x00005555557ea4e7 in funcall_lambda (fun=3D..., nargs=3D0, arg_vecto= r=3D0x7fffffffe3b0) at eval.c:3058 > #30 0x00005555557ea152 in apply_lambda (fun=3D..., args=3D..., count=3D4)= at eval.c:2994 > #31 0x00005555557e812f in eval_sub (form=3D...) at eval.c:2373 > #32 0x00005555557e7428 in Feval (form=3D..., lexical=3D...) at eval.c:214= 7 > #33 0x000055555571afd4 in top_level_2 () at keyboard.c:1099 > #34 0x00005555557e5427 in internal_condition_case (bfun=3D0x55555571afb1 = , handlers=3D..., hfun=3D0x55555571a9a7 ) at eval.c= :1376 > #35 0x000055555571b01c in top_level_1 (ignore=3D...) at keyboard.c:1107 > #36 0x00005555557e488c in internal_catch (tag=3D..., func=3D0x55555571afd= 6 , arg=3D...) at eval.c:1139 > #37 0x000055555571aefb in command_loop () at keyboard.c:1068 > #38 0x000055555571a48e in recursive_edit_1 () at keyboard.c:714 > #39 0x000055555571a686 in Frecursive_edit () at keyboard.c:785 > #40 0x0000555555718244 in main (argc=3D2, argv=3D0x7fffffffe8c8) at emacs= .c:1902 Thanks again, Karl From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 26 05:22:47 2019 Received: (at 34114-done) by debbugs.gnu.org; 26 Jan 2019 10:22:47 +0000 Received: from localhost ([127.0.0.1]:45836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnL6s-0008By-Pa for submit@debbugs.gnu.org; Sat, 26 Jan 2019 05:22:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnL6q-0008Bk-Ee for 34114-done@debbugs.gnu.org; Sat, 26 Jan 2019 05:22:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnL6j-0003gB-OV; Sat, 26 Jan 2019 05:22:37 -0500 Received: from [176.228.60.248] (port=3543 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gnL6j-0007ly-4W; Sat, 26 Jan 2019 05:22:37 -0500 Date: Sat, 26 Jan 2019 12:22:16 +0200 Message-Id: <83k1ir67mv.fsf@gnu.org> From: Eli Zaretskii To: Karl Otness In-reply-to: (message from Karl Otness on Thu, 24 Jan 2019 19:22:34 +0000) Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon References: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> <83lg3a6qf7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34114-done Cc: 34114-done@debbugs.gnu.org, dancol@dancol.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Karl Otness > Date: Thu, 24 Jan 2019 19:22:34 +0000 > Cc: Daniel Colascione , 34114@debbugs.gnu.org, > Kaushal Modi > > On Thu, Jan 24, 2019 at 3:12 PM Eli Zaretskii wrote: > > So Karl, could you please try the patch below, which is based on your > > idea, but with a quirk? > > That patch seems to fix the issue for me. Thanks for taking a look at it. Thanks, I installed it now. > > And before you apply the patch, could you perhaps show C and Lisp > > backtraces from the errors you were seeing? I don't see those errors > > here when I try your recipe, and I'd like to better understand where > > the problem happens. > > As far as backtraces, here's the output I get when running with my init > file containing just "(toggle-debug-on-error)" and "(load-theme 'wombat t)": Thanks for this and the C backtrace, I think I understand now what was the problem. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 27 13:41:06 2019 Received: (at 34114-done) by debbugs.gnu.org; 27 Jan 2019 18:41:06 +0000 Received: from localhost ([127.0.0.1]:47930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnpMg-0006Ae-Iq for submit@debbugs.gnu.org; Sun, 27 Jan 2019 13:41:06 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:40418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnpMf-0006A3-AG for 34114-done@debbugs.gnu.org; Sun, 27 Jan 2019 13:41:05 -0500 Received: by mail-lf1-f54.google.com with SMTP id v5so10248421lfe.7 for <34114-done@debbugs.gnu.org>; Sun, 27 Jan 2019 10:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wzwoq1sOK+B0rvtkJ2DJoIJpj8EPSsKU4ZTytrYAOII=; b=LXiRHKqtiOa5wLvWdoYFP6fLF2gcxDBjnjIM27DXsKgTSBazOXKd1T24e/ccCVV5RO GpgHfkM3mQRbvBLibKWS7XXiHnVc3G1lmjTlh5l7mzKqCbTELf169k1mAXgoQuybNPzD /dtuQ/PLZXLRllTP9z5ddjfrZLEiYhGotfKhqii3ImjPTlR3Vr8W02Hgqd8aTJLgzATq E7ZM+AxXhRcbbSAwQFXy2eukonFZ8qR+8odwZkL2mqWKQuxrMor2i0GOhrrnh1aKI97E Yh6QH6e5ONKItdEzJl/6pyQC/bonnHeLiUe5p0/T4yOG5UoX+qmVcnVBD4IN+V87liVe V2Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wzwoq1sOK+B0rvtkJ2DJoIJpj8EPSsKU4ZTytrYAOII=; b=Bu/+uZCVOrpK5t5+oVjvex3o1TkEWtF7TnXcIb3/EYL1kbZutrlo73RfpIwk2d4gQ6 n38bhpL3kheQgElJJqkU2qSC55CWx05WZGvEk1W2bww2kPBq0QKEYmzkih1uD2LuAIHp wpVSXrOZPw1wQDnlAxe3M8+gppP5gApwt6AAv0AmPhC5pRCFjsiqV1E1DBw4KL4Bmrfo l0m5lfYxJIsyTCBcAqS+2sI4mrdhWia0phaoIjWX3+ouHR44KuJ1kpE+CUIKEe4WpZDj HENjHbnLdAZsYYC6/7zy7XKmzxa9RBSPfLSd+uAh0yVBj+gv4VeehASKkPPf1rDYy4Yt nodQ== X-Gm-Message-State: AJcUuke/MsVK9zEBoS+FAWtqH0N/qI9SMKhsBW2GdWtsopN2TPG85ltK td9614Jty8lIg24H7Xr2EBWSlI1dF/dXBAYpVBg= X-Google-Smtp-Source: ALg8bN5vcafhFqjRIJsMQnFgugVJjBkprJvDi/5VOQHHOhAXuilyXDFsufGCY15GobQ+lkamiJd4y9tyodF+SU5B+Yc= X-Received: by 2002:a19:4f0c:: with SMTP id d12mr13009778lfb.121.1548614459106; Sun, 27 Jan 2019 10:40:59 -0800 (PST) MIME-Version: 1.0 References: <61329001-3288-47b4-ad82-de16ac532d12@email.android.com> <83lg3a6qf7.fsf@gnu.org> <83k1ir67mv.fsf@gnu.org> In-Reply-To: <83k1ir67mv.fsf@gnu.org> From: Kaushal Modi Date: Sun, 27 Jan 2019 13:40:22 -0500 Message-ID: Subject: Re: bug#34114: 27.0.50: pdumper and themes with Emacs daemon To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000bab111058074e680" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34114-done Cc: 34114-done@debbugs.gnu.org, Daniel Colascione , Karl Otness X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bab111058074e680 Content-Type: text/plain; charset="UTF-8" On Sat, Jan 26, 2019 at 5:22 AM Eli Zaretskii wrote: > > Thanks, I installed it now. > Thanks everyone! I updated Emacs from master and now my theme loads fine with the default pdumper option enabled. --000000000000bab111058074e680 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Jan 26, 2019 at 5:22 AM Eli Zaretskii <eliz@gnu.org> wrote:

Thanks, I installed it now.

Thanks ever= yone!

I updated Emacs from master and now my theme= loads fine with the default pdumper option enabled.
--000000000000bab111058074e680-- From unknown Fri Jun 20 07:18:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Feb 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator