GNU bug report logs - #34108
[PATCH] import: github: Use prereleases when package has no releases.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#34108: closed ([PATCH] import: github: Use prereleases when
 package has no releases.)
Date: Mon, 21 Jan 2019 12:37:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 21 Jan 2019 18:06:15 +0530
with message-id <cu7r2d6ur0g.fsf <at> systemreboot.net>
and subject line Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases.
has caused the debbugs.gnu.org bug report #34108,
regarding [PATCH] import: github: Use prereleases when package has no releases.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
34108: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34108
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Eric Bavier <ericbavier <at> centurylink.net>
Subject: [PATCH] import: github: Use prereleases when package has no releases.
Date: Thu, 17 Jan 2019 01:40:57 +0530

[Message part 3 (text/plain, inline)]

For github packages with only prereleases (that is, no releases), `guix
refresh PACKAGE` prints out the no-updater warning. This is incorrect
behavior. It should instead fall back to using preleases. This patch
fixes that.

For an example, see the package quaternion in (gnu packages messaging).

[0001-import-github-Use-prereleases-when-package-has-no-re.patch (text/x-patch, inline)]

From df660be0d7756b792a8356c7b02855cc327a7494 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac <at> systemreboot.net>
Date: Thu, 17 Jan 2019 01:34:07 +0530
Subject: [PATCH] import: github: Use prereleases when package has no releases.

* guix/import/github.scm (latest-released-version): Use preleases when package
has no releases.
---
 guix/import/github.scm | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/guix/import/github.scm b/guix/import/github.scm
index b287313d98..624b8c5a66 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -179,14 +179,16 @@ API. This may be fixed by using an access token and setting the environment
 variable GUIX_GITHUB_TOKEN, for instance one procured from
 https://github.com/settings/tokens"))
         (let loop ((releases
-                    (filter
-                     (lambda (x)
-                       ;; example pre-release:
-                       ;; https://github.com/wwood/OrfM/releases/tag/v0.5.1
-                       ;; or an all-prerelease set
-                       ;; https://github.com/powertab/powertabeditor/releases
-                       (not (hash-ref x "prerelease")))
-                     json)))
+                    (if (null?
+                         (filter
+                          (lambda (x)
+                            ;; example pre-release:
+                            ;; https://github.com/wwood/OrfM/releases/tag/v0.5.1
+                            ;; or an all-prerelease set
+                            ;; https://github.com/powertab/powertabeditor/releases
+                            (not (hash-ref x "prerelease")))
+                          json))
+                        json)))
           (match releases
             (()                                   ;empty release list
              #f)
-- 
2.19.2

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34108-done <at> debbugs.gnu.org, Eric Bavier <ericbavier <at> centurylink.net>
Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package
 has no releases.
Date: Mon, 21 Jan 2019 18:06:15 +0530

[Message part 7 (text/plain, inline)]

> Both LGTM, thanks for the cleanups!

Pushed, thanks for the review!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.