GNU bug report logs - #34108
[PATCH] import: github: Use prereleases when package has no releases.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Wed, 16 Jan 2019 20:12:01 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 34108 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 34108 <at> debbugs.gnu.org, Eric Bavier <ericbavier <at> centurylink.net>
Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package
 has no releases.
Date: Mon, 21 Jan 2019 10:44:15 +0100
Hello!

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

>> To improve readability, could you define a ‘pre-release?’ procedure so
>> we can write:
>>
>>   let ((releases (match (remove pre-release? json)
>>                    (() json)  ;keep everything
>>                    (releases releases))))
>
> I have made this change. In addition, I have also made another patch
> improving the readability of the function by using any and cond. Please
> find both patches attached.

Both LGTM, thanks for the cleanups!

Ludo’.




This bug report was last modified 6 years and 180 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.