Subject: bug#34108: closed (Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 21 Jan 2019 12:37:02 +0000

Your bug report

#34108: [PATCH] import: github: Use prereleases when package has no releases.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34108: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34108
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases.
From: Arun Isaac <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked], Eric Bavier <[email-masked]>
Date: Mon, 21 Jan 2019 18:06:15 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

> Both LGTM, thanks for the cleanups!

Pushed, thanks for the review!

Subject: [PATCH] import: github: Use prereleases when package has no releases.
From: Arun Isaac <[email-masked]>
To: [email-masked]
Cc: Eric Bavier <[email-masked]>
Date: Thu, 17 Jan 2019 01:40:57 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

For github packages with only prereleases (that is, no releases), `guix
refresh PACKAGE` prints out the no-updater warning. This is incorrect
behavior. It should instead fall back to using preleases. This patch
fixes that.

For an example, see the package quaternion in (gnu packages messaging).

From df660be0d7756b792a8356c7b02855cc327a7494 Mon Sep 17 00:00:00 2001
From: Arun Isaac <[email-masked]>
Date: Thu, 17 Jan 2019 01:34:07 +0530
Subject: [PATCH] import: github: Use prereleases when package has no releases.

* guix/import/github.scm (latest-released-version): Use preleases when package
has no releases.
---
 guix/import/github.scm | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/guix/import/github.scm b/guix/import/github.scm
index b287313d98..624b8c5a66 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -179,14 +179,16 @@ API. This may be fixed by using an access token and setting the environment
 variable GUIX_GITHUB_TOKEN, for instance one procured from
 https://github.com/settings/tokens"))
         (let loop ((releases
-                    (filter
-                     (lambda (x)
-                       ;; example pre-release:
-                       ;; https://github.com/wwood/OrfM/releases/tag/v0.5.1
-                       ;; or an all-prerelease set
-                       ;; https://github.com/powertab/powertabeditor/releases
-                       (not (hash-ref x "prerelease")))
-                     json)))
+                    (if (null?
+                         (filter
+                          (lambda (x)
+                            ;; example pre-release:
+                            ;; https://github.com/wwood/OrfM/releases/tag/v0.5.1
+                            ;; or an all-prerelease set
+                            ;; https://github.com/powertab/powertabeditor/releases
+                            (not (hash-ref x "prerelease")))
+                          json))
+                        json)))
           (match releases
             (()                                   ;empty release list
              #f)
-- 
2.19.2