From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 16 15:11:21 2019 Received: (at submit) by debbugs.gnu.org; 16 Jan 2019 20:11:21 +0000 Received: from localhost ([127.0.0.1]:33917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjrWz-0004bD-4c for submit@debbugs.gnu.org; Wed, 16 Jan 2019 15:11:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjrWx-0004b0-QJ for submit@debbugs.gnu.org; Wed, 16 Jan 2019 15:11:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:39380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gjrWs-0003Dc-K2 for submit@debbugs.gnu.org; Wed, 16 Jan 2019 15:11:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrWr-0005J8-KG for guix-patches@gnu.org; Wed, 16 Jan 2019 15:11:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_WEB autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjrWq-00033h-Lq for guix-patches@gnu.org; Wed, 16 Jan 2019 15:11:13 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:54304) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gjrWq-0002nn-6b for guix-patches@gnu.org; Wed, 16 Jan 2019 15:11:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=piBwaF9XLzV1cu8vvY6rs9U7lIapxNbodmnEjZpbh90=; b=m5K971kBslW/9Alwb8jFksAhZt 14PJYbWN0rpmcOY4MuV1K12pklIMEdGdeeS1bmb6yYwAMrbGdSfXbkjwWSi1PvF3IfVTb2pqi1q4G UQiU8/EWRavyE1Bu6pF0V8GuPHTBp92He4A1cu6U5QfIoWtX06oG99OfeV5RlECh5Qk4=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gjrWk-0006lF-VF; Thu, 17 Jan 2019 01:41:07 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] import: github: Use prereleases when package has no releases. Date: Thu, 17 Jan 2019 01:40:57 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 45.77.148.100 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: For github packages with only prereleases (that is, no releases), `guix refresh PACKAGE` prints out the no-updater warning. This is incorrect behavior. It should instead fall back to using preleases. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=arunisaac%40systemreboot.net; ip=209.51.188.92; r=debbugs.gnu.org] X-Debbugs-Envelope-To: submit Cc: Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: For github packages with only prereleases (that is, no releases), `guix refresh PACKAGE` prints out the no-updater warning. This is incorrect behavior. It should instead fall back to using preleases. [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=arunisaac%40systemreboot.net;ip=209.51.188.92;r=debbugs.gnu.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain For github packages with only prereleases (that is, no releases), `guix refresh PACKAGE` prints out the no-updater warning. This is incorrect behavior. It should instead fall back to using preleases. This patch fixes that. For an example, see the package quaternion in (gnu packages messaging). --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-import-github-Use-prereleases-when-package-has-no-re.patch Content-Transfer-Encoding: quoted-printable From=20df660be0d7756b792a8356c7b02855cc327a7494 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 17 Jan 2019 01:34:07 +0530 Subject: [PATCH] import: github: Use prereleases when package has no releas= es. * guix/import/github.scm (latest-released-version): Use preleases when pack= age has no releases. =2D-- guix/import/github.scm | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/guix/import/github.scm b/guix/import/github.scm index b287313d98..624b8c5a66 100644 =2D-- a/guix/import/github.scm +++ b/guix/import/github.scm @@ -179,14 +179,16 @@ API. This may be fixed by using an access token and s= etting the environment variable GUIX_GITHUB_TOKEN, for instance one procured from https://github.com/settings/tokens")) (let loop ((releases =2D (filter =2D (lambda (x) =2D ;; example pre-release: =2D ;; https://github.com/wwood/OrfM/releases/tag/v0.= 5.1 =2D ;; or an all-prerelease set =2D ;; https://github.com/powertab/powertabeditor/rel= eases =2D (not (hash-ref x "prerelease"))) =2D json))) + (if (null? + (filter + (lambda (x) + ;; example pre-release: + ;; https://github.com/wwood/OrfM/releases/tag/= v0.5.1 + ;; or an all-prerelease set + ;; https://github.com/powertab/powertabeditor/= releases + (not (hash-ref x "prerelease"))) + json)) + json))) (match releases (() ;empty release list #f) =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlw/j9IACgkQLiXui2GA K7N17wgAmfYlSFZmozIpxg36sqRydzA8PAXHiBKsvutVErmmUK3c/ty+QcruM0Ij rq1/Bt5bKtcFb5KqCi6YDim2X3HihHjsgx7ffcrzEl2zgV5UOeEmnlEFZtR95BFS euZgWLPozvvl86XM8Iqod1b4wIzL2IV+hkC7vGhVhzitHnXnq2rNgtRrlPHMwBzn uu2a9qcEvCOirPyEl4c58TeKFNQhS8fmXn8wvqZ7ua030K0AQNI+jrwUg9WcjbE5 tkpew8fxfPBTRZEDh670lVpXBMHbiPRPLrR47aTiwuvUdpCet/KCWp7Tdy2owoXP 6YV50OiEhB4pvT3vGDrd3E9+4P7JkA== =DsxX -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 18 10:55:35 2019 Received: (at 34108) by debbugs.gnu.org; 18 Jan 2019 15:55:35 +0000 Received: from localhost ([127.0.0.1]:36949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkWUZ-0008QZ-8x for submit@debbugs.gnu.org; Fri, 18 Jan 2019 10:55:35 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:42068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkWUY-0008QQ-0g for 34108@debbugs.gnu.org; Fri, 18 Jan 2019 10:55:34 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id BE9BF2598; Fri, 18 Jan 2019 16:55:32 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0gyQDqPSJs9s; Fri, 18 Jan 2019 16:55:32 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C819F2444; Fri, 18 Jan 2019 16:55:31 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Arun Isaac Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases. References: Date: Fri, 18 Jan 2019 16:55:31 +0100 In-Reply-To: (Arun Isaac's message of "Thu, 17 Jan 2019 01:40:57 +0530") Message-ID: <87h8e6rmdo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34108 Cc: 34108@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Arun Isaac skribis: > For github packages with only prereleases (that is, no releases), `guix > refresh PACKAGE` prints out the no-updater warning. This is incorrect > behavior. It should instead fall back to using preleases. This patch > fixes that. > > For an example, see the package quaternion in (gnu packages messaging). Makes sense. > From df660be0d7756b792a8356c7b02855cc327a7494 Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Thu, 17 Jan 2019 01:34:07 +0530 > Subject: [PATCH] import: github: Use prereleases when package has no rele= ases. > > * guix/import/github.scm (latest-released-version): Use preleases when pa= ckage > has no releases. > --- > guix/import/github.scm | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/guix/import/github.scm b/guix/import/github.scm > index b287313d98..624b8c5a66 100644 > --- a/guix/import/github.scm > +++ b/guix/import/github.scm > @@ -179,14 +179,16 @@ API. This may be fixed by using an access token and= setting the environment > variable GUIX_GITHUB_TOKEN, for instance one procured from > https://github.com/settings/tokens")) > (let loop ((releases > - (filter > - (lambda (x) > - ;; example pre-release: > - ;; https://github.com/wwood/OrfM/releases/tag/v0.= 5.1 > - ;; or an all-prerelease set > - ;; https://github.com/powertab/powertabeditor/rel= eases > - (not (hash-ref x "prerelease"))) > - json))) > + (if (null? > + (filter > + (lambda (x) > + ;; example pre-release: > + ;; https://github.com/wwood/OrfM/releases/ta= g/v0.5.1 > + ;; or an all-prerelease set > + ;; https://github.com/powertab/powertabedito= r/releases > + (not (hash-ref x "prerelease"))) > + json)) > + json))) To improve readability, could you define a =E2=80=98pre-release?=E2=80=99 p= rocedure so we can write: let ((releases (match (remove pre-release? json) (() json) ;keep everything (releases releases)))) OK with a change along these lines, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 20 15:17:44 2019 Received: (at 34108) by debbugs.gnu.org; 20 Jan 2019 20:17:44 +0000 Received: from localhost ([127.0.0.1]:39219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glJXM-0003XE-1P for submit@debbugs.gnu.org; Sun, 20 Jan 2019 15:17:44 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:47994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glJXJ-0003X5-1G for 34108@debbugs.gnu.org; Sun, 20 Jan 2019 15:17:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=riOrFaZvHBYedW0TcEgaTmCZ+B6ZTdJ6elFKnNd+uJE=; b=YcawF/3A1VtOVFEEVZRR7P3KW sAlCZavtdzYdKcubcH7XfW3N606A4OnucYkb7cDiCHfZwjLyFIsYlrOt8Fk1evokCjal23qWpMDZf kCoVitjaPRlwlCeVyFWRA5vNzpP+MCM8j/ylkphrskB2E5jQrW8GZcsuMXsXMuNOxueCU=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1glJXE-0002TS-4N; Mon, 21 Jan 2019 01:47:37 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases. In-Reply-To: <87h8e6rmdo.fsf@gnu.org> References: <87h8e6rmdo.fsf@gnu.org> Date: Mon, 21 Jan 2019 01:47:28 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > To improve readability, could you define a ‘pre-release?’ procedure so > we can write: > > let ((releases (match (remove pre-release? json) > (() json) ;keep everything > (releases releases)))) Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] X-Debbugs-Envelope-To: 34108 Cc: 34108@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > To improve readability, could you define a =E2=80=98pre-release?=E2=80=99= procedure so > we can write: > > let ((releases (match (remove pre-release? json) > (() json) ;keep everything > (releases releases)))) I have made this change. In addition, I have also made another patch improving the readability of the function by using any and cond. Please find both patches attached. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-import-github-Use-prereleases-when-package-has-no-re.patch Content-Transfer-Encoding: quoted-printable From=20f4347eaf3f4516a40bba563a3ec56a7d6b16b7fb Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 17 Jan 2019 01:34:07 +0530 Subject: [PATCH 1/2] import: github: Use prereleases when package has no releases. * guix/import/github.scm (latest-released-version): Use preleases when pack= age has no releases. =2D-- guix/import/github.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/guix/import/github.scm b/guix/import/github.scm index e17ef0b840..c78469dac5 100644 =2D-- a/guix/import/github.scm +++ b/guix/import/github.scm @@ -171,6 +171,9 @@ empty list." "Return a string of the newest released version name given a string URL = like 'https://github.com/arq5x/bedtools2/archive/v2.24.0.tar.gz' and the name of the package e.g. 'bedtools2'. Return #f if there is no releases" + (define (pre-release? x) + (hash-ref x "prerelease")) + (let* ((json (fetch-releases-or-tags url))) (if (eq? json #f) (if (%github-token) @@ -181,14 +184,9 @@ API. This may be fixed by using an access token and se= tting the environment variable GUIX_GITHUB_TOKEN, for instance one procured from https://github.com/settings/tokens")) (let loop ((releases =2D (filter =2D (lambda (x) =2D ;; example pre-release: =2D ;; https://github.com/wwood/OrfM/releases/tag/v0.= 5.1 =2D ;; or an all-prerelease set =2D ;; https://github.com/powertab/powertabeditor/rel= eases =2D (not (hash-ref x "prerelease"))) =2D json))) + (match (remove pre-release? json) + (() json) ; keep everything + (releases releases)))) (match releases (() ;empty release list #f) =2D-=20 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-import-github-Improve-readability.patch Content-Transfer-Encoding: quoted-printable From=2010dd67dd2980f532cfffc98a4d8042be5ac34f1e Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Mon, 21 Jan 2019 01:43:09 +0530 Subject: [PATCH 2/2] import: github: Improve readability. * guix/import/github.scm (latest-released-version): Use any and cond instead of a recursive loop and an if-else ladder respectively. =2D-- guix/import/github.scm | 55 ++++++++++++++++++++---------------------- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/guix/import/github.scm b/guix/import/github.scm index c78469dac5..4d12339204 100644 =2D-- a/guix/import/github.scm +++ b/guix/import/github.scm @@ -183,35 +183,32 @@ API when using a GitHub token") API. This may be fixed by using an access token and setting the environment variable GUIX_GITHUB_TOKEN, for instance one procured from https://github.com/settings/tokens")) =2D (let loop ((releases =2D (match (remove pre-release? json) =2D (() json) ; keep everything =2D (releases releases)))) =2D (match releases =2D (() ;empty release list =2D #f) =2D ((release . rest) ;one or more releases =2D (let ((tag (or (hash-ref release "tag_name") ;a "release" =2D (hash-ref release "name"))) ;a tag =2D (name-length (string-length package-name))) =2D ;; some tags include the name of the package e.g. "fdupes= -1.51" =2D ;; so remove these =2D (if (and (< name-length (string-length tag)) =2D (string=3D? (string-append package-name "-") =2D (substring tag 0 (+ name-length 1)))) =2D (substring tag (+ name-length 1)) =2D ;; some tags start with a "v" e.g. "v0.25.0" =2D ;; where some are just the version number =2D (if (string-prefix? "v" tag) =2D (substring tag 1) =2D =2D ;; Finally, reject tags that don't start with a d= igit: =2D ;; they may not represent a release. =2D (if (and (not (string-null? tag)) =2D (char-set-contains? char-set:digit =2D (string-ref tag 0))) =2D tag =2D (loop rest))))))))))) + (any + (lambda (release) + (let ((tag (or (hash-ref release "tag_name") ;a "release" + (hash-ref release "name"))) ;a tag + (name-length (string-length package-name))) + (cond + ;; some tags include the name of the package e.g. "fdupes-1.= 51" + ;; so remove these + ((and (< name-length (string-length tag)) + (string=3D? (string-append package-name "-") + (substring tag 0 (+ name-length 1)))) + (substring tag (+ name-length 1))) + ;; some tags start with a "v" e.g. "v0.25.0" + ;; where some are just the version number + ((string-prefix? "v" tag) + (substring tag 1)) + ;; Finally, reject tags that don't start with a digit: + ;; they may not represent a release. + ((and (not (string-null? tag)) + (char-set-contains? char-set:digit + (string-ref tag 0))) + tag) + (else #f)))) + (match (remove pre-release? json) + (() json) ; keep everything + (releases releases)))))) =20 (define (latest-release pkg) "Return an for the latest release of PKG." =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlxE11kACgkQLiXui2GA K7OHlQgAi00T2np2v/6fwNGe0lB4zOPBtPyDIKgvKnUMgcwUmUeMKvB9Wax6TLg3 XDN0LncNpkgHctKXtNSPq7HXPTY3kiqbLsXwvsKuPZpvMdhVrxCIHKbaQVTR/dJ4 5lgLsg9NvX1Fx2yHuZ3osKpMNaBLouKpNb7MtH1UTw3MoYWyU/GbLQhZ2F4huIu5 9kOupt3KlbLBsla75jkjHqIQFFmIDr4hs6EWkhwSd79gBd9h6IrToeOugdaCoyTf UZSTkH83n4nZFjhODelA2OU5yrkmCwAPJFgsi/l6lnYpRYfC0h/eg0fHb8MrWA3q eHloF3BBZJ3oZQ4p/yt0uY916eiICQ== =/7a9 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 21 04:44:20 2019 Received: (at 34108) by debbugs.gnu.org; 21 Jan 2019 09:44:20 +0000 Received: from localhost ([127.0.0.1]:39423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glW7v-0006Bf-Tl for submit@debbugs.gnu.org; Mon, 21 Jan 2019 04:44:20 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:52396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glW7u-0006BW-Gg for 34108@debbugs.gnu.org; Mon, 21 Jan 2019 04:44:19 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 736B93FB0; Mon, 21 Jan 2019 10:44:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rbjTG9G-YhEI; Mon, 21 Jan 2019 10:44:15 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9400B3F64; Mon, 21 Jan 2019 10:44:15 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Arun Isaac Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases. References: <87h8e6rmdo.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 =?utf-8?Q?Pluvi=C3=B4se?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 21 Jan 2019 10:44:15 +0100 In-Reply-To: (Arun Isaac's message of "Mon, 21 Jan 2019 01:47:28 +0530") Message-ID: <87o98al500.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 34108 Cc: 34108@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello! Arun Isaac skribis: >> To improve readability, could you define a =E2=80=98pre-release?=E2=80= =99 procedure so >> we can write: >> >> let ((releases (match (remove pre-release? json) >> (() json) ;keep everything >> (releases releases)))) > > I have made this change. In addition, I have also made another patch > improving the readability of the function by using any and cond. Please > find both patches attached. Both LGTM, thanks for the cleanups! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 21 07:36:34 2019 Received: (at 34108-done) by debbugs.gnu.org; 21 Jan 2019 12:36:34 +0000 Received: from localhost ([127.0.0.1]:39500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glYob-000465-Bg for submit@debbugs.gnu.org; Mon, 21 Jan 2019 07:36:34 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:53878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glYoZ-00045x-Ev for 34108-done@debbugs.gnu.org; Mon, 21 Jan 2019 07:36:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=51iaK6DVQ4+b/EJVwvSSj2/0c5Ak/WbCWIOwZ8+Ykrc=; b=Xr39n9Lw0AESN5LdVhD/5Qut2 Fm+g/1X+46u+IFvh/NZ7Ezdj4KWev4cp9LDOxxrOkub7zaf85XNnSdXV5NCWyyoHDhCcPY1Y6jKFC Pt0z+m8ySFz1+GaSGXVJUFjDrPITSw7FaBkSxMzj8oak3o1TnhHbhIfu1/zSPvsDYR0aU=; Received: from [14.139.128.10] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1glYoU-0001QI-GO; Mon, 21 Jan 2019 18:06:27 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases. In-Reply-To: <87o98al500.fsf@gnu.org> References: <87h8e6rmdo.fsf@gnu.org> <87o98al500.fsf@gnu.org> Date: Mon, 21 Jan 2019 18:06:15 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34108-done Cc: 34108-done@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > Both LGTM, thanks for the cleanups! Pushed, thanks for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlxFvL8ACgkQLiXui2GA K7PPDggAmWmlfp5in8iYT3Sf0KlMdeJCohw9fjwbtSLwNYbkKoUBINxa/0yc6BZR wlaWABisppaulyCsgdr3etmeL4oRmbd4buFfacG22puBudAcIAZSc+U6XfPsk9M1 XUwfrOCR5HP19WFsXiAOe2vKjoWNTS0+hSStJmY9ij8BHDoOpOjh/IIy299cY21V KvqHVKpmvU/tT2h4Vp3Nl519XWL5074KoyzVk0NOZY+VWAcSo2jgQbSlSniBpa/w TiCbNGtbwHKhq62/sI3nAP4tzd20CNvmbAqZJlVXepBr2Wc/fyryEjYuCFtnCrxH T7NgTtIqayxfrnksRiZFgeB/WWFLAA== =6xy/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 18:44:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Feb 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator