GNU bug report logs - #34106
27.0.50; master build failed with MSYS2/MinGW-w64

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chris Zheng <chriszheng99 <at> gmail.com>
Subject: bug#34106: closed (Re: bug#34106: 27.0.50; master build failed
 with MSYS2/MinGW-w64)
Date: Wed, 16 Jan 2019 18:07:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34106: 27.0.50; master build failed with MSYS2/MinGW-w64

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34106 <at> debbugs.gnu.org.

-- 
34106: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34106
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andy Moreton <andrewjmoreton <at> gmail.com>
Cc: 34106-done <at> debbugs.gnu.org
Subject: Re: bug#34106: 27.0.50; master build failed with MSYS2/MinGW-w64
Date: Wed, 16 Jan 2019 20:06:01 +0200

> From: Andy Moreton <andrewjmoreton <at> gmail.com>
> Date: Wed, 16 Jan 2019 17:44:10 +0000
> 
> The MSYS2/Mingw-w64 build also has a warning:
> 
> C:/emacs/git/emacs/master/src/emacs.c: In function 'load_pdump':
> C:/emacs/git/emacs/master/src/emacs.c:752:28: warning: field precision specifier '.*' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long long unsigned int'} [-Wformat=]
>      sprintf (dump_file, "%.*s%s", argv0_len - 4, argv[0], suffix);
>                           ~~^~     ~~~~~~~~~~~~~
> 
> The following patch fixes the warning, and fixes the bug above without
> needing a cast:

Thanks, pushed.

[Message part 3 (message/rfc822, inline)]

From: Chris Zheng <chriszheng99 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; master build failed with MSYS2/MinGW-w64
Date: Thu, 17 Jan 2019 01:28:26 +0800

When build master branch under MS-Windows I’m seeing this

 CC       pdumper.o
pdumper.c: In function 'dump_cold_bignum':
pdumper.c:3447:53: error: conversion from 'size_t' {aka 'long long unsigned int'} to 'mp_size_t' {aka 'long int'} may change value [-Werror=conversion]
      mp_limb_t limb = mpz_getlimbn (bignum->value, i);
cc1.exe: some warnings being treated as errors

Because with MSYS2/MinGW-w64 the `long' is 32-bit instead of 64-bit.

A explicit cast can fix it.

diff --git a/src/pdumper.c b/src/pdumper.c
index 3787408e6d..9d5ace6c38 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -3444,7 +3444,7 @@ dump_cold_bignum (struct dump_context *ctx, Lisp_Object object)
  Fputhash (object, descriptor, ctx->bignum_data);
  for (size_t i = 0; i < nlimbs; ++i)
    {
-      mp_limb_t limb = mpz_getlimbn (bignum->value, i);
+      mp_limb_t limb = mpz_getlimbn (bignum->value, (mp_size_t) i);
      dump_write (ctx, &limb, sizeof (limb));
    }
}

Thank you,

Chris

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.