GNU bug report logs - #34105
[PATCH] Add pencil2d.

Previous Next

Package: guix-patches;

Reported by: <pkill9 <at> runbox.com>

Date: Wed, 16 Jan 2019 15:28:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: <pkill9 <at> runbox.com>
Subject: bug#34105: closed (Re: [bug#34105] [PATCH] Add pencil2d.)
Date: Sun, 20 Jan 2019 18:22:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#34105: [PATCH] Add pencil2d.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34105 <at> debbugs.gnu.org.

-- 
34105: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34105
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: <pkill9 <at> runbox.com>
Cc: 34105-done <at> debbugs.gnu.org
Subject: Re: [bug#34105] [PATCH] Add pencil2d.
Date: Sun, 20 Jan 2019 19:21:25 +0100
[Message part 3 (text/plain, inline)]
Hello,

<pkill9 <at> runbox.com> skribis:

> From d0c680e629b4c85ee462b624c65683a0a52306d9 Mon Sep 17 00:00:00 2001
> From: Pkill -9 <pkill9 <at> runbox.com>
> Date: Wed, 16 Jan 2019 15:14:45 +0000
> Subject: [PATCH] gnu: Add pencil2d.
>
> * gnu/packages/animation.scm (pencil2d): New variable.

Applied with the minor changes below.  Thank you!

Ludo’.

[Message part 4 (text/x-patch, inline)]
diff --git a/gnu/packages/animation.scm b/gnu/packages/animation.scm
index 5b9ca033b5..965fff6d46 100644
--- a/gnu/packages/animation.scm
+++ b/gnu/packages/animation.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015, 2017 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2019 Pkill -9 <pkill9 <at> runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,7 +27,6 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages algebra)
-  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
@@ -275,27 +275,28 @@ waveform until they line up with the proper sounds.")
                 "1iv7drwxs32mqs3hybjx2lxyqn8cv2b4rw9ny7gzdacsbhi65knr"))))
     (build-system gnu-build-system)
     (inputs
-     `(("bash" ,bash) ;; Bash is used for wrap-program
-       ("qtbase" ,qtbase)
+     `(("qtbase" ,qtbase)
        ("qtxmlpatterns" ,qtxmlpatterns)
        ("qtmultimedia" ,qtmultimedia)
        ("qtsvg" ,qtsvg)))
     (arguments
      `(#:phases
-       (modify-phases standard-phases
+       (modify-phases %standard-phases
          (replace 'configure
            (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out"))
-                   (qmake (string-append (assoc-ref inputs "qtbase")
-                                         "/bin/qmake")))
-               (invoke qmake (string-append "PREFIX=" out)))))
+             (let ((out (assoc-ref outputs "out")))
+               (invoke "qmake" (string-append "PREFIX=" out)))))
          (add-after 'install 'wrap-executable
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out"))
                    (plugin-path (getenv "QT_PLUGIN_PATH")))
                (wrap-program (string-append out "/bin/pencil2d")
-                 `("QT_PLUGIN_PATH" ":" prefix (,plugin-path)))))))))
+                 `("QT_PLUGIN_PATH" ":" prefix (,plugin-path)))
+               #t))))))
     (home-page "https://www.pencil2d.org")
-    (synopsis "Tool to make 2D hand-drawn animations")
-    (description "Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations.")
+    (synopsis "Make 2D hand-drawn animations")
+    (description
+     "Pencil2D is an easy-to-use and intuitive animation and drawing tool.  It
+lets you create traditional hand-drawn animations (cartoons) using both bitmap
+and vector graphics.")
     (license license:gpl2)))
[Message part 5 (message/rfc822, inline)]
From: <pkill9 <at> runbox.com>
To: "guix-patches" <guix-patches <at> gnu.org>
Subject: [PATCH] Add pencil2d.
Date: Wed, 16 Jan 2019 15:27:32 +0000 (GMT)
[Message part 6 (text/plain, inline)]
This patch adds the Pencil2D software package (https://www.pencil2d.org). I've run `guix lint`, and checked that it builds/runs fine.
[0001-gnu-Add-pencil2d.patch (text/x-patch, attachment)]

This bug report was last modified 6 years and 183 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.