Subject: bug#34105: closed (Re: [bug#34105] [PATCH] Add pencil2d.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 20 Jan 2019 18:22:02 +0000

Your bug report

#34105: [PATCH] Add pencil2d.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34105: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34105
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#34105] [PATCH] Add pencil2d.
From: Ludovic Courtès <[email-masked]>
To: <[email-masked]>
Cc: [email-masked]
Date: Sun, 20 Jan 2019 19:21:25 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

<[email-masked]> skribis:

> From d0c680e629b4c85ee462b624c65683a0a52306d9 Mon Sep 17 00:00:00 2001
> From: Pkill -9 <[email-masked]>
> Date: Wed, 16 Jan 2019 15:14:45 +0000
> Subject: [PATCH] gnu: Add pencil2d.
>
> * gnu/packages/animation.scm (pencil2d): New variable.

Applied with the minor changes below.  Thank you!

Ludo’.

diff --git a/gnu/packages/animation.scm b/gnu/packages/animation.scm
index 5b9ca033b5..965fff6d46 100644
--- a/gnu/packages/animation.scm
+++ b/gnu/packages/animation.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015, 2017 Ricardo Wurmus <[email-masked]>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <[email-masked]>
+;;; Copyright © 2019 Pkill -9 <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,7 +27,6 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages algebra)
-  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
@@ -275,27 +275,28 @@ waveform until they line up with the proper sounds.")
                 "1iv7drwxs32mqs3hybjx2lxyqn8cv2b4rw9ny7gzdacsbhi65knr"))))
     (build-system gnu-build-system)
     (inputs
-     `(("bash" ,bash) ;; Bash is used for wrap-program
-       ("qtbase" ,qtbase)
+     `(("qtbase" ,qtbase)
        ("qtxmlpatterns" ,qtxmlpatterns)
        ("qtmultimedia" ,qtmultimedia)
        ("qtsvg" ,qtsvg)))
     (arguments
      `(#:phases
-       (modify-phases standard-phases
+       (modify-phases %standard-phases
          (replace 'configure
            (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out"))
-                   (qmake (string-append (assoc-ref inputs "qtbase")
-                                         "/bin/qmake")))
-               (invoke qmake (string-append "PREFIX=" out)))))
+             (let ((out (assoc-ref outputs "out")))
+               (invoke "qmake" (string-append "PREFIX=" out)))))
          (add-after 'install 'wrap-executable
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out"))
                    (plugin-path (getenv "QT_PLUGIN_PATH")))
                (wrap-program (string-append out "/bin/pencil2d")
-                 `("QT_PLUGIN_PATH" ":" prefix (,plugin-path)))))))))
+                 `("QT_PLUGIN_PATH" ":" prefix (,plugin-path)))
+               #t))))))
     (home-page "https://www.pencil2d.org")
-    (synopsis "Tool to make 2D hand-drawn animations")
-    (description "Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations.")
+    (synopsis "Make 2D hand-drawn animations")
+    (description
+     "Pencil2D is an easy-to-use and intuitive animation and drawing tool.  It
+lets you create traditional hand-drawn animations (cartoons) using both bitmap
+and vector graphics.")
     (license license:gpl2)))

Subject: [PATCH] Add pencil2d.
From: <[email-masked]>
To: "guix-patches" <[email-masked]>
Date: Wed, 16 Jan 2019 15:27:32 +0000 (GMT)
List-Id: <debbugs-submit.debbugs.gnu.org>

This patch adds the Pencil2D software package (https://www.pencil2d.org). I've run `guix lint`, and checked that it builds/runs fine.

From d0c680e629b4c85ee462b624c65683a0a52306d9 Mon Sep 17 00:00:00 2001
From: Pkill -9 <[email-masked]>
Date: Wed, 16 Jan 2019 15:14:45 +0000
Subject: [PATCH] gnu: Add pencil2d.

* gnu/packages/animation.scm (pencil2d): New variable.
---
 gnu/packages/animation.scm | 41 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/animation.scm b/gnu/packages/animation.scm
index a10747ef3..5b9ca033b 100644
--- a/gnu/packages/animation.scm
+++ b/gnu/packages/animation.scm
@@ -26,6 +26,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages algebra)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
@@ -258,3 +259,43 @@ easy to lip sync animated characters by making the process very simple – just
 type in the words being spoken, then drag the words on top of the sound’s
 waveform until they line up with the proper sounds.")
       (license license:gpl3+))))
+
+(define-public pencil2d
+  (package
+    (name "pencil2d")
+    (version "0.6.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/pencil2d/pencil")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1iv7drwxs32mqs3hybjx2lxyqn8cv2b4rw9ny7gzdacsbhi65knr"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("bash" ,bash) ;; Bash is used for wrap-program
+       ("qtbase" ,qtbase)
+       ("qtxmlpatterns" ,qtxmlpatterns)
+       ("qtmultimedia" ,qtmultimedia)
+       ("qtsvg" ,qtsvg)))
+    (arguments
+     `(#:phases
+       (modify-phases standard-phases
+         (replace 'configure
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (qmake (string-append (assoc-ref inputs "qtbase")
+                                         "/bin/qmake")))
+               (invoke qmake (string-append "PREFIX=" out)))))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (plugin-path (getenv "QT_PLUGIN_PATH")))
+               (wrap-program (string-append out "/bin/pencil2d")
+                 `("QT_PLUGIN_PATH" ":" prefix (,plugin-path)))))))))
+    (home-page "https://www.pencil2d.org")
+    (synopsis "Tool to make 2D hand-drawn animations")
+    (description "Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations.")
+    (license license:gpl2)))
-- 
2.20.1