GNU bug report logs - #34097
[PATCH] import: github: Do not update URI for packages using git-fetch.

Previous Next

Full log

Message #11 received at 34097 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 34097 <at> debbugs.gnu.org
Subject: Re: [bug#34097] [PATCH] import: github: Do not update URI for
 packages using git-fetch.
Date: Wed, 16 Jan 2019 08:32:05 -0600

[Message part 1 (text/plain, inline)]

On Wed, 16 Jan 2019 11:48:00 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi,
> 
> Arun Isaac <arunisaac <at> systemreboot.net> skribis:
> 
> > During `guix refresh PACKAGE`, the source URI for packages using
> > git-fetch need not be updated. It can be returned unchanged, as it
> > is. The attached patch does that.
> >
> > As a side issue, without this patch, git-fetch packages that do not have
> > a source URI ending in ".git" are not updated correctly using `guix
> > refresh PACKAGE`. See the package emacs-evil for an example.
> >
> > From f63bf518395a06dd0c947222e177a66e59c59e96 Mon Sep 17 00:00:00 2001
> > From: Arun Isaac <arunisaac <at> systemreboot.net>
> > Date: Wed, 16 Jan 2019 15:21:06 +0530
> > Subject: [PATCH] import: github: Do not update URI for packages using
> >  git-fetch.
> >
> > * guix/import/github.scm (updated-github-url): Return the unchanged source URI
> > for packages using git-fetch.
> > [updated-url]: Do not handle URIs which end with ".git".  
> 
> LGTM, thanks!

LGTM too.  I had considered something similar when I first patched the
updater for git-fetch, but hadn't found an example where it was needed
(e.g. "emacs-evil").  Thanks!

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.